126863 2014-01-12 18:14:24 -0800 Remove the last remaining uses of AtomicallyInitializedStatic 2014-01-12 18:19:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 967109 0 andersca 2014-01-12 18:14:24 -0800 Remove the last remaining uses of AtomicallyInitializedStatic 967110 1 220996 andersca 2014-01-12 18:17:06 -0800 Created attachment 220996 Patch 967111 2 commit-queue 2014-01-12 18:19:16 -0800 Attachment 220996 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/HashTable.cpp', u'Source/WTF/wtf/unicode/icu/CollatorICU.cpp', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/SecItemShim.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WTF/wtf/unicode/icu/CollatorICU.cpp:53: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/Shared/mac/SecItemShim.cpp:49: Missing space before { [whitespace/braces] [5] ERROR: Source/WTF/wtf/HashTable.cpp:42: Missing space before { [whitespace/braces] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 967112 3 andersca 2014-01-12 18:19:46 -0800 Committed r161849: <http://trac.webkit.org/changeset/161849> 220996 2014-01-12 18:17:06 -0800 2014-01-12 18:18:27 -0800 Patch bug-126863-20140112181705.patch text/plain 6173 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhkYWRhOThkOTJiMjgyYzQ1NWM2MGVi YjFjNmYzYzM1MGQwZWJjMWMuLjdiNmE4NTVjNzA3NmU1ZmUxNDI3NzNlN2Y0YmQzMzYyNzVhNTI3 MDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTQtMDEtMTIgIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdGhlIGxhc3QgcmVtYWluaW5nIHVz ZXMgb2YgQXRvbWljYWxseUluaXRpYWxpemVkU3RhdGljCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY4NjMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9IYXNoVGFibGUuY3BwOgorICAgICAgICAo V1RGOjpoYXNoVGFibGVTdGF0c011dGV4KToKKyAgICAgICAgKFdURjo6SGFzaFRhYmxlU3RhdHM6 OnJlY29yZENvbGxpc2lvbkF0Q291bnQpOgorICAgICAgICAoV1RGOjpIYXNoVGFibGVTdGF0czo6 ZHVtcFN0YXRzKToKKyAgICAgICAgKiB3dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJQ1UuY3BwOgor ICAgICAgICAoV1RGOjpjYWNoZWRDb2xsYXRvck11dGV4KToKKyAgICAgICAgKFdURjo6Q29sbGF0 b3I6OmNyZWF0ZUNvbGxhdG9yKToKKyAgICAgICAgKFdURjo6Q29sbGF0b3I6OnJlbGVhc2VDb2xs YXRvcik6CisKIDIwMTQtMDEtMTIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJlZHVjZSB1c2Ugb2YgU3RyaW5nOjpjaGFyYWN0ZXJzCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTVm MzY4MmUyMGI2YWEyNzI2Zjc1YzZjZWJmY2Y5MDQyMzU2MjhmMC4uZTJhNDkwZGQ2MWJhMWQ1Njhh YjY4MjA0YjJhNzA2ZmIzYjY2MTg3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0 LTAxLTEyICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAg UmVtb3ZlIHRoZSBsYXN0IHJlbWFpbmluZyB1c2VzIG9mIEF0b21pY2FsbHlJbml0aWFsaXplZFN0 YXRpYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2 ODYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT aGFyZWQvbWFjL1NlY0l0ZW1TaGltLmNwcDoKKyAgICAgICAgKFdlYktpdDo6cmVzcG9uc2VNYXAp OgorCiAyMDE0LTAxLTEyICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkZWQgYSByZWZlcmVuY2UgdG8gV2ViQ29udGVudFNlcnZpY2UvSW5mby1PU1gucGxpc3Qg dG8gdGhlIHByb2plY3QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuY3Bw IGIvU291cmNlL1dURi93dGYvSGFzaFRhYmxlLmNwcAppbmRleCA1MThhNGM4YzI0YWU1Y2RhMWZi MGM2NzY5ZWY2MDRiZjE5M2RkN2MxLi5hNTc4ZjUyZmRkZDQxMjAyOGY4MmJmYzY1NzgxYTYxNGNh ZjY4ODBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9IYXNoVGFibGUuY3BwCisrKyBiL1Nv dXJjZS9XVEYvd3RmL0hhc2hUYWJsZS5jcHAKQEAgLTE5LDcgKzE5LDkgQEAKIAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgIkhhc2hUYWJsZS5oIgorCiAjaW5jbHVkZSAiRGF0YUxvZy5o IgorI2luY2x1ZGUgPG11dGV4PgogCiBuYW1lc3BhY2UgV1RGIHsKIApAQCAtMzMsMTUgKzM1LDIx IEBAIGludCBIYXNoVGFibGVTdGF0czo6bnVtUmVoYXNoZXM7CiBpbnQgSGFzaFRhYmxlU3RhdHM6 Om51bVJlbW92ZXM7CiBpbnQgSGFzaFRhYmxlU3RhdHM6Om51bVJlaW5zZXJ0czsKIAotc3RhdGlj IE11dGV4JiBoYXNoVGFibGVTdGF0c011dGV4KCkKK3N0YXRpYyBzdGQ6Om11dGV4JiBoYXNoVGFi bGVTdGF0c011dGV4KCkKIHsKLSAgICBBdG9taWNhbGx5SW5pdGlhbGl6ZWRTdGF0aWMoTXV0ZXgm LCBtdXRleCA9ICpuZXcgTXV0ZXgpOwotICAgIHJldHVybiBtdXRleDsKKyAgICBzdGF0aWMgc3Rk OjpvbmNlX2ZsYWcgb25jZUZsYWc7CisgICAgc3RhdGljIHN0ZDo6bXV0ZXgqIG11dGV4OworICAg IHN0ZDo6Y2FsbF9vbmNlKG9uY2VGbGFnLCBbXXsKKyAgICAgICAgbXV0ZXggPSBzdGQ6Om1ha2Vf dW5pcXVlPHN0ZDo6bXV0ZXg+KCkucmVsZWFzZSgpOworICAgIH0pOworCisgICAgcmV0dXJuICpt dXRleDsKIH0KIAogdm9pZCBIYXNoVGFibGVTdGF0czo6cmVjb3JkQ29sbGlzaW9uQXRDb3VudChp bnQgY291bnQpCiB7Ci0gICAgTXV0ZXhMb2NrZXIgbG9jayhoYXNoVGFibGVTdGF0c011dGV4KCkp OworICAgIHN0ZDo6bG9ja19ndWFyZDxzdGQ6Om11dGV4PiBsb2NrKGhhc2hUYWJsZVN0YXRzTXV0 ZXgoKSk7CisKICAgICBpZiAoY291bnQgPiBtYXhDb2xsaXNpb25zKQogICAgICAgICBtYXhDb2xs aXNpb25zID0gY291bnQ7CiAgICAgbnVtQ29sbGlzaW9ucysrOwpAQCAtNTAsNyArNTgsNyBAQCB2 b2lkIEhhc2hUYWJsZVN0YXRzOjpyZWNvcmRDb2xsaXNpb25BdENvdW50KGludCBjb3VudCkKIAog dm9pZCBIYXNoVGFibGVTdGF0czo6ZHVtcFN0YXRzKCkKIHsKLSAgICBNdXRleExvY2tlciBsb2Nr KGhhc2hUYWJsZVN0YXRzTXV0ZXgoKSk7CisgICAgc3RkOjpsb2NrX2d1YXJkPHN0ZDo6bXV0ZXg+ IGxvY2soaGFzaFRhYmxlU3RhdHNNdXRleCgpKTsKIAogICAgIGRhdGFMb2dGKCJcbldURjo6SGFz aFRhYmxlIHN0YXRpc3RpY3NcblxuIik7CiAgICAgZGF0YUxvZ0YoIiVkIGFjY2Vzc2VzXG4iLCBu dW1BY2Nlc3Nlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi91bmljb2RlL2ljdS9Db2xs YXRvcklDVS5jcHAgYi9Tb3VyY2UvV1RGL3d0Zi91bmljb2RlL2ljdS9Db2xsYXRvcklDVS5jcHAK aW5kZXggNmRlNjQwNGNkYWM2NmE2MTQ3OTkwOTc3YmY1MGRiMTc3NWRlM2Q0ZC4uMjA5YzAyMzA4 YTUxMTZhZDIxNDJhZjg3OGY2NWRlZTU5MTU5Mzg5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93 dGYvdW5pY29kZS9pY3UvQ29sbGF0b3JJQ1UuY3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL3VuaWNv ZGUvaWN1L0NvbGxhdG9ySUNVLmNwcApAQCAtMzEsOSArMzEsOSBAQAogCiAjaWYgVVNFKElDVV9V TklDT0RFKSAmJiAhVUNPTkZJR19OT19DT0xMQVRJT04KIAorI2luY2x1ZGUgPG11dGV4PgogI2lu Y2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAjaW5jbHVkZSA8d3RmL1N0cmluZ0V4dHJhcy5oPgot I2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KICNpbmNsdWRlIDx1bmljb2RlL3Vjb2wuaD4KICNp bmNsdWRlIDxzdHJpbmcuaD4KIApAQCAtNDUsMTAgKzQ1LDE2IEBACiBuYW1lc3BhY2UgV1RGIHsK IAogc3RhdGljIFVDb2xsYXRvciogY2FjaGVkQ29sbGF0b3I7Ci1zdGF0aWMgTXV0ZXgmIGNhY2hl ZENvbGxhdG9yTXV0ZXgoKQorCitzdGF0aWMgc3RkOjptdXRleCYgY2FjaGVkQ29sbGF0b3JNdXRl eCgpCiB7Ci0gICAgQXRvbWljYWxseUluaXRpYWxpemVkU3RhdGljKE11dGV4JiwgbXV0ZXggPSAq bmV3IE11dGV4KTsKLSAgICByZXR1cm4gbXV0ZXg7CisgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFn IG9uY2VGbGFnOworICAgIHN0YXRpYyBzdGQ6Om11dGV4KiBtdXRleDsKKyAgICBzdGQ6OmNhbGxf b25jZShvbmNlRmxhZywgW117CisgICAgICAgIG11dGV4ID0gc3RkOjptYWtlX3VuaXF1ZTxzdGQ6 Om11dGV4PigpLnJlbGVhc2UoKTsKKyAgICB9KTsKKworICAgIHJldHVybiAqbXV0ZXg7CiB9CiAK IENvbGxhdG9yOjpDb2xsYXRvcihjb25zdCBjaGFyKiBsb2NhbGUpCkBAIC0xMDQsNyArMTEwLDcg QEAgdm9pZCBDb2xsYXRvcjo6Y3JlYXRlQ29sbGF0b3IoKSBjb25zdAogICAgIFVFcnJvckNvZGUg c3RhdHVzID0gVV9aRVJPX0VSUk9SOwogCiAgICAgewotICAgICAgICBMb2NrZXI8TXV0ZXg+IGxv Y2soY2FjaGVkQ29sbGF0b3JNdXRleCgpKTsKKyAgICAgICAgc3RkOjpsb2NrX2d1YXJkPHN0ZDo6 bXV0ZXg+IGxvY2soY2FjaGVkQ29sbGF0b3JNdXRleCgpKTsKICAgICAgICAgaWYgKGNhY2hlZENv bGxhdG9yKSB7CiAgICAgICAgICAgICBjb25zdCBjaGFyKiBjYWNoZWRDb2xsYXRvckxvY2FsZSA9 IHVjb2xfZ2V0TG9jYWxlQnlUeXBlKGNhY2hlZENvbGxhdG9yLCBVTE9DX1JFUVVFU1RFRF9MT0NB TEUsICZzdGF0dXMpOwogICAgICAgICAgICAgQVNTRVJUKFVfU1VDQ0VTUyhzdGF0dXMpKTsKQEAg LTExNyw3ICsxMjMsNyBAQCB2b2lkIENvbGxhdG9yOjpjcmVhdGVDb2xsYXRvcigpIGNvbnN0CiAg ICAgICAgICAgICBpZiAobV9sb2NhbGUgJiYgMCA9PSBzdHJjbXAoY2FjaGVkQ29sbGF0b3JMb2Nh bGUsIG1fbG9jYWxlKQogICAgICAgICAgICAgICAgICYmICgoVUNPTF9MT1dFUl9GSVJTVCA9PSBj YWNoZWRDb2xsYXRvckxvd2VyRmlyc3QgJiYgbV9sb3dlckZpcnN0KSB8fCAoVUNPTF9VUFBFUl9G SVJTVCA9PSBjYWNoZWRDb2xsYXRvckxvd2VyRmlyc3QgJiYgIW1fbG93ZXJGaXJzdCkpKSB7CiAg ICAgICAgICAgICAgICAgbV9jb2xsYXRvciA9IGNhY2hlZENvbGxhdG9yOwotICAgICAgICAgICAg ICAgIGNhY2hlZENvbGxhdG9yID0gMDsKKyAgICAgICAgICAgICAgICBjYWNoZWRDb2xsYXRvciA9 IG51bGxwdHI7CiAgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogICAgICAg ICB9CkBAIC0xNDAsMTEgKzE0NiwxMSBAQCB2b2lkIENvbGxhdG9yOjpjcmVhdGVDb2xsYXRvcigp IGNvbnN0CiB2b2lkIENvbGxhdG9yOjpyZWxlYXNlQ29sbGF0b3IoKQogewogICAgIHsKLSAgICAg ICAgTG9ja2VyPE11dGV4PiBsb2NrKGNhY2hlZENvbGxhdG9yTXV0ZXgoKSk7CisgICAgICAgIHN0 ZDo6bG9ja19ndWFyZDxzdGQ6Om11dGV4PiBsb2NrKGNhY2hlZENvbGxhdG9yTXV0ZXgoKSk7CiAg ICAgICAgIGlmIChjYWNoZWRDb2xsYXRvcikKICAgICAgICAgICAgIHVjb2xfY2xvc2UoY2FjaGVk Q29sbGF0b3IpOwogICAgICAgICBjYWNoZWRDb2xsYXRvciA9IG1fY29sbGF0b3I7Ci0gICAgICAg IG1fY29sbGF0b3IgID0gMDsKKyAgICAgICAgbV9jb2xsYXRvciA9IG51bGxwdHI7CiAgICAgfQog fQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvbWFjL1NlY0l0ZW1TaGltLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvU2VjSXRlbVNoaW0uY3BwCmluZGV4IGY3ZGI0 OGRlNDczMjU3OTM1MzAzMzc5ZjBjYmZhMzFkNzcwN2RjODkuLjNiODg3MjhhNDI3MTc0MjNiZGY4 NWNlZTE4YmM0MTE0MGQ5MGQ0MTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9t YWMvU2VjSXRlbVNoaW0uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9tYWMvU2VjSXRl bVNoaW0uY3BwCkBAIC0zNywxMiArMzcsMTkgQEAKICNpbmNsdWRlICJTZWNJdGVtU2hpbVByb3h5 TWVzc2FnZXMuaCIKICNpbmNsdWRlIDxTZWN1cml0eS9TZWN1cml0eS5oPgogI2luY2x1ZGUgPGRs ZmNuLmg+CisjaW5jbHVkZSA8bXV0ZXg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBzdGF0aWMg QmxvY2tpbmdSZXNwb25zZU1hcDxTZWNJdGVtUmVzcG9uc2VEYXRhPiYgcmVzcG9uc2VNYXAoKQog ewotICAgIEF0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpYyhCbG9ja2luZ1Jlc3BvbnNlTWFwPFNl Y0l0ZW1SZXNwb25zZURhdGE+KiwgcmVzcG9uc2VNYXAgPSBuZXcgQmxvY2tpbmdSZXNwb25zZU1h cDxTZWNJdGVtUmVzcG9uc2VEYXRhPik7CisgICAgc3RhdGljIHN0ZDo6b25jZV9mbGFnIG9uY2VG bGFnOworICAgIHN0YXRpYyBCbG9ja2luZ1Jlc3BvbnNlTWFwPFNlY0l0ZW1SZXNwb25zZURhdGE+ KiByZXNwb25zZU1hcDsKKworICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2VGbGFnLCBbXXsKKyAgICAg ICAgcmVzcG9uc2VNYXAgPSBzdGQ6Om1ha2VfdW5pcXVlPEJsb2NraW5nUmVzcG9uc2VNYXA8U2Vj SXRlbVJlc3BvbnNlRGF0YT4+KCkucmVsZWFzZSgpOworICAgIH0pOworCiAgICAgcmV0dXJuICpy ZXNwb25zZU1hcDsKIH0KIAo=