126851 2014-01-12 13:06:21 -0800 Use std::call_once instead of AtomicallyInitializedStatic in DatabaseBackendBase 2014-01-12 13:27:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 967017 0 andersca 2014-01-12 13:06:21 -0800 Use std::call_once instead of AtomicallyInitializedStatic in DatabaseBackendBase 967018 1 220982 andersca 2014-01-12 13:09:57 -0800 Created attachment 220982 Patch 967019 2 commit-queue 2014-01-12 13:11:28 -0800 Attachment 220982 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp:149: Missing space before { [whitespace/braces] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 967020 3 andersca 2014-01-12 13:27:02 -0800 Committed r161835: <http://trac.webkit.org/changeset/161835> 220982 2014-01-12 13:09:57 -0800 2014-01-12 13:25:39 -0800 Patch bug-126851-20140112130956.patch text/plain 5326 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTI3MDg4YzEyZmQ2ODAz MWUxM2FkM2ZmN2NmNGNkZjY4NzU5ZmFjMi4uM2E1MTQ5YTc4MDM0Nzg2MTYxMmMwZGE3NjQ5NDk5 NWFmODc0MTQxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTAxLTEyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgVXNlIHN0ZDo6Y2Fs bF9vbmNlIGluc3RlYWQgb2YgQXRvbWljYWxseUluaXRpYWxpemVkU3RhdGljIGluIERhdGFiYXNl QmFja2VuZEJhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNjg1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogTW9kdWxlcy93ZWJkYXRhYmFzZS9EYXRhYmFzZUJhY2tlbmRCYXNlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6Omd1aWRNdXRleCk6CisgICAgICAgIChXZWJDb3JlOjpndWlkVG9WZXJzaW9u TWFwKToKKyAgICAgICAgKFdlYkNvcmU6OnVwZGF0ZUd1aWRWZXJzaW9uTWFwKToKKyAgICAgICAg KFdlYkNvcmU6Omd1aWRUb0RhdGFiYXNlTWFwKToKKyAgICAgICAgKFdlYkNvcmU6Omd1aWRGb3JP cmlnaW5BbmROYW1lKToKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlQmFja2VuZEJhc2U6OkRh dGFiYXNlQmFja2VuZEJhc2UpOgorICAgICAgICAoV2ViQ29yZTo6RGF0YWJhc2VCYWNrZW5kQmFz ZTo6Y2xvc2VEYXRhYmFzZSk6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZUJhY2tlbmRCYXNl OjpwZXJmb3JtT3BlbkFuZFZlcmlmeSk6CisgICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZUJhY2tl bmRCYXNlOjpnZXRDYWNoZWRWZXJzaW9uKToKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlQmFj a2VuZEJhc2U6OnNldENhY2hlZFZlcnNpb24pOgorCisyMDE0LTAxLTEyICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgQ2xlYW4gdXAgTmV0d29ya1N0YXRl Tm90aWZpZXIgY2xhc3MKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTEyNjg1MAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRh dGFiYXNlL0RhdGFiYXNlQmFja2VuZEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93 ZWJkYXRhYmFzZS9EYXRhYmFzZUJhY2tlbmRCYXNlLmNwcAppbmRleCA3NDVkNTYzYTA4ZTk5MDIx ZWFjYTBmYmFiZDlmMTI0MjY2YzI2ZmFhLi5mNGE1NmUwYjUyYmFjZjljNzA4YTdiNWUwNGUxNjhj YWI2ZDM2YmVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmRhdGFiYXNl L0RhdGFiYXNlQmFja2VuZEJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi ZGF0YWJhc2UvRGF0YWJhc2VCYWNrZW5kQmFzZS5jcHAKQEAgLTE0MSwxOCArMTQxLDI1IEBAIHN0 YXRpYyBib29sIHNldFRleHRWYWx1ZUluRGF0YWJhc2UoU1FMaXRlRGF0YWJhc2UmIGRiLCBjb25z dCBTdHJpbmcmIHF1ZXJ5LCBjb25zCiB9CiAKIC8vIEZJWE1FOiBtb3ZlIGFsbCBndWlkLXJlbGF0 ZWQgZnVuY3Rpb25zIHRvIGEgRGF0YWJhc2VWZXJzaW9uVHJhY2tlciBjbGFzcy4KLXN0YXRpYyBN dXRleCYgZ3VpZE11dGV4KCkKK3N0YXRpYyBzdGQ6Om11dGV4JiBndWlkTXV0ZXgoKQogewotICAg IEF0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpYyhNdXRleCYsIG11dGV4ID0gKm5ldyBNdXRleCk7 Ci0gICAgcmV0dXJuIG11dGV4OworICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNlRmxhZzsK KyAgICBzdGF0aWMgc3RkOjptdXRleCogbXV0ZXg7CisKKyAgICBzdGQ6OmNhbGxfb25jZShvbmNl RmxhZywgW117CisgICAgICAgIG11dGV4ID0gc3RkOjptYWtlX3VuaXF1ZTxzdGQ6Om11dGV4Pigp LnJlbGVhc2UoKTsKKyAgICB9KTsKKworICAgIHJldHVybiAqbXV0ZXg7CiB9CiAKIHR5cGVkZWYg SGFzaE1hcDxEYXRhYmFzZUd1aWQsIFN0cmluZz4gR3VpZFZlcnNpb25NYXA7CiBzdGF0aWMgR3Vp ZFZlcnNpb25NYXAmIGd1aWRUb1ZlcnNpb25NYXAoKQogewogICAgIC8vIEVuc3VyZSB0aGUgdGhl IG11dGV4IGlzIGxvY2tlZC4KLSAgICBBU1NFUlQoIWd1aWRNdXRleCgpLnRyeUxvY2soKSk7Ci0g ICAgREVGSU5FX1NUQVRJQ19MT0NBTChHdWlkVmVyc2lvbk1hcCwgbWFwLCAoKSk7CisgICAgQVNT RVJUKCFndWlkTXV0ZXgoKS50cnlfbG9jaygpKTsKKworICAgIHN0YXRpYyBOZXZlckRlc3Ryb3ll ZDxHdWlkVmVyc2lvbk1hcD4gbWFwOwogICAgIHJldHVybiBtYXA7CiB9CiAKQEAgLTE2MCw3ICsx NjcsNyBAQCBzdGF0aWMgR3VpZFZlcnNpb25NYXAmIGd1aWRUb1ZlcnNpb25NYXAoKQogc3RhdGlj IGlubGluZSB2b2lkIHVwZGF0ZUd1aWRWZXJzaW9uTWFwKERhdGFiYXNlR3VpZCBndWlkLCBTdHJp bmcgbmV3VmVyc2lvbikKIHsKICAgICAvLyBFbnN1cmUgdGhlIHRoZSBtdXRleCBpcyBsb2NrZWQu Ci0gICAgQVNTRVJUKCFndWlkTXV0ZXgoKS50cnlMb2NrKCkpOworICAgIEFTU0VSVCghZ3VpZE11 dGV4KCkudHJ5X2xvY2soKSk7CiAKICAgICAvLyBOb3RlOiBJdCBpcyBub3Qgc2FmZSB0byBwdXQg YW4gZW1wdHkgc3RyaW5nIGludG8gdGhlIGd1aWRUb1ZlcnNpb25NYXAoKSBtYXAuCiAgICAgLy8g VGhhdCdzIGJlY2F1c2UgdGhlIG1hcCBpcyBjcm9zcy10aHJlYWQsIGJ1dCBlbXB0eSBzdHJpbmdz IGFyZSBwZXItdGhyZWFkLgpAQCAtMTc3LDcgKzE4NCw4IEBAIHR5cGVkZWYgSGFzaE1hcDxEYXRh YmFzZUd1aWQsIHN0ZDo6dW5pcXVlX3B0cjxIYXNoU2V0PERhdGFiYXNlQmFja2VuZEJhc2UqPj4+ IEd1CiBzdGF0aWMgR3VpZERhdGFiYXNlTWFwJiBndWlkVG9EYXRhYmFzZU1hcCgpCiB7CiAgICAg Ly8gRW5zdXJlIHRoZSB0aGUgbXV0ZXggaXMgbG9ja2VkLgotICAgIEFTU0VSVCghZ3VpZE11dGV4 KCkudHJ5TG9jaygpKTsKKyAgICBBU1NFUlQoIWd1aWRNdXRleCgpLnRyeV9sb2NrKCkpOworCiAg ICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPEd1aWREYXRhYmFzZU1hcD4gbWFwOwogICAgIHJldHVy biBtYXA7CiB9CkBAIC0xODUsNyArMTkzLDcgQEAgc3RhdGljIEd1aWREYXRhYmFzZU1hcCYgZ3Vp ZFRvRGF0YWJhc2VNYXAoKQogc3RhdGljIERhdGFiYXNlR3VpZCBndWlkRm9yT3JpZ2luQW5kTmFt ZShjb25zdCBTdHJpbmcmIG9yaWdpbiwgY29uc3QgU3RyaW5nJiBuYW1lKQogewogICAgIC8vIEVu c3VyZSB0aGUgdGhlIG11dGV4IGlzIGxvY2tlZC4KLSAgICBBU1NFUlQoIWd1aWRNdXRleCgpLnRy eUxvY2soKSk7CisgICAgQVNTRVJUKCFndWlkTXV0ZXgoKS50cnlfbG9jaygpKTsKIAogICAgIFN0 cmluZyBzdHJpbmdJRCA9IG9yaWdpbiArICIvIiArIG5hbWU7CiAKQEAgLTIzMyw3ICsyNDEsOCBA QCBEYXRhYmFzZUJhY2tlbmRCYXNlOjpEYXRhYmFzZUJhY2tlbmRCYXNlKFBhc3NSZWZQdHI8RGF0 YWJhc2VCYWNrZW5kQ29udGV4dD4gZGF0YQogICAgICAgICBtX25hbWUgPSBlbXB0eVN0cmluZygp OwogCiAgICAgewotICAgICAgICBNdXRleExvY2tlciBsb2NrZXIoZ3VpZE11dGV4KCkpOworICAg ICAgICBzdGQ6OmxvY2tfZ3VhcmQ8c3RkOjptdXRleD4gbG9ja2VyKGd1aWRNdXRleCgpKTsKKwog ICAgICAgICBtX2d1aWQgPSBndWlkRm9yT3JpZ2luQW5kTmFtZShzZWN1cml0eU9yaWdpbigpLT50 b1N0cmluZygpLCBuYW1lKTsKICAgICAgICAgc3RkOjp1bmlxdWVfcHRyPEhhc2hTZXQ8RGF0YWJh c2VCYWNrZW5kQmFzZSo+PiYgaGFzaFNldCA9IGd1aWRUb0RhdGFiYXNlTWFwKCkuYWRkKG1fZ3Vp ZCwgbnVsbHB0cikuaXRlcmF0b3ItPnZhbHVlOwogICAgICAgICBpZiAoIWhhc2hTZXQpCkBAIC0y NjgsNyArMjc3LDcgQEAgdm9pZCBEYXRhYmFzZUJhY2tlbmRCYXNlOjpjbG9zZURhdGFiYXNlKCkK ICAgICAvLyBTZWUgY29tbWVudCBhdCB0aGUgdG9wIHRoaXMgZmlsZSByZWdhcmRpbmcgY2FsbGlu ZyByZW1vdmVPcGVuRGF0YWJhc2UoKS4KICAgICBEYXRhYmFzZVRyYWNrZXI6OnRyYWNrZXIoKS5y ZW1vdmVPcGVuRGF0YWJhc2UodGhpcyk7CiAgICAgewotICAgICAgICBNdXRleExvY2tlciBsb2Nr ZXIoZ3VpZE11dGV4KCkpOworICAgICAgICBzdGQ6OmxvY2tfZ3VhcmQ8c3RkOjptdXRleD4gbG9j a2VyKGd1aWRNdXRleCgpKTsKIAogICAgICAgICBhdXRvIGl0ID0gZ3VpZFRvRGF0YWJhc2VNYXAo KS5maW5kKG1fZ3VpZCk7CiAgICAgICAgIEFTU0VSVChpdCAhPSBndWlkVG9EYXRhYmFzZU1hcCgp LmVuZCgpKTsKQEAgLTMzNyw3ICszNDYsNyBAQCBib29sIERhdGFiYXNlQmFja2VuZEJhc2U6OnBl cmZvcm1PcGVuQW5kVmVyaWZ5KGJvb2wgc2hvdWxkU2V0VmVyc2lvbkluTmV3RGF0YWJhcwogCiAg ICAgU3RyaW5nIGN1cnJlbnRWZXJzaW9uOwogICAgIHsKLSAgICAgICAgTXV0ZXhMb2NrZXIgbG9j a2VyKGd1aWRNdXRleCgpKTsKKyAgICAgICAgc3RkOjpsb2NrX2d1YXJkPHN0ZDo6bXV0ZXg+IGxv Y2tlcihndWlkTXV0ZXgoKSk7CiAKICAgICAgICAgYXV0byBlbnRyeSA9IGd1aWRUb1ZlcnNpb25N YXAoKS5maW5kKG1fZ3VpZCk7CiAgICAgICAgIGlmIChlbnRyeSAhPSBndWlkVG9WZXJzaW9uTWFw KCkuZW5kKCkpIHsKQEAgLTQ5NiwxNCArNTA1LDE2IEBAIHZvaWQgRGF0YWJhc2VCYWNrZW5kQmFz ZTo6c2V0RXhwZWN0ZWRWZXJzaW9uKGNvbnN0IFN0cmluZyYgdmVyc2lvbikKIAogU3RyaW5nIERh dGFiYXNlQmFja2VuZEJhc2U6OmdldENhY2hlZFZlcnNpb24oKSBjb25zdAogewotICAgIE11dGV4 TG9ja2VyIGxvY2tlcihndWlkTXV0ZXgoKSk7CisgICAgc3RkOjpsb2NrX2d1YXJkPHN0ZDo6bXV0 ZXg+IGxvY2tlcihndWlkTXV0ZXgoKSk7CisKICAgICByZXR1cm4gZ3VpZFRvVmVyc2lvbk1hcCgp LmdldChtX2d1aWQpLmlzb2xhdGVkQ29weSgpOwogfQogCiB2b2lkIERhdGFiYXNlQmFja2VuZEJh c2U6OnNldENhY2hlZFZlcnNpb24oY29uc3QgU3RyaW5nJiBhY3R1YWxWZXJzaW9uKQogewogICAg IC8vIFVwZGF0ZSB0aGUgaW4gbWVtb3J5IGRhdGFiYXNlIHZlcnNpb24gbWFwLgotICAgIE11dGV4 TG9ja2VyIGxvY2tlcihndWlkTXV0ZXgoKSk7CisgICAgc3RkOjpsb2NrX2d1YXJkPHN0ZDo6bXV0 ZXg+IGxvY2tlcihndWlkTXV0ZXgoKSk7CisKICAgICB1cGRhdGVHdWlkVmVyc2lvbk1hcChtX2d1 aWQsIGFjdHVhbFZlcnNpb24pOwogfQogCg==