126850 2014-01-12 12:39:41 -0800 Clean up NetworkStateNotifier class 2014-01-12 12:55:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 967013 0 andersca 2014-01-12 12:39:41 -0800 Clean up NetworkStateNotifier class 967014 1 220981 andersca 2014-01-12 12:40:47 -0800 Created attachment 220981 Patch 967015 2 commit-queue 2014-01-12 12:41:39 -0800 Attachment 220981 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/NetworkStateNotifier.cpp', u'Source/WebCore/platform/network/NetworkStateNotifier.h', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:61: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.h:71: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:40: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/network/NetworkStateNotifier.cpp:47: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 967016 3 andersca 2014-01-12 12:55:23 -0800 Committed r161830: <http://trac.webkit.org/changeset/161830> 220981 2014-01-12 12:40:47 -0800 2014-01-12 12:47:49 -0800 Patch bug-126850-20140112124046.patch text/plain 3664 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWZjNmJiOTZhMDFhYzg0 Y2Y5MDNjMTdiZmM2ZDFlNjI1YzMxNzJmMy4uNmRkZDBiOGVlOGZmOWE5NmUyNDM3NzcyMWNiYTc5 N2RhNzBiNWU1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTAxLTEyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgQ2xlYW4gdXAgTmV0 d29ya1N0YXRlTm90aWZpZXIgY2xhc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEyNjg1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFVzZSBzdGQ6OmNhbGxfb25jZSBpbnN0ZWFkIG9mIEF0b21pY2FsbHlJ bml0aWFsaXplZFN0YXRpYyBhbmQgYSBzdGQ6OmZ1bmN0aW9uCisgICAgICAgIGluc3RlYWQgb2Yg YSBjdXN0b20gZnVuY3Rpb24gcG9pbnRlciB0eXBlZGVmLgorCisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpuZXR3 b3JrU3RhdGVOb3RpZmllcik6CisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrU3RhdGVOb3RpZmll cjo6YWRkTmV0d29ya1N0YXRlQ2hhbmdlTGlzdGVuZXIpOgorICAgICAgICAoV2ViQ29yZTo6TmV0 d29ya1N0YXRlTm90aWZpZXI6Om5vdGlmeU5ldHdvcmtTdGF0ZUNoYW5nZSk6CisgICAgICAgICog cGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5oOgorCisyMDE0LTAxLTEyICBB bmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgUmVwbGFjZSBt b3JlIHVzZXMgb2YgQXRvbWljYWxseUluaXRpYWxpemVkU3RhdGljIHdpdGggc3RkOjpjYWxsX29u Y2UKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjg0 NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtT dGF0ZU5vdGlmaWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29y a1N0YXRlTm90aWZpZXIuY3BwCmluZGV4IGEyMTA4OTNlNTNkNzUwOTdiYTIxNmFjNjc4OGIwMTgz MGYxZjJiOTUuLjMxZmFiOGYwNzEwMjMwZTAzYTg5ZDkzNGFkNzY5YmM4N2I3NDIyODcgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZp ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRl Tm90aWZpZXIuY3BwCkBAIC0yNiwzMCArMjYsMzUgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNp bmNsdWRlICJOZXR3b3JrU3RhdGVOb3RpZmllci5oIgogCisjaW5jbHVkZSA8bXV0ZXg+CiAjaW5j bHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvU3RkTGliRXh0cmFzLmg+Ci0j aW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIE5ldHdv cmtTdGF0ZU5vdGlmaWVyJiBuZXR3b3JrU3RhdGVOb3RpZmllcigpCiB7Ci0gICAgQXRvbWljYWxs eUluaXRpYWxpemVkU3RhdGljKE5ldHdvcmtTdGF0ZU5vdGlmaWVyKiwgbmV0d29ya1N0YXRlTm90 aWZpZXIgPSBuZXcgTmV0d29ya1N0YXRlTm90aWZpZXIpOworICAgIHN0YXRpYyBzdGQ6Om9uY2Vf ZmxhZyBvbmNlRmxhZzsKKyAgICBzdGF0aWMgTmV0d29ya1N0YXRlTm90aWZpZXIqIG5ldHdvcmtT dGF0ZU5vdGlmaWVyOworCisgICAgc3RkOjpjYWxsX29uY2Uob25jZUZsYWcsIFtdeworICAgICAg ICBuZXR3b3JrU3RhdGVOb3RpZmllciA9IHN0ZDo6bWFrZV91bmlxdWU8TmV0d29ya1N0YXRlTm90 aWZpZXI+KCkucmVsZWFzZSgpOworICAgIH0pOwogCiAgICAgcmV0dXJuICpuZXR3b3JrU3RhdGVO b3RpZmllcjsKIH0KIAotdm9pZCBOZXR3b3JrU3RhdGVOb3RpZmllcjo6YWRkTmV0d29ya1N0YXRl Q2hhbmdlTGlzdGVuZXIoTmV0d29ya1N0YXRlQ2hhbmdlTGlzdGVuZXIgbGlzdGVuZXIpCit2b2lk IE5ldHdvcmtTdGF0ZU5vdGlmaWVyOjphZGROZXR3b3JrU3RhdGVDaGFuZ2VMaXN0ZW5lcihzdGQ6 OmZ1bmN0aW9uPHZvaWQgKGJvb2wpPiBsaXN0ZW5lcikKIHsKICAgICBBU1NFUlQobGlzdGVuZXIp OwotICAgIG1fbGlzdGVuZXJzLmFwcGVuZChsaXN0ZW5lcik7CisKKyAgICBtX2xpc3RlbmVycy5h cHBlbmQoc3RkOjptb3ZlKGxpc3RlbmVyKSk7CiB9CiAKIHZvaWQgTmV0d29ya1N0YXRlTm90aWZp ZXI6Om5vdGlmeU5ldHdvcmtTdGF0ZUNoYW5nZSgpCiB7Ci0gICAgVmVjdG9yPE5ldHdvcmtTdGF0 ZUNoYW5nZUxpc3RlbmVyPjo6aXRlcmF0b3IgZW5kID0gbV9saXN0ZW5lcnMuZW5kKCk7Ci0gICAg Zm9yIChWZWN0b3I8TmV0d29ya1N0YXRlQ2hhbmdlTGlzdGVuZXI+OjppdGVyYXRvciBpdCA9IG1f bGlzdGVuZXJzLmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkKLSAgICAgICAgKCppdCkobV9pc09u TGluZSk7CisgICAgZm9yIChjb25zdCBhdXRvJiBsaXN0ZW5lciA6IG1fbGlzdGVuZXJzKQorICAg ICAgICBsaXN0ZW5lcihtX2lzT25MaW5lKTsKIH0KIAotfQorfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3Rh dGVOb3RpZmllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3Rh dGVOb3RpZmllci5oCmluZGV4IGM5NzRhY2UxYjk5MzVjMjZkNTI0ZjNmMDE3OWJhZDk2ZmY4ZjZh ODMuLjRlMWFiMTBlNzJlMzkyZGZkNTU4ZjlkMDdlNjg5M2YyOTE4ZjNhNmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVy LmgKQEAgLTU4LDggKzU4LDcgQEAgcHVibGljOgogI2lmIFBMQVRGT1JNKEVGTCkKICAgICB+TmV0 d29ya1N0YXRlTm90aWZpZXIoKTsKICNlbmRpZgotICAgIHR5cGVkZWYgdm9pZCAoKk5ldHdvcmtT dGF0ZUNoYW5nZUxpc3RlbmVyKShib29sIG1faXNPbkxpbmUpOwotICAgIHZvaWQgYWRkTmV0d29y a1N0YXRlQ2hhbmdlTGlzdGVuZXIoTmV0d29ya1N0YXRlQ2hhbmdlTGlzdGVuZXIpOworICAgIHZv aWQgYWRkTmV0d29ya1N0YXRlQ2hhbmdlTGlzdGVuZXIoc3RkOjpmdW5jdGlvbjx2b2lkIChib29s IGlzT25MaW5lKT4pOwogCiAgICAgYm9vbCBvbkxpbmUoKSBjb25zdCB7IHJldHVybiBtX2lzT25M aW5lOyB9CiAgICAgCkBAIC02OSw3ICs2OCw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBi b29sIG1faXNPbkxpbmU7Ci0gICAgVmVjdG9yPE5ldHdvcmtTdGF0ZUNoYW5nZUxpc3RlbmVyPiBt X2xpc3RlbmVyczsKKyAgICBWZWN0b3I8c3RkOjpmdW5jdGlvbjx2b2lkIChib29sKT4+IG1fbGlz dGVuZXJzOwogCiAgICAgdm9pZCBub3RpZnlOZXR3b3JrU3RhdGVDaGFuZ2UoKTsKICAgICB2b2lk IHVwZGF0ZVN0YXRlKCk7Cg==