126848 2014-01-12 11:17:53 -0800 Move implementation of AuthenticationChallenge::setAuthenticationClient() to source file for USE(CFNETWORK) 2014-01-12 12:02:26 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ddkilzer ddkilzer ap beidson bfulgham commit-queue roger_fong sam simon.fraser oldest_to_newest 966996 0 ddkilzer 2014-01-12 11:17:53 -0800 We need to move the implementation of AuthenticationChallenge::setAuthenticationClient() to the source file for USE(CFNETWORK) so that we don't need to specialize WebCore.exp.in. I expect a Windows build failure, hence the patch for the EWS bots. 966997 1 220978 ddkilzer 2014-01-12 11:19:37 -0800 Created attachment 220978 Patch v1 967007 2 220978 commit-queue 2014-01-12 12:02:16 -0800 Comment on attachment 220978 Patch v1 Clearing flags on attachment: 220978 Committed r161821: <http://trac.webkit.org/changeset/161821> 967008 3 commit-queue 2014-01-12 12:02:26 -0800 All reviewed patches have been landed. Closing bug. 220978 2014-01-12 11:19:37 -0800 2014-01-12 12:02:14 -0800 Patch v1 bug-126848-20140112111936.patch text/plain 2866 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMxNDM1MDNkNDQyMzNi NWI2NWY5NzY1MmE1ZWJiMDNmODI0Y2RjZS4uMzg3MTliYmUwZWU0Y2UxYTc4YjQ5YTdmNjA0ZWRh OTY3ZDM2YzNiNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE0LTAxLTEyICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKKyAgICAgICAgTW92ZSBpbXBsZW1lbnRh dGlvbiBvZiBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTo6c2V0QXV0aGVudGljYXRpb25DbGllbnQo KSB0byBzb3VyY2UgZmlsZSBmb3IgVVNFKENGTkVUV09SSykKKyAgICAgICAgPGh0dHA6Ly93ZWJr aXQub3JnL2IvMTI2ODQ4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9BdXRoZW50aWNhdGlvbkNGLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOjpzZXRBdXRoZW50aWNhdGlv bkNsaWVudCk6CisgICAgICAgIE1vdmUgaW1wbGVtZW50YXRpb24gdG8gaGVyZS4uLgorICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvY2YvQXV0aGVudGljYXRpb25DaGFsbGVuZ2UuaDogLi4uZnJv bSBoZXJlLgorICAgICAgICBSZW1vdmUgZHVwbGljYXRlIGhlYWRlciBkZWZpbml0aW9ucyBpbnNp ZGUgVVNFKENGTkVUV09SSykuCisKKzIwMTQtMDEtMTIgIERhdmlkIEtpbHplciAgPGRka2lsemVy QGFwcGxlLmNvbT4KKwogICAgICAgICBbaU9TXSBGaXggbGluayBlcnJvcnMgZm9yIGlPUzogUGFy dCAzCiAKICAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQXV0aGVudGljYXRpb25DRi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0F1dGhlbnRpY2F0aW9uQ0YuY3BwCmluZGV4IDAzMDBh NDBhZmI4MDQ4ZTNiYTE3MDZhMDE2MTM0Y2E1NGY4ZjZhNzYuLjg5YmMzN2ZiMjFhYTYwMjllOTIx ZTg0YzE4YmRiMjg3N2QwNDJmYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvY2YvQXV0aGVudGljYXRpb25DRi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9jZi9BdXRoZW50aWNhdGlvbkNGLmNwcApAQCAtNjgsNiArNjgsMTEgQEAg QXV0aGVudGljYXRpb25DaGFsbGVuZ2U6OkF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKENGVVJMQXV0 aENoYWxsZW5nZVJlZiBjZkNoYWxsZW4KIHsKIH0KIAordm9pZCBBdXRoZW50aWNhdGlvbkNoYWxs ZW5nZTo6c2V0QXV0aGVudGljYXRpb25DbGllbnQoQXV0aGVudGljYXRpb25DbGllbnQqIGNsaWVu dCkKK3sKKyAgICBtX2F1dGhlbnRpY2F0aW9uQ2xpZW50ID0gY2xpZW50OworfQorCiBBdXRoZW50 aWNhdGlvbkNsaWVudCogQXV0aGVudGljYXRpb25DaGFsbGVuZ2U6OmF1dGhlbnRpY2F0aW9uQ2xp ZW50KCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9hdXRoZW50aWNhdGlvbkNsaWVudC5nZXQoKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY2YvQXV0 aGVudGljYXRpb25DaGFsbGVuZ2UuaAppbmRleCA3MjA5YWM3NTk5ZGYxOTZkZWQwOTI0OTljMjFj NzZkMTJhZjliZjA5Li4xNWY0ZWYzYjhjNWM3NDUyMGE1ZDFkMmUyMDFmZjY4MmZiZWZkMDcwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0F1dGhlbnRpY2F0 aW9uQ2hhbGxlbmdlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9B dXRoZW50aWNhdGlvbkNoYWxsZW5nZS5oCkBAIC01MywxOSArNTMsMTYgQEAgcHVibGljOgogI2lm IFVTRShDRk5FVFdPUkspCiAgICAgQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoQ0ZVUkxBdXRoQ2hh bGxlbmdlUmVmLCBBdXRoZW50aWNhdGlvbkNsaWVudCopOwogCi0gICAgQXV0aGVudGljYXRpb25D bGllbnQqIGF1dGhlbnRpY2F0aW9uQ2xpZW50KCkgY29uc3Q7Ci0gICAgdm9pZCBzZXRBdXRoZW50 aWNhdGlvbkNsaWVudChBdXRoZW50aWNhdGlvbkNsaWVudCogY2xpZW50KSB7IG1fYXV0aGVudGlj YXRpb25DbGllbnQgPSBjbGllbnQ7IH0KLQogICAgIENGVVJMQXV0aENoYWxsZW5nZVJlZiBjZlVS TEF1dGhDaGFsbGVuZ2VSZWYoKSBjb25zdCB7IHJldHVybiBtX2NmQ2hhbGxlbmdlLmdldCgpOyB9 CiAjZWxzZQogICAgIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKE5TVVJMQXV0aGVudGljYXRpb25D aGFsbGVuZ2UgKik7CiAKICAgICBpZCBzZW5kZXIoKSBjb25zdCB7IHJldHVybiBtX3NlbmRlci5n ZXQoKTsgfQogICAgIE5TVVJMQXV0aGVudGljYXRpb25DaGFsbGVuZ2UgKm5zVVJMQXV0aGVudGlj YXRpb25DaGFsbGVuZ2UoKSBjb25zdCB7IHJldHVybiBtX25zQ2hhbGxlbmdlLmdldCgpOyB9Cisj ZW5kaWYKIAogICAgIHZvaWQgc2V0QXV0aGVudGljYXRpb25DbGllbnQoQXV0aGVudGljYXRpb25D bGllbnQqKTsgLy8gQ2hhbmdlcyBzZW5kZXIgdG8gb25lIHRoYXQgaW52b2tlcyBjbGllbnQgbWV0 aG9kcy4KICAgICBBdXRoZW50aWNhdGlvbkNsaWVudCogYXV0aGVudGljYXRpb25DbGllbnQoKSBj b25zdDsKLSNlbmRpZgogCiBwcml2YXRlOgogICAgIGZyaWVuZCBjbGFzcyBBdXRoZW50aWNhdGlv bkNoYWxsZW5nZUJhc2U7Cg==