126845 2014-01-12 10:33:16 -0800 Web Inspector: add test for hitting breakpoints from functions called via console 2014-02-11 14:57:35 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg webkit-unassigned commit-queue dpino graouts joepeck timothy webkit-bug-importer oldest_to_newest 966971 0 bburg 2014-01-12 10:33:16 -0800 This is to prevent regression of https://bugs.webkit.org/show_bug.cgi?id=10214 966972 1 webkit-bug-importer 2014-01-12 10:33:32 -0800 <rdar://problem/15801029> 978872 2 223710 dpino 2014-02-10 07:28:51 -0800 Created attachment 223710 Patch 979026 3 223710 commit-queue 2014-02-10 13:32:23 -0800 Comment on attachment 223710 Patch Clearing flags on attachment: 223710 Committed r163811: <http://trac.webkit.org/changeset/163811> 979027 4 commit-queue 2014-02-10 13:32:25 -0800 All reviewed patches have been landed. Closing bug. 979042 5 223710 joepeck 2014-02-10 14:01:00 -0800 Comment on attachment 223710 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=223710&action=review > LayoutTests/inspector-protocol/debugger/hit-breakpoint-from-console.html:23 > + // Shoul hit breakpoint (a > 10). Typo: "Shoul" => "Should" 979619 6 dpino 2014-02-11 14:57:35 -0800 Fixed typo in http://trac.webkit.org/changeset/163911. Thanks. 223710 2014-02-10 07:28:51 -0800 2014-02-10 14:01:00 -0800 Patch bug-126845-20140210162849.patch text/plain 3442 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYzNzMzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTEyMDA4MGVhOTJkNDVmZjZjM2Mz Nzg2NjNjYzQxYWViOWEzY2IyOS4uNmNjZTg5MzRlYTU1ZGFhNmFjMjAxMzE4NzQ2NTI4Yzg3YTZk NzQ4NSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAyLTEwICBEaWVnbyBQaW5vIEdhcmNp YSAgPGRwaW5vQGlnYWxpYS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYWRkIHRlc3Qg Zm9yIGhpdHRpbmcgYnJlYWtwb2ludHMgZnJvbSBmdW5jdGlvbnMgY2FsbGVkIHZpYSBjb25zb2xl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY4NDUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3Bl Y3Rvci1wcm90b2NvbC9kZWJ1Z2dlci9oaXQtYnJlYWtwb2ludC1mcm9tLWNvbnNvbGUtZXhwZWN0 ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBpbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIvaGl0 LWJyZWFrcG9pbnQtZnJvbS1jb25zb2xlLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAyLTA4ICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBJREI6IHN0b3JhZ2UvaW5k ZXhlZGRiL21vemlsbGEvdmVyc2lvbmNoYW5nZS1hYm9ydC5odG1sIGZhaWxzCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIvaGl0LWJyZWFrcG9pbnQt ZnJvbS1jb25zb2xlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci1wcm90b2Nv bC9kZWJ1Z2dlci9oaXQtYnJlYWtwb2ludC1mcm9tLWNvbnNvbGUtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmQ3NjY0OWQyNTc1YzQ3NjhhOTg3MjBiZDUxNGFhYjAxMjEyYWUxNDYKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIvaGl0LWJy ZWFrcG9pbnQtZnJvbS1jb25zb2xlLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAKK0RlYnVn Z2VyLnNldEJyZWFrcG9pbnQgb24gbGluZToxOCBpbiA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2Jy ZWFrcG9pbnQuanMiPgorCitGb3VuZCBicmVha3BvaW50LmpzCitpbnNpZGUgYnJlYWtwb2ludEFj dGlvbnMgYTooMikgYjooW29iamVjdCBPYmplY3RdKQoraW5zaWRlIGJyZWFrcG9pbnRBY3Rpb25z IGE6KDEyKSBiOihbb2JqZWN0IE9iamVjdF0pCitIaXQgQnJlYWtwb2ludCEKK1BBU1MKKwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29sL2RlYnVnZ2VyL2hpdC1icmVh a3BvaW50LWZyb20tY29uc29sZS5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yLXByb3RvY29s L2RlYnVnZ2VyL2hpdC1icmVha3BvaW50LWZyb20tY29uc29sZS5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQx MmMzYmY4ZmQ1MzA0MjA5MmY0NTZiYzNlOTQ5NDA2Y2Y2ZjUwNDQKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9pbnNwZWN0b3ItcHJvdG9jb2wvZGVidWdnZXIvaGl0LWJyZWFrcG9pbnQt ZnJvbS1jb25zb2xlLmh0bWwKQEAgLTAsMCArMSw0MiBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3Jp cHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci1wcm90b2NvbC9yZXNvdXJjZXMvcHJv dG9jb2wtdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2JyZWFrcG9p bnQuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIEluc3Bl Y3RvclRlc3Quc2VuZENvbW1hbmQoIkRlYnVnZ2VyLmVuYWJsZSIsIHt9KTsKKworICAgIEluc3Bl Y3RvclRlc3QuZXZlbnRIYW5kbGVyWyJEZWJ1Z2dlci5zY3JpcHRQYXJzZWQiXSA9IGZ1bmN0aW9u KG1lc3NhZ2VPYmplY3QpCisgICAgeworICAgICAgICBpZiAoL3Jlc291cmNlc1wvYnJlYWtwb2lu dFwuanMkLy50ZXN0KG1lc3NhZ2VPYmplY3QucGFyYW1zLnVybCkpIHsKKyAgICAgICAgICAgIElu c3BlY3RvclRlc3QubG9nKCJGb3VuZCBicmVha3BvaW50LmpzIik7CisgICAgICAgICAgICB2YXIg c2NyaXB0SWRlbnRpZmllciA9IG1lc3NhZ2VPYmplY3QucGFyYW1zLnNjcmlwdElkOworICAgICAg ICAgICAgdmFyIGxvY2F0aW9uID0ge3NjcmlwdElkOiBzY3JpcHRJZGVudGlmaWVyLCBsaW5lTnVt YmVyOiAxOCwgY29sdW1uTnVtYmVyOiAwfTsKKyAgICAgICAgICAgIHZhciBvcHRpb25zID0gewor ICAgICAgICAgICAgICAgIGNvbmRpdGlvbjogImEgPiAxMCIsCisgICAgICAgICAgICB9OworICAg ICAgICAgICAgSW5zcGVjdG9yVGVzdC5zZW5kQ29tbWFuZCgiRGVidWdnZXIuc2V0QnJlYWtwb2lu dCIsIHtsb2NhdGlvbjogbG9jYXRpb24sIG9wdGlvbnM6IG9wdGlvbnN9LCBmdW5jdGlvbihyZXNw b25zZU9iamVjdCkgeworICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuY2hlY2tGb3JFcnJv cihyZXNwb25zZU9iamVjdCk7CisgICAgICAgICAgICAgICAgLy8gU2hvdWxkIE5PVCBoaXQgYnJl YWtwb2ludCAoYSA8IDEwKS4KKyAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LnNlbmRDb21t YW5kKCJSdW50aW1lLmV2YWx1YXRlIiwge2V4cHJlc3Npb246ICJicmVha3BvaW50QWN0aW9ucygy LCB7eDoxLHk6Mn0pIn0pOworICAgICAgICAgICAgICAgIC8vIFNob3VsIGhpdCBicmVha3BvaW50 IChhID4gMTApLgorICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Quc2VuZENvbW1hbmQoIlJ1 bnRpbWUuZXZhbHVhdGUiLCB7ZXhwcmVzc2lvbjogImJyZWFrcG9pbnRBY3Rpb25zKDEyLCB7eDox LHk6Mn0pIn0pOworICAgICAgICAgICAgfSk7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBJbnNw ZWN0b3JUZXN0LmV2ZW50SGFuZGxlclsiRGVidWdnZXIucGF1c2VkIl0gPSBmdW5jdGlvbihtZXNz YWdlT2JqZWN0KQorICAgIHsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coIkhpdCBCcmVha3Bv aW50ISIpOworICAgICAgICBJbnNwZWN0b3JUZXN0LmxvZygiUEFTUyIpOworICAgICAgICBJbnNw ZWN0b3JUZXN0LmNvbXBsZXRlVGVzdCgpOworICAgIH0KKworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+ Cis8Ym9keSBvbmxvYWQ9InJ1blRlc3QoKSI+Cis8cD5EZWJ1Z2dlci5zZXRCcmVha3BvaW50IG9u IGxpbmU6MTggaW4gJmx0O3NjcmlwdCBzcmM9InJlc291cmNlcy9icmVha3BvaW50LmpzIiZndDs8 L3A+Cis8L2JvZHk+Cis8L2h0bWw+Cg==