126839 2014-01-12 04:33:35 -0800 REGRESSION(r160806): line-height is not applied when only present in :link style. 2014-01-12 10:51:30 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kling kling allan.jensen commit-queue esprehn+autocc glenn gyuyoung.kim kling macpherson menard oldest_to_newest 966931 0 kling 2014-01-12 04:33:35 -0800 <rdar://problem/15799899> 966934 1 220966 kling 2014-01-12 04:36:56 -0800 Created attachment 220966 Patch 966935 2 220967 kling 2014-01-12 04:37:36 -0800 Created attachment 220967 Patch 966942 3 220967 koivisto 2014-01-12 05:11:20 -0800 Comment on attachment 220967 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220967&action=review > Source/WebCore/css/StyleResolver.cpp:4255 > + if (auto value = state.style()->insideLink() == NotInsideLink ? cssValue[0] : cssValue[SelectorChecker::MatchLink]) cssValue indexing by LinkMatchMask is pretty incomprehensible. It might be better to just have separate variables (cssValue/linkCSSValue/visitedCSSValue or similar). 966970 4 kling 2014-01-12 10:22:26 -0800 (In reply to comment #3) > (From update of attachment 220967 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220967&action=review > > > Source/WebCore/css/StyleResolver.cpp:4255 > > + if (auto value = state.style()->insideLink() == NotInsideLink ? cssValue[0] : cssValue[SelectorChecker::MatchLink]) > > cssValue indexing by LinkMatchMask is pretty incomprehensible. It might be better to just have separate variables (cssValue/linkCSSValue/visitedCSSValue or similar). Yeah, I agree. Let's keep this fix surgical and sort that in a separate change though. 966982 5 220967 commit-queue 2014-01-12 10:51:28 -0800 Comment on attachment 220967 Patch Clearing flags on attachment: 220967 Committed r161814: <http://trac.webkit.org/changeset/161814> 966983 6 commit-queue 2014-01-12 10:51:30 -0800 All reviewed patches have been landed. Closing bug. 220966 2014-01-12 04:36:56 -0800 2014-01-12 04:37:36 -0800 Patch bug-126839.diff text/plain 1525 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwZDNkOTdkLi5iZTkxMjU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMDEtMTIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04ocjE2MDgwNik6IGxpbmUtaGVpZ2h0IGlzIG5vdCBhcHBsaWVkIHdoZW4g b25seSBwcmVzZW50IGluIDpsaW5rIHN0eWxlLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcv Yi8xMjY4Mzk+CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNTc5OTg5OT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9saW5l LWhlaWdodC1saW5rLXN0eWxlLmh0bWwKKworICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlN0eWxlUmVzb2x2ZXI6OkNhc2NhZGVkUHJvcGVydGllczo6 UHJvcGVydHk6OmFwcGx5KToKKworICAgICAgICAgICAgVXNlIHRoZSBDU1NWYWx1ZSBmb3IgU2Vs ZWN0b3JDaGVja2VyOjpNYXRjaExpbmsgd2hlbiBhcHBseWluZworICAgICAgICAgICAgc3R5bGUg aW5zaWRlIGEgbGluay4KKwogMjAxNC0wMS0xMSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1NdIERvIG5vdCBsaW5rIHRvIEFwcGxpY2F0aW9uU2Vydmlj ZXMuZnJhbWV3b3JrIGZvciBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcAppbmRl eCAyZjdiNjA3Li4wNjRjNjM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVS ZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCkBA IC00MjUyLDggKzQyNTIsOCBAQCB2b2lkIFN0eWxlUmVzb2x2ZXI6OkNhc2NhZGVkUHJvcGVydGll czo6UHJvcGVydHk6OmFwcGx5KFN0eWxlUmVzb2x2ZXImIHJlc29sdmVyKQogCiAgICAgLy8gRklY TUU6IEl0IHdvdWxkIGJlIG5pY2UgaWYgbGluZS1oZWlnaHQgd2VyZSBsZXNzIG9mIGEgc3BlY2lh bCBzbm93Zmxha2UuCiAgICAgaWYgKGlkID09IENTU1Byb3BlcnR5TGluZUhlaWdodCkgewotICAg ICAgICBpZiAoY3NzVmFsdWVbMF0pCi0gICAgICAgICAgICBzdGF0ZS5zZXRMaW5lSGVpZ2h0VmFs dWUoY3NzVmFsdWVbMF0pOworICAgICAgICBpZiAoYXV0byB2YWx1ZSA9IHN0YXRlLnN0eWxlKCkt Pmluc2lkZUxpbmsoKSA9PSBOb3RJbnNpZGVMaW5rID8gY3NzVmFsdWVbMF0gOiBjc3NWYWx1ZVtT ZWxlY3RvckNoZWNrZXI6Ok1hdGNoTGlua10pCisgICAgICAgICAgICBzdGF0ZS5zZXRMaW5lSGVp Z2h0VmFsdWUodmFsdWUpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCg== 220967 2014-01-12 04:37:36 -0800 2014-01-12 10:51:28 -0800 Patch bug-126839.diff text/plain 3854 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5Y2FkMmZiLi44ZTc0NTUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDEt MTIgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjE2MDgwNik6IGxpbmUtaGVpZ2h0IGlzIG5vdCBhcHBsaWVkIHdoZW4gb25seSBwcmVzZW50 IGluIDpsaW5rIHN0eWxlLgorICAgICAgICA8aHR0cDovL3dlYmtpdC5vcmcvYi8xMjY4Mzk+Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNTc5OTg5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvY3NzL2xpbmUtaGVpZ2h0LWxpbmstc3R5 bGUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9saW5lLWhlaWdodC1s aW5rLXN0eWxlLmh0bWw6IEFkZGVkLgorCiAyMDE0LTAxLTExICBCcmVudCBGdWxnaGFtICA8YmZ1 bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHTF0gQ29ycmVjdCB1bmlmb3JtIGlucHV0 IHZhbGlkYXRpb24gZm9yIHRleHR1cmUgc2FtcGxlciB1bmlmb3JtcwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9jc3MvbGluZS1oZWlnaHQtbGluay1zdHlsZS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9saW5lLWhlaWdodC1saW5rLXN0eWxlLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi42NTM5MzQ0Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGluZS1oZWlnaHQtbGluay1zdHlsZS1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGhpcyB0ZXN0IHZlcmlmaWVzIHRoYXQgbGluZS1oZWln aHQgZ2V0cyBhcHBsaWVkIGZyb20gbGluay1vbmx5IHN0eWxlLgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKworUEFTUyByZWd1bGFyQ29tcHV0ZWRTdHlsZS5saW5lSGVpZ2h0IGlzICcx MDBweCcKK1BBU1MgbGlua0NvbXB1dGVkU3R5bGUubGluZUhlaWdodCBpcyAnMjAwcHgnCitQQVNT IHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvbGluZS1oZWlnaHQtbGluay1zdHlsZS5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9jc3MvbGluZS1oZWlnaHQtbGluay1zdHlsZS5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmRjYTQ4YjcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9mYXN0L2Nzcy9saW5lLWhlaWdodC1saW5rLXN0eWxlLmh0bWwKQEAgLTAsMCArMSwz MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPG1ldGEgY2hhcnNldD0idXRm LTgiPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3Jp cHQ+Cis8c3R5bGU+CithIHsgbGluZS1oZWlnaHQ6IDEwMHB4IH0KK2E6bGluayB7IGxpbmUtaGVp Z2h0OiAyMDBweCB9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGlkPSJndW5rIj4K KyAgICA8YSBpZD0iYV9yZWd1bGFyIj5yZWd1bGFyIGFuY2hvcjwvYT4KKyAgICA8YSBpZD0iYV9s aW5rIiBocmVmPSIjIj5saW5rIGFuY2hvcjwvYT4KKzwvZGl2PgorPHNjcmlwdD4KKworZGVzY3Jp cHRpb24oIlRoaXMgdGVzdCB2ZXJpZmllcyB0aGF0IGxpbmUtaGVpZ2h0IGdldHMgYXBwbGllZCBm cm9tIGxpbmstb25seSBzdHlsZS4iKTsKKwordmFyIHJlZ3VsYXJDb21wdXRlZFN0eWxlID0gd2lu ZG93LmdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImFfcmVndWxhciIp KTsKK3ZhciBsaW5rQ29tcHV0ZWRTdHlsZSA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJhX2xpbmsiKSk7CisKK3Nob3VsZEJlKCJyZWd1bGFyQ29tcHV0 ZWRTdHlsZS5saW5lSGVpZ2h0IiwgIicxMDBweCciKTsKK3Nob3VsZEJlKCJsaW5rQ29tcHV0ZWRT dHlsZS5saW5lSGVpZ2h0IiwgIicyMDBweCciKTsKKworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo Imd1bmsiKS5yZW1vdmUoKTsKKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3Vy Y2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggMGQzZDk3ZC4uYmU5MTI1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0 LTAxLTEyICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdS RVNTSU9OKHIxNjA4MDYpOiBsaW5lLWhlaWdodCBpcyBub3QgYXBwbGllZCB3aGVuIG9ubHkgcHJl c2VudCBpbiA6bGluayBzdHlsZS4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvMTI2ODM5 PgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTU3OTk4OTk+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvbGluZS1oZWlnaHQt bGluay1zdHlsZS5odG1sCisKKyAgICAgICAgKiBjc3MvU3R5bGVSZXNvbHZlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpTdHlsZVJlc29sdmVyOjpDYXNjYWRlZFByb3BlcnRpZXM6OlByb3BlcnR5 OjphcHBseSk6CisKKyAgICAgICAgICAgIFVzZSB0aGUgQ1NTVmFsdWUgZm9yIFNlbGVjdG9yQ2hl Y2tlcjo6TWF0Y2hMaW5rIHdoZW4gYXBwbHlpbmcKKyAgICAgICAgICAgIHN0eWxlIGluc2lkZSBh IGxpbmsuCisKIDIwMTQtMDEtMTEgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBEbyBub3QgbGluayB0byBBcHBsaWNhdGlvblNlcnZpY2VzLmZyYW1l d29yayBmb3IgaU9TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKaW5kZXggMmY3YjYw Ny4uMDY0YzYzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUmVzb2x2ZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcApAQCAtNDI1Miw4 ICs0MjUyLDggQEAgdm9pZCBTdHlsZVJlc29sdmVyOjpDYXNjYWRlZFByb3BlcnRpZXM6OlByb3Bl cnR5OjphcHBseShTdHlsZVJlc29sdmVyJiByZXNvbHZlcikKIAogICAgIC8vIEZJWE1FOiBJdCB3 b3VsZCBiZSBuaWNlIGlmIGxpbmUtaGVpZ2h0IHdlcmUgbGVzcyBvZiBhIHNwZWNpYWwgc25vd2Zs YWtlLgogICAgIGlmIChpZCA9PSBDU1NQcm9wZXJ0eUxpbmVIZWlnaHQpIHsKLSAgICAgICAgaWYg KGNzc1ZhbHVlWzBdKQotICAgICAgICAgICAgc3RhdGUuc2V0TGluZUhlaWdodFZhbHVlKGNzc1Zh bHVlWzBdKTsKKyAgICAgICAgaWYgKGF1dG8gdmFsdWUgPSBzdGF0ZS5zdHlsZSgpLT5pbnNpZGVM aW5rKCkgPT0gTm90SW5zaWRlTGluayA/IGNzc1ZhbHVlWzBdIDogY3NzVmFsdWVbU2VsZWN0b3JD aGVja2VyOjpNYXRjaExpbmtdKQorICAgICAgICAgICAgc3RhdGUuc2V0TGluZUhlaWdodFZhbHVl KHZhbHVlKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAo=