126838 2014-01-11 22:27:56 -0800 Remove unsafe uses of AtomicallyInitializedStatic 2014-01-12 09:29:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue japhet oldest_to_newest 966915 0 andersca 2014-01-11 22:27:56 -0800 Remove unsafe uses of AtomicallyInitializedStatic 966916 1 220960 andersca 2014-01-11 22:31:51 -0800 Created attachment 220960 Patch 966917 2 220960 kling 2014-01-11 22:43:31 -0800 Comment on attachment 220960 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220960&action=review What was even going on here. r=me > Source/WebCore/ChangeLog:12 > + (This is highly unlikely to have any real negative performance impact since these tow functions >tow 966967 3 andersca 2014-01-12 09:29:31 -0800 Committed r161812: <http://trac.webkit.org/changeset/161812> 220960 2014-01-11 22:31:51 -0800 2014-01-11 22:43:31 -0800 Patch bug-126838-20140111223150.patch text/plain 4478 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxODAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTRkZTVjODM4MmJmMTA3 ZTc5MDFhM2E5MTI5M2E3NWU0MTUxNjg0My4uMDUxYjc2MGU0ODQ4YjFkODJmOGNmNDY4MjE5Nzgx MzhjYmYxZWZkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTAxLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUmVtb3ZlIHVuc2Fm ZSB1c2VzIG9mIEF0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpYworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODM4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXRvbWljU3RyaW5ncyBhcmUgcGVyIHRocmVh ZCBzbyBhbnkgc3RhdGljIGluaXRpYWxpemF0aW9uIG9mIHRoZW0gaXMgcG90ZW50aWFsbHkgZGFu Z2Vyb3VzCisgICAgICAgIHVubGVzcyBpdCdzIGNlcnRhaW4gdGhhdCB0aGV5J3JlIG9ubHkgZXZl ciB1c2VkIGZyb20gdGhlIHNhbWUgdGhyZWFkLgorICAgICAgICAKKyAgICAgICAgVGhpcyBnb2Vz IGFnYWluc3QgdXNpbmcgdGhlbSB3aXRoIEF0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpYywgc28g anVzdCBjcmVhdGUgQXRvbWljU3RyaW5ncyB3aGVyZSBuZWVkZWQuCisgICAgICAgIChUaGlzIGlz IGhpZ2hseSB1bmxpa2VseSB0byBoYXZlIGFueSByZWFsIG5lZ2F0aXZlIHBlcmZvcm1hbmNlIGlt cGFjdCBzaW5jZSB0aGVzZSB0b3cgZnVuY3Rpb25zCisgICAgICAgIGFyZW4ndCBjYWxsZWQgdmVy eSBmcmVxdWVudGx5KS4KKworICAgICAgICAqIGxvYWRlci9Dcm9zc09yaWdpbkFjY2Vzc0NvbnRy b2wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cGFzc2VzQWNjZXNzQ29udHJvbENoZWNrKToKKyAg ICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VUaW1pbmcuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6cGFzc2VzVGltaW5nQWxsb3dDaGVjayk6CisKKzIwMTQtMDEtMTEgIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKwogICAgICAgICBVc2Ugc3RkOjpjYWxsX29uY2Ug aW5zdGVhZCBvZiBBdG9taWNhbGx5SW5pdGlhbGl6ZWRTdGF0aWMgd2hlbiBjcmVhdGluZyBhIEhU VFAgaGVhZGVyIHNldAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI2ODM3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Dcm9zc09y aWdpbkFjY2Vzc0NvbnRyb2wuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Nyb3NzT3JpZ2lu QWNjZXNzQ29udHJvbC5jcHAKaW5kZXggYWJjNjExZjY2MjQ5YzcwODRmNTg3M2I3OGZlM2Q4ODcw M2FmMDE5Ny4uMjU3YjQzZWQ4MzEzNzg0MWE0MDEyNDExODhjMTgwNDA0NWQxYTdkOCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Nyb3NzT3JpZ2luQWNjZXNzQ29udHJvbC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0Nyb3NzT3JpZ2luQWNjZXNzQ29udHJvbC5jcHAK QEAgLTEzMywxMiArMTMzLDkgQEAgUmVzb3VyY2VSZXF1ZXN0IGNyZWF0ZUFjY2Vzc0NvbnRyb2xQ cmVmbGlnaHRSZXF1ZXN0KGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWUKIAogYm9vbCBwYXNz ZXNBY2Nlc3NDb250cm9sQ2hlY2soY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVzcG9uc2UsIFN0 b3JlZENyZWRlbnRpYWxzIGluY2x1ZGVDcmVkZW50aWFscywgU2VjdXJpdHlPcmlnaW4qIHNlY3Vy aXR5T3JpZ2luLCBTdHJpbmcmIGVycm9yRGVzY3JpcHRpb24pCiB7Ci0gICAgQXRvbWljYWxseUlu aXRpYWxpemVkU3RhdGljKEF0b21pY1N0cmluZyYsIGFjY2Vzc0NvbnRyb2xBbGxvd09yaWdpbiA9 ICpuZXcgQXRvbWljU3RyaW5nKCJhY2Nlc3MtY29udHJvbC1hbGxvdy1vcmlnaW4iLCBBdG9taWNT dHJpbmc6OkNvbnN0cnVjdEZyb21MaXRlcmFsKSk7Ci0gICAgQXRvbWljYWxseUluaXRpYWxpemVk U3RhdGljKEF0b21pY1N0cmluZyYsIGFjY2Vzc0NvbnRyb2xBbGxvd0NyZWRlbnRpYWxzID0gKm5l dyBBdG9taWNTdHJpbmcoImFjY2Vzcy1jb250cm9sLWFsbG93LWNyZWRlbnRpYWxzIiwgQXRvbWlj U3RyaW5nOjpDb25zdHJ1Y3RGcm9tTGl0ZXJhbCkpOwotCiAgICAgLy8gQSB3aWxkY2FyZCBBY2Nl c3MtQ29udHJvbC1BbGxvdy1PcmlnaW4gY2FuIG5vdCBiZSB1c2VkIGlmIGNyZWRlbnRpYWxzIGFy ZSB0byBiZSBzZW50LAogICAgIC8vIGV2ZW4gd2l0aCBBY2Nlc3MtQ29udHJvbC1BbGxvdy1DcmVk ZW50aWFscyBzZXQgdG8gdHJ1ZS4KLSAgICBjb25zdCBTdHJpbmcmIGFjY2Vzc0NvbnRyb2xPcmln aW5TdHJpbmcgPSByZXNwb25zZS5odHRwSGVhZGVyRmllbGQoYWNjZXNzQ29udHJvbEFsbG93T3Jp Z2luKTsKKyAgICBjb25zdCBTdHJpbmcmIGFjY2Vzc0NvbnRyb2xPcmlnaW5TdHJpbmcgPSByZXNw b25zZS5odHRwSGVhZGVyRmllbGQoImFjY2Vzcy1jb250cm9sLWFsbG93LW9yaWdpbiIpOwogICAg IGlmIChhY2Nlc3NDb250cm9sT3JpZ2luU3RyaW5nID09ICIqIiAmJiBpbmNsdWRlQ3JlZGVudGlh bHMgPT0gRG9Ob3RBbGxvd1N0b3JlZENyZWRlbnRpYWxzKQogICAgICAgICByZXR1cm4gdHJ1ZTsK IApAQCAtMTU3LDcgKzE1NCw3IEBAIGJvb2wgcGFzc2VzQWNjZXNzQ29udHJvbENoZWNrKGNvbnN0 IFJlc291cmNlUmVzcG9uc2UmIHJlc3BvbnNlLCBTdG9yZWRDcmVkZW50aWFsCiAgICAgfQogCiAg ICAgaWYgKGluY2x1ZGVDcmVkZW50aWFscyA9PSBBbGxvd1N0b3JlZENyZWRlbnRpYWxzKSB7Ci0g ICAgICAgIGNvbnN0IFN0cmluZyYgYWNjZXNzQ29udHJvbENyZWRlbnRpYWxzU3RyaW5nID0gcmVz cG9uc2UuaHR0cEhlYWRlckZpZWxkKGFjY2Vzc0NvbnRyb2xBbGxvd0NyZWRlbnRpYWxzKTsKKyAg ICAgICAgY29uc3QgU3RyaW5nJiBhY2Nlc3NDb250cm9sQ3JlZGVudGlhbHNTdHJpbmcgPSByZXNw b25zZS5odHRwSGVhZGVyRmllbGQoImFjY2Vzcy1jb250cm9sLWFsbG93LWNyZWRlbnRpYWxzIik7 CiAgICAgICAgIGlmIChhY2Nlc3NDb250cm9sQ3JlZGVudGlhbHNTdHJpbmcgIT0gInRydWUiKSB7 CiAgICAgICAgICAgICBlcnJvckRlc2NyaXB0aW9uID0gIkNyZWRlbnRpYWxzIGZsYWcgaXMgdHJ1 ZSwgYnV0IEFjY2Vzcy1Db250cm9sLUFsbG93LUNyZWRlbnRpYWxzIGlzIG5vdCBcInRydWVcIi4i OwogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9QZXJmb3JtYW5jZVJlc291cmNlVGltaW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv UGVyZm9ybWFuY2VSZXNvdXJjZVRpbWluZy5jcHAKaW5kZXggZjhmZmMwY2M3OTE1YjJhYWU0ODJh ZWUzNGRlOTJlZjVmNzk5MDQ5Mi4uYmI2YmM2YWQ5ZDRhMTBhYzRhY2RiZjBmMDM3NDI5MjMwNGEw NWQwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZVJlc291cmNl VGltaW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlUmVzb3VyY2VU aW1pbmcuY3BwCkBAIC01MywxMyArNTMsMTEgQEAgc3RhdGljIGRvdWJsZSBtb25vdG9uaWNUaW1l VG9Eb2N1bWVudE1pbGxpc2Vjb25kcyhEb2N1bWVudCogZG9jdW1lbnQsIGRvdWJsZSBzZWMKIAog c3RhdGljIGJvb2wgcGFzc2VzVGltaW5nQWxsb3dDaGVjayhjb25zdCBSZXNvdXJjZVJlc3BvbnNl JiByZXNwb25zZSwgRG9jdW1lbnQqIHJlcXVlc3RpbmdEb2N1bWVudCkKIHsKLSAgICBBdG9taWNh bGx5SW5pdGlhbGl6ZWRTdGF0aWMoQXRvbWljU3RyaW5nJiwgdGltaW5nQWxsb3dPcmlnaW4gPSAq bmV3IEF0b21pY1N0cmluZygidGltaW5nLWFsbG93LW9yaWdpbiIpKTsKLQogICAgIFJlZlB0cjxT ZWN1cml0eU9yaWdpbj4gcmVzb3VyY2VPcmlnaW4gPSBTZWN1cml0eU9yaWdpbjo6Y3JlYXRlKHJl c3BvbnNlLnVybCgpKTsKICAgICBpZiAocmVzb3VyY2VPcmlnaW4tPmlzU2FtZVNjaGVtZUhvc3RQ b3J0KHJlcXVlc3RpbmdEb2N1bWVudC0+c2VjdXJpdHlPcmlnaW4oKSkpCiAgICAgICAgIHJldHVy biB0cnVlOwogCi0gICAgY29uc3QgU3RyaW5nJiB0aW1pbmdBbGxvd09yaWdpblN0cmluZyA9IHJl c3BvbnNlLmh0dHBIZWFkZXJGaWVsZCh0aW1pbmdBbGxvd09yaWdpbik7CisgICAgY29uc3QgU3Ry aW5nJiB0aW1pbmdBbGxvd09yaWdpblN0cmluZyA9IHJlc3BvbnNlLmh0dHBIZWFkZXJGaWVsZCgi dGltaW5nLWFsbG93LW9yaWdpbiIpOwogICAgIGlmICh0aW1pbmdBbGxvd09yaWdpblN0cmluZy5p c0VtcHR5KCkgfHwgZXF1YWxJZ25vcmluZ0Nhc2UodGltaW5nQWxsb3dPcmlnaW5TdHJpbmcsICJu dWxsIikpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAo=