126833 2014-01-11 20:35:27 -0800 Web Inspector: Resource and Frame saveIdentityToCookie should store URL hashes not URLs 2014-03-14 09:07:03 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy webkit-unassigned commit-queue joepeck timothy webkit-bug-importer oldest_to_newest 966890 0 timothy 2014-01-11 20:35:27 -0800 To save space and avoid some privacy leaks in URLs getting saved to disk, we should use String.prototype.hash to save the identity of the URL without the actual URL. We use String.prototype.hash for many state WebInspector.Settings already, some for URLs. 966891 1 webkit-bug-importer 2014-01-11 20:35:38 -0800 <rdar://problem/15800369> 990414 2 226688 dpino 2014-03-14 05:05:01 -0700 Created attachment 226688 Patch 990491 3 226688 timothy 2014-03-14 08:35:04 -0700 Comment on attachment 226688 Patch Thanks! 990509 4 226688 commit-queue 2014-03-14 09:07:00 -0700 Comment on attachment 226688 Patch Clearing flags on attachment: 226688 Committed r165621: <http://trac.webkit.org/changeset/165621> 990510 5 commit-queue 2014-03-14 09:07:03 -0700 All reviewed patches have been landed. Closing bug. 226688 2014-03-14 05:05:01 -0700 2014-03-14 09:07:00 -0700 Patch bug-126833-20140314130437.patch text/plain 2235 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMTY1NTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 MjBjMWI0OTQyNDMyYmEwZWJmMTNjNGQwMmRjMDIwOWQ1ODIzMzMxLi5lMTNjYzQ2OTUyZTk3YWFl MjI2ODAyNTdjZmQ2NWJkYWY2NmIyMTZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMy0xNCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJlc291cmNlIGFuZCBGcmFtZSBzYXZlSWRl bnRpdHlUb0Nvb2tpZSBzaG91bGQgc3RvcmUgVVJMIGhhc2hlcyBub3QgVVJMcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODMzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01v ZGVscy9GcmFtZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5GcmFtZS5wcm90b3R5cGUuc2F2 ZUlkZW50aXR5VG9Db29raWUpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1Jlc291 cmNlLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlLnByb3RvdHlwZS5zYXZlSWRl bnRpdHlUb0Nvb2tpZSk6CisKIDIwMTQtMDMtMTIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbaU9TIDZdIHVuY2F1Z2h0IGV4 Y2VwdGlvbiBhdHRlbXB0aW5nIHRvIHVzZSBDU1NBZ2VudC5nZXROYW1lZEZsb3dDb2xsZWN0aW9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv RnJhbWUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvRnJh bWUuanMKaW5kZXggN2U2MmE5OWQ4NzY3MDQ1ZWMzMWMzNDQ2NTQzMjlkMzk4ZTNlNzBiYi4uYTBi YTkzOThkYWYzMzFkMjMxNDMyMTQ2YzY4OGEzOGUzYzY5MjU1MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0ZyYW1lLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9GcmFtZS5qcwpAQCAtNDY0LDcg KzQ2NCw3IEBAIFdlYkluc3BlY3Rvci5GcmFtZS5wcm90b3R5cGUgPSB7CiAKICAgICBzYXZlSWRl bnRpdHlUb0Nvb2tpZTogZnVuY3Rpb24oY29va2llKQogICAgIHsKLSAgICAgICAgY29va2llW1dl Ykluc3BlY3Rvci5GcmFtZS5NYWluUmVzb3VyY2VVUkxDb29raWVLZXldID0gdGhpcy5tYWluUmVz b3VyY2UudXJsOworICAgICAgICBjb29raWVbV2ViSW5zcGVjdG9yLkZyYW1lLk1haW5SZXNvdXJj ZVVSTENvb2tpZUtleV0gPSB0aGlzLm1haW5SZXNvdXJjZS51cmwuaGFzaDsKICAgICB9LAogCiAg ICAgLy8gUHJpdmF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzCmluZGV4IDAxOWQ1M2FjZDkwZTJkMjYyOWYyYTUyOGVm ZDk3MWQ1ZjhmYTA2Y2UuLjgyNjQxYTgwZDQ0NmJmOTFhMjhlN2MzZjE0ZmVlNjNjMjMxNDQ5MjIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9S ZXNvdXJjZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2Rl bHMvUmVzb3VyY2UuanMKQEAgLTY5OSw3ICs2OTksNyBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2Uu cHJvdG90eXBlID0gewogCiAgICAgc2F2ZUlkZW50aXR5VG9Db29raWU6IGZ1bmN0aW9uKGNvb2tp ZSkKICAgICB7Ci0gICAgICAgIGNvb2tpZVtXZWJJbnNwZWN0b3IuUmVzb3VyY2UuVVJMQ29va2ll S2V5XSA9IHRoaXMudXJsOworICAgICAgICBjb29raWVbV2ViSW5zcGVjdG9yLlJlc291cmNlLlVS TENvb2tpZUtleV0gPSB0aGlzLnVybC5oYXNoOwogICAgICAgICBjb29raWVbV2ViSW5zcGVjdG9y LlJlc291cmNlLk1haW5SZXNvdXJjZUNvb2tpZUtleV0gPSB0aGlzLmlzTWFpblJlc291cmNlKCk7 CiAgICAgfQogfTsK