<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126823</bug_id>
          
          <creation_ts>2014-01-11 12:13:20 -0800</creation_ts>
          <short_desc>Support bool argument for encoding/decoding invocations.</short_desc>
          <delta_ts>2014-01-11 23:27:50 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yongjun Zhang">yongjun_zhang</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>andersca</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mitz</cc>
    
    <cc>sam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>966829</commentid>
    <comment_count>0</comment_count>
    <who name="Yongjun Zhang">yongjun_zhang</who>
    <bug_when>2014-01-11 12:13:20 -0800</bug_when>
    <thetext>For remote invocation argument, current we support int, double and ObjC objet; it would be nice to add support for bool type too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966853</commentid>
    <comment_count>1</comment_count>
      <attachid>220948</attachid>
    <who name="Yongjun Zhang">yongjun_zhang</who>
    <bug_when>2014-01-11 16:42:08 -0800</bug_when>
    <thetext>Created attachment 220948
add bool argument support for remote invocations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966897</commentid>
    <comment_count>2</comment_count>
      <attachid>220948</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2014-01-11 21:10:10 -0800</bug_when>
    <thetext>Comment on attachment 220948
add bool argument support for remote invocations.

Can you test this in testapi.mm?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966898</commentid>
    <comment_count>3</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2014-01-11 21:10:48 -0800</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 220948 [details])
&gt; Can you test this in testapi.mm?

Please ignore this comment completely. It makes no sense.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966918</commentid>
    <comment_count>4</comment_count>
      <attachid>220948</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-11 23:27:48 -0800</bug_when>
    <thetext>Comment on attachment 220948
add bool argument support for remote invocations.

Clearing flags on attachment: 220948

Committed r161804: &lt;http://trac.webkit.org/changeset/161804&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966919</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-11 23:27:50 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220948</attachid>
            <date>2014-01-11 16:42:08 -0800</date>
            <delta_ts>2014-01-11 23:27:48 -0800</delta_ts>
            <desc>add bool argument support for remote invocations.</desc>
            <filename>bool_argument.patch</filename>
            <type>text/plain</type>
            <size>1933</size>
            <attacher name="Yongjun Zhang">yongjun_zhang</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTc4MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTExICBZb25nanVu
IFpoYW5nICA8eW9uZ2p1bl96aGFuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcG9ydCBib29s
IGFyZ3VtZW50IGZvciBlbmNvZGluZy9kZWNvZGluZyBpbnZvY2F0aW9ucy4KKyAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjgyMworCisgICAgICAgIFJl
dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciByZW1vdGUgaW52b2NhdGlv
biBtZXRob2QgYXJndW1lbnQsIGN1cnJlbnQgd2Ugc3VwcG9ydCBpbnQsIGRvdWJsZSBhbmQgT2Jq
QworICAgICAgICBvYmplY3QsIHRoaXMgcGF0Y2ggYWRkIHN1cHBvcnQgZm9yIGJvb2wgdHlwZSB0
b28uCisKKyAgICAgICAgKiBTaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW06
CisgICAgICAgIChlbmNvZGVJbnZvY2F0aW9uKToKKyAgICAgICAgKGRlY29kZUludm9jYXRpb25B
cmd1bWVudHMpOgorCiAyMDE0LTAxLTExICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw
bGUuY29tPgogCiAgICAgICAgIFVuZm9yayBHcmFwaGljc0NvbnRleHQ6OmRyYXdOYXRpdmVJbWFn
ZSBmb3IgaU9TCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3Rl
T2JqZWN0Q29kZXIubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9D
b2NvYS9XS1JlbW90ZU9iamVjdENvZGVyLm1tCShyZXZpc2lvbiAxNjE3ODMpCisrKyBTb3VyY2Uv
V2ViS2l0Mi9TaGFyZWQvQVBJL0NvY29hL1dLUmVtb3RlT2JqZWN0Q29kZXIubW0JKHdvcmtpbmcg
Y29weSkKQEAgLTE0Niw2ICsxNDYsMTUgQEAgc3RhdGljIHZvaWQgZW5jb2RlSW52b2NhdGlvbihX
S1JlbW90ZU9iagogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KIAorICAgICAgICAvLyBi
b29sCisgICAgICAgIGNhc2UgJ0InOiB7CisgICAgICAgICAgICBCT09MIHZhbHVlOworICAgICAg
ICAgICAgW2ludm9jYXRpb24gZ2V0QXJndW1lbnQ6JnZhbHVlIGF0SW5kZXg6aV07OworCisgICAg
ICAgICAgICBlbmNvZGVUb09iamVjdFN0cmVhbShlbmNvZGVyLCBAKHZhbHVlKSk7CisgICAgICAg
ICAgICBicmVhazsKKyAgICAgICAgfQorCiAgICAgICAgIC8vIE9iamVjdGl2ZS1DIG9iamVjdAog
ICAgICAgICBjYXNlICdAJzogewogICAgICAgICAgICAgaWQgdmFsdWU7CkBAIC0zODUsNiArMzk0
LDEzIEBAIHN0YXRpYyB2b2lkIGRlY29kZUludm9jYXRpb25Bcmd1bWVudHMoV0sKICAgICAgICAg
ICAgIGJyZWFrOwogICAgICAgICB9CiAKKyAgICAgICAgLy8gYm9vbAorICAgICAgICBjYXNlICdC
JzogeworICAgICAgICAgICAgYm9vbCB2YWx1ZSA9IFtkZWNvZGVPYmplY3RGcm9tT2JqZWN0U3Ry
ZWFtKGRlY29kZXIsIFtOU1NldCBzZXRXaXRoT2JqZWN0OltOU051bWJlciBjbGFzc11dKSBib29s
VmFsdWVdOworICAgICAgICAgICAgW2ludm9jYXRpb24gc2V0QXJndW1lbnQ6JnZhbHVlIGF0SW5k
ZXg6aV07CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorCiAgICAgICAgIC8vIE9iamVj
dGl2ZS1DIG9iamVjdAogICAgICAgICBjYXNlICdAJzogewogICAgICAgICAgICAgTlNTZXQgKmFs
bG93ZWRDbGFzc2VzID0gYWxsb3dlZEFyZ3VtZW50Q2xhc3Nlc1tpIC0gMl0uZ2V0KCk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>