126821 2014-01-11 11:58:30 -0800 webkit-gtk 2.3.3 fails on darwin/quartz due to duplicate symbols in WebCore 2016-01-03 22:52:07 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://trac.macports.org/ticket/42010 P2 Normal --- 126492 1 jeremyhu zan cgarcia gustavo iain.lane mrobinson philip.chimento pnormand zan oldest_to_newest 966824 0 jeremyhu 2014-01-11 11:58:30 -0800 Reported at MacPorts. When building recent webkit-gtk on darwin (GTK/Quartz rather than GTK/X11), the build fails at: :info:build libtool: link: /usr/bin/clang++ -dynamiclib -Wl,-undefined -Wl,dynamic_lookup -o .libs/libwebkitgtk-1.0.0.dylib Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-TextCheckerClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-AcceleratedCompositingContextGL.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-AssertMatchingEnums.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-ChromeClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-ContextMenuClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DeviceMotionClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DeviceOrientationClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DocumentLoaderGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DragClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-DumpRenderTreeSupportGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-EditorClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-FrameLoaderClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-FrameNetworkingContextGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-GeolocationClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-GtkAdjustmentWatcher.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-InspectorClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-NavigatorContentUtilsClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-PlatformStrategiesGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-UserMediaClientGtk.o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_1_0_la-WebViewInputMethodFilter.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitapplicationcache.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitauthenticationdialog.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitdownload.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkiterror.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitfavicondatabase.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitfilechooserrequest.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitgeolocationpolicydecision.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitglobals.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkithittestresult.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkiticondatabase.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitnetworkrequest.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitnetworkresponse.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitsecurityorigin.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitsoupauthdialog.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitspellchecker.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitspellcheckerenchant.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitversion.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitviewportattributes.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebbackforwardlist.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebdatabase.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebdatasource.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebframe.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebhistoryitem.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebinspector.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebnavigationaction.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebpolicydecision.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebresource.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebplugin.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebplugindatabase.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebsettings.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebview.o Source/WebKit/gtk/webkit/.libs/libwebkitgtk_1_0_la-webkitwebwindowfeatures.o DerivedSources/webkit/.libs/libwebkitgtk_1_0_la-webkitenumtypes.o DerivedSources/webkit/.libs/libwebkitgtk_1_0_la-webkitmarshal.o -Wl,-force_load,./.libs/libPlatform.a -Wl,-force_load,./.libs/libPlatformGtk.a -Wl,-force_load,./.libs/libWebCore.a -Wl,-force_load,./.libs/libWebCorePlatform.a -Wl,-force_load,./.libs/libWebCoreModules.a -Wl,-force_load,./.libs/libWebCoreDOM.a -Wl,-force_load,./.libs/libWebCoreGtk.a -Wl,-force_load,./.libs/libWebCoreSVG.a -L/opt/local/lib ./.libs/libjavascriptcoregtk-1.0.dylib -lenchant -lharfbuzz-icu -lharfbuzz -lgeoclue -ldbus-glib-1 -ldbus-1 -lgmodule-2.0 -lgthread-2.0 -lgstapp-1.0 -lgstaudio-1.0 -lgstfft-1.0 -lgstpbutils-1.0 -lgstvideo-1.0 -lgstbase-1.0 -lgstreamer-1.0 -lgtk-quartz-2.0 -lgdk-quartz-2.0 -framework Cocoa -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -ljpeg -lsecret-1 -lsoup-2.4 -lgio-2.0 -lxslt -lpthread -liconv -lxml2 -lpangoft2-1.0 -lpango-1.0 -lm -lgobject-2.0 -lglib-2.0 -lintl -lfontconfig -lfreetype -lpng16 -lsqlite3 -licui18n -licuuc -licudata -lwebp -lz -Os -arch x86_64 -pthread -O2 -Wl,-headerpad_max_install_names -arch x86_64 -Wl,--no-demangle -pthread -framework Cocoa -install_name /opt/local/lib/libwebkitgtk-1.0.0.dylib -compatibility_version 20 -current_version 20.11 -Wl,-single_module :info:build clang: warning: argument unused during compilation: '-pthread' :info:build clang: warning: argument unused during compilation: '-pthread' :info:build duplicate symbol __ZN7WebCore13PluginPackage9fetchInfoEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt1-libWebCore_) :info:build duplicate symbol __ZN7WebCore13PluginPackage4loadEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt1-libWebCore_) :info:build duplicate symbol __ZNK7WebCore13PluginPackage9NPVersionEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt1-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView8setFocusEb in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView4showEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView4hideEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView5paintEPNS_15GraphicsContextERKNS_7IntRectE in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView19handleKeyboardEventEPNS_13KeyboardEventE in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView16handleMouseEventEPNS_10MouseEventE in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView9setParentEPNS_10ScrollViewE in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView15setNPWindowRectERKNS_7IntRectE in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView18handlePostReadFileERN3WTF6VectorIcLm0ENS1_15CrashOnOverflowEEEjPKc in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView16platformGetValueE11NPNVariablePvPs in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView22platformGetValueStaticE11NPNVariablePvPs in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView14invalidateRectEP7_NPRect in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView14invalidateRectERKNS_7IntRectE in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView16invalidateRegionEPv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView11forceRedrawEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView13platformStartEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView15platformDestroyEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView16setParentVisibleEb in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView18updatePluginWidgetEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView18handleFocusInEventEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build duplicate symbol __ZN7WebCore10PluginView19handleFocusOutEventEv in: :info:build ./.libs/libWebCore.a(libWebCore_la-P) :info:build ./.libs/libWebCore.a(lt2-libWebCore_) :info:build ld: 24 duplicate symbols for architecture x86_64 :info:build clang: error: linker command failed with exit code 1 (use -v to see invocation) :info:build make[1]: *** [libwebkitgtk-1.0.la] Error 1 : 966825 1 jeremyhu 2014-01-11 12:05:01 -0800 It looks like these duplicates come from PluginPackageNone.cpp is being included as well as PluginViewGtk.cpp 966826 2 jeremyhu 2014-01-11 12:08:35 -0800 Actually no, the GTK one isn't included. This looks interesting: :info:build ar: warning: libWebCore_la-PluginPackageNone.o truncated to libWebCore_la-P :info:build ar: warning: libWebCore_la-PluginViewNone.o truncated to libWebCore_la-P :info:build ar: warning: lt1-libWebCore_la-PluginPackageNone.o truncated to lt1-libWebCore_ :info:build ar: warning: lt2-libWebCore_la-PluginViewNone.o truncated to lt2-libWebCore_ 966828 3 jeremyhu 2014-01-11 12:12:42 -0800 Actually no, the GTK one isn't included. This looks interesting: :info:build ar: warning: libWebCore_la-PluginPackageNone.o truncated to libWebCore_la-P :info:build ar: warning: libWebCore_la-PluginViewNone.o truncated to libWebCore_la-P :info:build ar: warning: lt1-libWebCore_la-PluginPackageNone.o truncated to lt1-libWebCore_ :info:build ar: warning: lt2-libWebCore_la-PluginViewNone.o truncated to lt2-libWebCore_ It looks like this block gets added in the else for TARGET_X11_OR_WAYLAND as well as the else for TARGET_X11: webcore_sources += \ Source/WebCore/plugins/PluginPackageNone.cpp \ Source/WebCore/plugins/PluginViewNone.cpp 966831 4 jeremyhu 2014-01-11 12:22:47 -0800 (In reply to comment #3) > It looks like this block gets added in the else for TARGET_X11_OR_WAYLAND as well as the else for TARGET_X11: > > webcore_sources += \ > Source/WebCore/plugins/PluginPackageNone.cpp \ > Source/WebCore/plugins/PluginViewNone.cpp I'm asking MacPorts users reporting the issue to test with a patch that just removes that from the ! TARGET_X11 block. 968450 5 221303 jeremyhu 2014-01-15 13:24:14 -0800 Created attachment 221303 quartz-duplicate-symbols.patch This patch fixes the issue of including the files twice. 968636 6 221341 zan 2014-01-16 00:32:59 -0800 Created attachment 221341 Patch 968637 7 zan 2014-01-16 00:38:50 -0800 ?(In reply to comment #6) > Created an attachment (id=221341) [details] > Patch Now lists additional build targets for every window target separately. No more else branches. The PluginPackageNone.cpp and PluginViewNone.cpp files are now explicitly added to the build for Quartz, and that is done only once, so it should remove duplicate definitions. Please try the patch out and report back as I'm unable to test on this specific configuration. 1030029 8 221341 darin 2014-08-19 08:52:04 -0700 Comment on attachment 221341 Patch We don’t use automake any more. 1030052 9 jeremyhu 2014-08-19 10:22:27 -0700 Yeah, well the cmake build fails on darwin even worse. The fact that you guys ripped out automake before cmake was ready for use is quite frustrating. I wish you heeded my request to have side-by-side automake/cmake for a couple transition releases =( We've decided to just stay at webkit-gtk-1.4.x in MacPorts for the foreseeable future (read: until someone else wants to take over maintainer-ship, if anyone is interested) due to too much maintainance overhead in the switch to cmake. 1030069 10 mrobinson 2014-08-19 11:17:30 -0700 (In reply to comment #9) > Yeah, well the cmake build fails on darwin even worse. > > The fact that you guys ripped out automake before cmake was ready for use is quite frustrating. I wish you heeded my request to have side-by-side automake/cmake for a couple transition releases =( It's likely that the build fails, because we also removed WebKit1. To my knowledge, WebKit2GTK+ only works on systems which support XComposite/XDamage. We don't have support for Darwin yet. WebKit1 lives on in a stable branch. Please see the discussion here: https://lists.webkit.org/pipermail/webkit-gtk/2014-March/001821.html. 1039146 11 239184 philip.chimento 2014-10-03 00:33:44 -0700 Created attachment 239184 Updated patch 1039147 12 philip.chimento 2014-10-03 00:34:15 -0700 (In reply to comment #7) > ?(In reply to comment #6) > > Created an attachment (id=221341) [details] [details] > > Patch > > Now lists additional build targets for every window target separately. No more else branches. > > The PluginPackageNone.cpp and PluginViewNone.cpp files are now explicitly added to the build for Quartz, and that is done only once, so it should remove duplicate definitions. > > Please try the patch out and report back as I'm unable to test on this specific configuration. I did try this out on 2.4.6 and it resolves all but one duplicate symbol. To fix the last one, PluginPackage::determineQuirks(const String&) needs to be removed from Source/WebCore/plugins/PluginPackageNone.cpp. Here's an updated patch. Since WebKit2 does indeed not support WebKitGTK on Quartz yet, would it be possible to have this committed to the 2.4 stable branch as well? 1039955 13 239391 philip.chimento 2014-10-06 22:40:08 -0700 Created attachment 239391 Patch 1039956 14 philip.chimento 2014-10-06 22:40:56 -0700 Here's an updated patch with ChangeLog. 1046721 15 philip.chimento 2014-11-05 22:07:51 -0800 Would it be possible to get this reviewed for 2.4.8? 1049508 16 pnormand 2014-11-18 09:52:24 -0800 Carlos, any thoughts on this one? 1058671 17 cgarcia 2015-01-05 00:20:47 -0800 Commited to 2.4 branch <http://trac.webkit.org/changeset/177885> <http://trac.webkit.org/changeset/177886> <http://trac.webkit.org/changeset/177887> Thanks! 1061167 18 iain.lane 2015-01-14 07:20:19 -0800 On my Ubuntu package build of 2.4.8, the first release with these patches, I'm getting a multiple definition failure: ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginPackageGtk.o: In function `_ZN3WTF6VectorINS_6StringELm0ENS_15CrashOnOverflowEEaSERKS3_': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:126: multiple definition of `_ZN7WebCore13PluginPackage4loadEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginPackageNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginPackageNone.cpp:37: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginPackageGtk.o: In function `_ZNK7WebCore13PluginPackage9NPVersionEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:199: multiple definition of `_ZNK7WebCore13PluginPackage9NPVersionEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginPackageNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginPackageNone.cpp:43: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginPackageGtk.o: In function `_ZN7WebCore13PluginPackage9fetchInfoEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginPackageGtk.cpp:44: multiple definition of `_ZN7WebCore13PluginPackage9fetchInfoEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginPackageNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginPackageNone.cpp:32: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView15setNPWindowRectERKNS_7IntRectE': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:473: multiple definition of `_ZN7WebCore10PluginView15setNPWindowRectERKNS_7IntRectE' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:65: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView5paintEPNS_15GraphicsContextERKNS_7IntRectE': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:176: multiple definition of `_ZN7WebCore10PluginView5paintEPNS_15GraphicsContextERKNS_7IntRectE' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:49: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView16setParentVisibleEb': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:579: multiple definition of `_ZN7WebCore10PluginView16setParentVisibleEb' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:113: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView18handlePostReadFileERN3WTF6VectorIcLm0ENS1_15CrashOnOverflowEEEjPKc': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:594: multiple definition of `_ZN7WebCore10PluginView18handlePostReadFileERN3WTF6VectorIcLm0ENS1_15CrashOnOverflowEEEjPKc' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:70: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView22platformGetValueStaticE11NPNVariablePvPs': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:625: multiple definition of `_ZN7WebCore10PluginView22platformGetValueStaticE11NPNVariablePvPs' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:80: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView14invalidateRectERKNS_7IntRectE': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:691: multiple definition of `_ZN7WebCore10PluginView14invalidateRectERKNS_7IntRectE' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:90: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView14invalidateRectEP7_NPRect': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:700: multiple definition of `_ZN7WebCore10PluginView14invalidateRectEP7_NPRect' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:85: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView16invalidateRegionEP8_XRegion': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:711: multiple definition of `_ZN7WebCore10PluginView16invalidateRegionEP8_XRegion' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:95: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView15platformDestroyEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:882: multiple definition of `_ZN7WebCore10PluginView15platformDestroyEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:109: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView18updatePluginWidgetEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:121: multiple definition of `_ZN7WebCore10PluginView18updatePluginWidgetEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:117: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView19handleKeyboardEventEPNS_13KeyboardEventE': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:266: multiple definition of `_ZN7WebCore10PluginView19handleKeyboardEventEPNS_13KeyboardEventE' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:53: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView18handleFocusInEventEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:432: multiple definition of `_ZN7WebCore10PluginView18handleFocusInEventEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:122: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView19handleFocusOutEventEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:448: multiple definition of `_ZN7WebCore10PluginView19handleFocusOutEventEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:126: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView16handleMouseEventEPNS_10MouseEventE': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:392: multiple definition of `_ZN7WebCore10PluginView16handleMouseEventEPNS_10MouseEventE' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:57: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView16platformGetValueE11NPNVariablePvPs': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:653: multiple definition of `_ZN7WebCore10PluginView16platformGetValueE11NPNVariablePvPs' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:75: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView11forceRedrawEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:718: multiple definition of `_ZN7WebCore10PluginView11forceRedrawEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:100: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView8setFocusEb': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:156: multiple definition of `_ZN7WebCore10PluginView8setFocusEb' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:37: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView4showEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:164: multiple definition of `_ZN7WebCore10PluginView4showEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:41: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView13platformStartEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:786: multiple definition of `_ZN7WebCore10PluginView13platformStartEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:104: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView4hideEv': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:170: multiple definition of `_ZN7WebCore10PluginView4hideEv' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:45: first defined here ./.libs/../Source/WebCore/plugins/gtk/.libs/libWebCoreGtk_la-PluginViewGtk.o: In function `_ZN7WebCore10PluginView9setParentEPNS_10ScrollViewE': /build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/gtk/PluginViewGtk.cpp:464: multiple definition of `_ZN7WebCore10PluginView9setParentEPNS_10ScrollViewE' ./.libs/../Source/WebCore/plugins/.libs/libWebCore_la-PluginViewNone.o:/build/buildd/webkitgtk-2.4.8/build-3.0/../Source/WebCore/plugins/PluginViewNone.cpp:61: first defined here TARGET_X11 and TARGET_WAYLAND are both defined, so I think that we're getting *None.cpp and *Gtk.cpp both included erroneously. 1061514 19 cgarcia 2015-01-15 01:38:38 -0800 See https://bugs.webkit.org/show_bug.cgi?id=140241 1152249 20 jeremyhu 2016-01-03 22:52:07 -0800 *** Bug 100723 has been marked as a duplicate of this bug. *** 221303 2014-01-15 13:24:14 -0800 2014-01-16 00:32:50 -0800 quartz-duplicate-symbols.patch quartz-duplicate-symbols.patch text/plain 508 jeremyhu LS0tIFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0ub3JpZwkyMDEzLTEyLTE4IDAz OjAzOjQxLjAwMDAwMDAwMCAtMDgwMAorKysgU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlz dC5hbQkyMDE0LTAxLTExIDEyOjE1OjA3LjAwMDAwMDAwMCAtMDgwMApAQCAtNjI4MywxMCArNjI4 Myw2IEBAIHdlYmNvcmVndGtfc291cmNlcyArPSBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ2x4L0dMQ29udGV4dEdMWC5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguaAogZW5kaWYgIyBFTkQgVVNFX0dMWAotZWxzZQot d2ViY29yZV9zb3VyY2VzICs9IFwKLQlTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2th Z2VOb25lLmNwcCBcCi0JU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAK IGVuZGlmICMgRU5EIFRBUkdFVF9YMTEKIAogaWYgVEFSR0VUX1gxMV9PUl9XQVlMQU5ECg== 221341 2014-01-16 00:32:59 -0800 2014-08-19 08:52:04 -0700 Patch bug-126821-20140116003257.patch text/plain 2591 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTE0MDMyZjM4YjQxNGQ4 YTk4Njg5NTI0NDZhMDNiNTNiYjY5OWU0ZC4uYjNhMTc3YTNjZDA3MTJlYWZmYWNlOTI1MDUzMjUz M2NjMjExYTJkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTE2ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICB3ZWJraXQtZ3RrIDIu My4zIGZhaWxzIG9uIGRhcndpbi9xdWFydHogZHVlIHRvIGR1cGxpY2F0ZSBzeW1ib2xzIGluIFdl YkNvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NjgyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog R05VbWFrZWZpbGUubGlzdC5hbTogU2ltcGxpZnkgdGhlIGxvZ2ljIGZvciBkZXRlcm1pbmluZyBi dWlsZCB0YXJnZXRzIHRoYXQgYXJlIHNwZWNpZmljIHRvIHdpbmRvd2luZyB0YXJnZXRzLgorICAg ICAgICBBdm9pZCBuZXN0ZWQgdGFyZ2V0IGNoZWNrcyBhbmQgbGlzdCBhbGwgdGhlIGFkZGl0aW9u YWwgYnVpbGQgdGFyZ2V0cyBmb3IgZWFjaCB3aW5kb3dpbmcgdGFyZ2V0IC0gWDExLCBXYXlsYW5k LAorICAgICAgICBYMTEgYW5kIFdheWxhbmQgKGkuZS4gdGhlIGJ1aWxkIHRhcmdldHMgdGhhdCBh cmUgc2hhcmVkIGJldHdlZW4gdGhlIHR3byBjb25maWd1cmF0aW9ucyksIFdpbjMyIGFuZCBRdWFy dHouCisgICAgICAgIFRoaXMgYXZvaWRzIHRoZSBjdXJyZW50IHByb2JsZW1zIG9mIGJ1aWxkaW5n IGR1cGxpY2F0ZSBidWlsZCB0YXJnZXRzIG9uIFF1YXJ0eiwgYW5kIGFsc28gY2xlYW5zIHVwIHRo ZSBsaXN0LgorCiAyMDE0LTAxLTE1ICBNaWhhaSBUaWNhICA8bWl0aWNhQGFkb2JlLmNvbT4KIAog ICAgICAgICBSZWFwcGx5aW5nOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZp bGUubGlzdC5hbSBiL1NvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KaW5kZXggZjYx MzgwZDFkNmUzYTVlZDIyMzI5NjFlZjc2NDI0NWE1Njg3MDIwNy4uNDEwZWNhZGNhNmI0NDg5Yzhi MTRlMjBhOWRlOGZjYTQ0YzJlNTk5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvR05VbWFr ZWZpbGUubGlzdC5hbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCkBA IC02MzExLDExICs2MzExLDEzIEBAIHdlYmNvcmVndGtfc291cmNlcyArPSBcCiAJU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ2x4L0dMQ29udGV4dEdMWC5jcHAgXAogCVNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dseC9HTENvbnRleHRHTFguaAogZW5kaWYgIyBFTkQg VVNFX0dMWAotZWxzZQorZW5kaWYgIyBFTkQgVEFSR0VUX1gxMQorCitpZiBUQVJHRVRfV0FZTEFO RAogd2ViY29yZV9zb3VyY2VzICs9IFwKIAlTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBh Y2thZ2VOb25lLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5j cHAKLWVuZGlmICMgRU5EIFRBUkdFVF9YMTEKK2VuZGlmICMgRU5EIFRBUkdFVF9XQVlMQU5ECiAK IGlmIFRBUkdFVF9YMTFfT1JfV0FZTEFORAogcGxhdGZvcm1ndGtfc291cmNlcyArPSBcCkBAIC02 MzMzLDcgKzYzMzUsOCBAQCB3ZWJjb3JlZ3RrX3NvdXJjZXMgKz0gXAogCVNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwIFwKIAlTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmgKIGVuZGlmICMgRU5EIFVTRV9F R0wKLWVsc2UKK2VuZGlmICMgRU5EIFRBUkdFVF9YMTFfT1JfV0FZTEFORAorCiBpZiBUQVJHRVRf V0lOMzIKIHdlYmNvcmVfc291cmNlcyArPSBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3Mvd2luL0RJQlBpeGVsRGF0YS5jcHAgXApAQCAtNjM1NiwxMiArNjM1OSwxMyBAQCB3ZWJj b3JlZ3RrX3NvdXJjZXMgKz0gXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2NhaXJvL1dpZGdl dEJhY2tpbmdTdG9yZUNhaXJvLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8v V2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uaCBcCiAJU291cmNlL1dlYkNvcmUvcGx1Z2lucy93aW4v UGx1Z2luVmlld1dpbi5jcHAKLWVsc2UKK2VuZGlmICMgRU5EIFRBUkdFVF9XSU4zMgorCitpZiBU QVJHRVRfUVVBUlRaCiB3ZWJjb3JlX3NvdXJjZXMgKz0gXAogCVNvdXJjZS9XZWJDb3JlL3BsdWdp bnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdp blZpZXdOb25lLmNwcAotZW5kaWYgIyBFTkQgVEFSR0VUX1dJTjMyCi1lbmRpZiAjIEVORCBUQVJH RVRfWDExX09SX1dBWUxBTkQKK2VuZGlmICMgRU5EIFRBUkdFVF9RVUFSVFoKIAogaWYgVVNFX0dM RVMyCiB3ZWJjb3JlX3NvdXJjZXMgKz0gXAo= 239184 2014-10-03 00:33:44 -0700 2014-10-06 22:40:03 -0700 Updated patch 126821-duplicate-symbols.patch text/plain 2022 philip.chimento SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUubGlzdC5hbSAgKHJldmlzaW9uIDE3NDI1OCkKKysr IFNvdXJjZS9XZWJDb3JlL0dOVW1ha2VmaWxlLmxpc3QuYW0gICh3b3JraW5nIGNvcHkpCkBAIC02 MjUxLDExICs2MjUxLDEzIEBACiAgICBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n bHgvR0xDb250ZXh0R0xYLmNwcCBcCiAgICBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nbHgvR0xDb250ZXh0R0xYLmgKIGVuZGlmICMgRU5EIFVTRV9HTFgKLWVsc2UKK2VuZGlmICMg RU5EIFRBUkdFVF9YMTEKKworaWYgVEFSR0VUX1dBWUxBTkQKIHdlYmNvcmVfc291cmNlcyArPSBc CiAgICBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcCBcCiAgICBT b3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdOb25lLmNwcAotZW5kaWYgIyBFTkQgVEFS R0VUX1gxMQorZW5kaWYgIyBFTkQgVEFSR0VUX1dBWUxBTkQKIAogaWYgVEFSR0VUX1gxMV9PUl9X QVlMQU5ECiBwbGF0Zm9ybWd0a19zb3VyY2VzICs9IFwKQEAgLTYyNzMsNyArNjI3NSw4IEBACiAg ICBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmNwcCBc CiAgICBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmgK IGVuZGlmICMgRU5EIFVTRV9FR0wKLWVsc2UKK2VuZGlmICMgRU5EIFRBUkdFVF9YMTFfT1JfV0FZ TEFORAorCiBpZiBUQVJHRVRfV0lOMzIKIHdlYmNvcmVfc291cmNlcyArPSBcCiAgICBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRElCUGl4ZWxEYXRhLmNwcCBcCkBAIC02Mjk5 LDEyICs2MzAyLDE2IEBACiAgICBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRC YWNraW5nU3RvcmVDYWlyby5jcHAgXAogICAgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8v V2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uaCBcCiAgICBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dp bi9QbHVnaW5WaWV3V2luLmNwcAotZWxzZQorZW5kaWYgIyBFTkQgVEFSR0VUX1dJTjMyCisKK2lm IFRBUkdFVF9RVUFSVFoKIHdlYmNvcmVfc291cmNlcyArPSBcCiAgICBTb3VyY2UvV2ViQ29yZS9w bHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcCBcCiAgICBTb3VyY2UvV2ViQ29yZS9wbHVnaW5z L1BsdWdpblZpZXdOb25lLmNwcAotZW5kaWYgIyBFTkQgVEFSR0VUX1dJTjMyCi1lbmRpZiAjIEVO RCBUQVJHRVRfWDExX09SX1dBWUxBTkQKK3BsYXRmb3JtZ3RrX3NvdXJjZXMgKz0gXAorICAgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uaCBcCisg ICBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmVDYWlyby5j cHAKK2VuZGlmICMgRU5EIFRBUkdFVF9RVUFSVFoKIAogaWYgVVNFX0dMRVMyCiB3ZWJjb3JlX3Nv dXJjZXMgKz0gXApJbmRleDogU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9u ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdl Tm9uZS5jcHAgICAgKHJldmlzaW9uIDE3NDI1OCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMv UGx1Z2luUGFja2FnZU5vbmUuY3BwICAgICh3b3JraW5nIGNvcHkpCkBAIC0yOCwxMCArMjgsNiBA QAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXZvaWQgUGx1Z2luUGFja2FnZTo6ZGV0ZXJtaW5l UXVpcmtzKGNvbnN0IFN0cmluZyYpCi17Ci19Ci0KIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJ bmZvKCkKIHsKICAgICByZXR1cm4gZmFsc2U7 239391 2014-10-06 22:40:08 -0700 2015-01-05 00:21:03 -0800 Patch bug-126821-20141006224008.patch text/plain 3527 philip.chimento SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NDM4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTEwLTA2ICBQaGlsaXAg Q2hpbWVudG8gIDxwaGlsaXAuY2hpbWVudG9AZ21haWwuY29tPgorCisgICAgICAgIHdlYmtpdC1n dGsgMi4zLjMgZmFpbHMgb24gZGFyd2luL3F1YXJ0eiBkdWUgdG8gZHVwbGljYXRlIHN5bWJvbHMg aW4gV2ViQ29yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI2ODIxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBHTlVtYWtlZmlsZS5saXN0LmFtOiBTaW1wbGlmeSB0aGUgbG9naWMgZm9yIGRldGVybWlu aW5nIGJ1aWxkCisgICAgICAgIHRhcmdldHMgdGhhdCBhcmUgc3BlY2lmaWMgdG8gd2luZG93aW5n IHRhcmdldHMuIEF2b2lkIG5lc3RlZCB0YXJnZXQKKyAgICAgICAgY2hlY2tzIGFuZCBsaXN0IGFs bCB0aGUgYWRkaXRpb25hbCBidWlsZCB0YXJnZXRzIGZvciBlYWNoIHdpbmRvd2luZworICAgICAg ICB0YXJnZXQgLSBYMTEsIFdheWxhbmQsIFgxMSBhbmQgV2F5bGFuZCAoaS5lLiB0aGUgYnVpbGQg dGFyZ2V0cyB0aGF0CisgICAgICAgIGFyZSBzaGFyZWQgYmV0d2VlbiB0aGUgdHdvIGNvbmZpZ3Vy YXRpb25zKSwgV2luMzIgYW5kIFF1YXJ0ei4gVGhpcworICAgICAgICBhdm9pZHMgdGhlIGN1cnJl bnQgcHJvYmxlbXMgb2YgYnVpbGRpbmcgZHVwbGljYXRlIGJ1aWxkIHRhcmdldHMgb24KKyAgICAg ICAgUXVhcnR6LCBhbmQgYWxzbyBjbGVhbnMgdXAgdGhlIGxpc3QuIChaYW4gRG9iZXJzZWsgPHpk b2JlcnNla0BpZ2FsaWEuY29tPikKKyAgICAgICAgQWRkIFdpZGdldEJhY2tpbmdTdG9yZUNhaXJv IHRvIHBsYXRmb3JtZ3RrX3NvdXJjZXMgZm9yIHRoZSBRdWFydHoKKyAgICAgICAgYnVpbGQgdGFy Z2V0LCBvdGhlcndpc2UgV2ViS2l0R1RLIGFib3J0cyB3aXRoIGFuIHVuZGVmaW5lZCBzeW1ib2wK KyAgICAgICAgYXQgcnVudGltZS4gKFBoaWxpcCBDaGltZW50bykKKyAgICAgICAgKiBwbHVnaW5z L1BsdWdpblBhY2thZ2VOb25lLmNwcDogUmVtb3ZlIFBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1 aXJrcygpCisgICAgICAgIGZyb20gUGx1Z2luUGFja2FnZU5vbmUuY3BwIGFzIGl0IGFsc28gc2hv d3MgdXAgYXMgYSBkdXBsaWNhdGUKKyAgICAgICAgc3ltYm9sLiAoUGhpbGlwIENoaW1lbnRvKQor CiAyMDE0LTA5LTI2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLiBGaXggbWFrZSBkaXN0Y2hlY2suCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9HTlVtYWtlZmlsZS5saXN0LmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L0dOVW1ha2VmaWxlLmxpc3QuYW0JKHJldmlzaW9uIDE3NDMwNykKKysrIFNvdXJjZS9XZWJDb3Jl L0dOVW1ha2VmaWxlLmxpc3QuYW0JKHdvcmtpbmcgY29weSkKQEAgLTYyNTEsMTEgKzYyNTEsMTMg QEAgd2ViY29yZWd0a19zb3VyY2VzICs9IFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nbHgvR0xDb250ZXh0R0xYLmNwcCBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ2x4L0dMQ29udGV4dEdMWC5oCiBlbmRpZiAjIEVORCBVU0VfR0xYCi1lbHNlCitlbmRp ZiAjIEVORCBUQVJHRVRfWDExCisKK2lmIFRBUkdFVF9XQVlMQU5ECiB3ZWJjb3JlX3NvdXJjZXMg Kz0gXAogCVNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwIFwKIAlT b3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdOb25lLmNwcAotZW5kaWYgIyBFTkQgVEFS R0VUX1gxMQorZW5kaWYgIyBFTkQgVEFSR0VUX1dBWUxBTkQKIAogaWYgVEFSR0VUX1gxMV9PUl9X QVlMQU5ECiBwbGF0Zm9ybWd0a19zb3VyY2VzICs9IFwKQEAgLTYyNzMsNyArNjI3NSw4IEBAIHdl YmNvcmVndGtfc291cmNlcyArPSBcCiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZWdsL0dMQ29udGV4dEVHTC5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2VnbC9HTENvbnRleHRFR0wuaAogZW5kaWYgIyBFTkQgVVNFX0VHTAotZWxzZQorZW5kaWYgIyBF TkQgVEFSR0VUX1gxMV9PUl9XQVlMQU5ECisKIGlmIFRBUkdFVF9XSU4zMgogd2ViY29yZV9zb3Vy Y2VzICs9IFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vRElCUGl4ZWxE YXRhLmNwcCBcCkBAIC02Mjk5LDEyICs2MzAyLDE2IEBAIHdlYmNvcmVndGtfc291cmNlcyArPSBc CiAJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8u Y3BwIFwKIAlTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jYWlyby9XaWRnZXRCYWNraW5nU3RvcmVD YWlyby5oIFwKIAlTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAot ZWxzZQorZW5kaWYgIyBFTkQgVEFSR0VUX1dJTjMyCisKK2lmIFRBUkdFVF9RVUFSVFoKIHdlYmNv cmVfc291cmNlcyArPSBcCiAJU291cmNlL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9u ZS5jcHAgXAogCVNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld05vbmUuY3BwCi1lbmRp ZiAjIEVORCBUQVJHRVRfV0lOMzIKLWVuZGlmICMgRU5EIFRBUkdFVF9YMTFfT1JfV0FZTEFORAor cGxhdGZvcm1ndGtfc291cmNlcyArPSBcCisJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fpcm8v V2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uaCBcCisJU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2Fp cm8vV2lkZ2V0QmFja2luZ1N0b3JlQ2Fpcm8uY3BwCitlbmRpZiAjIEVORCBUQVJHRVRfUVVBUlRa CiAKIGlmIFVTRV9HTEVTMgogd2ViY29yZV9zb3VyY2VzICs9IFwKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL3BsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCShyZXZpc2lvbiAxNzQzMDcpCisr KyBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjgsMTAgKzI4LDYgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi12b2lkIFBs dWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyhjb25zdCBTdHJpbmcmKQotewotfQotCiBib29s IFBsdWdpblBhY2thZ2U6OmZldGNoSW5mbygpCiB7CiAgICAgcmV0dXJuIGZhbHNlOwo=