126819 2014-01-11 11:16:30 -0800 ScriptDebugServer should use a separate member function for its timer handler 2014-01-11 13:44:33 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 966815 0 andersca 2014-01-11 11:16:30 -0800 ScriptDebugServer should use a separate member function for its timer handler 966816 1 220940 andersca 2014-01-11 11:17:50 -0800 Created attachment 220940 Patch 966817 2 andersca 2014-01-11 11:27:24 -0800 Committed r161771: <http://trac.webkit.org/changeset/161771> 966841 3 220940 joepeck 2014-01-11 13:44:33 -0800 Comment on attachment 220940 Patch Although I don't disagree with the change. What is the reason why here? In any case, we want to remove the Timer, since this will need to be pushed down into JavaScriptCore soon anyways (which doesn't have a platform/Timer and we should be able to avoid it). 220940 2014-01-11 11:17:50 -0800 2014-01-11 13:44:33 -0800 Patch bug-126819-20140111111749.patch text/plain 6955 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY0ZDkyYTlmODAxZDM4 MzY5NjJjODNkZDJjMDUwMjYzYzA0NjQ1My4uYWY3YTg4YzdkZDY2YjExNjM2MWY5Mzk3YzQ4MWMy MTFjZWM1MjNmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDE0LTAxLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU2NyaXB0RGVidWdT ZXJ2ZXIgc2hvdWxkIHVzZSBhIHNlcGFyYXRlIG1lbWJlciBmdW5jdGlvbiBmb3IgaXRzIHRpbWVy IGhhbmRsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNjgxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogYmluZGluZ3MvanMvUGFnZVNjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlBhZ2VTY3JpcHREZWJ1Z1NlcnZlcjo6cmVjb21waWxlQWxsSlNGdW5jdGlvbnMpOgorICAg ICAgICAqIGJpbmRpbmdzL2pzL1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5oOgorICAgICAgICAqIGJp bmRpbmdzL2pzL1NjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dERlYnVnU2VydmVyOjpTY3JpcHREZWJ1Z1NlcnZlcik6CisgICAgICAgIChXZWJDb3JlOjpTY3Jp cHREZWJ1Z1NlcnZlcjo6cmVjb21waWxlQWxsSlNGdW5jdGlvbnNUaW1lckZpcmVkKToKKyAgICAg ICAgKiBiaW5kaW5ncy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5oOgorICAgICAgICAqIGJpbmRpbmdz L2pzL1dvcmtlclNjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oldvcmtl clNjcmlwdERlYnVnU2VydmVyOjphZGRMaXN0ZW5lcik6CisgICAgICAgIChXZWJDb3JlOjpXb3Jr ZXJTY3JpcHREZWJ1Z1NlcnZlcjo6cmVjb21waWxlQWxsSlNGdW5jdGlvbnMpOgorICAgICAgICAq IGJpbmRpbmdzL2pzL1dvcmtlclNjcmlwdERlYnVnU2VydmVyLmg6CisgICAgICAgICogaW5zcGVj dG9yL0luc3BlY3RvclByb2ZpbGVyQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVj dG9yUHJvZmlsZXJBZ2VudDo6c3RhcnQpOgorCisyMDE0LTAxLTExICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgU2ltcGxpZnkgVGltZXIgYW5kIERlZmVy cmFibGVPbmVTaG90VGltZXIgdXNpbmcgc3RkOjpmdW5jdGlvbgogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODE2CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy9qcy9QYWdlU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCmluZGV4IDk3M2U4 YzAwMDMwNDM5NWU5ZWM4M2Q2ZDFhMzNhYWU4OWUzNzE3MmUuLjFjZWM3YjNlNWFhNmMwNWMxNWZm OTkzNTQwMDVlYmE5ZTIyNWM3YTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL1BhZ2VTY3JpcHREZWJ1Z1NlcnZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvUGFnZVNjcmlwdERlYnVnU2VydmVyLmNwcApAQCAtMTE3LDcgKzExNyw3IEBAIHZvaWQg UGFnZVNjcmlwdERlYnVnU2VydmVyOjpyZW1vdmVMaXN0ZW5lcihTY3JpcHREZWJ1Z0xpc3RlbmVy KiBsaXN0ZW5lciwgUGFnZSoKICAgICB9CiB9CiAKLXZvaWQgUGFnZVNjcmlwdERlYnVnU2VydmVy OjpyZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucyhUaW1lcjxTY3JpcHREZWJ1Z1NlcnZlcj4qKQordm9p ZCBQYWdlU2NyaXB0RGVidWdTZXJ2ZXI6OnJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKCkKIHsKICAg ICBKU0xvY2tIb2xkZXIgbG9jayhKU0RPTVdpbmRvdzo6Y29tbW9uVk0oKSk7CiAgICAgLy8gSWYg SmF2YVNjcmlwdCBzdGFjayBpcyBub3QgZW1wdHkgcG9zdHBvbmUgcmVjb21waWxhdGlvbi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1BhZ2VTY3JpcHREZWJ1Z1NlcnZl ci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvUGFnZVNjcmlwdERlYnVnU2VydmVyLmgK aW5kZXggMDViOGExYTRiNmQ2YzE3NTRmYTJhYmM1MjNjNjMzNDU4OGI2YzFiZS4uZThiZjY3MjM5 YjUyZTgwYzY1MTY3MDM1OTEyNWRhNGM3ZjNjNTQ1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvUGFnZVNjcmlwdERlYnVnU2VydmVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvUGFnZVNjcmlwdERlYnVnU2VydmVyLmgKQEAgLTUxLDcgKzUxLDcgQEAg cHVibGljOgogICAgIHZvaWQgYWRkTGlzdGVuZXIoU2NyaXB0RGVidWdMaXN0ZW5lciosIFBhZ2Uq KTsKICAgICB2b2lkIHJlbW92ZUxpc3RlbmVyKFNjcmlwdERlYnVnTGlzdGVuZXIqLCBQYWdlKik7 CiAKLSAgICB2aXJ0dWFsIHZvaWQgcmVjb21waWxlQWxsSlNGdW5jdGlvbnMoVGltZXI8U2NyaXB0 RGVidWdTZXJ2ZXI+Kik7CisgICAgdmlydHVhbCB2b2lkIHJlY29tcGlsZUFsbEpTRnVuY3Rpb25z KCkgT1ZFUlJJREU7CiAKIHByaXZhdGU6CiAgICAgdHlwZWRlZiBIYXNoTWFwPFBhZ2UqLCBPd25Q dHI8TGlzdGVuZXJTZXQ+PiBQYWdlTGlzdGVuZXJzTWFwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCmluZGV4IGFkYTU5MjlhNDI4MjEwMWI1 YTljYWI2ODMxNmVkNjNhZTQyNTBmMjMuLmM5NzNkYzc5YjA3ZGQ5ZDE1ODZhMDFlNjRjYzA5MmZh YzYxZmJlY2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdERl YnVnU2VydmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1 Z1NlcnZlci5jcHAKQEAgLTU0LDcgKzU0LDcgQEAgU2NyaXB0RGVidWdTZXJ2ZXI6OlNjcmlwdERl YnVnU2VydmVyKGJvb2wgaXNJbldvcmtlclRocmVhZCkKICAgICA6IERlYnVnZ2VyKGlzSW5Xb3Jr ZXJUaHJlYWQpCiAgICAgLCBtX2RvbmVQcm9jZXNzaW5nRGVidWdnZXJFdmVudHModHJ1ZSkKICAg ICAsIG1fY2FsbGluZ0xpc3RlbmVycyhmYWxzZSkKLSAgICAsIG1fcmVjb21waWxlVGltZXIodGhp cywgJlNjcmlwdERlYnVnU2VydmVyOjpyZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucykKKyAgICAsIG1f cmVjb21waWxlVGltZXIodGhpcywgJlNjcmlwdERlYnVnU2VydmVyOjpyZWNvbXBpbGVBbGxKU0Z1 bmN0aW9uc1RpbWVyRmlyZWQpCiB7CiB9CiAKQEAgLTI4NSw2ICsyODUsMTEgQEAgdm9pZCBTY3Jp cHREZWJ1Z1NlcnZlcjo6cmVjb21waWxlQWxsSlNGdW5jdGlvbnNTb29uKCkKICAgICBtX3JlY29t cGlsZVRpbWVyLnN0YXJ0T25lU2hvdCgwKTsKIH0KIAordm9pZCBTY3JpcHREZWJ1Z1NlcnZlcjo6 cmVjb21waWxlQWxsSlNGdW5jdGlvbnNUaW1lckZpcmVkKFRpbWVyPFNjcmlwdERlYnVnU2VydmVy PiYpCit7CisgICAgcmVjb21waWxlQWxsSlNGdW5jdGlvbnMoKTsKK30KKwogfSAvLyBuYW1lc3Bh Y2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5BQkxFKEpBVkFTQ1JJUFRfREVCVUdHRVIpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5oIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuaAppbmRleCAzZmIw MDY1YThhODNiZDZjNGZmNGRmOWZhZDkyNTAyNTkxMmY3NzE0Li5lYjkwZGM5OWVmZmUyMmUzOGU0 ZTcwN2RkMGRiZjVhMzAwN2NlNjUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9TY3JpcHREZWJ1Z1NlcnZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L1NjcmlwdERlYnVnU2VydmVyLmgKQEAgLTYwLDcgKzYwLDcgQEAgcHVibGljOgogICAgIHZvaWQg Y2xlYXJCcmVha3BvaW50cygpOwogCiAgICAgdm9pZCByZWNvbXBpbGVBbGxKU0Z1bmN0aW9uc1Nv b24oKTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVjb21waWxlQWxsSlNGdW5jdGlvbnMoVGltZXI8U2Ny aXB0RGVidWdTZXJ2ZXI+KiA9IDApID0gMDsKKyAgICB2aXJ0dWFsIHZvaWQgcmVjb21waWxlQWxs SlNGdW5jdGlvbnMoKSA9IDA7CiAKICAgICBjbGFzcyBUYXNrIHsKICAgICAgICAgV1RGX01BS0Vf RkFTVF9BTExPQ0FURUQ7CkBAIC0xMDYsNiArMTA2LDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFs IHZvaWQgaGFuZGxlUGF1c2UoSlNDOjpEZWJ1Z2dlcjo6UmVhc29uRm9yUGF1c2UsIEpTQzo6SlNH bG9iYWxPYmplY3QqKSBPVkVSUklERSBGSU5BTDsKICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5RG9u ZVByb2Nlc3NpbmdEZWJ1Z2dlckV2ZW50cygpIE9WRVJSSURFIEZJTkFMOwogCisgICAgdm9pZCBy ZWNvbXBpbGVBbGxKU0Z1bmN0aW9uc1RpbWVyRmlyZWQoVGltZXI8U2NyaXB0RGVidWdTZXJ2ZXI+ Jik7CisKICAgICBib29sIG1fY2FsbGluZ0xpc3RlbmVyczsKICAgICBCcmVha3BvaW50SURUb0Fj dGlvbnNNYXAgbV9icmVha3BvaW50SURUb0FjdGlvbnM7CiAgICAgVGltZXI8U2NyaXB0RGVidWdT ZXJ2ZXI+IG1fcmVjb21waWxlVGltZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9Xb3JrZXJTY3JpcHREZWJ1Z1NlcnZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9qcy9Xb3JrZXJTY3JpcHREZWJ1Z1NlcnZlci5jcHAKaW5kZXggNjhhNDg1MzVlZjc0N2Uw MDUyZDdhZmJmODExMGNjYTkzMzdkYTlhNC4uYmVjOWU1NzFiNzQ1ZDQ3ZjYyNjc3YTdjYWMxY2My N2MzNDZlNWU3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2Vy U2NyaXB0RGVidWdTZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dv cmtlclNjcmlwdERlYnVnU2VydmVyLmNwcApAQCAtNTgsMTAgKzU4LDEwIEBAIHZvaWQgV29ya2Vy U2NyaXB0RGVidWdTZXJ2ZXI6OmFkZExpc3RlbmVyKFNjcmlwdERlYnVnTGlzdGVuZXIqIGxpc3Rl bmVyKQogICAgIGlmIChtX2xpc3RlbmVycy5pc0VtcHR5KCkpCiAgICAgICAgIG1fd29ya2VyR2xv YmFsU2NvcGUtPnNjcmlwdCgpLT5hdHRhY2hEZWJ1Z2dlcih0aGlzKTsKICAgICBtX2xpc3RlbmVy cy5hZGQobGlzdGVuZXIpOwotICAgIHJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKDApOworICAgIHJl Y29tcGlsZUFsbEpTRnVuY3Rpb25zKCk7CiB9CiAKLXZvaWQgV29ya2VyU2NyaXB0RGVidWdTZXJ2 ZXI6OnJlY29tcGlsZUFsbEpTRnVuY3Rpb25zKFRpbWVyPFNjcmlwdERlYnVnU2VydmVyPiopCit2 b2lkIFdvcmtlclNjcmlwdERlYnVnU2VydmVyOjpyZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucygpCiB7 CiAgICAgSlNDOjpWTSogdm0gPSBtX3dvcmtlckdsb2JhbFNjb3BlLT5zY3JpcHQoKS0+dm0oKTsK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0RGVi dWdTZXJ2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dvcmtlclNjcmlwdERlYnVn U2VydmVyLmgKaW5kZXggYjA1Nzg2MTJiMjc5NzQ2NDk4ZjQ2MjlmNGI3MzhlY2Q5MDljNjY3ZS4u ZmIwMmQyMDYxMWZhMTJlM2U3YjEyNzkzZjNjZTkyZDA4YWE2MzljZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV29ya2VyU2NyaXB0RGVidWdTZXJ2ZXIuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9Xb3JrZXJTY3JpcHREZWJ1Z1NlcnZlci5oCkBAIC01 MCw3ICs1MCw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgaW50ZXJydXB0QW5kUnVuVGFzayhQYXNz T3duUHRyPFNjcmlwdERlYnVnU2VydmVyOjpUYXNrPik7CiAKLSAgICB2b2lkIHJlY29tcGlsZUFs bEpTRnVuY3Rpb25zKFRpbWVyPFNjcmlwdERlYnVnU2VydmVyPiopOworICAgIHZvaWQgcmVjb21w aWxlQWxsSlNGdW5jdGlvbnMoKSBPVkVSUklERTsKIAogcHJpdmF0ZToKICAgICB2aXJ0dWFsIExp c3RlbmVyU2V0KiBnZXRMaXN0ZW5lcnNGb3JHbG9iYWxPYmplY3QoSlNDOjpKU0dsb2JhbE9iamVj dCopIE9WRVJSSURFIHsgcmV0dXJuICZtX2xpc3RlbmVyczsgfQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclByb2ZpbGVyQWdlbnQuY3BwIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclByb2ZpbGVyQWdlbnQuY3BwCmluZGV4IDBhZjlkNGVi OWY2YmJiZGJmZTcwYmZhYTk5ODcxODI2MTA2MTEzOTkuLmNjODMwMjJhNzM2MmQwZWMwY2ZjZmFk ZmRjNmFiNjZmMzUwMGMwODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JQcm9maWxlckFnZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yUHJvZmlsZXJBZ2VudC5jcHAKQEAgLTM0OSw3ICszNDksNyBAQCB2b2lkIEluc3Bl Y3RvclByb2ZpbGVyQWdlbnQ6OnN0YXJ0KEVycm9yU3RyaW5nKikKICAgICAgICAgcmV0dXJuOwog ICAgIGlmICghZW5hYmxlZCgpKSB7CiAgICAgICAgIGVuYWJsZSh0cnVlKTsKLSAgICAgICAgUGFn ZVNjcmlwdERlYnVnU2VydmVyOjpzaGFyZWQoKS5yZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucygwKTsK KyAgICAgICAgUGFnZVNjcmlwdERlYnVnU2VydmVyOjpzaGFyZWQoKS5yZWNvbXBpbGVBbGxKU0Z1 bmN0aW9ucygpOwogICAgIH0KICAgICBtX3JlY29yZGluZ0NQVVByb2ZpbGUgPSB0cnVlOwogICAg IFN0cmluZyB0aXRsZSA9IGdldEN1cnJlbnRVc2VySW5pdGlhdGVkUHJvZmlsZU5hbWUodHJ1ZSk7 Cg==