126816 2014-01-11 10:48:12 -0800 Simplify Timer and DeferrableOneShotTimer using std::function 2014-01-11 11:12:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca commit-queue oldest_to_newest 966804 0 andersca 2014-01-11 10:48:12 -0800 Simplify Timer and DeferrableOneShotTimer using std::function 966809 1 220939 andersca 2014-01-11 11:03:08 -0800 Created attachment 220939 Patch 966811 2 commit-queue 2014-01-11 11:06:58 -0800 Attachment 220939 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/Timer.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/WebKit2.xcconfig', '--commit-queue']" exit_code: 1 ERROR: Source/WebCore/platform/Timer.h:133: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 966813 3 andersca 2014-01-11 11:12:12 -0800 Committed r161769: <http://trac.webkit.org/changeset/161769> 220939 2014-01-11 11:03:08 -0800 2014-01-11 11:09:48 -0800 Patch bug-126816-20140111110308.patch text/plain 6290 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWU2YzJjZTkwMTRlYTE0 MDQzMjNhZjNkMWJhZjJlMGVmMjdjMzIyZi4uNjI5MDZiMDM5YWViYTQ5MGFkNjNiZjJiMjk4ZDY3 YzViYTc2N2FhYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE0LTAxLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgU2ltcGxpZnkgVGlt ZXIgYW5kIERlZmVycmFibGVPbmVTaG90VGltZXIgdXNpbmcgc3RkOjpmdW5jdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODE2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9UaW1l ci5oOgorICAgICAgICAoV2ViQ29yZTo6VGltZXI6OlRpbWVyKToKKworMjAxNC0wMS0xMSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIENUVEUgVGltZXIg YW5kIERlZmVycmFibGVPbmVTaG90VGltZXIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNjgxNAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTAxNzhjMzZmMGFlOWQ0 OWEyNmFhMWFlOThlNWVkMzNiOTQwYzQ4Zi4uYTdmZTkxNWVhNGY3YmNlZjExZjU0MWQwYzNlMjMz ODgwODZmMzY2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTAxLTExICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU2ltcGxpZnkgVGlt ZXIgYW5kIERlZmVycmFibGVPbmVTaG90VGltZXIgdXNpbmcgc3RkOjpmdW5jdGlvbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODE2CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFub3RoZXIgdW5l eHBvcnRlZCBzeW1ib2wuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJLaXQyLnhjY29u ZmlnOgorCiAyMDE0LTAxLTExICBKaW53b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNv bT4KIAogICAgICAgICBbRUZMXVtXSzJdIFVzZSBudWxscHRyIGluc3RlYWQgb2YgMCBpbiBFRkwg QVBJIGxheWVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UaW1lci5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVGltZXIuaAppbmRleCBjZDMxZWExYmNhZTZlYzk1YWIw MGRkNzZkMTkzNjJmYjNiZGMyYmUwLi43YjdkZjVhYzU3YzI0MmJjMzA5MGNiNzAzZjJlNGQ3ZDky OTAxZmUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UaW1lci5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RpbWVyLmgKQEAgLTI2LDYgKzI2LDcgQEAKICNpZm5k ZWYgVGltZXJfaAogI2RlZmluZSBUaW1lcl9oCiAKKyNpbmNsdWRlIDxmdW5jdGlvbmFsPgogI2lu Y2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogI2luY2x1ZGUgPHd0Zi9UaHJlYWRpbmcuaD4KICNp bmNsdWRlIDx3dGYvVmVjdG9yLmg+CkBAIC0xMTMsMzQgKzExNCwyMyBAQCBwdWJsaWM6CiAgICAg dHlwZWRlZiB2b2lkIChUaW1lckZpcmVkQ2xhc3M6OipUaW1lckZpcmVkRnVuY3Rpb24pKFRpbWVy Jik7CiAgICAgdHlwZWRlZiB2b2lkIChUaW1lckZpcmVkQ2xhc3M6OipEZXByZWNhdGVkVGltZXJG aXJlZEZ1bmN0aW9uKShUaW1lciopOwogCi0gICAgVGltZXIoVGltZXJGaXJlZENsYXNzKiBvYmpl Y3QsIFRpbWVyRmlyZWRGdW5jdGlvbiBmdW5jdGlvbikKLSAgICAgICAgOiBtX29iamVjdChvYmpl Y3QpCi0gICAgICAgICwgbV9kZXByZWNhdGVkRnVuY3Rpb24obnVsbHB0cikKLSAgICAgICAgLCBt X2Z1bmN0aW9uKGZ1bmN0aW9uKQorICAgIFRpbWVyKFRpbWVyRmlyZWRDbGFzcyogb2JqZWN0ICwg VGltZXJGaXJlZEZ1bmN0aW9uIGZ1bmN0aW9uKQorICAgICAgICA6IG1fZnVuY3Rpb24oc3RkOjpi aW5kKGZ1bmN0aW9uLCBvYmplY3QsIHN0ZDo6cmVmKCp0aGlzKSkpCiAgICAgewogICAgIH0KIAog ICAgIFRpbWVyKFRpbWVyRmlyZWRDbGFzcyogb2JqZWN0LCBEZXByZWNhdGVkVGltZXJGaXJlZEZ1 bmN0aW9uIGZ1bmN0aW9uKQotICAgICAgICA6IG1fb2JqZWN0KG9iamVjdCkKLSAgICAgICAgLCBt X2RlcHJlY2F0ZWRGdW5jdGlvbihmdW5jdGlvbikKLSAgICAgICAgLCBtX2Z1bmN0aW9uKG51bGxw dHIpCisgICAgICAgIDogbV9mdW5jdGlvbihzdGQ6OmJpbmQoZnVuY3Rpb24sIG9iamVjdCwgdGhp cykpCiAgICAgewogICAgIH0KIAogcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgZmlyZWQoKSBP VkVSUklERQogICAgIHsKLSAgICAgICAgaWYgKG1fZGVwcmVjYXRlZEZ1bmN0aW9uKSB7Ci0gICAg ICAgICAgICAobV9vYmplY3QtPiptX2RlcHJlY2F0ZWRGdW5jdGlvbikodGhpcyk7Ci0gICAgICAg ICAgICByZXR1cm47Ci0gICAgICAgIH0KLQotICAgICAgICAobV9vYmplY3QtPiptX2Z1bmN0aW9u KSgqdGhpcyk7CisgICAgICAgIG1fZnVuY3Rpb24oKTsKICAgICB9CiAKLSAgICBUaW1lckZpcmVk Q2xhc3MqIG1fb2JqZWN0OwotICAgIERlcHJlY2F0ZWRUaW1lckZpcmVkRnVuY3Rpb24gbV9kZXBy ZWNhdGVkRnVuY3Rpb247Ci0gICAgVGltZXJGaXJlZEZ1bmN0aW9uIG1fZnVuY3Rpb247CisgICAg c3RkOjpmdW5jdGlvbjx2b2lkICgpPiBtX2Z1bmN0aW9uOwogfTsKIAogaW5saW5lIGJvb2wgVGlt ZXJCYXNlOjppc0FjdGl2ZSgpIGNvbnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9Db25m aWd1cmF0aW9ucy9XZWJLaXQyLnhjY29uZmlnIGIvU291cmNlL1dlYktpdDIvQ29uZmlndXJhdGlv bnMvV2ViS2l0Mi54Y2NvbmZpZwppbmRleCA3MjZjYmIzZmY3MWU0MDJiMjgyZWM2MWRjMWQyNWVh ZjQwN2U3ZjNiLi4xOGE4Yjk3NDZkNzJiNGRiNjU3ZGJiY2RkYjk3MmFkZTBlZjA1NjM4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9XZWJLaXQyLnhjY29uZmlnCisr KyBiL1NvdXJjZS9XZWJLaXQyL0NvbmZpZ3VyYXRpb25zL1dlYktpdDIueGNjb25maWcKQEAgLTMy LDcgKzMyLDcgQEAgRFlMSUJfSU5TVEFMTF9OQU1FX0JBU0UgPSAkKE5PUk1BTF9XRUJLSVQyX0ZS QU1FV09SS1NfRElSKTsKIEZSQU1FV09SS19BTkRfTElCUkFSWV9MREZMQUdTID0gLWZyYW1ld29y ayBBcHBsaWNhdGlvblNlcnZpY2VzIC1mcmFtZXdvcmsgQ2FyYm9uIC1mcmFtZXdvcmsgQ29jb2Eg LWZyYW1ld29yayBDb3JlU2VydmljZXMgLWZyYW1ld29yayBJT0tpdCAtZnJhbWV3b3JrIEphdmFT Y3JpcHRDb3JlIC1saWN1Y29yZSAtZnJhbWV3b3JrIFF1YXJ0ekNvcmUgLWZyYW1ld29yayBXZWJD b3JlIC1mcmFtZXdvcmsgQ29yZUF1ZGlvIC1mcmFtZXdvcmsgSU9TdXJmYWNlOwogCiAvLyBQcmV2 ZW50IEMrKyBzdGFuZGFyZCBsaWJyYXJ5IG9wZXJhdG9yIG5ldywgZGVsZXRlIGFuZCB0aGVpciBy ZWxhdGVkIGV4Y2VwdGlvbiB0eXBlcyBmcm9tIGJlaW5nIGV4cG9ydGVkIGFzIHdlYWsgc3ltYm9s cy4KLVVORVhQT1JURURfU1lNQk9MX0xERkxBR1MgPSAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1X bCxfX1pUSVN0OWJhZF9hbGxvYyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX1pUSVN0OWV4 Y2VwdGlvbiAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX1pUU1N0OWJhZF9hbGxvYyAtV2ws LXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX1pUU1N0OWV4Y2VwdGlvbiAtV2wsLXVuZXhwb3J0ZWRf c3ltYm9sIC1XbCxfX1pkbFB2U18gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19abndtUHYg LVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19abndtIC1XbCwtdW5leHBvcnRlZF9zeW1ib2ws IC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVDMkVP UzRfIC1XbCwtdW5leHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdX ZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVDMUVPUzRfIC1XbCwtdW5leHBvcnRlZF9zeW1ib2wsIC1X bCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVhU0VEbiAt V2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTktTdDNfXzE4ZnVuY3Rpb25JRnZON1dlYkNv cmUxMlBvbGljeUFjdGlvbkVFRWNsRVMyXyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19a TlN0M19fMThmdW5jdGlvbklGdk43V2ViQ29yZTEyUG9saWN5QWN0aW9uRUVFNHN3YXBFUlM0XyAt V2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTlN0M19fMThmdW5jdGlvbklGdk43V2ViQ29y ZTEyUG9saWN5QWN0aW9uRUVFQzFFUktTNF8gLVdsLC11bmV4cG9ydGVkX3N5bWJvbCwgLVdsLF9f Wk5TdDNfXzE4ZnVuY3Rpb25JRnZON1dlYkNvcmUxMlBvbGljeUFjdGlvbkVFRUMyRVJLUzRfIC1X bCwtdW5leHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3Jl MTJQb2xpY3lBY3Rpb25FRUVEMUV2IC1XbCwtdW5leHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3Qz X18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVEMkV2IC1XbCwtdW5leHBv cnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lB Y3Rpb25FRUVhU0VSS1M0XzsKK1VORVhQT1JURURfU1lNQk9MX0xERkxBR1MgPSAtV2wsLXVuZXhw b3J0ZWRfc3ltYm9sIC1XbCxfX1pUSVN0OWJhZF9hbGxvYyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9s IC1XbCxfX1pUSVN0OWV4Y2VwdGlvbiAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX1pUU1N0 OWJhZF9hbGxvYyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX1pUU1N0OWV4Y2VwdGlvbiAt V2wsLXVuZXhwb3J0ZWRfc3ltYm9sIC1XbCxfX1pkbFB2U18gLVdsLC11bmV4cG9ydGVkX3N5bWJv bCAtV2wsX19abndtUHYgLVdsLC11bmV4cG9ydGVkX3N5bWJvbCAtV2wsX19abndtIC1XbCwtdW5l eHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xp Y3lBY3Rpb25FRUVDMkVPUzRfIC1XbCwtdW5leHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18x OGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVDMUVPUzRfIC1XbCwtdW5leHBv cnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lB Y3Rpb25FRUVhU0VEbiAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTktTdDNfXzE4ZnVu Y3Rpb25JRnZON1dlYkNvcmUxMlBvbGljeUFjdGlvbkVFRWNsRVMyXyAtV2wsLXVuZXhwb3J0ZWRf c3ltYm9sLCAtV2wsX19aTlN0M19fMThmdW5jdGlvbklGdk43V2ViQ29yZTEyUG9saWN5QWN0aW9u RUVFNHN3YXBFUlM0XyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAtV2wsX19aTlN0M19fMThmdW5j dGlvbklGdk43V2ViQ29yZTEyUG9saWN5QWN0aW9uRUVFQzFFUktTNF8gLVdsLC11bmV4cG9ydGVk X3N5bWJvbCwgLVdsLF9fWk5TdDNfXzE4ZnVuY3Rpb25JRnZON1dlYkNvcmUxMlBvbGljeUFjdGlv bkVFRUMyRVJLUzRfIC1XbCwtdW5leHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0 aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVEMUV2IC1XbCwtdW5leHBvcnRlZF9zeW1i b2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdXZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVE MkV2IC1XbCwtdW5leHBvcnRlZF9zeW1ib2wsIC1XbCxfX1pOU3QzX18xOGZ1bmN0aW9uSUZ2TjdX ZWJDb3JlMTJQb2xpY3lBY3Rpb25FRUVhU0VSS1M0XyAtV2wsLXVuZXhwb3J0ZWRfc3ltYm9sLCAt V2wsX19aVFZOU3QzX18xMTdiYWRfZnVuY3Rpb25fY2FsbEU7CiAKIE9USEVSX0xERkxBR1MgPSAk KGluaGVyaXRlZCkgJChVTkVYUE9SVEVEX1NZTUJPTF9MREZMQUdTKSAkKE9USEVSX0xERkxBR1Nf JChQTEFURk9STV9OQU1FKSk7CiBPVEhFUl9MREZMQUdTX21hY29zeCA9ICQoRlJBTUVXT1JLX0FO RF9MSUJSQVJZX0xERkxBR1MpOwo=