<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126815</bug_id>
          
          <creation_ts>2014-01-11 10:13:15 -0800</creation_ts>
          <short_desc>[Mac] xcodebuild color output is suppressed when using make</short_desc>
          <delta_ts>2014-06-03 23:07:58 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>mitz</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>966800</commentid>
    <comment_count>0</comment_count>
    <who name="">mitz</who>
    <bug_when>2014-01-11 10:13:15 -0800</bug_when>
    <thetext>When using make to build WebKit, xcodebuild’s output is piped through a filter, which causes it not to format its output with color and emphasis.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966802</commentid>
    <comment_count>1</comment_count>
      <attachid>220936</attachid>
    <who name="">mitz</who>
    <bug_when>2014-01-11 10:16:14 -0800</bug_when>
    <thetext>Created attachment 220936
Pass COLOR_DIAGNOSTICS=YES to xcodebuild</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966820</commentid>
    <comment_count>2</comment_count>
    <who name="">mitz</who>
    <bug_when>2014-01-11 11:44:19 -0800</bug_when>
    <thetext>Fixed (to the extent possible) in &lt;http://trac.webkit.org/r161772&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1013165</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2014-06-03 15:35:18 -0700</bug_when>
    <thetext>This caused a &quot;make d&quot; in Source/WebCore to do a  full rebuild because its environment has COLOR_DIAGNOSTICS=NO</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1013233</commentid>
    <comment_count>4</comment_count>
    <who name="">mitz</who>
    <bug_when>2014-06-03 22:08:43 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; This caused a &quot;make d&quot; in Source/WebCore to do a  full rebuild because its environment has COLOR_DIAGNOSTICS=NO

Is this something specific to WebCore? When I try this in Source/WTF I see COLOR_DIAGNOSTICS being set to YES when using make and to NO when building in the Xcode IDE, but alternating between the two doesn’t cause any files to recompile. I’m using Xcode 5.1.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1013236</commentid>
    <comment_count>5</comment_count>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2014-06-03 22:59:36 -0700</bug_when>
    <thetext>This may depend on the Xcode version. I&apos;ve only noticed this rebuilding issue fairly recently.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1013237</commentid>
    <comment_count>6</comment_count>
    <who name="">mitz</who>
    <bug_when>2014-06-03 23:07:58 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; This may depend on the Xcode version. I&apos;ve only noticed this rebuilding issue fairly recently.

Just using xcodebuild from the command line (without piping through a filter) results in COLOR_DIAGNOSTICS being set to YES, whereas building from the IDE sets it to NO. If this difference alone causes some version of Xcode to rebuild everything, then it’s an issue with global impact, not affecting only WebKit.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220936</attachid>
            <date>2014-01-11 10:16:14 -0800</date>
            <delta_ts>2014-01-11 11:43:32 -0800</delta_ts>
            <desc>Pass COLOR_DIAGNOSTICS=YES to xcodebuild</desc>
            <filename>color-on.diff</filename>
            <type>text/plain</type>
            <size>1364</size>
            <attacher>mitz</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTc2
NykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAx
LTExICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10geGNv
ZGVidWlsZCBjb2xvciBvdXRwdXQgaXMgc3VwcHJlc3NlZCB3aGVuIHVzaW5nIG1ha2UKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjgxNQorCisgICAg
ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdIZW4gdXNpbmcgbWFr
ZSwgeGNvZGVidWlsZOKAmXMgb3V0cHV0IGlzIHBpcGVkIHRocm91Z2ggYSBmaWx0ZXIsIHdoaWNo
IGNhdXNlcyBpdCBub3QgdG8KKyAgICAgICAgZm9ybWF0IGl0cyBvdXRwdXQgd2l0aCBjb2xvciBh
bmQgZW1waGFzaXMuCisKKyAgICAgICAgKiBNYWtlZmlsZS5zaGFyZWQ6IFBhc3MgQ09MT1JfRElB
R05PU1RJQ1M9WUVTIHRvIHhjb2RlYnVpbGQgdG8gZm9yY2UgY29sb3Igb3V0cHV0IG9uLiBEdWUg
dG8KKyAgICAgICAgeGNvZGVidWlsZCBsaW1pdGF0aW9ucywgdGhpcyByZXN0b3JlcyBzb21lIG9m
IHRoZSBmb3JtYXR0aW5nLCBidXQgbm90IGFsbCBvZiBpdC4KKwogMjAxNC0wMS0xMCAgQmVuamFt
aW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgdGhlIEJs
YWNrQmVycnkgcG9ydCBmcm9tIHRydW5rCkluZGV4OiBNYWtlZmlsZS5zaGFyZWQKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gTWFrZWZpbGUuc2hhcmVkCShyZXZpc2lvbiAxNjE3NjcpCisrKyBNYWtlZmlsZS5zaGFy
ZWQJKHdvcmtpbmcgY29weSkKQEAgLTEsNiArMSw2IEBACiBTQ1JJUFRTX1BBVEggPz0gLi4vVG9v
bHMvU2NyaXB0cwogCi1YQ09ERV9PUFRJT05TID0gYHBlcmwgLUkkKFNDUklQVFNfUEFUSCkgLU13
ZWJraXRkaXJzIC1lICdwcmludCBYY29kZU9wdGlvblN0cmluZygpJyAtLSAkKEJVSUxEX1dFQktJ
VF9PUFRJT05TKWAgJChBUkdTKQorWENPREVfT1BUSU9OUyA9IGBwZXJsIC1JJChTQ1JJUFRTX1BB
VEgpIC1Nd2Via2l0ZGlycyAtZSAncHJpbnQgWGNvZGVPcHRpb25TdHJpbmcoKScgLS0gJChCVUlM
RF9XRUJLSVRfT1BUSU9OUylgIENPTE9SX0RJQUdOT1NUSUNTPVlFUyAkKEFSR1MpCiAKIGlmbmVx
ICgsJChTREtST09UKSkKIAlYQ09ERV9PUFRJT05TICs9IFNES1JPT1Q9JChTREtST09UKQo=
</data>
<flag name="review"
          id="244751"
          type_id="1"
          status="+"
          setter="andersca"
    />
          </attachment>
      

    </bug>

</bugzilla>