126810 2014-01-11 01:03:01 -0800 [Win] Application name in user agent string is truncated. 2014-01-14 10:38:15 -0800 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) PC Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned andersca benjamin bfulgham cmarcelo commit-queue oldest_to_newest 966769 0 peavo 2014-01-11 01:03:01 -0800 The application name part of the user agent string is cut off after the first letter. We need to make the application name string 8 bit. 966770 1 220924 peavo 2014-01-11 01:08:57 -0800 Created attachment 220924 Patch 966771 2 220925 peavo 2014-01-11 01:47:57 -0800 Created attachment 220925 Patch 966792 3 220925 andersca 2014-01-11 08:07:09 -0800 Comment on attachment 220925 Patch This won't work if the application name contains 16-bit characters. Maybe something in the network layer is wrong? 966793 4 220925 bfulgham 2014-01-11 09:40:39 -0800 Comment on attachment 220925 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220925&action=review > Source/WebKit/win/WebView.cpp:3186 > + m_applicationName = String::make8BitFrom16BitSource(applicationName16.characters16(), applicationName16.length()); Maybe this should just be applicationName16.utf8().data(). 966839 5 220945 peavo 2014-01-11 13:20:23 -0800 Created attachment 220945 Patch 966840 6 peavo 2014-01-11 13:21:18 -0800 (In reply to comment #4) > (From update of attachment 220925 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=220925&action=review > > > Source/WebKit/win/WebView.cpp:3186 > > + m_applicationName = String::make8BitFrom16BitSource(applicationName16.characters16(), applicationName16.length()); > > Maybe this should just be applicationName16.utf8().data(). Thanks for looking into this, guys :) Updated patch according to comments. 966855 7 220945 andersca 2014-01-11 16:51:09 -0800 Comment on attachment 220945 Patch I don't think this is quite right either. m_applicationName is already Unicode encoded. 967313 8 221042 peavo 2014-01-13 07:52:31 -0800 Created attachment 221042 Patch 967810 9 peavo 2014-01-14 07:05:05 -0800 (In reply to comment #8) > Created an attachment (id=221042) [details] > Patch Updated patch, the root of the problem seems to be a missing 8-bit check in the string concatenation. 967917 10 221042 commit-queue 2014-01-14 10:38:12 -0800 Comment on attachment 221042 Patch Clearing flags on attachment: 221042 Committed r161983: <http://trac.webkit.org/changeset/161983> 967918 11 commit-queue 2014-01-14 10:38:15 -0800 All reviewed patches have been landed. Closing bug. 220924 2014-01-11 01:08:57 -0800 2014-01-11 01:47:44 -0800 Patch bug-126810-20140111100838.patch text/plain 1410 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTc1OCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTEx ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5d IEFwcGxpY2F0aW9uIG5hbWUgaW4gdXNlciBhZ2VudCBzdHJpbmcgaXMgdHJ1bmNhdGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODEwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFwcGxpY2F0 aW9uIG5hbWUgc3RyaW5nIGlzIGN1dCBvZmYgYWZ0ZXIgZmlyc3QgbGV0dGVyLCBzaW5jZSBpdCdz IGluIHVuaWNvZGUuCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6 OnNldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudCk6IENvbnZlcnQgYXBwbGljYXRpb24gbmFt ZSBzdHJpbmcgdG8gOCBiaXQuCisKIDIwMTQtMDEtMTAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBUd2VhayBQcm9ncmVzc1RyYWNrZXJDbGllbnQgZnVu Y3Rpb25zCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTYxNzU4KQorKysgU291 cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxODIsNyArMzE4 Miw4IEBAIGZsb2F0IFdlYlZpZXc6Onpvb21NdWx0aXBsaWVyKGJvb2wgaXNUZXgKIEhSRVNVTFQg U1RETUVUSE9EQ0FMTFRZUEUgV2ViVmlldzo6c2V0QXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50 KCAKICAgICAvKiBbaW5dICovIEJTVFIgYXBwbGljYXRpb25OYW1lKQogewotICAgIG1fYXBwbGlj YXRpb25OYW1lID0gdG9TdHJpbmcoYXBwbGljYXRpb25OYW1lKTsKKyAgICBTdHJpbmcgYXBwbGlj YXRpb25OYW1lID0gdG9TdHJpbmcoYXBwbGljYXRpb25OYW1lKTsKKyAgICBtX2FwcGxpY2F0aW9u TmFtZSA9IFN0cmluZzo6bWFrZThCaXRGcm9tMTZCaXRTb3VyY2UoYXBwbGljYXRpb25OYW1lLmNo YXJhY3RlcnMxNigpLCBhcHBsaWNhdGlvbk5hbWUubGVuZ3RoKCkpOwogICAgIG1fdXNlckFnZW50 U3RhbmRhcmQgPSBTdHJpbmcoKTsKICAgICByZXR1cm4gU19PSzsKIH0K 220925 2014-01-11 01:47:57 -0800 2014-01-11 13:20:15 -0800 Patch bug-126810-20140111104737.patch text/plain 1416 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTc1OCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTEx ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5d IEFwcGxpY2F0aW9uIG5hbWUgaW4gdXNlciBhZ2VudCBzdHJpbmcgaXMgdHJ1bmNhdGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODEwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFwcGxpY2F0 aW9uIG5hbWUgc3RyaW5nIGlzIGN1dCBvZmYgYWZ0ZXIgZmlyc3QgbGV0dGVyLCBzaW5jZSBpdCdz IGluIHVuaWNvZGUuCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6 OnNldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudCk6IENvbnZlcnQgYXBwbGljYXRpb24gbmFt ZSBzdHJpbmcgdG8gOCBiaXQuCisKIDIwMTQtMDEtMTAgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVy c2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBUd2VhayBQcm9ncmVzc1RyYWNrZXJDbGllbnQgZnVu Y3Rpb25zCkluZGV4OiBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkocmV2aXNpb24gMTYxNzU4KQorKysgU291 cmNlL1dlYktpdC93aW4vV2ViVmlldy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxODIsNyArMzE4 Miw4IEBAIGZsb2F0IFdlYlZpZXc6Onpvb21NdWx0aXBsaWVyKGJvb2wgaXNUZXgKIEhSRVNVTFQg U1RETUVUSE9EQ0FMTFRZUEUgV2ViVmlldzo6c2V0QXBwbGljYXRpb25OYW1lRm9yVXNlckFnZW50 KCAKICAgICAvKiBbaW5dICovIEJTVFIgYXBwbGljYXRpb25OYW1lKQogewotICAgIG1fYXBwbGlj YXRpb25OYW1lID0gdG9TdHJpbmcoYXBwbGljYXRpb25OYW1lKTsKKyAgICBTdHJpbmcgYXBwbGlj YXRpb25OYW1lMTYgPSB0b1N0cmluZyhhcHBsaWNhdGlvbk5hbWUpOworICAgIG1fYXBwbGljYXRp b25OYW1lID0gU3RyaW5nOjptYWtlOEJpdEZyb20xNkJpdFNvdXJjZShhcHBsaWNhdGlvbk5hbWUx Ni5jaGFyYWN0ZXJzMTYoKSwgYXBwbGljYXRpb25OYW1lMTYubGVuZ3RoKCkpOwogICAgIG1fdXNl ckFnZW50U3RhbmRhcmQgPSBTdHJpbmcoKTsKICAgICByZXR1cm4gU19PSzsKIH0K 220945 2014-01-11 13:20:23 -0800 2014-01-13 07:52:24 -0800 Patch bug-126810-20140111222002.patch text/plain 1353 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTc1OCkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTEx ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5d IEFwcGxpY2F0aW9uIG5hbWUgaW4gdXNlciBhZ2VudCBzdHJpbmcgaXMgdHJ1bmNhdGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODEwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGFwcGxpY2F0 aW9uIG5hbWUgc3RyaW5nIGlzIGN1dCBvZmYgYWZ0ZXIgZmlyc3QgbGV0dGVyLCBzaW5jZSBpdCdz IGluIHVuaWNvZGUuCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKFdlYlZpZXc6 OnNldEFwcGxpY2F0aW9uTmFtZUZvclVzZXJBZ2VudCk6IENvbnZlcnQgYXBwbGljYXRpb24gbmFt ZSBzdHJpbmcgdG8gdXRmOC4KKwogMjAxNC0wMS0xMCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJz Y2FAYXBwbGUuY29tPgogCiAgICAgICAgIFR3ZWFrIFByb2dyZXNzVHJhY2tlckNsaWVudCBmdW5j dGlvbnMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQvd2luL1dlYlZpZXcuY3BwCShyZXZpc2lvbiAxNjE3NTgpCisrKyBTb3Vy Y2UvV2ViS2l0L3dpbi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzE4Miw3ICszMTgy LDggQEAgZmxvYXQgV2ViVmlldzo6em9vbU11bHRpcGxpZXIoYm9vbCBpc1RleAogSFJFU1VMVCBT VERNRVRIT0RDQUxMVFlQRSBXZWJWaWV3OjpzZXRBcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQo IAogICAgIC8qIFtpbl0gKi8gQlNUUiBhcHBsaWNhdGlvbk5hbWUpCiB7Ci0gICAgbV9hcHBsaWNh dGlvbk5hbWUgPSB0b1N0cmluZyhhcHBsaWNhdGlvbk5hbWUpOworICAgIFN0cmluZyBhcHBsaWNh dGlvbk5hbWUxNiA9IHRvU3RyaW5nKGFwcGxpY2F0aW9uTmFtZSk7CisgICAgbV9hcHBsaWNhdGlv bk5hbWUgPSBhcHBsaWNhdGlvbk5hbWUxNi51dGY4KCkuZGF0YSgpOwogICAgIG1fdXNlckFnZW50 U3RhbmRhcmQgPSBTdHJpbmcoKTsKICAgICByZXR1cm4gU19PSzsKIH0K 221042 2014-01-13 07:52:31 -0800 2014-01-14 10:38:11 -0800 Patch bug-126810-20140113165225.patch text/plain 1400 peavo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxNjE4NzcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTEzICBwZWF2b0BvdXRsb29rLmNvbSAg PHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIEFwcGxpY2F0aW9uIG5hbWUgaW4g dXNlciBhZ2VudCBzdHJpbmcgaXMgdHJ1bmNhdGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2ODEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oOgor ICAgICAgICAoV1RGOjp0cnlNYWtlU3RyaW5nKTogQWRkIG1pc3NpbmcgOCBiaXQgY2hlY2sgZm9y IGxhc3QgYXJndW1lbnQuIAorCiAyMDE0LTAxLTEzICBDb21taXQgUXVldWUgIDxjb21taXQtcXVl dWVAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTYxODU1 LgpJbmRleDogU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RleHQvU3RyaW5nQ29uY2F0ZW5hdGUuaAkocmV2aXNpb24g MTYxODc3KQorKysgU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC03MDEsNyArNzAxLDcgQEAgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiB0cnlN YWtlU3RyaW5nKFN0cgogICAgIGlmIChvdmVyZmxvdykKICAgICAgICAgcmV0dXJuIDA7CiAKLSAg ICBpZiAoYWRhcHRlcjEuaXM4Qml0KCkgJiYgYWRhcHRlcjIuaXM4Qml0KCkgJiYgYWRhcHRlcjMu aXM4Qml0KCkgJiYgYWRhcHRlcjQuaXM4Qml0KCkgJiYgYWRhcHRlcjUuaXM4Qml0KCkgJiYgYWRh cHRlcjYuaXM4Qml0KCkpIHsKKyAgICBpZiAoYWRhcHRlcjEuaXM4Qml0KCkgJiYgYWRhcHRlcjIu aXM4Qml0KCkgJiYgYWRhcHRlcjMuaXM4Qml0KCkgJiYgYWRhcHRlcjQuaXM4Qml0KCkgJiYgYWRh cHRlcjUuaXM4Qml0KCkgJiYgYWRhcHRlcjYuaXM4Qml0KCkgJiYgYWRhcHRlcjcuaXM4Qml0KCkp IHsKICAgICAgICAgTENoYXIqIGJ1ZmZlcjsKICAgICAgICAgUmVmUHRyPFN0cmluZ0ltcGw+IHJl c3VsdEltcGwgPSBTdHJpbmdJbXBsOjp0cnlDcmVhdGVVbmluaXRpYWxpemVkKGxlbmd0aCwgYnVm ZmVyKTsKICAgICAgICAgaWYgKCFyZXN1bHRJbXBsKQo=