126800 2014-01-10 17:57:11 -0800 Web Inspector: Switching tabs to window with inspector open prohibits typing into console 2015-03-25 14:19:46 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) Mac OS X 10.9 RESOLVED FIXED InRadar P2 Normal --- 143030 1 jonowells rniwa darin dbates enrica joepeck jonlee rniwa sam timothy webkit-bug-importer oldest_to_newest 966713 0 jonowells 2014-01-10 17:57:11 -0800 There is an issue with the text input field in the console. In many situations, switching back to a window with the console open, clicking into the console text entry field, then typing results in no text being entered. To reproduce: 1. Open Safari using the nightly build to a blank page. 2. Hit Option-Command-C to open the console 3. Enter a command to confirm the field currently works. 4. Hit Command-T to open a new tab. 5. Hit Shift-Command-[ to move back to the first tab. 6. Click inside the console entry field. 7. Type a key other than Tab or Delete. A key other than these will not work. 966714 1 webkit-bug-importer 2014-01-10 17:57:29 -0800 <rdar://problem/15798159> 1079919 2 249396 rniwa 2015-03-25 03:35:08 -0700 Created attachment 249396 Fixes the bug 1080029 3 249396 andersca 2015-03-25 13:59:27 -0700 Comment on attachment 249396 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=249396&action=review > Source/WebKit2/UIProcess/WebPageProxy.h:396 > + void updateFocusAppearance(); I think this should have a more descriptive name that indicates that it restores the selection. 1080032 4 rniwa 2015-03-25 14:14:49 -0700 (In reply to comment #3) > Comment on attachment 249396 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=249396&action=review > > > Source/WebKit2/UIProcess/WebPageProxy.h:396 > > + void updateFocusAppearance(); > > I think this should have a more descriptive name that indicates that it > restores the selection. Renamed to restoreSelectionInFocusedEditableElement. 1080036 5 rniwa 2015-03-25 14:19:46 -0700 Committed r181972: <http://trac.webkit.org/changeset/181972> 249396 2015-03-25 03:35:08 -0700 2015-03-25 13:59:27 -0700 Fixes the bug bug-126800-20150325033431.patch text/plain 5169 rniwa SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE4MTk0MykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBACisyMDE1LTAzLTI1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFN3aXRj aGluZyB0YWJzIHRvIHdpbmRvdyB3aXRoIGluc3BlY3RvciBvcGVuIHByb2hpYml0cyB0eXBpbmcg aW50byBjb25zb2xlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMjY4MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGlzIGEgcmVncmVzc2lvbiBmcm9tIHI4NTM1NiBhbmQgcjgzODE0LiBUaGVzZSB0 d28gcGF0Y2hlcyBtYWRlIFdLV2ViVmlldyBjbGVhciBpdHMgc2VsZWN0aW9uCisgICAgICAgIHdo ZW4gV0tWaWV3IHJlc2lnbnMgdGhlIGZpcnN0IHJlc3BvbmRlciB3aXRob3V0IGV2ZXIgcmVzdG9y aW5nIGl0IGV2ZW4gaWYgV0tWaWV3IGxhdGVyIGJlY29tZXMKKyAgICAgICAgdGhlIGZpcnN0IHJl c3BvbmRlciBhZ2Fpbi4gVGhpcyBpcyBwcm9ibGVtYXRpYyB3aGVuIGEgdGV4dCBmaWVsZCBvciBh IGVkaXRpbmcgaG9zdCBlbGVtZW50IGhhZCBiZWVuCisgICAgICAgIGZvY3VzZWQgYW5kIHNlbGVj dGVkIHByaW9yIHRvIHRoZSByZXNpZ25hdGlvbiBzaW5jZSB0aGUgZWRpdGluZyBjb2RlIHVzZXMg dGhlIHNlbGVjdGlvbiB0byBkZXRlcm1pbmUKKyAgICAgICAgdGhlIGVkaXRhYmlsaXR5IG9mIHRo ZSBlbGVtZW50LgorCisgICAgICAgIEZpeGVkIHRoZSBidWcgYnkgcmVzdG9yaW5nIHNlbGVjdGlv biBpbiBbV0tWaWV3IGJlY29tZUZpcnN0UmVzcG9uZGVyXSBpZiB0aGUgc2VsZWN0aW9uIGlzIGVt cHR5LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tOgorICAgICAgICAo LVtXS1ZpZXcgYmVjb21lRmlyc3RSZXNwb25kZXJdKToKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5Ojp1cGRhdGVGb2N1 c0FwcGVhcmFuY2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaDoKKyAgICAg ICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2U6OnVwZGF0ZUZvY3VzQXBwZWFyYW5jZSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL1dlYlBhZ2UuaDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNz YWdlcy5pbjoKKwogMjAxNS0wMy0yNSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CiAKICAgICAgICAgW1dLMl0gV2ViVXNlck1lZGlhQ2xpZW50OjpwYWdlRGVzdHJveWVkKCkg dmlydHVhbCBtZXRob2Qgc2hvdWxkIGJlIG1hcmtlZCBhcyBvdmVycmlkZQpJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDE4MTkyOCkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xNDQ0LDYgKzE0NDQsMTMgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmNsZWFyU2VsZWN0aW9u KCkKICAgICBtX3Byb2Nlc3MtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OkNsZWFyU2VsZWN0aW9u KCksIG1fcGFnZUlEKTsKIH0KIAordm9pZCBXZWJQYWdlUHJveHk6OnVwZGF0ZUZvY3VzQXBwZWFy YW5jZSgpCit7CisgICAgaWYgKCFpc1ZhbGlkKCkpCisgICAgICAgIHJldHVybjsKKyAgICBtX3By b2Nlc3MtPnNlbmQoTWVzc2FnZXM6OldlYlBhZ2U6OlVwZGF0ZUZvY3VzQXBwZWFyYW5jZSgpLCBt X3BhZ2VJRCk7Cit9CisKIHZvaWQgV2ViUGFnZVByb3h5Ojp2YWxpZGF0ZUNvbW1hbmQoY29uc3Qg U3RyaW5nJiBjb21tYW5kTmFtZSwgc3RkOjpmdW5jdGlvbjx2b2lkIChjb25zdCBTdHJpbmcmLCBi b29sLCBpbnQzMl90LCBDYWxsYmFja0Jhc2U6OkVycm9yKT4gY2FsbGJhY2tGdW5jdGlvbikKIHsK ICAgICBpZiAoIWlzVmFsaWQoKSkgewpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dl YlBhZ2VQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuaAkocmV2aXNpb24gMTgxOTI4KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOTMsNiArMzkzLDcgQEAgcHVibGlj OgogICAgIHZvaWQgc2V0V2luZG93UmVzaXplclNpemUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYp OwogICAgIAogICAgIHZvaWQgY2xlYXJTZWxlY3Rpb24oKTsKKyAgICB2b2lkIHVwZGF0ZUZvY3Vz QXBwZWFyYW5jZSgpOwogCiAgICAgdm9pZCBzZXRWaWV3TmVlZHNEaXNwbGF5KGNvbnN0IFdlYkNv cmU6OkludFJlY3QmKTsKICAgICB2b2lkIGRpc3BsYXlWaWV3KCk7CkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9tYWMvV0tWaWV3Lm1tCShyZXZpc2lvbiAxODE5MjgpCisrKyBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL21hYy9XS1ZpZXcubW0JKHdvcmtpbmcgY29weSkK QEAgLTQ0Nyw2ICs0NDcsOCBAQCAtIChCT09MKWJlY29tZUZpcnN0UmVzcG9uZGVyCiAgICAgCiAg ICAgW3NlbGYgX3VwZGF0ZVNlY3VyZUlucHV0U3RhdGVdOwogICAgIF9kYXRhLT5fcGFnZS0+dmll d1N0YXRlRGlkQ2hhbmdlKFZpZXdTdGF0ZTo6SXNGb2N1c2VkKTsKKyAgICAvLyBSZXN0b3JlIHRo ZSBzZWxlY3Rpb24gaW4gdGhlIGVkaXRhYmxlIHJlZ2lvbiBpZiByZXNpZ25pbmcgZmlyc3QgcmVz cG9uZGVyIGNsZWFyZWQgc2VsZWN0aW9uLgorICAgIF9kYXRhLT5fcGFnZS0+dXBkYXRlRm9jdXNB cHBlYXJhbmNlKCk7CiAKICAgICBfZGF0YS0+X2luQmVjb21lRmlyc3RSZXNwb25kZXIgPSBmYWxz ZTsKICAgICAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAJKHJldmlzaW9uIDE4MTkyOCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9XZWJQYWdlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzM2NCw2ICszMzY0LDE4IEBA IHZvaWQgV2ViUGFnZTo6Y2xlYXJTZWxlY3Rpb24oKQogfQogI2VuZGlmCiAKK3ZvaWQgV2ViUGFn ZTo6dXBkYXRlRm9jdXNBcHBlYXJhbmNlKCkKK3sKKyAgICBGcmFtZSYgZnJhbWUgPSBtX3BhZ2Ut PmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOworICAgIGlmICghZnJhbWUu c2VsZWN0aW9uKCkuaXNOb25lKCkpCisgICAgICAgIHJldHVybjsKKworICAgIGlmIChhdXRvIGRv Y3VtZW50ID0gZnJhbWUuZG9jdW1lbnQoKSkgeworICAgICAgICBpZiAoYXV0byBlbGVtZW50ID0g ZG9jdW1lbnQtPmZvY3VzZWRFbGVtZW50KCkpCisgICAgICAgICAgICBlbGVtZW50LT51cGRhdGVG b2N1c0FwcGVhcmFuY2UodHJ1ZSk7CisgICAgfQorfQorCiBib29sIFdlYlBhZ2U6Om1haW5GcmFt ZUhhc0N1c3RvbUNvbnRlbnRQcm92aWRlcigpIGNvbnN0CiB7CiAgICAgaWYgKEZyYW1lKiBmcmFt ZSA9IG1haW5GcmFtZSgpKSB7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmgJKHJldmlzaW9uIDE4MTkyOCkKKysrIFNvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4Myw2ICs2ODMsNyBA QCBwdWJsaWM6CiAKICAgICB2b2lkIHJlcGxhY2VTZWxlY3Rpb25XaXRoVGV4dChXZWJDb3JlOjpG cmFtZSosIGNvbnN0IFN0cmluZyYpOwogICAgIHZvaWQgY2xlYXJTZWxlY3Rpb24oKTsKKyAgICB2 b2lkIHVwZGF0ZUZvY3VzQXBwZWFyYW5jZSgpOwogCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkK ICNpZiBQTEFURk9STShHVEspCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5tZXNzYWdlcy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5tZXNzYWdlcy5pbgkocmV2aXNpb24gMTgxOTI4KQorKysg U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UubWVzc2FnZXMuaW4JKHdv cmtpbmcgY29weSkKQEAgLTE0Myw2ICsxNDMsNyBAQCBtZXNzYWdlcyAtPiBXZWJQYWdlIExlZ2Fj eVJlY2VpdmVyIHsKICAgICBEaWRSZWNlaXZlUG9saWN5RGVjaXNpb24odWludDY0X3QgZnJhbWVJ RCwgdWludDY0X3QgbGlzdGVuZXJJRCwgdWludDMyX3QgcG9saWN5QWN0aW9uLCB1aW50NjRfdCBu YXZpZ2F0aW9uSUQsIHVpbnQ2NF90IGRvd25sb2FkSUQpCiAKICAgICBDbGVhclNlbGVjdGlvbigp CisgICAgVXBkYXRlRm9jdXNBcHBlYXJhbmNlKCkKIAogICAgICMgQ2FsbGJhY2tzLgogICAgIEdl dENvbnRlbnRzQXNTdHJpbmcodWludDY0X3QgY2FsbGJhY2tJRCkK