126796 2014-01-10 17:16:56 -0800 [iOS] Fix PlatformScreenIOS.mm for iOS 2014-01-10 17:34:04 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned joepeck simon.fraser oldest_to_newest 966701 0 joepeck 2014-01-10 17:16:56 -0800 Build errors: Source/WebCore/platform/ios/PlatformScreenIOS.mm:39:5: error: no previous prototype for function 'screenHorizontalDPI' [-Werror,-Wmissing-prototypes] int screenHorizontalDPI(Widget*) Source/WebCore/platform/ios/PlatformScreenIOS.mm:45:5: error: no previous prototype for function 'screenVerticalDPI' [-Werror,-Wmissing-prototypes] int screenVerticalDPI(Widget*) 966703 1 220909 joepeck 2014-01-10 17:18:39 -0800 Created attachment 220909 [PATCH] Proposed Fix 966704 2 220909 joepeck 2014-01-10 17:20:50 -0800 Comment on attachment 220909 [PATCH] Proposed Fix Ahh, we are just landing build fixes unreviewed. Closing out this bug! 966711 3 joepeck 2014-01-10 17:34:04 -0800 This landed as. <http://trac.webkit.org/changeset/161704> 220909 2014-01-10 17:18:39 -0800 2014-01-10 17:20:49 -0800 [PATCH] Proposed Fix platform.patch text/plain 2000 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NmY1ODQ5Li5iNWEwYTdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcg QEAKIDIwMTQtMDEtMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBbaU9TXSBGaXggUGxhdGZvcm1TY3JlZW5JT1MubW0gZm9yIGlPUworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2Nzk2CisKKyAgICAgICAg UGxhdGZvcm1TY3JlZW4uaCByZW1vdmVkIHNjcmVlblZlcnRpY2FsRFBJIGFuZCBzY3JlZW5Ib3Jp em9udGFsRFBJIGluIHIxMzI0MTksCisgICAgICAgIHNvIHJlbW92ZSB0aGUgc3RhbGUgaW1wbGVt ZW50YXRpb25zIG9uIGlPUy4gQWxzbywgYWRkIGEgbm90SW1wbGVtZW50ZWQgdmVyc2lvbgorICAg ICAgICBvZiBzY3JlZW5Db2xvclByb2ZpbGUsIHdoaWNoIG1hdGNoZXMgTWFjIGFuZCBpcyB1bnVz ZWQgaW4gV2ViQ29yZSBmb3IgdGhpcyBwb3J0LgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1Bs YXRmb3JtU2NyZWVuSU9TLm1tOgorICAgICAgICAoV2ViQ29yZTo6c2NyZWVuQ29sb3JQcm9maWxl KToKKworMjAxNC0wMS0xMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgor CiAgICAgICAgIFVucmV2aWV3ZWQgRUZMIGJ1aWxkIGZpeCBhZnRlciByMTYxNjc4LgogCiAgICAg ICAgIHN0YXRpY19jYXN0IGEgc2l6ZV90IHRvIHVuc2lnbmVkIGxvbmcgZm9yICVsdSBmb3JtYXQg c3RyaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRmb3Jt U2NyZWVuSU9TLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRmb3JtU2NyZWVu SU9TLm1tCmluZGV4IDJiZjIyMTAuLjI4NTcwNGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2lvcy9QbGF0Zm9ybVNjcmVlbklPUy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9pb3MvUGxhdGZvcm1TY3JlZW5JT1MubW0KQEAgLTM2LDE4ICszNiw2IEBACiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAotaW50IHNjcmVlbkhvcml6b250YWxEUEkoV2lkZ2V0KikKLXsK LSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiAwOwotfQotCi1pbnQgc2NyZWVuVmVy dGljYWxEUEkoV2lkZ2V0KikKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiAw OwotfQotCiBpbnQgc2NyZWVuRGVwdGgoV2lkZ2V0KikKIHsKICAgICAvLyBBc3N1bWUgMzIgYml0 cyBwZXIgcGl4ZWwuIFNlZSA8cmRhcjovL3Byb2JsZW0vOTM3ODgyOT4uCkBAIC02NSw3ICs1Myw3 IEBAIGJvb2wgc2NyZWVuSXNNb25vY2hyb21lKFdpZGdldCopCiAgICAgcmV0dXJuIGZhbHNlOwog fQogCi0vLyBUaGVzZSBmdW5jdGlvbnMgc2NhbGUgYmV0d2VlbiBzY3JlZW4gYW5kIHBhZ2UgY29v cmRpbmF0ZXMgYmVjYXVzZSBKYXZhU2NyaXB0L0RPTSBvcGVyYXRpb25zIAorLy8gVGhlc2UgZnVu Y3Rpb25zIHNjYWxlIGJldHdlZW4gc2NyZWVuIGFuZCBwYWdlIGNvb3JkaW5hdGVzIGJlY2F1c2Ug SmF2YVNjcmlwdC9ET00gb3BlcmF0aW9ucwogLy8gYXNzdW1lIHRoYXQgdGhlIHNjcmVlbiBhbmQg dGhlIHBhZ2Ugc2hhcmUgdGhlIHNhbWUgY29vcmRpbmF0ZSBzeXN0ZW0uCiBGbG9hdFJlY3Qgc2Ny ZWVuUmVjdChXaWRnZXQqIHdpZGdldCkKIHsKQEAgLTg5LDQgKzc3LDkgQEAgRmxvYXRSZWN0IHNj cmVlbkF2YWlsYWJsZVJlY3QoV2lkZ2V0KiB3aWRnZXQpCiAgICAgcmV0dXJuIGVuY2xvc2luZ0lu dFJlY3Qoc2NyZWVuUmVjdCk7CiB9CiAKK3ZvaWQgc2NyZWVuQ29sb3JQcm9maWxlKENvbG9yUHJv ZmlsZSYpCit7CisgICAgbm90SW1wbGVtZW50ZWQoKTsKK30KKwogfSAvLyBuYW1lc3BhY2UgV2Vi Q29yZQo=