126779 2014-01-10 13:45:12 -0800 FreeBSD build fixes 2014-02-14 13:51:11 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128598 1 kwm webkit-unassigned ajacoutot andersca commit-queue dbates landry sam oldest_to_newest 966566 0 kwm 2014-01-10 13:45:12 -0800 Add sys/wait.h for WIFEXITED and WEXITSTATUS defines. FreeBSD doesn't have SIGCLD, wrap the code in #if defined(SIGCLD). 966567 1 220882 kwm 2014-01-10 13:45:58 -0800 Created attachment 220882 build fixes 968401 2 220882 kwm 2014-01-15 10:53:20 -0800 Comment on attachment 220882 build fixes set review flag 968417 3 220882 sergio 2014-01-15 11:49:58 -0800 Comment on attachment 220882 build fixes View in context: https://bugs.webkit.org/attachment.cgi?id=220882&action=review > ChangeLog:10 > + I believe you shouldn't update this file, only the one in Source/WebKit2/Changelog. 969429 4 221543 kwm 2014-01-18 06:42:38 -0800 Created attachment 221543 Build fixes for FreeBSD Same patch as before but used Tools/Scripts/prepare-ChangeLog to generate the Changelog. 970648 5 221543 commit-queue 2014-01-22 03:11:03 -0800 Comment on attachment 221543 Build fixes for FreeBSD Clearing flags on attachment: 221543 Committed r162513: <http://trac.webkit.org/changeset/162513> 970649 6 commit-queue 2014-01-22 03:11:05 -0800 All reviewed patches have been landed. Closing bug. 972543 7 ajacoutot 2014-01-27 13:42:31 -0800 Hi. I don't understand this patch. Isn't SIGCLD the same as SIGCHLD? If so then why not s/SIGCLD/SIGCHLD which will work everywhere. That is what we've been using on OpenBSD. Unless I am missing something obvious... 980955 8 landry 2014-02-14 13:51:11 -0800 (In reply to comment #7) > Hi. > > I don't understand this patch. Isn't SIGCLD the same as SIGCHLD? > If so then why not s/SIGCLD/SIGCHLD which will work everywhere. That is what we've been using on OpenBSD. > Unless I am missing something obvious... Yes... Koop, can you elaborate on why #if'ing out those parts ? We've used this for 2.2: http://www.openbsd.org/cgi-bin/cvsweb/ports/www/webkit/patches/patch-Source_WebKit2_UIProcess_Plugins_unix_PluginProcessProxyUnix_cpp?rev=1.4;content-type=text%2Fplain 220882 2014-01-10 13:45:58 -0800 2014-01-18 06:42:38 -0800 build fixes Source_WebKit2_UIProcess_Plugins_unix_PluginProcessProxyUnix.cpp.diff text/plain 2292 kwm SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTY1 OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAx LTEwICBLb29wIE1hc3QgPGt3bUBGcmVlQlNELm9yZz4KKworICAgICAgICBCdWlsZCBmaXhlcyBm b3IgRnJlZUJTRC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNjc3OQorCisgICAgICAgIEFkZCBzeXMvd2FpdC5oIGZvciBXSUZFWElURUQgYW5kIFdF WElUU1RBVFVTIGRlZmluZXMuCisgICAgICAgIEZyZWVCU0QgZG9lc24ndCBoYXZlIFNJR0NMRCwg d3JhcCB0aGUgY29kZSBpbiAjaWYgZGVmaW5lZChTSUdDTEQpLgorCisgICAgICAgICogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNw cDoKKwogMjAxNC0wMS0wOSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4K IAogICAgICAgICBSZW1vdmUgdGhlIEJsYWNrQmVycnkgZmlsZXMgb3V0c2lkZSBXZWJDb3JlCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjE2NTkpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0wMS0xMCAgS29vcCBNYXN0 IDxrd21ARnJlZUJTRC5vcmc+CisKKyAgICAgICAgQnVpbGQgZml4ZXMgZm9yIEZyZWVCU0QuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY3NzkKKwor ICAgICAgICBBZGQgc3lzL3dhaXQuaCBmb3IgV0lGRVhJVEVEIGFuZCBXRVhJVFNUQVRVUyBkZWZp bmVzLgorICAgICAgICBGcmVlQlNEIGRvZXNuJ3QgaGF2ZSBTSUdDTEQsIHdyYXAgdGhlIGNvZGUg aW4gI2lmIGRlZmluZWQoU0lHQ0xEKS4KKworICAgICAgICAqIFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHA6CisKIDIwMTQtMDEt MTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IEltcGxlbWVudCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnJlY2VpdmVkQ2FuY2VsbGF0aW9uCklu ZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpblByb2Nlc3NQ cm94eVVuaXguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVn aW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAJKHJldmlzaW9uIDE2MTY1OSkKKysr IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5 VW5peC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDYgKzQwLDggQEAKICNpbmNsdWRlIDx3dGYv Z29iamVjdC9HT3duUHRyLmg+CiAjZW5kaWYKIAorI2luY2x1ZGUgPHN5cy93YWl0Lmg+CisKIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKQEAgLTc5LDYgKzgx LDcgQEAKICAgICAvLyBhYmxlIHRvIHJldHVybiB0aGUgc3RhdHVzLgogICAgIC8vIEFzIGEgY29u c2VxdWVuY2UsIHdlIG1ha2Ugc3VyZSB0aGF0IHRoZSBkaXNwb3NpdGlvbiBpcyBzZXQgdG8KICAg ICAvLyBTSUdfREZMIGJlZm9yZSBjYWxsaW5nIGdfc3Bhd25fc3luYygpLgorI2lmIGRlZmluZWQo U0lHQ0xEKQogICAgIHN0cnVjdCBzaWdhY3Rpb24gYWN0aW9uOwogICAgIHNpZ2FjdGlvbihTSUdD TEQsIDAsICZhY3Rpb24pOwogICAgIGlmIChhY3Rpb24uc2FfaGFuZGxlciA9PSBTSUdfSUdOKSB7 CkBAIC04NSw2ICs4OCw3IEBACiAgICAgICAgIGFjdGlvbi5zYV9oYW5kbGVyID0gU0lHX0RGTDsK ICAgICAgICAgc2lnYWN0aW9uKFNJR0NMRCwgJmFjdGlvbiwgMCk7CiAgICAgfQorI2VuZGlmCiAK ICAgICBpZiAoIWdfc3Bhd25fc3luYygwLCBhcmd2LCAwLCBHX1NQQVdOX1NUREVSUl9UT19ERVZf TlVMTCwgMCwgMCwgJnN0ZE91dC5vdXRQdHIoKSwgMCwgJnN0YXR1cywgMCkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsK 221543 2014-01-18 06:42:38 -0800 2014-01-22 03:11:02 -0800 Build fixes for FreeBSD Source_WebKit2_UIProcess_Plugins_unix_PluginProcessProxyUnix.cpp.diff text/plain 1589 kwm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjI1MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTE4ICBLb29wIE1h c3QgPGt3bUBGcmVlQlNELm9yZz4KKworICAgICAgICBCdWlsZCBmaXhlcyBmb3IgRnJlZUJTRC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjc3OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcDoKKyAgICAgICAgKFdl YktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpzY2FuUGx1Z2luKToKKwogMjAxNC0wMS0xNyAgQ29t bWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjE2MjIzNyBhbmQgcjE2MjI0MS4KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luUHJvY2Vzc1Byb3h5VW5peC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9j ZXNzUHJveHlVbml4LmNwcAkocmV2aXNpb24gMTYyMjUwKQorKysgU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL1BsdWdpbnMvdW5peC9QbHVnaW5Qcm9jZXNzUHJveHlVbml4LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNDAsNiArNDAsOCBAQAogI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dPd25QdHIuaD4K ICNlbmRpZgogCisjaW5jbHVkZSA8c3lzL3dhaXQuaD4KKwogdXNpbmcgbmFtZXNwYWNlIFdlYkNv cmU7CiAKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtNzksNiArODEsNyBAQAogICAgIC8vIGFibGUg dG8gcmV0dXJuIHRoZSBzdGF0dXMuCiAgICAgLy8gQXMgYSBjb25zZXF1ZW5jZSwgd2UgbWFrZSBz dXJlIHRoYXQgdGhlIGRpc3Bvc2l0aW9uIGlzIHNldCB0bwogICAgIC8vIFNJR19ERkwgYmVmb3Jl IGNhbGxpbmcgZ19zcGF3bl9zeW5jKCkuCisjaWYgZGVmaW5lZChTSUdDTEQpCiAgICAgc3RydWN0 IHNpZ2FjdGlvbiBhY3Rpb247CiAgICAgc2lnYWN0aW9uKFNJR0NMRCwgMCwgJmFjdGlvbik7CiAg ICAgaWYgKGFjdGlvbi5zYV9oYW5kbGVyID09IFNJR19JR04pIHsKQEAgLTg1LDYgKzg4LDcgQEAK ICAgICAgICAgYWN0aW9uLnNhX2hhbmRsZXIgPSBTSUdfREZMOwogICAgICAgICBzaWdhY3Rpb24o U0lHQ0xELCAmYWN0aW9uLCAwKTsKICAgICB9CisjZW5kaWYKIAogICAgIGlmICghZ19zcGF3bl9z eW5jKDAsIGFyZ3YsIDAsIEdfU1BBV05fU1RERVJSX1RPX0RFVl9OVUxMLCAwLCAwLCAmc3RkT3V0 Lm91dFB0cigpLCAwLCAmc3RhdHVzLCAwKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=