<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126774</bug_id>
          
          <creation_ts>2014-01-10 13:10:03 -0800</creation_ts>
          <short_desc>Remove unused error.h header.</short_desc>
          <delta_ts>2014-02-24 07:00:59 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>128598</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Koop Mast">kwm</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>berto</cc>
    
    <cc>landry</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>966535</commentid>
    <comment_count>0</comment_count>
    <who name="Koop Mast">kwm</who>
    <bug_when>2014-01-10 13:10:03 -0800</bug_when>
    <thetext>This header doesn&apos;t exists on FreeBSD.

According to https://www.gnu.org/software/gnulib/manual/html_node/error_002eh.html the function that this header implements are not present in the file. So there isn&apos;t any need for this header.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966538</commentid>
    <comment_count>1</comment_count>
      <attachid>220879</attachid>
    <who name="Koop Mast">kwm</who>
    <bug_when>2014-01-10 13:12:02 -0800</bug_when>
    <thetext>Created attachment 220879
Remove unused error.h header</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>968402</commentid>
    <comment_count>2</comment_count>
      <attachid>220879</attachid>
    <who name="Koop Mast">kwm</who>
    <bug_when>2014-01-15 10:54:10 -0800</bug_when>
    <thetext>Comment on attachment 220879
Remove unused error.h header

set review flag</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>981583</commentid>
    <comment_count>3</comment_count>
    <who name="Landry Breuil">landry</who>
    <bug_when>2014-02-17 11:41:15 -0800</bug_when>
    <thetext>Fwiw i have the same issue on OpenBSD when trying to update our webkit from 2.2.4 to 2.3.5 - removing the inclusion of error.h fixes the build breakage.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>983888</commentid>
    <comment_count>4</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-02-24 07:00:59 -0800</bug_when>
    <thetext>Committed r164583: &lt;http://trac.webkit.org/changeset/164583&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220879</attachid>
            <date>2014-01-10 13:12:02 -0800</date>
            <delta_ts>2014-01-16 13:22:04 -0800</delta_ts>
            <desc>Remove unused error.h header</desc>
            <filename>Source_WebKit2_NetworkProcess_unix_NetworkProcessMainUnix.cpp.diff</filename>
            <type>text/plain</type>
            <size>2082</size>
            <attacher name="Koop Mast">kwm</attacher>
            
              <data encoding="base64">SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTY1
OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAx
LTEwICBLb29wIE1hc3QgPGt3bUBGcmVlQlNELm9yZz4KKworICAgICAgICBSZW1vdmUgdW51c2Vk
IGVycm9yLmggaGVhZGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MTI2Nzc0CisKKyAgICAgICAgVGhpcyBoZWFkZXIgZG9lc24ndCBleGlzdHMgb24g
RnJlZUJTRC4gQWNjb3JkaW5nIHRvCisgICAgICAgIGh0dHBzOi8vd3d3LmdudS5vcmcvc29mdHdh
cmUvZ251bGliL21hbnVhbC9odG1sX25vZGUvZXJyb3JfMDAyZWguaHRtbAorICAgICAgICB0aGUg
ZnVuY3Rpb24gdGhhdCB0aGlzIGhlYWRlciBpbXBsZW1lbnRzIGFyZSBub3QgcHJlc2VudCBpbiB0
aGUgZmlsZS4KKyAgICAgICAgU28gdGhlcmUgaXNuJ3QgYW55IG5lZWQgZm9yIHRoaXMgaGVhZGVy
LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvdW5peC9OZXR3b3JrUHJvY2Vzc01haW5Vbml4
LmNwcDoKKwogMjAxNC0wMS0wOSAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNv
bT4KIAogICAgICAgICBSZW1vdmUgdGhlIEJsYWNrQmVycnkgZmlsZXMgb3V0c2lkZSBXZWJDb3Jl
CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl
YktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjE2NTkpCisrKyBTb3VyY2UvV2ViS2l0Mi9DaGFu
Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNC0wMS0xMCAgS29vcCBN
YXN0IDxrd21ARnJlZUJTRC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBlcnJvci5oIGhl
YWRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy
Njc3NAorCisgICAgICAgIFRoaXMgaGVhZGVyIGRvZXNuJ3QgZXhpc3RzIG9uIEZyZWVCU0QuIEFj
Y29yZGluZyB0byAKKyAgICAgICAgaHR0cHM6Ly93d3cuZ251Lm9yZy9zb2Z0d2FyZS9nbnVsaWIv
bWFudWFsL2h0bWxfbm9kZS9lcnJvcl8wMDJlaC5odG1sCisgICAgICAgIHRoZSBmdW5jdGlvbiB0
aGF0IHRoaXMgaGVhZGVyIGltcGxlbWVudHMgYXJlIG5vdCBwcmVzZW50IGluIHRoZSBmaWxlLgor
ICAgICAgICBTbyB0aGVyZSBpc24ndCBhbnkgbmVlZCBmb3IgdGhpcyBoZWFkZXIuCisKKyAgICAg
ICAgKiBOZXR3b3JrUHJvY2Vzcy91bml4L05ldHdvcmtQcm9jZXNzTWFpblVuaXguY3BwOgorCiAy
MDE0LTAxLTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog
ICAgICAgICBJbXBsZW1lbnQgTmV0d29ya1Jlc291cmNlTG9hZGVyOjpyZWNlaXZlZENhbmNlbGxh
dGlvbgpJbmRleDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvdW5peC9OZXR3b3JrUHJv
Y2Vzc01haW5Vbml4LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv
Y2Vzcy91bml4L05ldHdvcmtQcm9jZXNzTWFpblVuaXguY3BwCShyZXZpc2lvbiAxNjE2NTkpCisr
KyBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy91bml4L05ldHdvcmtQcm9jZXNzTWFpblVu
aXguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw3ICszNCw2IEBACiAjaW5jbHVkZSAiV2ViS2l0
MkluaXRpYWxpemUuaCIKICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlSGFuZGxlLmg+CiAjaW5j
bHVkZSA8V2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy5oPgotI2luY2x1ZGUgPGVycm9yLmg+CiAjaW5j
bHVkZSA8cnVudGltZS9Jbml0aWFsaXplVGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8c3RkbGliLmg+
CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4K
</data>
<flag name="review"
          id="245167"
          type_id="1"
          status="+"
          setter="andersca"
    />
          </attachment>
      

    </bug>

</bugzilla>