126773 2014-01-10 12:32:06 -0800 make make_names.pl default to default system compiler 2014-02-11 06:20:31 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Other RESOLVED FIXED P2 Normal --- 128598 1 kwm webkit-unassigned commit-queue esprehn+autocc kangil.han ossy oldest_to_newest 966515 0 kwm 2014-01-10 12:32:06 -0800 As I understand it cc and c++ are the default C and C++ system compilers. So as the final fall though the script should use them instead of hoping gcc might be installed. This was found because on FreeBSD 10 we don't have gcc anymore in base on the x86* archs. 966516 1 220877 kwm 2014-01-10 12:34:18 -0800 Created attachment 220877 Switch to system default compiler 967257 2 ossy 2014-01-13 05:26:05 -0800 Please set r? flag if you would like to ask for review. 967378 3 220877 ap 2014-01-13 10:01:50 -0800 Comment on attachment 220877 Switch to system default compiler View in context: https://bugs.webkit.org/attachment.cgi?id=220877&action=review > ChangeLog:4 > + Use system default compiler instead of gcc, as final fall through. > + https://bugs.webkit.org/show_bug.cgi?id=126773 Please revert this change to root ChangeLog, updating Source/WebCore/ChangeLog is sufficient. 968384 4 221281 kwm 2014-01-15 10:11:41 -0800 Created attachment 221281 Drop root changelog entry, set review flag Is there a general rule for when to update the root Changelog or not? 968385 5 ossy 2014-01-15 10:14:43 -0800 > Is there a general rule for when to update the root Changelog or not? yes, when Tools/Scripts/prepare-ChangeLog automatically does it ;) 968481 6 221281 ap 2014-01-15 14:58:40 -0800 Comment on attachment 221281 Drop root changelog entry, set review flag View in context: https://bugs.webkit.org/attachment.cgi?id=221281&action=review > Source/WebCore/dom/make_names.pl:73 > + $gccLocation = "/usr/bin/cc"; Should rename the variable one day. 977356 7 221281 commit-queue 2014-02-06 08:40:15 -0800 Comment on attachment 221281 Drop root changelog entry, set review flag Clearing flags on attachment: 221281 Committed r163534: <http://trac.webkit.org/changeset/163534> 977357 8 commit-queue 2014-02-06 08:40:18 -0800 All reviewed patches have been landed. Closing bug. 220877 2014-01-10 12:34:18 -0800 2014-01-15 10:11:41 -0800 Switch to system default compiler Source_WebCore_dom_make-names.pl.diff text/plain 1597 kwm SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTY1 OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAx LTEwICBLb29wIE1hc3QgPGt3bUBGcmVlQlNELm9yZz4KKworICAgICAgICBVc2Ugc3lzdGVtIGRl ZmF1bHQgY29tcGlsZXIgaW5zdGVhZCBvZiBnY2MsIGFzIGZpbmFsIGZhbGwgdGhyb3VnaC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjc3MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlcy9X ZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsOgorCiAyMDE0LTAxLTA5ICBCZW5qYW1pbiBQb3VsYWlu ICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB0aGUgQmxhY2tCZXJyeSBm aWxlcyBvdXRzaWRlIFdlYkNvcmUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTY1OSkKKysr IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA CisyMDE0LTAxLTEwICBLb29wIE1hc3QgPGt3bUBGcmVlQlNELm9yZz4KKworICAgICAgICBVc2Ug c3lzdGVtIGRlZmF1bHQgY29tcGlsZXIgaW5zdGVhZCBvZiBnY2MsIGFzIGZpbmFsIGZhbGwgdGhy b3VnaC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy Njc3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog ZG9tL21ha2VfbmFtZXMucGw6CisKIDIwMTQtMDEtMDkgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBw bGUuY29tPgogCiAgICAgICAgIFtpT1NdIFVwc3RyZWFtIGlPUyBjaGFuZ2VzIHRvIE1pZ3JhdGVI ZWFkZXJzLm1ha2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9tYWtlX25hbWVzLnBsCShyZXZpc2lvbiAxNjE2 NTkpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAkod29ya2luZyBjb3B5KQpA QCAtNzAsNyArNzAsNyBAQAogfSBlbHNpZiAoJENvbmZpZzo6Q29uZmlneyJvc25hbWUifSBlcSAi ZGFyd2luIiAmJiAkRU5We1NES1JPT1R9KSB7CiAgICAgY2hvbXAoJGdjY0xvY2F0aW9uID0gYHhj cnVuIC1maW5kIGNjIC1zZGsgJyRFTlZ7U0RLUk9PVH0nYCk7CiB9IGVsc2UgewotICAgICRnY2NM b2NhdGlvbiA9ICIvdXNyL2Jpbi9nY2MiOworICAgICRnY2NMb2NhdGlvbiA9ICIvdXNyL2Jpbi9j YyI7CiB9CiBteSAkcHJlcHJvY2Vzc29yID0gJGdjY0xvY2F0aW9uIC4gIiAtRSAteCBjKysiOwog Cg== 221281 2014-01-15 10:11:41 -0800 2014-02-06 08:40:15 -0800 Drop root changelog entry, set review flag Source_WebCore_dom_make-names.pl.diff text/plain 1059 kwm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE2MjA3NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAxLTE1ICBLb29wIE1h c3QgPGt3bUBGcmVlQlNELm9yZz4KKworICAgICAgICBVc2Ugc3lzdGVtIGRlZmF1bHQgY29tcGls ZXIgaW5zdGVhZCBvZiBnY2MsIGFzIGZpbmFsIGZhbGwgdGhyb3VnaC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjc3MworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL21ha2VfbmFtZXMucGw6CisK IDIwMTQtMDEtMTUgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgV29yZE1lYXN1cmVtZW50IGlzIGEgc3RydWN0LCBub3QgYSBjbGFzcwpJbmRleDogU291cmNl L1dlYkNvcmUvZG9tL21ha2VfbmFtZXMucGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv ZG9tL21ha2VfbmFtZXMucGwJKHJldmlzaW9uIDE2MjA3NykKKysrIFNvdXJjZS9XZWJDb3JlL2Rv bS9tYWtlX25hbWVzLnBsCSh3b3JraW5nIGNvcHkpCkBAIC03MCw3ICs3MCw3IEBACiB9IGVsc2lm ICgkQ29uZmlnOjpDb25maWd7Im9zbmFtZSJ9IGVxICJkYXJ3aW4iICYmICRFTlZ7U0RLUk9PVH0p IHsKICAgICBjaG9tcCgkZ2NjTG9jYXRpb24gPSBgeGNydW4gLWZpbmQgY2MgLXNkayAnJEVOVntT REtST09UfSdgKTsKIH0gZWxzZSB7Ci0gICAgJGdjY0xvY2F0aW9uID0gIi91c3IvYmluL2djYyI7 CisgICAgJGdjY0xvY2F0aW9uID0gIi91c3IvYmluL2NjIjsKIH0KIG15ICRwcmVwcm9jZXNzb3Ig PSAkZ2NjTG9jYXRpb24gLiAiIC1FIC14IGMrKyI7CiAK