<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126771</bug_id>
          
          <creation_ts>2014-01-10 12:18:05 -0800</creation_ts>
          <short_desc>Web Inspector: use c++11 features in web-only agents</short_desc>
          <delta_ts>2014-08-01 14:19:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Blaze Burg">bburg</reporter>
          <assigned_to name="Joseph Pecoraro">joepeck</assigned_to>
          <cc>joepeck</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>966502</commentid>
    <comment_count>0</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2014-01-10 12:18:05 -0800</bug_when>
    <thetext>This has been annoying me. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966506</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2014-01-10 12:22:42 -0800</bug_when>
    <thetext>&lt;rdar://problem/15794772&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966514</commentid>
    <comment_count>2</comment_count>
    <who name="Timothy Hatcher">timothy</who>
    <bug_when>2014-01-10 12:30:07 -0800</bug_when>
    <thetext>Joe fixed InspectorAgent in bug 126763 when he moved it to JSC. No need to do that one, you will just conflict.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966541</commentid>
    <comment_count>3</comment_count>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2014-01-10 13:15:10 -0800</bug_when>
    <thetext>Joe is handling this when moving stuff around to JSC.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966542</commentid>
    <comment_count>4</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-01-10 13:17:42 -0800</bug_when>
    <thetext>Yes, as I&apos;ve been moving code down into JSC I&apos;ve been making it sparkle. So nullptr, unique_ptr, some references, better whitespace, etc.

There is plenty of code that code be updated in WebCore though. InstrumentingAgents, any WebCore agent (so not Runtime/Debugger). I&apos;ll happily review a patch making these changes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966545</commentid>
    <comment_count>5</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-01-10 13:18:28 -0800</bug_when>
    <thetext>Another big one that is annoying me: OVERRIDE, FINAL</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966593</commentid>
    <comment_count>6</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-01-10 14:20:07 -0800</bug_when>
    <thetext>Another big one that is annoying me: ASCIILiteral</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>969334</commentid>
    <comment_count>7</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-01-17 17:14:25 -0800</bug_when>
    <thetext>With Anders help I was about to get clang-modernize working. With that we can automate adding &quot;override&quot; where it is needed and using &quot;nullptr&quot;.

It makes a bunch of changes:

    Transform: AddOverride - Accepted: 1488
    Transform: UseNullptr - Accepted: 267

Though I should first let Brian&apos;s more involved Reference change land first.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>969983</commentid>
    <comment_count>8</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-01-20 13:30:59 -0800</bug_when>
    <thetext>Fixed nullptr and override with:
&lt;https://webkit.org/b/127206&gt; Modernize WebCore/inspector with override
&lt;https://webkit.org/b/127303&gt; Modernize WebCore/inspector with nullptr</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1026333</commentid>
    <comment_count>9</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2014-08-01 14:19:38 -0700</bug_when>
    <thetext>Pretty sure this is fixed, right? nullptr, override, final, lots of unique_ptr. We can file new bugs about other things (ASCIILiteral, References).</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>