126765 2014-01-10 10:57:19 -0800 Web Inspector: Exception in WebInspector.Color trying to concat a function 2014-01-10 14:02:16 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 966461 0 timothy 2014-01-10 10:57:19 -0800 Viewing source with the token "constructor" will cause an exception in WebInspector.Color because ("constructor" in WebInspector.Color.Nicknames) will be true. 966462 1 webkit-bug-importer 2014-01-10 10:58:14 -0800 <rdar://problem/15793773> 966465 2 220863 timothy 2014-01-10 11:00:01 -0800 Created attachment 220863 Patch 966471 3 220863 joepeck 2014-01-10 11:10:14 -0800 Comment on attachment 220863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220863&action=review r=me > Source/WebInspectorUI/ChangeLog:10 > + (WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array. Typo: hasOwnPrperty 966574 4 220863 commit-queue 2014-01-10 14:02:13 -0800 Comment on attachment 220863 Patch Clearing flags on attachment: 220863 Committed r161674: <http://trac.webkit.org/changeset/161674> 966575 5 commit-queue 2014-01-10 14:02:16 -0800 All reviewed patches have been landed. Closing bug. 220863 2014-01-10 11:00:01 -0800 2014-01-10 14:02:13 -0800 Patch bug-126765-20140110110000.patch text/plain 2130 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 MTQ3ZGNhZmEyNmRjOGFkOGY4YTZmYjY2ZDhmNzdkZDk1ZmU2NjhjLi42YmIxZTc1NTM1MWVlMzJh ZWVjN2Q3MzI3YWEzM2M3ZTEyZmUzN2Y4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNC0wMS0xMCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgRml4IGFuIGV4Y2VwdGlvbiBpbiBXZWJJbnNwZWN0b3IuQ29sb3IuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjc2NQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9Db2xvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2xvci5mcm9tU3RyaW5n KTogQ2hlY2sgaGFzT3duUHJwZXJ0eSBiZWZvcmUgdXNpbmcgdGhlIG5pY2tuYW1lIGNvbG9yIGFy cmF5LgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbG9yLnByb3RvdHlwZS5fdG9OaWNrbmFtZVN0 cmluZyk6IERpdHRvLgorCiAyMDE0LTAxLTA4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFw cGxlLmNvbT4KIAogICAgICAgICBDb3JyZWN0bHkgdHJhY2sgdGltZSBib3VuZHMgb2YgV2ViSW5z cGVjdG9yLlRpbWVsaW5lIGFuZCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db2xvci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbG9yLmpzCmluZGV4IDEzZjMwYjg3 NzliNDJjNjNjOTYwYzU3NmZlZjczZTQxZmNiZjE2ZDMuLmVkZjVjZDA5MmUxZjYyMjE5Yzk3YjAz M2EzMTM2Mzc4OTA5MWVmYjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0NvbG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0NvbG9yLmpzCkBAIC05Myw3ICs5Myw3IEBAIFdlYkluc3BlY3Rvci5Db2xvci5mcm9tU3Ry aW5nID0gZnVuY3Rpb24oY29sb3JTdHJpbmcpCiAgICAgICAgICAgICBdKTsKICAgICAgICAgfSBl bHNlIGlmIChtYXRjaFszXSkgeyAvLyBuaWNrbmFtZQogICAgICAgICAgICAgdmFyIG5pY2tuYW1l ID0gbWF0Y2hbM10udG9Mb3dlckNhc2UoKTsKLSAgICAgICAgICAgIGlmIChuaWNrbmFtZSBpbiBX ZWJJbnNwZWN0b3IuQ29sb3IuTmlja25hbWVzKSB7CisgICAgICAgICAgICBpZiAoV2ViSW5zcGVj dG9yLkNvbG9yLk5pY2tuYW1lcy5oYXNPd25Qcm9wZXJ0eShuaWNrbmFtZSkpIHsKICAgICAgICAg ICAgICAgICB2YXIgY29sb3IgPSBuZXcgV2ViSW5zcGVjdG9yLkNvbG9yKFdlYkluc3BlY3Rvci5D b2xvci5Gb3JtYXQuTmlja25hbWUsIFdlYkluc3BlY3Rvci5Db2xvci5OaWNrbmFtZXNbbmlja25h bWVdLmNvbmNhdCgxKSk7CiAgICAgICAgICAgICAgICAgY29sb3Iubmlja25hbWUgPSBuaWNrbmFt ZTsKICAgICAgICAgICAgICAgICBjb2xvci5vcmlnaW5hbCA9IGNvbG9yU3RyaW5nOwpAQCAtMjc2 LDYgKzI3Niw5IEBAIFdlYkluc3BlY3Rvci5Db2xvci5wcm90b3R5cGUgPSB7CiAKICAgICAgICAg dmFyIG5pY2tuYW1lcyA9IFdlYkluc3BlY3Rvci5Db2xvci5OaWNrbmFtZXM7CiAgICAgICAgIGZv ciAodmFyIG5pY2tuYW1lIGluIG5pY2tuYW1lcykgeworICAgICAgICAgICAgaWYgKCFuaWNrbmFt ZXMuaGFzT3duUHJvcGVydHkobmlja25hbWUpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOwor CiAgICAgICAgICAgICB2YXIgbmlja25hbWVSR0IgPSBuaWNrbmFtZXNbbmlja25hbWVdOwogICAg ICAgICAgICAgaWYgKG5pY2tuYW1lUkdCWzBdID09PSByZ2JhWzBdICYmIG5pY2tuYW1lUkdCWzFd ID09PSByZ2JhWzFdICYmIG5pY2tuYW1lUkdCWzJdID09PSByZ2JhWzJdKQogICAgICAgICAgICAg ICAgIHJldHVybiBuaWNrbmFtZTsK