126760 2014-01-10 10:31:33 -0800 Web Inspector: Resource durations are sometimes years long 2014-01-10 13:27:46 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 966427 0 timothy 2014-01-10 10:31:33 -0800 Lets go back 2 years ago: http://trac.webkit.org/changeset/102961/trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp A chromium engineer changed InspectorInstrumentation::didFinishLoadingImpl to expect monotonic time instead of wall clock time. The argument was renamed to monotonicFinishTime. The header was never changed (still says finishTime instead of monotonicFinishTime) and neither was any other port changed to pass the new expected time format. Fast forward to today. Sigh. This causes end times to essentially double because convertMonotonicTimeToDocumentTime will add the finish time (wall clock time) to the document start time (also wall clock time), minus a reference monotonic time (a smaller number than wall clock time). Most call sites pass 0 for finishTime, so this just caused currentTime to be used later down the line. Thanks Google. 966428 1 webkit-bug-importer 2014-01-10 10:32:11 -0800 <rdar://problem/15793435> 966435 2 220856 timothy 2014-01-10 10:42:46 -0800 Created attachment 220856 Patch 966440 3 220856 joepeck 2014-01-10 10:46:34 -0800 Comment on attachment 220856 Patch r=me 966556 4 220856 commit-queue 2014-01-10 13:27:44 -0800 Comment on attachment 220856 Patch Clearing flags on attachment: 220856 Committed r161670: <http://trac.webkit.org/changeset/161670> 966557 5 commit-queue 2014-01-10 13:27:46 -0800 All reviewed patches have been landed. Closing bug. 220856 2014-01-10 10:42:46 -0800 2014-01-10 13:27:44 -0800 Patch bug-126760-20140110104245.patch text/plain 2778 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhjYzRjNDlmMTFkZDdh YWVmNmNjYWFkZDVlMzA2OWRkMDcwYjdiNy4uNDk1NGZkNWRiZmE2ZDRiYTBhZjY1MDg1NTk5OWE1 YzBiMTI0NmNlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTEwICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBQcmV2ZW50IHNvbWUg cmVzb3VyY2VzIGZyb20gc2hvd2luZyB1cCBpbiBXZWIgSW5zcGVjdG9yIGFzIHllYXJzIGluIGR1 cmF0aW9uLgorCisgICAgICAgIE5vIFdlYktpdCBwb3J0IHBhc3NlZCBhIG1vbm90b25pYyB0aW1l IHRvIEluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkRmluaXNoTG9hZGluZyAtLSBleGNlcHQg Q2hyb21pdW0uCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEyNjc2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaW5zcGVjdG9yL0luc3BlY3Rvckluc3RydW1lbnRhdGlvbi5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpJbnNwZWN0b3JJbnN0cnVtZW50YXRpb246OmRpZEZpbmlzaExvYWRpbmdJbXBsKToK KyAgICAgICAgUmV2ZXJ0IHBhcnQgb2YgcjEwMjk2MSB0byB1c2UgZmluaXNoVGltZSBhcy1pcyBh bmQgbm90IGV4cGVjdCBhIG1vbm90b25pYyB0aW1lLgorCiAyMDE0LTAxLTA5ICBCcmVudCBGdWxn aGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXZWJHTF0gUmV0dXJuIGZpbHRl cmVkIHJlc3VsdHMgZm9yIGdldFByb2dyYW1QYXJhbWV0ZXIgZm9yIEFDVElWRV9BVFRSSUJVVEVT IGFuZCBBQ1RJVkVfVU5JRk9STVMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JJbnN0cnVtZW50YXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3Rvckluc3RydW1lbnRhdGlvbi5jcHAKaW5kZXggMjUxOGI5NDIwNTIzZDFiMmIxYzJl NTFlNTE3ZGM2NDIyZTYzNmU4YS4uZTMyNjdlMDJmZGU1NDNlODY2NjE4Zjg0M2I1YWQ2ZWZhZDI0 NDA2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvckluc3Ry dW1lbnRhdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvcklu c3RydW1lbnRhdGlvbi5jcHAKQEAgLTY4NywyMSArNjg3LDExIEBAIHZvaWQgSW5zcGVjdG9ySW5z dHJ1bWVudGF0aW9uOjpkaWRSZWNlaXZlRGF0YUltcGwoSW5zdHJ1bWVudGluZ0FnZW50cyogaW5z dHJ1bWVuCiAgICAgICAgIHJlc291cmNlQWdlbnQtPmRpZFJlY2VpdmVEYXRhKGlkZW50aWZpZXIs IGRhdGEsIGRhdGFMZW5ndGgsIGVuY29kZWREYXRhTGVuZ3RoKTsKIH0KIAotdm9pZCBJbnNwZWN0 b3JJbnN0cnVtZW50YXRpb246OmRpZEZpbmlzaExvYWRpbmdJbXBsKEluc3RydW1lbnRpbmdBZ2Vu dHMqIGluc3RydW1lbnRpbmdBZ2VudHMsIHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgRG9jdW1l bnRMb2FkZXIqIGxvYWRlciwgZG91YmxlIG1vbm90b25pY0ZpbmlzaFRpbWUpCit2b2lkIEluc3Bl Y3Rvckluc3RydW1lbnRhdGlvbjo6ZGlkRmluaXNoTG9hZGluZ0ltcGwoSW5zdHJ1bWVudGluZ0Fn ZW50cyogaW5zdHJ1bWVudGluZ0FnZW50cywgdW5zaWduZWQgbG9uZyBpZGVudGlmaWVyLCBEb2N1 bWVudExvYWRlciogbG9hZGVyLCBkb3VibGUgZmluaXNoVGltZSkKIHsKLSAgICBJbnNwZWN0b3JU aW1lbGluZUFnZW50KiB0aW1lbGluZUFnZW50ID0gaW5zdHJ1bWVudGluZ0FnZW50cy0+aW5zcGVj dG9yVGltZWxpbmVBZ2VudCgpOwotICAgIEluc3BlY3RvclJlc291cmNlQWdlbnQqIHJlc291cmNl QWdlbnQgPSBpbnN0cnVtZW50aW5nQWdlbnRzLT5pbnNwZWN0b3JSZXNvdXJjZUFnZW50KCk7Ci0g ICAgaWYgKCF0aW1lbGluZUFnZW50ICYmICFyZXNvdXJjZUFnZW50KQotICAgICAgICByZXR1cm47 Ci0KLSAgICBkb3VibGUgZmluaXNoVGltZSA9IDAuMDsKLSAgICAvLyBGSVhNRTogRXhwb3NlIGFs bCBvZiB0aGUgdGltaW5nIGRldGFpbHMgdG8gaW5zcGVjdG9yIGFuZCBoYXZlIGl0IGNhbGN1bGF0 ZSBmaW5pc2hUaW1lLgotICAgIGlmIChtb25vdG9uaWNGaW5pc2hUaW1lKQotICAgICAgICBmaW5p c2hUaW1lID0gbG9hZGVyLT50aW1pbmcoKS0+bW9ub3RvbmljVGltZVRvUHNldWRvV2FsbFRpbWUo bW9ub3RvbmljRmluaXNoVGltZSk7Ci0KLSAgICBpZiAodGltZWxpbmVBZ2VudCkKKyAgICBpZiAo SW5zcGVjdG9yVGltZWxpbmVBZ2VudCogdGltZWxpbmVBZ2VudCA9IGluc3RydW1lbnRpbmdBZ2Vu dHMtPmluc3BlY3RvclRpbWVsaW5lQWdlbnQoKSkKICAgICAgICAgdGltZWxpbmVBZ2VudC0+ZGlk RmluaXNoTG9hZGluZ1Jlc291cmNlKGlkZW50aWZpZXIsIGZhbHNlLCBmaW5pc2hUaW1lLCBsb2Fk ZXItPmZyYW1lKCkpOwotICAgIGlmIChyZXNvdXJjZUFnZW50KQorICAgIGlmIChJbnNwZWN0b3JS ZXNvdXJjZUFnZW50KiByZXNvdXJjZUFnZW50ID0gaW5zdHJ1bWVudGluZ0FnZW50cy0+aW5zcGVj dG9yUmVzb3VyY2VBZ2VudCgpKQogICAgICAgICByZXNvdXJjZUFnZW50LT5kaWRGaW5pc2hMb2Fk aW5nKGlkZW50aWZpZXIsIGxvYWRlciwgZmluaXNoVGltZSk7CiB9CiAK