126754 2014-01-10 09:00:07 -0800 [JSC] Revise typed array implementations to match ECMAScript and WebGL Specification 2014-01-11 18:47:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 126803 1 bfulgham dino bfulgham commit-queue dino fpizlo ggaren oliver webkit-bug-importer oldest_to_newest 966386 0 bfulgham 2014-01-10 09:00:07 -0800 The ECMAScript specification requires that 'new' be used with DataView (see https://bugs.ecmascript.org/show_bug.cgi?id=695). This was confirmed by discussion about the WebGL test suite (https://github.com/KhronosGroup/WebGL/issues/446). Our DataView implementation should not allow use as a constructor function, and should require the use of 'new'. 966409 1 bfulgham 2014-01-10 09:54:47 -0800 Ken Russel notes that this is true of all of the Typed Array constructors as well. 966410 2 webkit-bug-importer 2014-01-10 09:54:58 -0800 <rdar://problem/15793039> 966691 3 220907 dino 2014-01-10 17:02:39 -0800 Created attachment 220907 Patch 966692 4 dino 2014-01-10 17:06:20 -0800 Committed r161702: <http://trac.webkit.org/changeset/161702> 966729 5 ap 2014-01-10 19:53:14 -0800 This change broke four JS tests: ** The following JSC stress test failures have been introduced: jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout-no-cjit jsc-layout-tests.yaml/js/script-tests/typedarray-constructors.js.layout-dfg-eager-no-cjit While this is probably expected, it makes the tree red. 966730 6 ap 2014-01-10 19:56:07 -0800 And also fast/canvas/webgl/data-view-test.html. 966732 7 commit-queue 2014-01-10 20:00:08 -0800 Re-opened since this is blocked by bug 126803 966858 8 bfulgham 2014-01-11 17:33:04 -0800 I think all of these changes are expected, and should have been part of the patch. I'll correct and re-land. 966871 9 220907 bfulgham 2014-01-11 18:41:16 -0800 Comment on attachment 220907 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220907&action=review > LayoutTests/js/script-tests/typedarray-constructors.js:7 > +shouldNotThrow("new Int8Array()"); It turns out that 'shouldNotThrow' is NOT part of "standalone-pre.js", which is what's used for the JSC stress tests. 966873 10 bfulgham 2014-01-11 18:47:27 -0800 Committed r161789: <http://trac.webkit.org/changeset/161789> 220907 2014-01-10 17:02:39 -0800 2014-01-11 18:41:16 -0800 Patch bug-126754-20140111120238.patch text/plain 6702 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx OGViODE3NmU4MThlNWFmZDg3YzU1OGEzMzY3ZmIyYmE1ZGMyNzE2Li5mZjg0NTA0MmVkNWZiZWMw YTE0MmYwNTBmNWE5NGU5YmJiM2Y5NDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNC0wMS0xMCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisK KyAgICAgICAgW0pTQ10gUmV2aXNlIHR5cGVkIGFycmF5IGltcGxlbWVudGF0aW9ucyB0byBtYXRj aCBFQ01BU2NyaXB0IGFuZCBXZWJHTCBTcGVjaWZpY2F0aW9uCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY3NTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgRUNNQVNjcmlwdCBzcGVjaWZpY2F0aW9u IGZvcmJpZHMgY2FsbGluZyB0aGUgdHlwZWQgYXJyYXkKKyAgICAgICAgY29uc3RydWN0b3JzIHdp dGhvdXQgdXNpbmcgIm5ldyIuIENoYW5nZSB0aGUgY2FsbCBkYXRhIHRvIHJldHVybgorICAgICAg ICBub25lIHNvIHdlIHRocm93IGFuZCBleGNlcHRpb24gaW4gdGhlc2UgY2FzZXMuCisKKyAgICAg ICAgKiBydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3JJbmxpbmVzLmg6 CisgICAgICAgIChKU0M6OkpTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3I8Vmlld0Ns YXNzPjo6Z2V0Q2FsbERhdGEpOgorCiAyMDE0LTAxLTEwICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJv ZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04oQyBzdGFjayB3b3JrKTogc3RhY2sg dHJhY2VzIG5vIGxvbmdlciB3b3JrIGluIENyYXNoVHJhY2VyLCBsbGRiLCBhbmQgb3RoZXIgdG9v bHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5 cGVkQXJyYXlWaWV3Q29uc3RydWN0b3JJbmxpbmVzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9KU0dlbmVyaWNUeXBlZEFycmF5Vmlld0NvbnN0cnVjdG9ySW5saW5lcy5oCmluZGV4 IDg3MDM5NWE2M2FiNDIxYmViNjY0M2RhYTBmZjU3MDk4MWRhOWEzNzEuLjJkZGMyOWY3MTg5N2Ji NTFkMzkwYjA2YjI1YTczODMzODc0YmEwYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0b3JJbmxpbmVzLmgK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHZW5lcmljVHlwZWRBcnJheVZp ZXdDb25zdHJ1Y3RvcklubGluZXMuaApAQCAtMTU3LDcgKzE1Nyw3IEBAIHRlbXBsYXRlPHR5cGVu YW1lIFZpZXdDbGFzcz4KIENhbGxUeXBlIEpTR2VuZXJpY1R5cGVkQXJyYXlWaWV3Q29uc3RydWN0 b3I8Vmlld0NsYXNzPjo6Z2V0Q2FsbERhdGEoSlNDZWxsKiwgQ2FsbERhdGEmIGNhbGxEYXRhKQog ewogICAgIGNhbGxEYXRhLm5hdGl2ZS5mdW5jdGlvbiA9IGNvbnN0cnVjdEdlbmVyaWNUeXBlZEFy cmF5VmlldzxWaWV3Q2xhc3M+OwotICAgIHJldHVybiBDYWxsVHlwZUhvc3Q7CisgICAgcmV0dXJu IENhbGxUeXBlTm9uZTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTAzMzFjYTQy Y2VkMzFhZTFjMzNlNjU2NTE2ZDQ0NjlhYTQ2MzkwOC4uNTYwNDI3ZDM5YmU5NWMwNjdmNzJmZmY4 YWZkZmVjZDk0ZDdkNmYyYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTAxLTEwICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAorICAgICAgICBbSlNDXSBSZXZpc2UgdHlwZWQg YXJyYXkgaW1wbGVtZW50YXRpb25zIHRvIG1hdGNoIEVDTUFTY3JpcHQgYW5kIFdlYkdMIFNwZWNp ZmljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNjc1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5ldyB0ZXN0IHdoaWNoIGNoZWNrcyB0aGF0IHdlIHRocm93IGFuIGV4Y2VwdGlvbiB3aGVuIGNh bGxpbmcKKyAgICAgICAgYW55IG9mIHRoZSB0eXBlZCBhcnJheSBjb25zdHJ1Y3RvcnMgd2l0aG91 dCB1c2luZyAibmV3Ii4KKworICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy90eXBlZGFycmF5LWNv bnN0cnVjdG9ycy5qczogQWRkZWQuCisgICAgICAgICoganMvdHlwZWRhcnJheS1jb25zdHJ1Y3Rv cnMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBqcy90eXBlZGFycmF5LWNvbnN0cnVj dG9ycy5odG1sOiBBZGRlZC4KKworMjAxNC0wMS0xMCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBs ZS5jb20+CisKICAgICAgICAgSW1wbGVtZW50IE9FUyB0ZXh0dXJlIGhhbGYgZmxvYXQgbGluZWFy CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjUwNjAK IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3R5cGVkYXJyYXktY29u c3RydWN0b3JzLmpzIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3R5cGVkYXJyYXktY29u c3RydWN0b3JzLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBiMjhiOGU2YzQ4MjEyZmQyNzgwMDI5MzJjYjhkMWQ2 NGZhMzhjNjMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMv dHlwZWRhcnJheS1jb25zdHJ1Y3RvcnMuanMKQEAgLTAsMCArMSwzNSBAQAorZGVzY3JpcHRpb24o CisnVGhpcyB0ZXN0IGNhc2UgdGVzdHMgdGhlIHZhcmlvdXMgdHlwZWQgYXJyYXkgYW5kIHJlbGF0 ZWQgY29uc3RydWN0b3JzLiAnICsKKydJbiBwYXJ0aWN1bGFyLCBtYWtlcyBzdXJlIHRoYXQgeW91 IHVzZSB0aGUgIm5ldyIga2V5d29yZCB3aGVuIHVzaW5nIHRoZSBjb25zdHJ1Y3RvcnMuJworKTsK Kworc2hvdWxkVGhyb3coIkludDhBcnJheSgpIik7CitzaG91bGROb3RUaHJvdygibmV3IEludDhB cnJheSgpIik7CisKK3Nob3VsZFRocm93KCJJbnQxNkFycmF5KCkiKTsKK3Nob3VsZE5vdFRocm93 KCJuZXcgSW50MTZBcnJheSgpIik7CisKK3Nob3VsZFRocm93KCJJbnQzMkFycmF5KCkiKTsKK3No b3VsZE5vdFRocm93KCJuZXcgSW50MzJBcnJheSgpIik7CisKK3Nob3VsZFRocm93KCJVaW50OEFy cmF5KCkiKTsKK3Nob3VsZE5vdFRocm93KCJuZXcgVWludDhBcnJheSgpIik7CisKK3Nob3VsZFRo cm93KCJVaW50MTZBcnJheSgpIik7CitzaG91bGROb3RUaHJvdygibmV3IFVpbnQxNkFycmF5KCki KTsKKworc2hvdWxkVGhyb3coIlVpbnQzMkFycmF5KCkiKTsKK3Nob3VsZE5vdFRocm93KCJuZXcg VWludDMyQXJyYXkoKSIpOworCitzaG91bGRUaHJvdygiVWludDhDbGFtcGVkQXJyYXkoKSIpOwor c2hvdWxkTm90VGhyb3coIm5ldyBVaW50OENsYW1wZWRBcnJheSgpIik7CisKK3Nob3VsZFRocm93 KCJGbG9hdDMyQXJyYXkoKSIpOworc2hvdWxkTm90VGhyb3coIm5ldyBGbG9hdDMyQXJyYXkoKSIp OworCitzaG91bGRUaHJvdygiRmxvYXQ2NEFycmF5KCkiKTsKK3Nob3VsZE5vdFRocm93KCJuZXcg RmxvYXQ2NEFycmF5KCkiKTsKKworc2hvdWxkVGhyb3coIkRhdGFWaWV3KG5ldyBBcnJheUJ1ZmZl cigpKSIpOworc2hvdWxkTm90VGhyb3coIm5ldyBEYXRhVmlldyhuZXcgQXJyYXlCdWZmZXIoKSki KTsKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvanMvdHlwZWRhcnJheS1jb25zdHJ1Y3RvcnMt ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvdHlwZWRhcnJheS1jb25zdHJ1Y3RvcnMtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjVhNTUyZWIzYzVhN2Q1Y2ZkZGU1YTE0NTU1ODYzMGU1ZWZj MjA3YmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9qcy90eXBlZGFycmF5LWNvbnN0 cnVjdG9ycy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyOSBAQAorVGhpcyB0ZXN0IGNhc2UgdGVz dHMgdGhlIHZhcmlvdXMgdHlwZWQgYXJyYXkgYW5kIHJlbGF0ZWQgY29uc3RydWN0b3JzLiBJbiBw YXJ0aWN1bGFyLCBtYWtlcyBzdXJlIHRoYXQgeW91IHVzZSB0aGUgIm5ldyIga2V5d29yZCB3aGVu IHVzaW5nIHRoZSBjb25zdHJ1Y3RvcnMuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKwor CitQQVNTIEludDhBcnJheSgpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IEZ1bmN0aW9uIGlz IG5vdCBhIGZ1bmN0aW9uIChldmFsdWF0aW5nICdJbnQ4QXJyYXkoKScpLgorUEFTUyBuZXcgSW50 OEFycmF5KCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIEludDE2QXJyYXkoKSB0aHJl dyBleGNlcHRpb24gVHlwZUVycm9yOiBGdW5jdGlvbiBpcyBub3QgYSBmdW5jdGlvbiAoZXZhbHVh dGluZyAnSW50MTZBcnJheSgpJykuCitQQVNTIG5ldyBJbnQxNkFycmF5KCkgZGlkIG5vdCB0aHJv dyBleGNlcHRpb24uCitQQVNTIEludDMyQXJyYXkoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9y OiBGdW5jdGlvbiBpcyBub3QgYSBmdW5jdGlvbiAoZXZhbHVhdGluZyAnSW50MzJBcnJheSgpJyku CitQQVNTIG5ldyBJbnQzMkFycmF5KCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIFVp bnQ4QXJyYXkoKSB0aHJldyBleGNlcHRpb24gVHlwZUVycm9yOiBGdW5jdGlvbiBpcyBub3QgYSBm dW5jdGlvbiAoZXZhbHVhdGluZyAnVWludDhBcnJheSgpJykuCitQQVNTIG5ldyBVaW50OEFycmF5 KCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIFVpbnQxNkFycmF5KCkgdGhyZXcgZXhj ZXB0aW9uIFR5cGVFcnJvcjogRnVuY3Rpb24gaXMgbm90IGEgZnVuY3Rpb24gKGV2YWx1YXRpbmcg J1VpbnQxNkFycmF5KCknKS4KK1BBU1MgbmV3IFVpbnQxNkFycmF5KCkgZGlkIG5vdCB0aHJvdyBl eGNlcHRpb24uCitQQVNTIFVpbnQzMkFycmF5KCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjog RnVuY3Rpb24gaXMgbm90IGEgZnVuY3Rpb24gKGV2YWx1YXRpbmcgJ1VpbnQzMkFycmF5KCknKS4K K1BBU1MgbmV3IFVpbnQzMkFycmF5KCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIFVp bnQ4Q2xhbXBlZEFycmF5KCkgdGhyZXcgZXhjZXB0aW9uIFR5cGVFcnJvcjogRnVuY3Rpb24gaXMg bm90IGEgZnVuY3Rpb24gKGV2YWx1YXRpbmcgJ1VpbnQ4Q2xhbXBlZEFycmF5KCknKS4KK1BBU1Mg bmV3IFVpbnQ4Q2xhbXBlZEFycmF5KCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIEZs b2F0MzJBcnJheSgpIHRocmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IEZ1bmN0aW9uIGlzIG5vdCBh IGZ1bmN0aW9uIChldmFsdWF0aW5nICdGbG9hdDMyQXJyYXkoKScpLgorUEFTUyBuZXcgRmxvYXQz MkFycmF5KCkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIEZsb2F0NjRBcnJheSgpIHRo cmV3IGV4Y2VwdGlvbiBUeXBlRXJyb3I6IEZ1bmN0aW9uIGlzIG5vdCBhIGZ1bmN0aW9uIChldmFs dWF0aW5nICdGbG9hdDY0QXJyYXkoKScpLgorUEFTUyBuZXcgRmxvYXQ2NEFycmF5KCkgZGlkIG5v dCB0aHJvdyBleGNlcHRpb24uCitQQVNTIERhdGFWaWV3KG5ldyBBcnJheUJ1ZmZlcigpKSB0aHJl dyBleGNlcHRpb24gVHlwZUVycm9yOiBGdW5jdGlvbiBpcyBub3QgYSBmdW5jdGlvbiAoZXZhbHVh dGluZyAnRGF0YVZpZXcobmV3IEFycmF5QnVmZmVyKCkpJykuCitQQVNTIG5ldyBEYXRhVmlldyhu ZXcgQXJyYXlCdWZmZXIoKSkgZGlkIG5vdCB0aHJvdyBleGNlcHRpb24uCitQQVNTIHN1Y2Nlc3Nm dWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvanMvdHlwZWRhcnJheS1jb25zdHJ1Y3RvcnMuaHRtbCBiL0xheW91dFRlc3RzL2pzL3R5 cGVkYXJyYXktY29uc3RydWN0b3JzLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNWJmYjM5ZWI2NzZmOGRkYjE2 YzE2ZTQwYzk2YWIyZDY0MGJkODMwOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2pz L3R5cGVkYXJyYXktY29uc3RydWN0b3JzLmh0bWwKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBF IEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxz Y3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFk PgorPGJvZHk+Cis8c2NyaXB0IHNyYz0ic2NyaXB0LXRlc3RzL3R5cGVkYXJyYXktY29uc3RydWN0 b3JzLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0 LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K