<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126750</bug_id>
          
          <creation_ts>2014-01-10 07:27:33 -0800</creation_ts>
          <short_desc>[WinCairo] Crash when rendering (in pixman dll)</short_desc>
          <delta_ts>2014-01-10 09:13:24 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>peavo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>966362</commentid>
    <comment_count>0</comment_count>
    <who name="">peavo</who>
    <bug_when>2014-01-10 07:27:33 -0800</bug_when>
    <thetext>I&apos;m getting a consistent crash in libpixman-1.0.dll when rendering.

The libpixman-1.0.dll is from the gstreamer installation, and we should not be using that in our rendering.
It is used because we link with cairo.lib, but since there is also a cairo.lib in the gstreamer installation,
we link with the wrong cairo.lib, and when executing, loads the wrong cairo dll (from the gstreamer installation). 

We need to make sure the WebKitLibraries path comes before the gstreamer lib path, so we pick up the correct cairo.lib.

This is the message, and stack trace of the crash:

First-chance exception at 0x653893BC (libpixman-1-0.dll) in WinLauncher.exe: 0xC0000005: Access violation reading location 0x00000000.

	libpixman-1-0.dll!653893bc()	Unknown
 	[Frames below may be incorrect and/or missing, no symbols loaded for libpixman-1-0.dll]	
 	libpixman-1-0.dll!6534a8a0()	Unknown</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966366</commentid>
    <comment_count>1</comment_count>
      <attachid>220845</attachid>
    <who name="">peavo</who>
    <bug_when>2014-01-10 07:39:30 -0800</bug_when>
    <thetext>Created attachment 220845
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966376</commentid>
    <comment_count>2</comment_count>
      <attachid>220845</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-01-10 08:45:30 -0800</bug_when>
    <thetext>Comment on attachment 220845
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966378</commentid>
    <comment_count>3</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-01-10 08:47:07 -0800</bug_when>
    <thetext>It would probably make sense to have a single bundle of stuff that included the GStreamer and Cairo libraries all together, rather than the current situation of WebKit-built libxml/pixmal/cairo/etc plus an external bundle of stuff that includes similar libraries.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966394</commentid>
    <comment_count>4</comment_count>
      <attachid>220845</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-10 09:13:22 -0800</bug_when>
    <thetext>Comment on attachment 220845
Patch

Clearing flags on attachment: 220845

Committed r161640: &lt;http://trac.webkit.org/changeset/161640&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>966395</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-10 09:13:24 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220845</attachid>
            <date>2014-01-10 07:39:30 -0800</date>
            <delta_ts>2014-01-10 09:13:22 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-126750-20140110163912.patch</filename>
            <type>text/plain</type>
            <size>2761</size>
            <attacher>peavo</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGli
cmFyaWVzL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxNjMyKQorKysgV2ViS2l0TGlicmFyaWVzL0No
YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTEwICBwZWF2
b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10g
Q3Jhc2ggd2hlbiByZW5kZXJpbmcgKGluIHBpeG1hbiBkbGwpCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY3NTAKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSB3ZSBsaW5rIHdpdGggY2Fpcm8ubGli
LCBhbmQgdGhlIGdzdHJlYW1lciBpbnN0YWxsYXRpb24gYWxzbyBjb21lcyB3aXRoIGNhaXJvLmxp
YiwKKyAgICAgICAgd2UgbGluayB3aXRoIHRoZSB3cm9uZyBjYWlyby5saWIsIGFuZCBsb2FkcyBn
c3RyZWFtZXJzIGNhaXJvIGRsbCwgaW5zdGVhZCBvZiBvdXIgb3duLgorICAgICAgICBXZSBzaG91
bGQgdXNlciBvdXIgb3duIGNhaXJvIGRsbCBmb3IgcmVuZGVyaW5nLgorCisgICAgICAgICogd2lu
L3Rvb2xzL3ZzcHJvcHMvR1N0cmVhbWVyMzIucHJvcHM6IFB1dCBnc3RyZWFtZXIgbGliIHBhdGgg
bGFzdCwgc28gd2UgbGluayB3aXRoIHRoZSBjb3JyZWN0IGNhaXJvLmxpYi4KKyAgICAgICAgKiB3
aW4vdG9vbHMvdnNwcm9wcy9HU3RyZWFtZXI2NC5wcm9wczogRGl0dG8uCisKIDIwMTQtMDEtMDMg
IEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBb
V2luQ2Fpcm9dIEVuYWJsZSB2aWRlbyB1c2luZyBHU3RyZWFtZXIuCkluZGV4OiBXZWJLaXRMaWJy
YXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvR1N0cmVhbWVyMzIucHJvcHMKPT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g
V2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL0dTdHJlYW1lcjMyLnByb3BzCShyZXZp
c2lvbiAxNjE2MzIpCisrKyBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvR1N0cmVh
bWVyMzIucHJvcHMJKHdvcmtpbmcgY29weSkKQEAgLTUsNyArNSw3IEBACiAgICAgICA8QWRkaXRp
b25hbEluY2x1ZGVEaXJlY3Rvcmllcz4kKEdTVFJFQU1FUl8xXzBfUk9PVF9YODYpaW5jbHVkZVxn
c3RyZWFtZXItMS4wOyQoR1NUUkVBTUVSXzFfMF9ST09UX1g4NilpbmNsdWRlXGdsaWItMi4wOyQo
R1NUUkVBTUVSXzFfMF9ST09UX1g4NilsaWJcZ2xpYi0yLjBcaW5jbHVkZTslKEFkZGl0aW9uYWxJ
bmNsdWRlRGlyZWN0b3JpZXMpPC9BZGRpdGlvbmFsSW5jbHVkZURpcmVjdG9yaWVzPg0KICAgICA8
L0NsQ29tcGlsZT4NCiAgICAgPExpbms+DQotICAgICAgPEFkZGl0aW9uYWxMaWJyYXJ5RGlyZWN0
b3JpZXM+JChHU1RSRUFNRVJfMV8wX1JPT1RfWDg2KWxpYjslKEFkZGl0aW9uYWxMaWJyYXJ5RGly
ZWN0b3JpZXMpPC9BZGRpdGlvbmFsTGlicmFyeURpcmVjdG9yaWVzPg0KKyAgICAgIDxBZGRpdGlv
bmFsTGlicmFyeURpcmVjdG9yaWVzPiUoQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmllcyk7JChH
U1RSRUFNRVJfMV8wX1JPT1RfWDg2KWxpYjwvQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmllcz4N
CiAgICAgPC9MaW5rPg0KICAgPC9JdGVtRGVmaW5pdGlvbkdyb3VwPg0KIDwvUHJvamVjdD4KXCBO
byBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCkluZGV4OiBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xz
L3ZzcHJvcHMvR1N0cmVhbWVyNjQucHJvcHMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0TGlicmFyaWVz
L3dpbi90b29scy92c3Byb3BzL0dTdHJlYW1lcjY0LnByb3BzCShyZXZpc2lvbiAxNjE2MzIpCisr
KyBXZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJvcHMvR1N0cmVhbWVyNjQucHJvcHMJKHdv
cmtpbmcgY29weSkKQEAgLTUsNyArNSw3IEBACiAgICAgICA8QWRkaXRpb25hbEluY2x1ZGVEaXJl
Y3Rvcmllcz4kKEdTVFJFQU1FUl8xXzBfUk9PVF9YODZfNjQpaW5jbHVkZVxnc3RyZWFtZXItMS4w
OyQoR1NUUkVBTUVSXzFfMF9ST09UX1g4Nl82NClpbmNsdWRlXGdsaWItMi4wOyQoR1NUUkVBTUVS
XzFfMF9ST09UX1g4Nl82NClsaWJcZ2xpYi0yLjBcaW5jbHVkZTslKEFkZGl0aW9uYWxJbmNsdWRl
RGlyZWN0b3JpZXMpPC9BZGRpdGlvbmFsSW5jbHVkZURpcmVjdG9yaWVzPg0KICAgICA8L0NsQ29t
cGlsZT4NCiAgICAgPExpbms+DQotICAgICAgPEFkZGl0aW9uYWxMaWJyYXJ5RGlyZWN0b3JpZXM+
JChHU1RSRUFNRVJfMV8wX1JPT1RfWDg2XzY0KWxpYjslKEFkZGl0aW9uYWxMaWJyYXJ5RGlyZWN0
b3JpZXMpPC9BZGRpdGlvbmFsTGlicmFyeURpcmVjdG9yaWVzPg0KKyAgICAgIDxBZGRpdGlvbmFs
TGlicmFyeURpcmVjdG9yaWVzPiUoQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmllcyk7JChHU1RS
RUFNRVJfMV8wX1JPT1RfWDg2XzY0KWxpYjwvQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmllcz4N
CiAgICAgPC9MaW5rPg0KICAgPC9JdGVtRGVmaW5pdGlvbkdyb3VwPg0KIDwvUHJvamVjdD4KXCBO
byBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>