126748 2014-01-10 07:13:24 -0800 Fix building with SVG support disabled 2014-01-10 14:53:40 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez webkit-unassigned andersca aperez commit-queue dbates koivisto rego oldest_to_newest 966357 0 220840 aperez 2014-01-10 07:13:24 -0800 Created attachment 220840 Patch Building with SVG disabled fails due to a stray closing brace inside the #if ENABLED(SVG) block. Moving the brace fixes the compilation failure. 966359 1 220842 aperez 2014-01-10 07:15:22 -0800 Created attachment 220842 Patch 966391 2 220842 ossy 2014-01-10 09:04:24 -0800 Comment on attachment 220842 Patch LGTM, r=me. It is a correct fix after r161589. 966536 3 220842 commit-queue 2014-01-10 13:10:18 -0800 Comment on attachment 220842 Patch Rejecting attachment 220842 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 220842, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: e: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/FontFastPath.cpp Hunk #1 FAILED at 228. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/FontFastPath.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Csaba Osztrogon\xe1c']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5006518286024704 966611 4 rego 2014-01-10 14:53:25 -0800 It was already fixed at http://trac.webkit.org/changeset/161652 220840 2014-01-10 07:13:24 -0800 2014-01-10 07:15:15 -0800 Patch 20140110171346.patch text/plain 1463 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdhOWNlNTU2ZDUwMTU2 Y2I4MTMwOGJmNjc1OWFkYzFiYTEwNzIwZi4uMjc5MWFhODA3ZWMzYzY5MDgwMTIyNDVjMGQyNjhh NzZlN2IwYjM2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTEwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IGJ1 aWxkaW5nIHdpdGggU1ZHIHN1cHBvcnQgZGlzYWJsZWQKKyAgICAgICAgTmVlZCB0aGUgYnVnIFVS TCAoT09QUyEpLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9G b250RmFzdFBhdGguY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udDo6ZHJhd0dseXBoQnVmZmVy KToKKwogMjAxNC0wMS0xMCAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg ICAgICAgQ3Jhc2ggd2hlbiBtdXRhdGluZyBTVkcgdGV4dCB3aXRoIHRyYW5zZm9ybQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhc3RQYXRoLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ZvbnRGYXN0UGF0aC5jcHAKaW5kZXgg OTU2MzQzNzNlOTU1N2E0OTUwMjliMmY5MGEwNGMwYWEzNDBjYjYwZC4uNjYwMmMzYjY2NjMzOGZm M2MxM2VjZWRiNDM3ZTQ2Yjk4NzJmZjdlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvRm9udEZhc3RQYXRoLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9Gb250RmFzdFBhdGguY3BwCkBAIC0yMjgsOCArMjI4LDkgQEAgdm9pZCBG b250OjpkcmF3R2x5cGhCdWZmZXIoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBUZXh0 UnVuJiBydW4sIGNvbnN0IEcKICNpZiBFTkFCTEUoU1ZHX0ZPTlRTKQogICAgIGlmIChyZW5kZXJp bmdDb250ZXh0ICYmIGZvbnREYXRhLT5pc1NWR0ZvbnQoKSkKICAgICAgICAgcmVuZGVyaW5nQ29u dGV4dC0+ZHJhd1NWR0dseXBocyhjb250ZXh0LCBmb250RGF0YSwgZ2x5cGhCdWZmZXIsIGxhc3RG cm9tLCBuZXh0R2x5cGggLSBsYXN0RnJvbSwgc3RhcnRQb2ludCk7Ci0gICAgZWxzZSB7CisgICAg ZWxzZQogI2VuZGlmCisgICAgewogICAgICAgICBkcmF3R2x5cGhzKGNvbnRleHQsIGZvbnREYXRh LCBnbHlwaEJ1ZmZlciwgbGFzdEZyb20sIG5leHRHbHlwaCAtIGxhc3RGcm9tLCBzdGFydFBvaW50 KTsKICAgICAgICAgcG9pbnQuc2V0WChuZXh0WCk7CiAgICAgfQo= 220842 2014-01-10 07:15:22 -0800 2014-01-10 14:53:40 -0800 Patch bug-126748-20140110171543.patch text/plain 1484 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzdhOWNlNTU2ZDUwMTU2 Y2I4MTMwOGJmNjc1OWFkYzFiYTEwNzIwZi4uYmQ3ZDlkOTNkMmU1MDY3Y2M3YWQ0OWFjNzNmODYy OGM0ZGFmZmVkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTEwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgRml4IGJ1 aWxkaW5nIHdpdGggU1ZHIHN1cHBvcnQgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjc0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9Gb250RmFzdFBhdGguY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Rm9udDo6ZHJhd0dseXBoQnVmZmVyKToKKwogMjAxNC0wMS0xMCAgQW50dGkgS29pdmlzdG8gIDxh bnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggd2hlbiBtdXRhdGluZyBTVkcgdGV4dCB3 aXRoIHRyYW5zZm9ybQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvRm9udEZhc3RQYXRoLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zv bnRGYXN0UGF0aC5jcHAKaW5kZXggOTU2MzQzNzNlOTU1N2E0OTUwMjliMmY5MGEwNGMwYWEzNDBj YjYwZC4uNjYwMmMzYjY2NjMzOGZmM2MxM2VjZWRiNDM3ZTQ2Yjk4NzJmZjdlYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRm9udEZhc3RQYXRoLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9Gb250RmFzdFBhdGguY3BwCkBAIC0y MjgsOCArMjI4LDkgQEAgdm9pZCBGb250OjpkcmF3R2x5cGhCdWZmZXIoR3JhcGhpY3NDb250ZXh0 KiBjb250ZXh0LCBjb25zdCBUZXh0UnVuJiBydW4sIGNvbnN0IEcKICNpZiBFTkFCTEUoU1ZHX0ZP TlRTKQogICAgIGlmIChyZW5kZXJpbmdDb250ZXh0ICYmIGZvbnREYXRhLT5pc1NWR0ZvbnQoKSkK ICAgICAgICAgcmVuZGVyaW5nQ29udGV4dC0+ZHJhd1NWR0dseXBocyhjb250ZXh0LCBmb250RGF0 YSwgZ2x5cGhCdWZmZXIsIGxhc3RGcm9tLCBuZXh0R2x5cGggLSBsYXN0RnJvbSwgc3RhcnRQb2lu dCk7Ci0gICAgZWxzZSB7CisgICAgZWxzZQogI2VuZGlmCisgICAgewogICAgICAgICBkcmF3R2x5 cGhzKGNvbnRleHQsIGZvbnREYXRhLCBnbHlwaEJ1ZmZlciwgbGFzdEZyb20sIG5leHRHbHlwaCAt IGxhc3RGcm9tLCBzdGFydFBvaW50KTsKICAgICAgICAgcG9pbnQuc2V0WChuZXh0WCk7CiAgICAg fQo=