126741 2014-01-10 01:27:30 -0800 [GTK] Fix return value of WebKitDownload::created-destination 2014-01-12 00:41:52 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned commit-queue gustavo mrobinson oldest_to_newest 966283 0 cgarcia 2014-01-10 01:27:30 -0800 Fortunately this is not an API break because it was actually unused, if anybody is using a boolean callback it will still work. I guess it's another copy-paste error :-( 966286 1 220820 cgarcia 2014-01-10 01:30:39 -0800 Created attachment 220820 Patch 966287 2 commit-queue 2014-01-10 01:33:31 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 966927 3 cgarcia 2014-01-12 00:41:52 -0800 Committed r161805: <http://trac.webkit.org/changeset/161805> 220820 2014-01-10 01:30:39 -0800 2014-01-10 07:59:57 -0800 Patch wk2-download-created-dest.diff text/plain 4707 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNDAzMDIwLi5jNWVlMGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkg QEAKIDIwMTQtMDEtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIEZpeCByZXR1cm4gdmFsdWUgb2YgV2ViS2l0RG93bmxvYWQ6OmNy ZWF0ZWQtZGVzdGluYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNjc0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFdlYktpdERvd25sb2FkOjpjcmVhdGVkLWRlc3RpbmF0aW9uIHNpZ25hbCBzaG91 bGQgYmUgdm9pZCBpbnN0ZWFkCisgICAgICAgIG9mIGdib29sZWFuLiBUaGlzIGRvZXNuJ3QgYnJl YWsgdGhlIEFQSS9BQkkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3du bG9hZC5jcHA6CisgICAgICAgICh3ZWJraXRfZG93bmxvYWRfY2xhc3NfaW5pdCk6CisgICAgICAg ICh3ZWJraXREb3dubG9hZERlc3RpbmF0aW9uQ3JlYXRlZCk6CisKKzIwMTQtMDEtMTAgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIEltcGxlbWVu dCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnJlY2VpdmVkQ2FuY2VsbGF0aW9uCiAgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYxMjkKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuY3BwCmluZGV4 IGU5NTI0YzIuLmZmNmQyYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXREb3dubG9hZC5jcHAKQEAgLTI2NCwxMyArMjY0LDE0IEBAIHN0YXRpYyB2 b2lkIHdlYmtpdF9kb3dubG9hZF9jbGFzc19pbml0KFdlYktpdERvd25sb2FkQ2xhc3MqIGRvd25s b2FkQ2xhc3MpCiAgICAgICogY3JlYXRlZCBzdWNjZXNzZnVsbHkgYXQgQGRlc3RpbmF0aW9uLgog ICAgICAqLwogICAgIHNpZ25hbHNbQ1JFQVRFRF9ERVNUSU5BVElPTl0gPQotICAgICAgICBnX3Np Z25hbF9uZXcoImNyZWF0ZWQtZGVzdGluYXRpb24iLAotICAgICAgICAgICAgICAgICAgICAgR19U WVBFX0ZST01fQ0xBU1Mob2JqZWN0Q2xhc3MpLAotICAgICAgICAgICAgICAgICAgICAgR19TSUdO QUxfUlVOX0xBU1QsCi0gICAgICAgICAgICAgICAgICAgICAwLCAwLCAwLAotICAgICAgICAgICAg ICAgICAgICAgZ19jY2xvc3VyZV9tYXJzaGFsX1ZPSURfX1NUUklORywKLSAgICAgICAgICAgICAg ICAgICAgIEdfVFlQRV9CT09MRUFOLCAxLAotICAgICAgICAgICAgICAgICAgICAgR19UWVBFX1NU UklORyk7CisgICAgICAgIGdfc2lnbmFsX25ldygKKyAgICAgICAgICAgICJjcmVhdGVkLWRlc3Rp bmF0aW9uIiwKKyAgICAgICAgICAgIEdfVFlQRV9GUk9NX0NMQVNTKG9iamVjdENsYXNzKSwKKyAg ICAgICAgICAgIEdfU0lHTkFMX1JVTl9MQVNULAorICAgICAgICAgICAgMCwgMCwgMCwKKyAgICAg ICAgICAgIGdfY2Nsb3N1cmVfbWFyc2hhbF9WT0lEX19TVFJJTkcsCisgICAgICAgICAgICBHX1RZ UEVfTk9ORSwgMSwKKyAgICAgICAgICAgIEdfVFlQRV9TVFJJTkcpOwogfQogCiBXZWJLaXREb3du bG9hZCogd2Via2l0RG93bmxvYWRDcmVhdGUoRG93bmxvYWRQcm94eSogZG93bmxvYWRQcm94eSkK QEAgLTM4Miw4ICszODMsNyBAQCB2b2lkIHdlYmtpdERvd25sb2FkRGVzdGluYXRpb25DcmVhdGVk KFdlYktpdERvd25sb2FkKiBkb3dubG9hZCwgY29uc3QgQ1N0cmluZyYgZAogewogICAgIGlmIChk b3dubG9hZC0+cHJpdi0+aXNDYW5jZWxsZWQpCiAgICAgICAgIHJldHVybjsKLSAgICBnYm9vbGVh biByZXR1cm5WYWx1ZTsKLSAgICBnX3NpZ25hbF9lbWl0KGRvd25sb2FkLCBzaWduYWxzW0NSRUFU RURfREVTVElOQVRJT05dLCAwLCBkZXN0aW5hdGlvblVSSS5kYXRhKCksICZyZXR1cm5WYWx1ZSk7 CisgICAgZ19zaWduYWxfZW1pdChkb3dubG9hZCwgc2lnbmFsc1tDUkVBVEVEX0RFU1RJTkFUSU9O XSwgMCwgZGVzdGluYXRpb25VUkkuZGF0YSgpLCBudWxscHRyKTsKIH0KIAogLyoqCmRpZmYgLS1n aXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmExNDMzOC4uNDM2 MzI1MCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEzIEBACisyMDE0LTAxLTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBGaXggcmV0dXJuIHZhbHVlIG9mIFdlYktp dERvd25sb2FkOjpjcmVhdGVkLWRlc3RpbmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY3NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9U ZXN0RG93bmxvYWRzLmNwcDogRml4IHJldHVybgorICAgICAgICB2YWx1ZSBvZiBzZXZlcmFsIGNh bGxiYWNrcy4KKwogMjAxNC0wMS0wOSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgog CiAgICAgICAgIFtDb2NvYV0gUHJvbW90ZSBXS0JhY2tGb3J3YXJkTGlzdHssSXRlbX0uaCB0byBw dWJsaWMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9U ZXN0RG93bmxvYWRzLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9U ZXN0RG93bmxvYWRzLmNwcAppbmRleCA4Njc4MjRmLi5iN2NhNzNhIDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdERvd25sb2Fkcy5jcHAKKysrIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3REb3dubG9hZHMuY3BwCkBA IC01MiwzMSArNTIsMjcgQEAgcHVibGljOgogICAgICAgICB0ZXN0LT5yZWNlaXZlZFJlc3BvbnNl KGRvd25sb2FkKTsKICAgICB9CiAKLSAgICBzdGF0aWMgZ2Jvb2xlYW4gY3JlYXRlZERlc3RpbmF0 aW9uQ2FsbGJhY2soV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBjb25zdCBnY2hhciogZGVzdGlu YXRpb24sIERvd25sb2FkVGVzdCogdGVzdCkKKyAgICBzdGF0aWMgdm9pZCBjcmVhdGVkRGVzdGlu YXRpb25DYWxsYmFjayhXZWJLaXREb3dubG9hZCogZG93bmxvYWQsIGNvbnN0IGdjaGFyKiBkZXN0 aW5hdGlvbiwgRG93bmxvYWRUZXN0KiB0ZXN0KQogICAgIHsKICAgICAgICAgZ19hc3NlcnQod2Vi a2l0X2Rvd25sb2FkX2dldF9kZXN0aW5hdGlvbihkb3dubG9hZCkpOwogICAgICAgICBnX2Fzc2Vy dF9jbXBzdHIod2Via2l0X2Rvd25sb2FkX2dldF9kZXN0aW5hdGlvbihkb3dubG9hZCksID09LCBk ZXN0aW5hdGlvbik7CiAgICAgICAgIHRlc3QtPmNyZWF0ZWREZXN0aW5hdGlvbihkb3dubG9hZCwg ZGVzdGluYXRpb24pOwotICAgICAgICByZXR1cm4gVFJVRTsKICAgICB9CiAKLSAgICBzdGF0aWMg Z2Jvb2xlYW4gcmVjZWl2ZWREYXRhQ2FsbGJhY2soV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBn dWludDY0IGRhdGFMZW5ndGgsIERvd25sb2FkVGVzdCogdGVzdCkKKyAgICBzdGF0aWMgdm9pZCBy ZWNlaXZlZERhdGFDYWxsYmFjayhXZWJLaXREb3dubG9hZCogZG93bmxvYWQsIGd1aW50NjQgZGF0 YUxlbmd0aCwgRG93bmxvYWRUZXN0KiB0ZXN0KQogICAgIHsKICAgICAgICAgdGVzdC0+cmVjZWl2 ZWREYXRhKGRvd25sb2FkLCBkYXRhTGVuZ3RoKTsKLSAgICAgICAgcmV0dXJuIFRSVUU7CiAgICAg fQogCi0gICAgc3RhdGljIGdib29sZWFuIGZpbmlzaGVkQ2FsbGJhY2soV2ViS2l0RG93bmxvYWQq IGRvd25sb2FkLCBEb3dubG9hZFRlc3QqIHRlc3QpCisgICAgc3RhdGljIHZvaWQgZmluaXNoZWRD YWxsYmFjayhXZWJLaXREb3dubG9hZCogZG93bmxvYWQsIERvd25sb2FkVGVzdCogdGVzdCkKICAg ICB7CiAgICAgICAgIHRlc3QtPmZpbmlzaGVkKGRvd25sb2FkKTsKLSAgICAgICAgcmV0dXJuIFRS VUU7CiAgICAgfQogCi0gICAgc3RhdGljIGdib29sZWFuIGZhaWxlZENhbGxiYWNrKFdlYktpdERv d25sb2FkKiBkb3dubG9hZCwgR0Vycm9yKiBlcnJvciwgRG93bmxvYWRUZXN0KiB0ZXN0KQorICAg IHN0YXRpYyB2b2lkIGZhaWxlZENhbGxiYWNrKFdlYktpdERvd25sb2FkKiBkb3dubG9hZCwgR0Vy cm9yKiBlcnJvciwgRG93bmxvYWRUZXN0KiB0ZXN0KQogICAgIHsKICAgICAgICAgZ19hc3NlcnQo ZXJyb3IpOwogICAgICAgICB0ZXN0LT5mYWlsZWQoZG93bmxvYWQsIGVycm9yKTsKLSAgICAgICAg cmV0dXJuIFRSVUU7CiAgICAgfQogCiAgICAgc3RhdGljIGdib29sZWFuIGRlY2lkZURlc3RpbmF0 aW9uQ2FsbGJhY2soV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBjb25zdCBnY2hhciogc3VnZ2Vz dGVkRmlsZW5hbWUsIERvd25sb2FkVGVzdCogdGVzdCkK