126735 2014-01-09 21:53:02 -0800 Fix a build break on EFL debug build 2014-01-09 22:18:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim oldest_to_newest 966223 0 gyuyoung.kim 2014-01-09 21:53:02 -0800 There is a build error when compiling EFL debug build. [ 14%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o /home/gyuyoung/webkit/WebKit/Source/WebCore/platform/ThreadTimers.cpp: In member function ‘void WebCore::ThreadTimers::sharedTimerFiredInternal()’: /home/gyuyoung/webkit/WebKit/Source/WebCore/platform/ThreadTimers.cpp:112:5: error: suggest parentheses around ‘&&’ within ‘||’ [-Werror=parentheses] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/ThreadTimers.cpp.o] Error 1 make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 966224 1 220801 gyuyoung.kim 2014-01-09 21:57:36 -0800 Created attachment 220801 Patch 966225 2 220801 andersca 2014-01-09 22:10:15 -0800 Comment on attachment 220801 Patch Patch looks good since it doesn't change the meaning, but this makes me wonder what the assertion is there for at all! 966227 3 220801 gyuyoung.kim 2014-01-09 22:18:21 -0800 Comment on attachment 220801 Patch Clearing flags on attachment: 220801 Committed r161621: <http://trac.webkit.org/changeset/161621> 966228 4 gyuyoung.kim 2014-01-09 22:18:27 -0800 All reviewed patches have been landed. Closing bug. 220801 2014-01-09 21:57:36 -0800 2014-01-09 22:18:20 -0800 Patch bug-126735-20140110145734.patch text/plain 1331 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTY3NDg0YWFkZTgyZmRl NThhNTkxNWM4NDA1ZWY2ZDAxYzNlNTYzZi4uMGMyOTI5NzFjYjJmZTMxNzdjOTFiYmYyNDg5MWU3 ODM3NmE3NDA5MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTAxLTA5ICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgRml4IGEgYnVp bGQgYnJlYWsgb24gRUZMIGRlYnVnIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY3MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgYnVpbGQgZml4LgorCisgICAg ICAgICogcGxhdGZvcm0vVGhyZWFkVGltZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRocmVh ZFRpbWVyczo6c2hhcmVkVGltZXJGaXJlZEludGVybmFsKTogIEFkZCBwYXJlbnRoZXNlcy4KKwog MjAxNC0wMS0wOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQgV2luZG93cyBidWlsZCBmaXggZm9yIHIxNjE1NjMuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UaHJlYWRUaW1lcnMuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vVGhyZWFkVGltZXJzLmNwcAppbmRleCA3ODkzNzhjZTNmZWI0ZTNiMGNjZjQw Yjc1N2JmNTNmMThjYzUzOTMzLi44ZTFhZTg2ZmQ3NDlmZGY3MmZhNzkxNjExYjZlMmU2OWNiNmRl NjExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9UaHJlYWRUaW1lcnMuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RocmVhZFRpbWVycy5jcHAKQEAgLTEwOSw3 ICsxMDksNyBAQCB2b2lkIFRocmVhZFRpbWVyczo6c2hhcmVkVGltZXJGaXJlZCgpCiAKIHZvaWQg VGhyZWFkVGltZXJzOjpzaGFyZWRUaW1lckZpcmVkSW50ZXJuYWwoKQogewotICAgIEFTU0VSVChp c01haW5UaHJlYWQoKSB8fCAhaXNXZWJUaHJlYWQoKSAmJiAhaXNVSVRocmVhZCgpKTsKKyAgICBB U1NFUlQoaXNNYWluVGhyZWFkKCkgfHwgKCFpc1dlYlRocmVhZCgpICYmICFpc1VJVGhyZWFkKCkp KTsKICAgICAvLyBEbyBhIHJlLWVudHJhbmN5IGNoZWNrLgogICAgIGlmIChtX2ZpcmluZ1RpbWVy cykKICAgICAgICAgcmV0dXJuOwo=