126723 2014-01-09 15:25:01 -0800 [EFL] Change test font installed path to webkitgtk-font-tests 2014-01-15 01:51:01 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 changseok changseok bunhere commit-queue gustavo gyuyoung.kim gyuyoung.kim lucas.de.marchi mrobinson rakuco oldest_to_newest 966095 0 changseok 2014-01-09 15:25:01 -0800 I'd like to bump up webkitgtk-font-tests to 0.0.4 and accordingly change the installed directory to 'webkitgtk-font-tests' like gtk port does. I think it would help to reduce maintenance efforts for both gtk and efl ports. 966096 1 220775 changseok 2014-01-09 15:30:52 -0800 Created attachment 220775 Patch 966147 2 gyuyoung.kim 2014-01-09 17:17:42 -0800 Isn't there any regression on EFL layout test ? We SHOULD check if there is any layout test failure in EFL layout test before updating font. 966279 3 changseok 2014-01-10 01:14:15 -0800 (In reply to comment #2) > Isn't there any regression on EFL layout test ? We SHOULD check if there is any layout test failure in EFL layout test before updating font. I don't think this change makes anything worse and actually it did. 966285 4 gyuyoung.kim 2014-01-10 01:29:04 -0800 (In reply to comment #3) > (In reply to comment #2) > > Isn't there any regression on EFL layout test ? We SHOULD check if there is any layout test failure in EFL layout test before updating font. > > I don't think this change makes anything worse and actually it did. I mean we need to make sure if there isn't any failure when using 0.4 ver. instead of 0.3. Did you run whole EFL layout test with 0.0.4 ver. ? Isn't there any additional failure between with 0.3 and 0.4 when you run whole EFL layout test ? As you may know, test font affects layout test result. 966372 5 changseok 2014-01-10 08:24:07 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Isn't there any regression on EFL layout test ? We SHOULD check if there is any layout test failure in EFL layout test before updating font. > > > > I don't think this change makes anything worse and actually it did. > > I mean we need to make sure if there isn't any failure when using 0.4 ver. instead of 0.3. Did you run whole EFL layout test with 0.0.4 ver. ? Isn't there any additional failure between with 0.3 and 0.4 when you run whole EFL layout test ? As you may know, test font affects layout test result. Doesn't efl bot check regressions? If this hurts something, it doesn't make sense that efl EWS bots show green. Bumping webkitgtk-test-fonts up doesn't mean changing the test font itself. Saying over, I believe nothing hurt. If you find something wrong, you can simply revert it. BEFORE : 25705 tests ran as expected, 6832 didn't AFTER : 25705 tests ran as expected, 6829 didn't 967177 6 changseok 2014-01-12 23:58:17 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Isn't there any regression on EFL layout test ? We SHOULD check if there is any layout test failure in EFL layout test before updating font. > > > > I don't think this change makes anything worse and actually it did. > > I mean we need to make sure if there isn't any failure when using 0.4 ver. instead of 0.3. Did you run whole EFL layout test with 0.0.4 ver. ? Isn't there any additional failure between with 0.3 and 0.4 when you run whole EFL layout test ? As you may know, test font affects layout test result. Well. if bumping the version makes you be concerned, I don't mind if this bug deals with only changing the installed path from webkitgtk-test-fonts-0.0.3 to webkitgtk-test-fonts. Different path name is really cumbersome when switching between gtk and efl... 967268 7 gyuyoung.kim 2014-01-13 06:06:29 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > Isn't there any regression on EFL layout test ? We SHOULD check if there is any layout test failure in EFL layout test before updating font. > > > > > > I don't think this change makes anything worse and actually it did. > > > > I mean we need to make sure if there isn't any failure when using 0.4 ver. instead of 0.3. Did you run whole EFL layout test with 0.0.4 ver. ? Isn't there any additional failure between with 0.3 and 0.4 when you run whole EFL layout test ? As you may know, test font affects layout test result. > > Doesn't efl bot check regressions? If this hurts something, it doesn't make sense that efl EWS bots show green. Bumping webkitgtk-test-fonts up doesn't mean changing the test font itself. Saying over, I believe nothing hurt. If you find something wrong, you can simply revert it. The layout test on buildbot exists to find regression whenever landing a commit. However, we SHOULD not land any patch if we find or know any possibility that can make any fault or regression. In this case, I think we should check if this test font can influence on EFL layout test. Because we're able to be enough to suspect this change can influence on EFL layout test. That's why I concerned this patch. > BEFORE : 25705 tests ran as expected, 6832 didn't > AFTER : 25705 tests ran as expected, 6829 didn't Test result looks good. 967269 8 gyuyoung.kim 2014-01-13 06:11:05 -0800 (In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #2) > > > > Isn't there any regression on EFL layout test ? We SHOULD check if there is any layout test failure in EFL layout test before updating font. > > > > > > I don't think this change makes anything worse and actually it did. > > > > I mean we need to make sure if there isn't any failure when using 0.4 ver. instead of 0.3. Did you run whole EFL layout test with 0.0.4 ver. ? Isn't there any additional failure between with 0.3 and 0.4 when you run whole EFL layout test ? As you may know, test font affects layout test result. > > Well. if bumping the version makes you be concerned, I didn't concern to bump test font. I just concerned that we bump the test font without testing whole EFL layout test. 967718 9 221124 changseok 2014-01-14 01:45:16 -0800 Created attachment 221124 Patch 967730 10 221124 gyuyoung.kim 2014-01-14 02:17:49 -0800 Comment on attachment 221124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221124&action=review > Tools/ChangeLog:9 > + to 'webkitgtk-test-fonts' like gtk port. I believe it would help to reduce I don't see why this can reduce maintenance cost. How ? I'm starting to get frustrated with these patch. You don't seem to understand what we're doing here. 967784 11 221124 changseok 2014-01-14 05:49:34 -0800 Comment on attachment 221124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221124&action=review >> Tools/ChangeLog:9 >> + to 'webkitgtk-test-fonts' like gtk port. I believe it would help to reduce > > I don't see why this can reduce maintenance cost. How ? > I'm starting to get frustrated with these patch. You don't seem to understand what we're doing here. Because we have to reset webkit test fonts path to fit that of each ports everytime when switching them, though efl and gtk use same source. Indeed, I think using webkitgtk-test-fonts-0.0.3 is wrong since DumpRenderTree and efl is looking for the font set in "webkitgtk-test-fonts" which is hard coded. See https://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/FontManagement.cpp#L105 968161 12 221124 gyuyoung.kim 2014-01-14 20:51:16 -0800 Comment on attachment 221124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221124&action=review >>> Tools/ChangeLog:9 >>> + to 'webkitgtk-test-fonts' like gtk port. I believe it would help to reduce >> >> I don't see why this can reduce maintenance cost. How ? >> I'm starting to get frustrated with these patch. You don't seem to understand what we're doing here. > > Because we have to reset webkit test fonts path to fit that of each ports everytime when switching them, though efl and gtk use same source. Indeed, I think using webkitgtk-test-fonts-0.0.3 is wrong since DumpRenderTree and efl is looking for the font set in "webkitgtk-test-fonts" which is hard coded. See https://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/FontManagement.cpp#L105 My stance focuses on maintenance cost. I don't think we can share the test font when switching between efl and gtk. Because, IIRC, we can't build EFL(or GTK port) port by only using "--update-efl" option without removing "WebKitBuild/Dependencies of GTK". There were some conflicts. So, we need to download dependent libraries(the test font is also included the download list) again when switching from GTK port. That's why I think there is no benefit to reduce maintenance cost. (If it is possible, I wouldn't prefer to keep each port dependencies in same directory.) I don't mind to rename the test font directory. But, I don't agree there will be big benefit from the maintenance cost perspective. 968186 13 221124 changseok 2014-01-14 23:12:05 -0800 Comment on attachment 221124 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221124&action=review >>>> Tools/ChangeLog:9 >>>> + to 'webkitgtk-test-fonts' like gtk port. I believe it would help to reduce >>> >>> I don't see why this can reduce maintenance cost. How ? >>> I'm starting to get frustrated with these patch. You don't seem to understand what we're doing here. >> >> Because we have to reset webkit test fonts path to fit that of each ports everytime when switching them, though efl and gtk use same source. Indeed, I think using webkitgtk-test-fonts-0.0.3 is wrong since DumpRenderTree and efl is looking for the font set in "webkitgtk-test-fonts" which is hard coded. See https://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/FontManagement.cpp#L105 > > My stance focuses on maintenance cost. I don't think we can share the test font when switching between efl and gtk. Because, IIRC, we can't build EFL(or GTK port) port by only using "--update-efl" option without removing "WebKitBuild/Dependencies of GTK". There were some conflicts. So, we need to download dependent libraries(the test font is also included the download list) again when switching from GTK port. That's why I think there is no benefit to reduce maintenance cost. (If it is possible, I wouldn't prefer to keep each port dependencies in same directory.) I don't mind to rename the test font directory. But, I don't agree there will be big benefit from the maintenance cost perspective. Yes it's possible through extra jhbuild.module files! So we don't need to build whole dependencies duplicated twice and also don't need to rebuild. One remained thing is to modify test fonts path to meet each ports requirement whenever we should run layout test. I believe this is definitely wasting of time. One more thing to tell you is actually this patch is not intended to keep both ports dependencies in same directory. just intended to change the path to install test fonts and it would correct the path to fit hard coded one for efl port. 968198 14 221235 changseok 2014-01-15 00:24:38 -0800 Created attachment 221235 Patch 968207 15 gyuyoung.kim 2014-01-15 01:16:18 -0800 I agree to fix a wrong font path for DRT. However, I'm not sure we can say now we reduce maintenance cost with unofficial jhbuild file which isn't upstream. 968211 16 changseok 2014-01-15 01:23:24 -0800 (In reply to comment #15) > I agree to fix a wrong font path for DRT. However, I'm not sure we can say now we reduce maintenance cost with unofficial jhbuild file which isn't upstream. Thanks for the r+, this change saves my huge time, though you may not take any benefit for the maintenance const. ;) 968224 17 221235 commit-queue 2014-01-15 01:50:58 -0800 Comment on attachment 221235 Patch Clearing flags on attachment: 221235 Committed r162060: <http://trac.webkit.org/changeset/162060> 968225 18 commit-queue 2014-01-15 01:51:01 -0800 All reviewed patches have been landed. Closing bug. 220775 2014-01-09 15:30:52 -0800 2014-01-14 01:45:09 -0800 Patch bug-126723-20140110083050.patch text/plain 3738 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNTc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYmExNDMzODA2Yjg2ZDdkZjk1Y2FiZDNlYWNmNTI2MWY1 MTExMTI0Ni4uYTYxYTM5NzkxYjg2MGEyNDQ0MzU2NzNmMGU4MmEyZGQ3MTE3NzQxYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAxLTA5ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbRUZMXSBCdW1wIHdlYmtpdGd0ay1mb250LXRlc3RzIHRvIDAuMC40Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY3MjMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJJ2QgbGlrZSB0 byBidW1wIHVwIHdlYmtpdGd0ay1mb250LXRlc3RzIHRvIDAuMC40IGFuZCBhY2NvcmRpbmdseSBj aGFuZ2UKKyAgICAgICAgdGhlIGluc3RhbGxlZCBkaXJlY3RvcnkgdG8gJ3dlYmtpdGd0ay1mb250 LXRlc3RzJyBsaWtlIGd0ayBwb3J0IGRvZXMuCisgICAgICAgIEkgdGhpbmsgaXQgd291bGQgaGVs cCB0byByZWR1Y2UgbWFpbnRlbmFuY2UgZWZmb3J0cyBmb3IgYm90aCBndGsgYW5kIGVmbCBwb3J0 cy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlOgorICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1FZmwuY21ha2U6CisgICAgICAgICogZWZsL2po YnVpbGQubW9kdWxlczoKKwogMjAxNC0wMS0wOSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUu Y29tPgogCiAgICAgICAgIFtDb2NvYV0gUHJvbW90ZSBXS0JhY2tGb3J3YXJkTGlzdHssSXRlbX0u aCB0byBwdWJsaWMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZs LmNtYWtlIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1FZmwuY21ha2UKaW5kZXggZDc1 MWJjODc0ODhmYmNhMmMxMjIwMGY3MzY3MzVmZmY0MTYzZjRkMy4uYjlkZTJmOGZhMjIwOTgyYjc4 NTE3MzNlZjAxMjI4NmRhYjc0M2QzNyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUv UGxhdGZvcm1FZmwuY21ha2UKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1FZmwu Y21ha2UKQEAgLTc3LDQgKzc3LDQgQEAgZW5kaWYgKCkKICMgRklYTUU6IERPV05MT0FERURfRk9O VFNfRElSIHNob3VsZCBub3QgaGFyZGNvZGUgdGhlIGRpcmVjdG9yeQogIyBzdHJ1Y3R1cmUuIFNl ZSA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDc1Pi4KIGFkZF9k ZWZpbml0aW9ucygtREZPTlRTX0NPTkZfRElSPSIke1RPT0xTX0RJUn0vRHVtcFJlbmRlclRyZWUv Z3RrL2ZvbnRzIgotICAgICAgICAgICAgICAgIC1ERE9XTkxPQURFRF9GT05UU19ESVI9IiR7Q01B S0VfU09VUkNFX0RJUn0vV2ViS2l0QnVpbGQvRGVwZW5kZW5jaWVzL1NvdXJjZS93ZWJraXRndGst dGVzdC1mb250cy0wLjAuMyIpCisgICAgICAgICAgICAgICAgLURET1dOTE9BREVEX0ZPTlRTX0RJ Uj0iJHtDTUFLRV9TT1VSQ0VfRElSfS9XZWJLaXRCdWlsZC9EZXBlbmRlbmNpZXMvU291cmNlL3dl YmtpdGd0ay10ZXN0LWZvbnRzIikKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv UGxhdGZvcm1FZmwuY21ha2UgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtRWZsLmNt YWtlCmluZGV4IDE4MThhNWQzMjg4MWMxN2FkNmQxNjcyMzJkN2NhZWNiYzI3YmRmMDQuLmZiYWFm ZGU2YmFjNTI5MmMzNTdkNWZiNzc3MmYxNDQzNzc0NTM5MTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvUGxhdGZvcm1FZmwuY21ha2UKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9QbGF0Zm9ybUVmbC5jbWFrZQpAQCAtNzgsNyArNzgsNyBAQCBsaXN0KEFQUEVORCBXZWJL aXRUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGVfU09VUkNFUwogIyBGSVhNRTogRE9XTkxPQURFRF9G T05UU19ESVIgc2hvdWxkIG5vdCBoYXJkY29kZSB0aGUgZGlyZWN0b3J5CiAjIHN0cnVjdHVyZS4g U2VlIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODE0NzU+LgogYWRk X2RlZmluaXRpb25zKC1ERk9OVFNfQ09ORl9ESVI9IiR7VE9PTFNfRElSfS9EdW1wUmVuZGVyVHJl ZS9ndGsvZm9udHMiCi0gICAgICAgICAgICAgICAgLURET1dOTE9BREVEX0ZPTlRTX0RJUj0iJHtD TUFLRV9TT1VSQ0VfRElSfS9XZWJLaXRCdWlsZC9EZXBlbmRlbmNpZXMvU291cmNlL3dlYmtpdGd0 ay10ZXN0LWZvbnRzLTAuMC4zIikKKyAgICAgICAgICAgICAgICAtRERPV05MT0FERURfRk9OVFNf RElSPSIke0NNQUtFX1NPVVJDRV9ESVJ9L1dlYktpdEJ1aWxkL0RlcGVuZGVuY2llcy9Tb3VyY2Uv d2Via2l0Z3RrLXRlc3QtZm9udHMiKQogCiBpZiAoRU5BQkxFX0FDQ0VTU0lCSUxJVFkpCiAgICAg bGlzdChBUFBFTkQgV2ViS2l0VGVzdFJ1bm5lcl9JTkNMVURFX0RJUkVDVE9SSUVTCmRpZmYgLS1n aXQgYS9Ub29scy9lZmwvamhidWlsZC5tb2R1bGVzIGIvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxl cwppbmRleCBiZDUxZGY5ZjU2YjRmNmEwODZmZDhlMzJlNDViNmRjZWIzNTZkN2QwLi4yNDdjNTUy NTg3Y2ZiMWRlOWQ3OTIxMTU2YjI0YzZkNTMzY2IyOTM5IDEwMDY0NAotLS0gYS9Ub29scy9lZmwv amhidWlsZC5tb2R1bGVzCisrKyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKQEAgLTI5LDgg KzI5LDggQEAKICAgICA8L2RlcGVuZGVuY2llcz4KICAgPC9tZXRhbW9kdWxlPgogCi0gIDxyZXBv c2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9ImdpdGh1Yi5jb20iCi0gICAgICBocmVmPSJodHRw czovL2dpdGh1Yi5jb20iLz4KKyAgPHJlcG9zaXRvcnkgdHlwZT0iZ2l0IiBuYW1lPSJnaXRodWIu Y29tIgorICAgICAgaHJlZj0iZ2l0Oi8vZ2l0aHViLmNvbSIvPgogICA8cmVwb3NpdG9yeSB0eXBl PSJ0YXJiYWxsIiBuYW1lPSJzb3VyY2V3YXJlLm9yZyIKICAgICAgIGhyZWY9ImZ0cDovL3NvdXJj ZXdhcmUub3JnIi8+CiAgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9ImZ0cC5nbm9t ZS5vcmciCkBAIC03NiwxMSArNzYsNyBAQAogCiAgIDxhdXRvdG9vbHMgaWQ9ImZvbnRzIgogICAg ICAgICAgICAgIHNraXAtYXV0b2dlbj0idHJ1ZSI+Ci0gICAgPGJyYW5jaCBtb2R1bGU9ImRvd25s b2Fkcy9tcm9iaW5zb24vd2Via2l0Z3RrLXRlc3QtZm9udHMvd2Via2l0Z3RrLXRlc3QtZm9udHMt MC4wLjMudGFyLmd6IiB2ZXJzaW9uPSIwLjAuMyIKLSAgICAgICAgICAgIHJlcG89ImdpdGh1Yi5j b20iCi0gICAgICAgICAgICBoYXNoPSJzaGEyNTY6NGEwYTAxZjAwODU1OTk3Y2RjYzcyMDFmMTY0 YjMzYTRlNDE0NGU4ZWFkZjQwYTVlNTQyYTFjNDQ4ZTAzNWRlNSIKLSAgICAgICAgICAgIG1kNXN1 bT0iMTBlNzRkZTFhOGJhOTYxZDkwMzc5OTRkNDI3YjFkZDIiIHNpemU9IjE2OTgxNjQyIj4KLSAg ICA8L2JyYW5jaD4KKyAgICA8YnJhbmNoIHJlcG89ImdpdGh1Yi5jb20iIG1vZHVsZT0ibXJvYmlu c29uL3dlYmtpdGd0ay10ZXN0LWZvbnRzLmdpdCIgY2hlY2tvdXRkaXI9IndlYmtpdGd0ay10ZXN0 LWZvbnRzIiB0YWc9IjAuMC40Ii8+CiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMgaWQ9 ImxpYmZmaSIgYXV0b2dlbi1zaD0iY29uZmlndXJlIj4K 221124 2014-01-14 01:45:16 -0800 2014-01-15 00:24:32 -0800 Patch bug-126723-20140114184514.patch text/plain 3207 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxOTUxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWI5ZDMzMmMwOTlmNjM5MzY3NjcxYzA0MTExYzdhM2Jh Mzg3YWJjZS4uN2ZhNGUzYmY5MmJmZGI5MTE4OWRmODg3MjM1MWQxZWQzMDY5NjAyMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAxLTEzICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbRUZMXSBDaGFuZ2UgdGVzdCBmb250IGluc3RhbGxlZCBwYXRoIHRvIHdl YmtpdGd0ay1mb250LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjY3MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJJ2QgbGlrZSB0byBjaGFuZ2UgdGhlIGluc3RhbGxlZCBkaXJlY3RvcnkgZnJv bSAnd2Via2l0Z3RrLXRlc3QtZm9udHMtMC4wLjMnCisgICAgICAgIHRvICd3ZWJraXRndGstdGVz dC1mb250cycgbGlrZSBndGsgcG9ydC4gSSBiZWxpZXZlIGl0IHdvdWxkIGhlbHAgdG8gcmVkdWNl CisgICAgICAgIG1haW50ZW5hbmNlIGVmZm9ydHMgZm9yIGJvdGggcG9ydHMuCisKKyAgICAgICAg KiBEdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybUVmbC5jbWFrZToKKyAgICAgICAgKiBXZWJLaXRUZXN0 UnVubmVyL1BsYXRmb3JtRWZsLmNtYWtlOgorICAgICAgICAqIGVmbC9qaGJ1aWxkLm1vZHVsZXM6 CisKIDIwMTQtMDEtMTMgIEx1Y2FzIEZvcnNjaGxlciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tPgog CiAgICAgICAgIFVwZGF0ZSB0aGUgTExJTlQgQ0xvb3AgQm90IGJ1aWxkIGluZnJhc3RydWN0dXJl CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybUVmbC5jbWFrZSBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGQ3NTFiYzg3NDg4ZmJj YTJjMTIyMDBmNzM2NzM1ZmZmNDE2M2Y0ZDMuLmI5ZGUyZjhmYTIyMDk4MmI3ODUxNzMzZWYwMTIy ODZkYWI3NDNkMzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZs LmNtYWtlCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlCkBAIC03 Nyw0ICs3Nyw0IEBAIGVuZGlmICgpCiAjIEZJWE1FOiBET1dOTE9BREVEX0ZPTlRTX0RJUiBzaG91 bGQgbm90IGhhcmRjb2RlIHRoZSBkaXJlY3RvcnkKICMgc3RydWN0dXJlLiBTZWUgPGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTQ3NT4uCiBhZGRfZGVmaW5pdGlvbnMo LURGT05UU19DT05GX0RJUj0iJHtUT09MU19ESVJ9L0R1bXBSZW5kZXJUcmVlL2d0ay9mb250cyIK LSAgICAgICAgICAgICAgICAtRERPV05MT0FERURfRk9OVFNfRElSPSIke0NNQUtFX1NPVVJDRV9E SVJ9L1dlYktpdEJ1aWxkL0RlcGVuZGVuY2llcy9Tb3VyY2Uvd2Via2l0Z3RrLXRlc3QtZm9udHMt MC4wLjMiKQorICAgICAgICAgICAgICAgIC1ERE9XTkxPQURFRF9GT05UU19ESVI9IiR7Q01BS0Vf U09VUkNFX0RJUn0vV2ViS2l0QnVpbGQvRGVwZW5kZW5jaWVzL1NvdXJjZS93ZWJraXRndGstdGVz dC1mb250cyIpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRmb3JtRWZs LmNtYWtlIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybUVmbC5jbWFrZQppbmRleCAx ODE4YTVkMzI4ODFjMTdhZDZkMTY3MjMyZDdjYWVjYmMyN2JkZjA0Li5mYmFhZmRlNmJhYzUyOTJj MzU3ZDVmYjc3NzJmMTQ0Mzc3NDUzOTE2IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVu bmVyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvUGxhdGZv cm1FZmwuY21ha2UKQEAgLTc4LDcgKzc4LDcgQEAgbGlzdChBUFBFTkQgV2ViS2l0VGVzdFJ1bm5l ckluamVjdGVkQnVuZGxlX1NPVVJDRVMKICMgRklYTUU6IERPV05MT0FERURfRk9OVFNfRElSIHNo b3VsZCBub3QgaGFyZGNvZGUgdGhlIGRpcmVjdG9yeQogIyBzdHJ1Y3R1cmUuIFNlZSA8aHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDc1Pi4KIGFkZF9kZWZpbml0aW9u cygtREZPTlRTX0NPTkZfRElSPSIke1RPT0xTX0RJUn0vRHVtcFJlbmRlclRyZWUvZ3RrL2ZvbnRz IgotICAgICAgICAgICAgICAgIC1ERE9XTkxPQURFRF9GT05UU19ESVI9IiR7Q01BS0VfU09VUkNF X0RJUn0vV2ViS2l0QnVpbGQvRGVwZW5kZW5jaWVzL1NvdXJjZS93ZWJraXRndGstdGVzdC1mb250 cy0wLjAuMyIpCisgICAgICAgICAgICAgICAgLURET1dOTE9BREVEX0ZPTlRTX0RJUj0iJHtDTUFL RV9TT1VSQ0VfRElSfS9XZWJLaXRCdWlsZC9EZXBlbmRlbmNpZXMvU291cmNlL3dlYmtpdGd0ay10 ZXN0LWZvbnRzIikKIAogaWYgKEVOQUJMRV9BQ0NFU1NJQklMSVRZKQogICAgIGxpc3QoQVBQRU5E IFdlYktpdFRlc3RSdW5uZXJfSU5DTFVERV9ESVJFQ1RPUklFUwpkaWZmIC0tZ2l0IGEvVG9vbHMv ZWZsL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggYmQ1 MWRmOWY1NmI0ZjZhMDg2ZmQ4ZTMyZTQ1YjZkY2ViMzU2ZDdkMC4uNTUwZDMzM2U4ZmRkMDcxZjA0 ODU5ZjU0NGViNGMxZDk4NzY0NmYyZCAxMDA2NDQKLS0tIGEvVG9vbHMvZWZsL2poYnVpbGQubW9k dWxlcworKysgYi9Ub29scy9lZmwvamhidWlsZC5tb2R1bGVzCkBAIC03Nyw2ICs3Nyw3IEBACiAg IDxhdXRvdG9vbHMgaWQ9ImZvbnRzIgogICAgICAgICAgICAgIHNraXAtYXV0b2dlbj0idHJ1ZSI+ CiAgICAgPGJyYW5jaCBtb2R1bGU9ImRvd25sb2Fkcy9tcm9iaW5zb24vd2Via2l0Z3RrLXRlc3Qt Zm9udHMvd2Via2l0Z3RrLXRlc3QtZm9udHMtMC4wLjMudGFyLmd6IiB2ZXJzaW9uPSIwLjAuMyIK KyAgICAgICAgICAgIGNoZWNrb3V0ZGlyPSJ3ZWJraXRndGstdGVzdC1mb250cyIKICAgICAgICAg ICAgIHJlcG89ImdpdGh1Yi5jb20iCiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6NGEwYTAxZjAw ODU1OTk3Y2RjYzcyMDFmMTY0YjMzYTRlNDE0NGU4ZWFkZjQwYTVlNTQyYTFjNDQ4ZTAzNWRlNSIK ICAgICAgICAgICAgIG1kNXN1bT0iMTBlNzRkZTFhOGJhOTYxZDkwMzc5OTRkNDI3YjFkZDIiIHNp emU9IjE2OTgxNjQyIj4K 221235 2014-01-15 00:24:38 -0800 2014-01-15 01:50:57 -0800 Patch bug-126723-20140115172437.patch text/plain 3213 changseok U3VidmVyc2lvbiBSZXZpc2lvbjogMTYyMDU4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGNmNzkyODgzOTg3OTdkMDg3YWJiMDI4MWI0ZWY4NzFl ODQ4M2RhZS4uZDIwZjk0YWFjOGUyYTIwODI1Yzc1Mjc0ZTkwOThhNzE1OTQ5NzhmMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTAxLTE1ICBDaGFuZ1Nlb2sgT2ggIDxjaGFuZ3Nlb2sub2hAY29sbGFib3JhLmNv bT4KKworICAgICAgICBbRUZMXSBDaGFuZ2UgdGVzdCBmb250IGluc3RhbGxlZCBwYXRoIHRvIHdl YmtpdGd0ay1mb250LXRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMjY3MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBJJ2QgbGlrZSB0byBjaGFuZ2UgdGhlIHRlc3QgZm9udHMgaW5zdGFsbGVkIGRp cmVjdG9yeSBmcm9tICd3ZWJraXRndGstdGVzdC1mb250cy0wLjAuMycKKyAgICAgICAgdG8gJ3dl YmtpdGd0ay10ZXN0LWZvbnRzJy4gd2Via2l0Z3RrLXRlc3QtZm9udHMtMC4wLjMgZG9lc24ndCBt YXRjaCB0aGUgcGF0aAorICAgICAgICBoYXJkLWNvZGVkIGluIEZvbnRNYW5hZ2VtZW50LmNwcCMx MDUKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlOgorICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvUGxhdGZvcm1FZmwuY21ha2U6CisgICAgICAgICogZWZsL2po YnVpbGQubW9kdWxlczoKKwogMjAxNC0wMS0xNCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0 Lm9yZz4KIAogICAgICAgICBNYWtlIERvWW91RXZlbkJlbmNoIHJ1bm5hYmxlIGJ5IHJ1bi1wZXJm LXRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybUVmbC5jbWFr ZSBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtlCmluZGV4IGQ3NTFiYzg3 NDg4ZmJjYTJjMTIyMDBmNzM2NzM1ZmZmNDE2M2Y0ZDMuLmI5ZGUyZjhmYTIyMDk4MmI3ODUxNzMz ZWYwMTIyODZkYWI3NDNkMzcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRm b3JtRWZsLmNtYWtlCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtRWZsLmNtYWtl CkBAIC03Nyw0ICs3Nyw0IEBAIGVuZGlmICgpCiAjIEZJWE1FOiBET1dOTE9BREVEX0ZPTlRTX0RJ UiBzaG91bGQgbm90IGhhcmRjb2RlIHRoZSBkaXJlY3RvcnkKICMgc3RydWN0dXJlLiBTZWUgPGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MTQ3NT4uCiBhZGRfZGVmaW5p dGlvbnMoLURGT05UU19DT05GX0RJUj0iJHtUT09MU19ESVJ9L0R1bXBSZW5kZXJUcmVlL2d0ay9m b250cyIKLSAgICAgICAgICAgICAgICAtRERPV05MT0FERURfRk9OVFNfRElSPSIke0NNQUtFX1NP VVJDRV9ESVJ9L1dlYktpdEJ1aWxkL0RlcGVuZGVuY2llcy9Tb3VyY2Uvd2Via2l0Z3RrLXRlc3Qt Zm9udHMtMC4wLjMiKQorICAgICAgICAgICAgICAgIC1ERE9XTkxPQURFRF9GT05UU19ESVI9IiR7 Q01BS0VfU09VUkNFX0RJUn0vV2ViS2l0QnVpbGQvRGVwZW5kZW5jaWVzL1NvdXJjZS93ZWJraXRn dGstdGVzdC1mb250cyIpCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1BsYXRm b3JtRWZsLmNtYWtlIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9QbGF0Zm9ybUVmbC5jbWFrZQpp bmRleCAxODE4YTVkMzI4ODFjMTdhZDZkMTY3MjMyZDdjYWVjYmMyN2JkZjA0Li5mYmFhZmRlNmJh YzUyOTJjMzU3ZDVmYjc3NzJmMTQ0Mzc3NDUzOTE2IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL1BsYXRmb3JtRWZsLmNtYWtlCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv UGxhdGZvcm1FZmwuY21ha2UKQEAgLTc4LDcgKzc4LDcgQEAgbGlzdChBUFBFTkQgV2ViS2l0VGVz dFJ1bm5lckluamVjdGVkQnVuZGxlX1NPVVJDRVMKICMgRklYTUU6IERPV05MT0FERURfRk9OVFNf RElSIHNob3VsZCBub3QgaGFyZGNvZGUgdGhlIGRpcmVjdG9yeQogIyBzdHJ1Y3R1cmUuIFNlZSA8 aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgxNDc1Pi4KIGFkZF9kZWZp bml0aW9ucygtREZPTlRTX0NPTkZfRElSPSIke1RPT0xTX0RJUn0vRHVtcFJlbmRlclRyZWUvZ3Rr L2ZvbnRzIgotICAgICAgICAgICAgICAgIC1ERE9XTkxPQURFRF9GT05UU19ESVI9IiR7Q01BS0Vf U09VUkNFX0RJUn0vV2ViS2l0QnVpbGQvRGVwZW5kZW5jaWVzL1NvdXJjZS93ZWJraXRndGstdGVz dC1mb250cy0wLjAuMyIpCisgICAgICAgICAgICAgICAgLURET1dOTE9BREVEX0ZPTlRTX0RJUj0i JHtDTUFLRV9TT1VSQ0VfRElSfS9XZWJLaXRCdWlsZC9EZXBlbmRlbmNpZXMvU291cmNlL3dlYmtp dGd0ay10ZXN0LWZvbnRzIikKIAogaWYgKEVOQUJMRV9BQ0NFU1NJQklMSVRZKQogICAgIGxpc3Qo QVBQRU5EIFdlYktpdFRlc3RSdW5uZXJfSU5DTFVERV9ESVJFQ1RPUklFUwpkaWZmIC0tZ2l0IGEv VG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcyBiL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMKaW5k ZXggYmQ1MWRmOWY1NmI0ZjZhMDg2ZmQ4ZTMyZTQ1YjZkY2ViMzU2ZDdkMC4uNTUwZDMzM2U4ZmRk MDcxZjA0ODU5ZjU0NGViNGMxZDk4NzY0NmYyZCAxMDA2NDQKLS0tIGEvVG9vbHMvZWZsL2poYnVp bGQubW9kdWxlcworKysgYi9Ub29scy9lZmwvamhidWlsZC5tb2R1bGVzCkBAIC03Nyw2ICs3Nyw3 IEBACiAgIDxhdXRvdG9vbHMgaWQ9ImZvbnRzIgogICAgICAgICAgICAgIHNraXAtYXV0b2dlbj0i dHJ1ZSI+CiAgICAgPGJyYW5jaCBtb2R1bGU9ImRvd25sb2Fkcy9tcm9iaW5zb24vd2Via2l0Z3Rr LXRlc3QtZm9udHMvd2Via2l0Z3RrLXRlc3QtZm9udHMtMC4wLjMudGFyLmd6IiB2ZXJzaW9uPSIw LjAuMyIKKyAgICAgICAgICAgIGNoZWNrb3V0ZGlyPSJ3ZWJraXRndGstdGVzdC1mb250cyIKICAg ICAgICAgICAgIHJlcG89ImdpdGh1Yi5jb20iCiAgICAgICAgICAgICBoYXNoPSJzaGEyNTY6NGEw YTAxZjAwODU1OTk3Y2RjYzcyMDFmMTY0YjMzYTRlNDE0NGU4ZWFkZjQwYTVlNTQyYTFjNDQ4ZTAz NWRlNSIKICAgICAgICAgICAgIG1kNXN1bT0iMTBlNzRkZTFhOGJhOTYxZDkwMzc5OTRkNDI3YjFk ZDIiIHNpemU9IjE2OTgxNjQyIj4K