126713 2014-01-09 12:31:08 -0800 [CSS Shapes] Change parseBasicShape to return a CSSPrimitiveValue 2014-01-10 13:09:40 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 124173 1 betravis betravis commit-queue esprehn+autocc glenn gyuyoung.kim macpherson menard oldest_to_newest 966023 0 betravis 2014-01-09 12:31:08 -0800 All calls eventually wrap the shape in a CSSPrimitiveValue, so we can clean this up by just factoring that into the function. 966255 1 220811 betravis 2014-01-09 23:33:44 -0800 Created attachment 220811 Initial Patch 966266 2 220811 krit 2014-01-09 23:59:18 -0800 Comment on attachment 220811 Initial Patch r=me 966533 3 220811 commit-queue 2014-01-10 13:09:37 -0800 Comment on attachment 220811 Initial Patch Clearing flags on attachment: 220811 Committed r161667: <http://trac.webkit.org/changeset/161667> 966534 4 commit-queue 2014-01-10 13:09:40 -0800 All reviewed patches have been landed. Closing bug. 220811 2014-01-09 23:33:44 -0800 2014-01-10 13:09:37 -0800 Initial Patch shapes-parsing.patch text/plain 4322 betravis U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNTczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzc2MzZiODA3OThjZTk4 YmJlYTA2OWZlOTcwNzE5ZTllOWI0NTRlNi4uNjFhZmRhNDZlOTVlNmQwMDAzYmYzNWExMDRmZTA5 ODljZWNlOTZkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTAxLTA5ICBCZWFy IFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KKworICAgICAgICBbQ1NTIFNoYXBlc10gQ2hh bmdlIHBhcnNlQmFzaWNTaGFwZSB0byByZXR1cm4gYSBDU1NQcmltaXRpdmVWYWx1ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NzEzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWQgdGhlIGR1cGxp Y2F0ZWQgY29kZSB3cmFwcGluZyB0aGUgQ1NTQmFzaWNTaGFwZSBpbiBhIENTU1ByaW1pdGl2ZVZh bHVlCisgICAgICAgIGJ5IGhhdmluZyBwYXJzZUJhc2ljU2hhcGUgcmV0dXJuIGEgQ1NTUHJpbWl0 aXZlVmFsdWUgcmVmZXJlbmNlLgorCisgICAgICAgIFJlZmFjdG9yaW5nLCBubyBuZXcgdGVzdHMu CisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Bh cnNlcjo6cGFyc2VTaGFwZVByb3BlcnR5KToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6 cGFyc2VDbGlwUGF0aCk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlQmFzaWNT aGFwZSk6CisgICAgICAgICogY3NzL0NTU1BhcnNlci5oOgorCiAyMDE0LTAxLTA5ICBNeWxlcyBD LiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgTmFycm93IHVuZGVy bGluZXMgYXJlIHRvbyB0YWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFy c2VyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDY4MDIxMDE4 NmE3N2EzNjI4NjQ4YjVhMjQzZTdkMzcyMjg5YmU0MzYuLjY5MTAxNmFiYjMxZWMzZjMxOGIzMWI3 MjRkMGY1MTM4Zjk4ZWExNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC01ODY2LDcg KzU4NjYsNyBAQCBQYXNzUmVmUHRyPENTU1ZhbHVlPiBDU1NQYXJzZXI6OnBhcnNlU2hhcGVQcm9w ZXJ0eShDU1NQcm9wZXJ0eUlEIHByb3BJZCkKICAgICBDU1NQYXJzZXJWYWx1ZSogdmFsdWUgPSBt X3ZhbHVlTGlzdC0+Y3VycmVudCgpOwogICAgIENTU1ZhbHVlSUQgdmFsdWVJZCA9IHZhbHVlLT5p ZDsKICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IGtleXdvcmRWYWx1ZTsKLSAgICBSZWZQ dHI8Q1NTQmFzaWNTaGFwZT4gc2hhcGVWYWx1ZTsKKyAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFs dWU+IHNoYXBlVmFsdWU7CiAKICAgICBpZiAodmFsdWVJZCA9PSBDU1NWYWx1ZU5vbmUKICAgICAg ICAgfHwgKHZhbHVlSWQgPT0gQ1NTVmFsdWVPdXRzaWRlU2hhcGUgJiYgcHJvcElkID09IENTU1By b3BlcnR5V2Via2l0U2hhcGVJbnNpZGUpKSB7CkBAIC01OTAyLDEwICs1OTAyLDEyIEBAIFBhc3NS ZWZQdHI8Q1NTVmFsdWU+IENTU1BhcnNlcjo6cGFyc2VTaGFwZVByb3BlcnR5KENTU1Byb3BlcnR5 SUQgcHJvcElkKQogICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQogCisgICAgQVNT RVJUKCFzaGFwZVZhbHVlIHx8IHNoYXBlVmFsdWUtPmlzU2hhcGUoKSk7CisKICAgICBpZiAoc2hh cGVWYWx1ZSAmJiBrZXl3b3JkVmFsdWUpCi0gICAgICAgIHNoYXBlVmFsdWUtPnNldExheW91dEJv eChrZXl3b3JkVmFsdWUucmVsZWFzZSgpKTsKKyAgICAgICAgc2hhcGVWYWx1ZS0+Z2V0U2hhcGVW YWx1ZSgpLT5zZXRMYXlvdXRCb3goa2V5d29yZFZhbHVlLnJlbGVhc2UoKSk7CiAKLSAgICByZXR1 cm4gc2hhcGVWYWx1ZSA/IGNzc1ZhbHVlUG9vbCgpLmNyZWF0ZVZhbHVlKHNoYXBlVmFsdWUucmVs ZWFzZSgpKSA6IGtleXdvcmRWYWx1ZS5yZWxlYXNlKCk7CisgICAgcmV0dXJuIHNoYXBlVmFsdWUg PyBzaGFwZVZhbHVlLnJlbGVhc2UoKSA6IGtleXdvcmRWYWx1ZS5yZWxlYXNlKCk7CiB9CiAjZW5k aWYKIApAQCAtNTkzNCwxMCArNTkzNiwxMCBAQCBQYXNzUmVmUHRyPENTU1ZhbHVlPiBDU1NQYXJz ZXI6OnBhcnNlQ2xpcFBhdGgoKQogICAgICAgICB2YWx1ZUlkID0gdmFsdWUtPmlkOwogICAgICAg ICBpZiAodmFsdWUtPnVuaXQgPT0gQ1NTUGFyc2VyVmFsdWU6OkZ1bmN0aW9uICYmICFzaGFwZUZv dW5kKSB7CiAgICAgICAgICAgICAvLyBwYXJzZUJhc2ljU2hhcGUgYWxyZWFkeSBhc2tzIGZvciB0 aGUgbmV4dCB2YWx1ZSBsaXN0IGl0ZW0uCi0gICAgICAgICAgICBSZWZQdHI8Q1NTQmFzaWNTaGFw ZT4gc2hhcGVWYWx1ZSA9IHBhcnNlQmFzaWNTaGFwZSgpOworICAgICAgICAgICAgUmVmUHRyPENT U1ByaW1pdGl2ZVZhbHVlPiBzaGFwZVZhbHVlID0gcGFyc2VCYXNpY1NoYXBlKCk7CiAgICAgICAg ICAgICBpZiAoIXNoYXBlVmFsdWUpCiAgICAgICAgICAgICAgICAgcmV0dXJuIG51bGxwdHI7Ci0g ICAgICAgICAgICBsaXN0LT5hcHBlbmQoY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUoc2hhcGVW YWx1ZS5yZWxlYXNlKCkpKTsKKyAgICAgICAgICAgIGxpc3QtPmFwcGVuZChzaGFwZVZhbHVlLnJl bGVhc2UoKSk7CiAgICAgICAgICAgICBzaGFwZUZvdW5kID0gdHJ1ZTsKICAgICAgICAgfSBlbHNl IGlmICgoaXNCb3hWYWx1ZSh2YWx1ZUlkKSB8fCB2YWx1ZUlkID09IENTU1ZhbHVlQm91bmRpbmdC b3gpICYmICFib3hGb3VuZCkgewogICAgICAgICAgICAgbGlzdC0+YXBwZW5kKHBhcnNlVmFsaWRQ cmltaXRpdmUodmFsdWVJZCwgdmFsdWUpKTsKQEAgLTU5NjYsNyArNTk2OCw3IEBAIHN0YXRpYyBi b29sIGlzRGVwcmVjYXRlZEJhc2ljU2hhcGUoQ1NTUGFyc2VyVmFsdWVMaXN0KiBhcmdzKQogICAg IHJldHVybiBmYWxzZTsKIH0KIAotUGFzc1JlZlB0cjxDU1NCYXNpY1NoYXBlPiBDU1NQYXJzZXI6 OnBhcnNlQmFzaWNTaGFwZSgpCitQYXNzUmVmUHRyPENTU1ByaW1pdGl2ZVZhbHVlPiBDU1NQYXJz ZXI6OnBhcnNlQmFzaWNTaGFwZSgpCiB7CiAgICAgQ1NTUGFyc2VyVmFsdWUqIHZhbHVlID0gbV92 YWx1ZUxpc3QtPmN1cnJlbnQoKTsKICAgICBBU1NFUlQodmFsdWUtPnVuaXQgPT0gQ1NTUGFyc2Vy VmFsdWU6OkZ1bmN0aW9uKTsKQEAgLTU5OTksNyArNjAwMSw3IEBAIFBhc3NSZWZQdHI8Q1NTQmFz aWNTaGFwZT4gQ1NTUGFyc2VyOjpwYXJzZUJhc2ljU2hhcGUoKQogICAgICAgICByZXR1cm4gbnVs bHB0cjsKIAogICAgIG1fdmFsdWVMaXN0LT5uZXh0KCk7Ci0gICAgcmV0dXJuIHNoYXBlLnJlbGVh c2UoKTsKKyAgICByZXR1cm4gY3NzVmFsdWVQb29sKCkuY3JlYXRlVmFsdWUoc2hhcGUucmVsZWFz ZSgpKTsKIH0KIAogLy8gWyAnZm9udC1zdHlsZScgfHwgJ2ZvbnQtdmFyaWFudCcgfHwgJ2ZvbnQt d2VpZ2h0JyBdPyAnZm9udC1zaXplJyBbIC8gJ2xpbmUtaGVpZ2h0JyBdPyAnZm9udC1mYW1pbHkn CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmggYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvQ1NTUGFyc2VyLmgKaW5kZXggMTliMjY5NmYzZmNiZGQzMTY5ZDE5NDI0NzkwNzFi ZTk1NzUxZjY5NC4uNzYyYzI2MWU3N2U2ZDU0YTA3NzM3YTYzZWYzMzNiOTNhMDcxY2QwMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2Nzcy9DU1NQYXJzZXIuaApAQCAtMTc5LDcgKzE3OSw3IEBAIHB1YmxpYzoKICAgICBQYXNz UmVmUHRyPENTU1ZhbHVlPiBwYXJzZVNoYXBlUHJvcGVydHkoQ1NTUHJvcGVydHlJRCk7CiAjZW5k aWYKIAotICAgIFBhc3NSZWZQdHI8Q1NTQmFzaWNTaGFwZT4gcGFyc2VCYXNpY1NoYXBlKCk7Cisg ICAgUGFzc1JlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gcGFyc2VCYXNpY1NoYXBlKCk7CiAgICAg UGFzc1JlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gcGFyc2VTaGFwZVJhZGl1cyhDU1NQYXJzZXJW YWx1ZSopOwogICAgIFBhc3NSZWZQdHI8Q1NTQmFzaWNTaGFwZT4gcGFyc2VCYXNpY1NoYXBlUmVj dGFuZ2xlKENTU1BhcnNlclZhbHVlTGlzdCopOwogICAgIFBhc3NSZWZQdHI8Q1NTQmFzaWNTaGFw ZT4gcGFyc2VCYXNpY1NoYXBlQ2lyY2xlKENTU1BhcnNlclZhbHVlTGlzdCopOwo=