126699 2014-01-09 08:01:24 -0800 Regression: failing RegExp tests on 32 bit architectures. 2014-01-09 10:42:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kilvadyb webkit-unassigned benjamin cmarcelo commit-queue fpizlo fu gergely ggaren jbriance mhahnenberg msaboff oliver palfia oldest_to_newest 965903 0 kilvadyb 2014-01-09 08:01:24 -0800 setRegExpConstructorInput and setRegExpConstructorMultiline functions are defined with (ExecState*, JSObject*, JSValue) parameters but are called with (ExecState*, EncodedJSValue, EncodedJSValue) parameters: (gdb) p entry->m_u.property.put $6 = (JSC::PutFunction) 0x7791feac <JSC::setRegExpConstructorMultiline(JSC::ExecState*, JSC::JSObject*, JSC::JSValue)> (gdb) ptype entry->m_u.property.put type = void (*)(JSC::ExecState *, JSC::EncodedJSValue, JSC::EncodedJSValue) 965907 1 220737 kilvadyb 2014-01-09 08:11:26 -0800 Created attachment 220737 proposed patch. 965967 2 220737 oliver 2014-01-09 10:29:20 -0800 Comment on attachment 220737 proposed patch. whoops, sorry 965977 3 220737 commit-queue 2014-01-09 10:42:24 -0800 Comment on attachment 220737 proposed patch. Clearing flags on attachment: 220737 Committed r161562: <http://trac.webkit.org/changeset/161562> 965978 4 commit-queue 2014-01-09 10:42:26 -0800 All reviewed patches have been landed. Closing bug. 220737 2014-01-09 08:11:26 -0800 2014-01-09 10:42:24 -0800 proposed patch. regexp.diff text/plain 2717 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDM1ZmU4OTguLmI3NjVhMzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAxLTA5ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgUmVncmVzc2lvbjogZmFpbGlu ZyBSZWdFeHAgdGVzdHMgb24gMzIgYml0IGFyY2hpdGVjdHVyZXMuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY2OTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggc2V0UmVnRXhwQ29uc3RydWN0b3Ig ZnVuY3Rpb25zIGZvciAzMiBiaXQgYXJjaGl0ZWN0dXJlcy4KKworICAgICAgICAqIHJ1bnRpbWUv UmVnRXhwQ29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpzZXRSZWdFeHBDb25zdHJ1Y3Rv cklucHV0KToKKyAgICAgICAgKEpTQzo6c2V0UmVnRXhwQ29uc3RydWN0b3JNdWx0aWxpbmUpOgor CiAyMDE0LTAxLTA4ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2ZXJ0aW5nIGFjY2lkZW50YWwgR0MgbG9nZ2luZwpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ29uc3RydWN0b3IuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwQ29uc3RydWN0b3IuY3BwCmluZGV4IGQ0ZjU2 MDIuLjE4OWIxNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Jl Z0V4cENvbnN0cnVjdG9yLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9S ZWdFeHBDb25zdHJ1Y3Rvci5jcHAKQEAgLTQ1LDggKzQ1LDggQEAgc3RhdGljIEVuY29kZWRKU1Zh bHVlIHJlZ0V4cENvbnN0cnVjdG9yRG9sbGFyNyhFeGVjU3RhdGUqLCBFbmNvZGVkSlNWYWx1ZSwg RW5jb2QKIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSByZWdFeHBDb25zdHJ1Y3RvckRvbGxhcjgoRXhl Y1N0YXRlKiwgRW5jb2RlZEpTVmFsdWUsIEVuY29kZWRKU1ZhbHVlLCBQcm9wZXJ0eU5hbWUpOwog c3RhdGljIEVuY29kZWRKU1ZhbHVlIHJlZ0V4cENvbnN0cnVjdG9yRG9sbGFyOShFeGVjU3RhdGUq LCBFbmNvZGVkSlNWYWx1ZSwgRW5jb2RlZEpTVmFsdWUsIFByb3BlcnR5TmFtZSk7CiAKLXN0YXRp YyB2b2lkIHNldFJlZ0V4cENvbnN0cnVjdG9ySW5wdXQoRXhlY1N0YXRlKiwgSlNPYmplY3QqLCBK U1ZhbHVlKTsKLXN0YXRpYyB2b2lkIHNldFJlZ0V4cENvbnN0cnVjdG9yTXVsdGlsaW5lKEV4ZWNT dGF0ZSosIEpTT2JqZWN0KiwgSlNWYWx1ZSk7CitzdGF0aWMgdm9pZCBzZXRSZWdFeHBDb25zdHJ1 Y3RvcklucHV0KEV4ZWNTdGF0ZSosIEVuY29kZWRKU1ZhbHVlLCBFbmNvZGVkSlNWYWx1ZSk7Citz dGF0aWMgdm9pZCBzZXRSZWdFeHBDb25zdHJ1Y3Rvck11bHRpbGluZShFeGVjU3RhdGUqLCBFbmNv ZGVkSlNWYWx1ZSwgRW5jb2RlZEpTVmFsdWUpOwogCiB9IC8vIG5hbWVzcGFjZSBKU0MKIApAQCAt MjQzLDE0ICsyNDMsMTQgQEAgdm9pZCBSZWdFeHBDb25zdHJ1Y3Rvcjo6cHV0KEpTQ2VsbCogY2Vs bCwgRXhlY1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHkKICAgICBsb29rdXBQdXQ8 UmVnRXhwQ29uc3RydWN0b3IsIEludGVybmFsRnVuY3Rpb24+KGV4ZWMsIHByb3BlcnR5TmFtZSwg dmFsdWUsIEV4ZWNTdGF0ZTo6cmVnRXhwQ29uc3RydWN0b3JUYWJsZShleGVjKSwganNDYXN0PFJl Z0V4cENvbnN0cnVjdG9yKj4oY2VsbCksIHNsb3QpOwogfQogCi12b2lkIHNldFJlZ0V4cENvbnN0 cnVjdG9ySW5wdXQoRXhlY1N0YXRlKiBleGVjLCBKU09iamVjdCogYmFzZU9iamVjdCwgSlNWYWx1 ZSB2YWx1ZSkKK3ZvaWQgc2V0UmVnRXhwQ29uc3RydWN0b3JJbnB1dChFeGVjU3RhdGUqIGV4ZWMs IEVuY29kZWRKU1ZhbHVlIGJhc2VPYmplY3QsIEVuY29kZWRKU1ZhbHVlIHZhbHVlKQogewotICAg IGFzUmVnRXhwQ29uc3RydWN0b3IoYmFzZU9iamVjdCktPnNldElucHV0KGV4ZWMsIHZhbHVlLnRv U3RyaW5nKGV4ZWMpKTsKKyAgICBhc1JlZ0V4cENvbnN0cnVjdG9yKGFzT2JqZWN0KEpTVmFsdWU6 OmRlY29kZShiYXNlT2JqZWN0KSkpLT5zZXRJbnB1dChleGVjLCBKU1ZhbHVlOjpkZWNvZGUodmFs dWUpLnRvU3RyaW5nKGV4ZWMpKTsKIH0KIAotdm9pZCBzZXRSZWdFeHBDb25zdHJ1Y3Rvck11bHRp bGluZShFeGVjU3RhdGUqIGV4ZWMsIEpTT2JqZWN0KiBiYXNlT2JqZWN0LCBKU1ZhbHVlIHZhbHVl KQordm9pZCBzZXRSZWdFeHBDb25zdHJ1Y3Rvck11bHRpbGluZShFeGVjU3RhdGUqIGV4ZWMsIEVu Y29kZWRKU1ZhbHVlIGJhc2VPYmplY3QsIEVuY29kZWRKU1ZhbHVlIHZhbHVlKQogewotICAgIGFz UmVnRXhwQ29uc3RydWN0b3IoYmFzZU9iamVjdCktPnNldE11bHRpbGluZSh2YWx1ZS50b0Jvb2xl YW4oZXhlYykpOworICAgIGFzUmVnRXhwQ29uc3RydWN0b3IoYXNPYmplY3QoSlNWYWx1ZTo6ZGVj b2RlKGJhc2VPYmplY3QpKSktPnNldE11bHRpbGluZShKU1ZhbHVlOjpkZWNvZGUodmFsdWUpLnRv Qm9vbGVhbihleGVjKSk7CiB9CiAKIC8vIEVDTUEgMTUuMTAuNAo=