126695 2014-01-09 07:09:28 -0800 Possible crash in ApplicationCache::removeResource 2014-01-10 13:14:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 piotr.grad webkit-unassigned commit-queue japhet oldest_to_newest 965884 0 piotr.grad 2014-01-09 07:09:28 -0800 "Iterator it" variable is used after is removed. Working on patch, will be proposed soon. 965885 1 220730 piotr.grad 2014-01-09 07:13:36 -0800 Created attachment 220730 Patch 965918 2 220730 piotr.grad 2014-01-09 08:36:39 -0800 Comment on attachment 220730 Patch mac-wk2 is not passing also with other attachments with same output. 965940 3 220730 ap 2014-01-09 09:16:43 -0800 Comment on attachment 220730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220730&action=review > Source/WebCore/ChangeLog:8 > + No new tests. This is not a very helpful line. You could explain _why_ there are no tests, but even that is better to do in the bug, not in ChangeLog I think. 966066 4 220768 piotr.grad 2014-01-09 14:15:51 -0800 Created attachment 220768 Patch 966529 5 220730 commit-queue 2014-01-10 13:04:50 -0800 Comment on attachment 220730 Patch Clearing flags on attachment: 220730 Committed r161665: <http://trac.webkit.org/changeset/161665> 966530 6 commit-queue 2014-01-10 13:04:52 -0800 All reviewed patches have been landed. Closing bug. 966540 7 220730 darin 2014-01-10 13:14:40 -0800 Comment on attachment 220730 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220730&action=review >> Source/WebCore/ChangeLog:8 >> + No new tests. > > This is not a very helpful line. You could explain _why_ there are no tests, but even that is better to do in the bug, not in ChangeLog I think. Given that our iterators are checked, I think we could indeed make a test for this. If we can get this code to run, it should assert in a debug build. This fix should not have gone in without a test! 220730 2014-01-09 07:13:36 -0800 2014-01-10 13:14:40 -0800 Patch patch2.txt text/plain 1315 piotr.grad ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYTY0OGM5Li45YThlOWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDEtMDkgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgUG9zc2libGUgY3Jhc2ggaW4gQXBwbGljYXRpb25DYWNoZTo6cmVtb3ZlUmVzb3VyY2UuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY2OTUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMuCisKKyAgICAgICAgSXRlcmF0b3IgdmFyaWFibGUgd2FzIHVzZWQgYWZ0ZXIgaXQgd2FzIHJl bW92ZWQuCisKKyAgICAgICAgKiBsb2FkZXIvYXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpBcHBsaWNhdGlvbkNhY2hlOjpyZW1vdmVSZXNvdXJjZSk6CisK IDIwMTQtMDEtMDkgIEFuZHJlaSBCdWN1ciAgPGFidWN1ckBhZG9iZS5jb20+CiAKICAgICAgICAg W0NTU1JlZ2lvbnNdIE1vdmUgcmVnaW9ucyBhdXRvLXNpemUgY29kZSBpbnRvIFJlbmRlck5hbWVk Rmxvd0ZyYWdtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUv QXBwbGljYXRpb25DYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvYXBwY2FjaGUvQXBw bGljYXRpb25DYWNoZS5jcHAKaW5kZXggZTExZmI3OS4uODI5YmIwOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGUuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlLmNwcApAQCAtMTA4 LDEwICsxMDgsMTAgQEAgdW5zaWduZWQgQXBwbGljYXRpb25DYWNoZTo6cmVtb3ZlUmVzb3VyY2Uo Y29uc3QgU3RyaW5nJiB1cmwpCiAgICAgLy8gVGhlIHJlc291cmNlIGV4aXN0cywgZ2V0IGl0cyB0 eXBlIHNvIHdlIGNhbiByZXR1cm4gaXQuCiAgICAgdW5zaWduZWQgdHlwZSA9IGl0LT52YWx1ZS0+ dHlwZSgpOwogCi0gICAgbV9yZXNvdXJjZXMucmVtb3ZlKGl0KTsKLQogICAgIG1fZXN0aW1hdGVk U2l6ZUluU3RvcmFnZSAtPSBpdC0+dmFsdWUtPmVzdGltYXRlZFNpemVJblN0b3JhZ2UoKTsKIAor ICAgIG1fcmVzb3VyY2VzLnJlbW92ZShpdCk7CisKICAgICByZXR1cm4gdHlwZTsKIH0gICAgCiAg ICAgCg== 220768 2014-01-09 14:15:51 -0800 2014-01-10 11:58:30 -0800 Patch patch.txt text/plain 1295 piotr.grad ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiYTY0OGM5Li45YThlOWVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDEtMDkgIFBpb3RyIEdyYWQgIDxwLmdyYWRAc2Ftc3VuZy5jb20+CisKKyAgICAg ICAgUG9zc2libGUgY3Jhc2ggaW4gQXBwbGljYXRpb25DYWNoZTo6cmVtb3ZlUmVzb3VyY2UuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY2OTUKKwor ICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292LgorCisgICAgICAgIEl0ZXJh dG9yIHZhcmlhYmxlIHdhcyB1c2VkIGFmdGVyIGl0IHdhcyByZW1vdmVkLgorCisgICAgICAgICog bG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXBwbGljYXRpb25DYWNoZTo6cmVtb3ZlUmVzb3VyY2UpOgorCiAyMDE0LTAxLTA5ICBBbmRyZWkg QnVjdXIgIDxhYnVjdXJAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1NSZWdpb25zXSBNb3ZlIHJl Z2lvbnMgYXV0by1zaXplIGNvZGUgaW50byBSZW5kZXJOYW1lZEZsb3dGcmFnbWVudApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL0FwcGxpY2F0aW9uQ2FjaGUuY3BwCmlu ZGV4IGUxMWZiNzkuLjgyOWJiMDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9h cHBjYWNoZS9BcHBsaWNhdGlvbkNhY2hlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv YXBwY2FjaGUvQXBwbGljYXRpb25DYWNoZS5jcHAKQEAgLTEwOCwxMCArMTA4LDEwIEBAIHVuc2ln bmVkIEFwcGxpY2F0aW9uQ2FjaGU6OnJlbW92ZVJlc291cmNlKGNvbnN0IFN0cmluZyYgdXJsKQog ICAgIC8vIFRoZSByZXNvdXJjZSBleGlzdHMsIGdldCBpdHMgdHlwZSBzbyB3ZSBjYW4gcmV0dXJu IGl0LgogICAgIHVuc2lnbmVkIHR5cGUgPSBpdC0+dmFsdWUtPnR5cGUoKTsKIAotICAgIG1fcmVz b3VyY2VzLnJlbW92ZShpdCk7Ci0KICAgICBtX2VzdGltYXRlZFNpemVJblN0b3JhZ2UgLT0gaXQt PnZhbHVlLT5lc3RpbWF0ZWRTaXplSW5TdG9yYWdlKCk7CiAKKyAgICBtX3Jlc291cmNlcy5yZW1v dmUoaXQpOworCiAgICAgcmV0dXJuIHR5cGU7CiB9ICAgIAogICAgIAo=