126678 2014-01-08 20:55:20 -0800 WebKit2 EFL build fix after r161530 2014-01-08 23:10:41 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jinwoo7.song jinwoo7.song commit-queue gyuyoung.kim simon.fraser thorton oldest_to_newest 965772 0 jinwoo7.song 2014-01-08 20:55:20 -0800 In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WTF/wtf/FastMalloc.h:28:0, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/config.h:56, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:26: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WTF/wtf/StdLibExtras.h: In instantiation of ‘typename std::_Unique_if<T>::_Single_object std::make_unique(Args&& ...) [with T = WebKit::CoordinatedDrawingArea; Args = {WebKit::WebPage*&, const WebKit::WebPageCreationParameters&}; typename std::_Unique_if<T>::_Single_object = std::unique_ptr<WebKit::CoordinatedDrawingArea, std::default_delete<WebKit::CoordinatedDrawingArea> >]’: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:59:76: required from here /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WTF/wtf/StdLibExtras.h:342:64: error: cannot allocate an object of abstract type ‘WebKit::CoordinatedDrawingArea’ In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:36:0: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:39:7: note: because the following virtual functions are pure within ‘WebKit::CoordinatedDrawingArea’: In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:27:0: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/DrawingArea.h:89:18: note: virtual void WebKit::DrawingArea::setExposedRect(const WebCore::FloatRect&) /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/DrawingArea.h:90:32: note: virtual WebCore::FloatRect WebKit::DrawingArea::exposedRect() const In file included from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WTF/wtf/FastMalloc.h:28:0, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/config.h:56, from /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:26: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WTF/wtf/StdLibExtras.h: In function ‘typename std::_Unique_if<T>::_Single_object std::make_unique(Args&& ...) [with T = WebKit::CoordinatedDrawingArea; Args = {WebKit::WebPage*&, const WebKit::WebPageCreationParameters&}; typename std::_Unique_if<T>::_Single_object = std::unique_ptr<WebKit::CoordinatedDrawingArea, std::default_delete<WebKit::CoordinatedDrawingArea> >]’: /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WTF/wtf/StdLibExtras.h:343:5: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors make[2]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/WebProcess/WebPage/DrawingArea.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/Source/WebKit2/WebProcess/Plugins/PluginView.cpp:499:6: warning: unused parameter ‘changed’ [-Wunused-parameter] make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2.dir/all] Error 2 make: *** [all] Error 2 965777 1 220698 jinwoo7.song 2014-01-08 21:38:45 -0800 Created attachment 220698 Patch 965782 2 gyuyoung.kim 2014-01-08 22:40:27 -0800 CC'ing Tim and Simon, could you take a look this patch ? 965784 3 220698 commit-queue 2014-01-08 23:10:37 -0800 Comment on attachment 220698 Patch Clearing flags on attachment: 220698 Committed r161548: <http://trac.webkit.org/changeset/161548> 965785 4 commit-queue 2014-01-08 23:10:41 -0800 All reviewed patches have been landed. Closing bug. 220698 2014-01-08 21:38:45 -0800 2014-01-08 23:10:37 -0800 Patch bug-126678-20140109143843.patch text/plain 2497 jinwoo7.song U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNTQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmQxMWQ5NGRkY2ZkZWQy YjA0OTY5NjUzNmIyZWQ2MTM2MWI5OThiYS4uODIzMzNhNjFmZGNmNDE2ZmI0MGQ1Zjg2ZTlmM2Zi ZDI2ZTIwMTJhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTAxLTA4ICBKaW53 b28gU29uZyAgPGppbndvbzcuc29uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBXZWJLaXQyIEVG TCBidWlsZCBmaXggYWZ0ZXIgcjE2MTUzMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTI2Njc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIFBMQVRGT1JNKE1BQykgZ3VhcmRzIGFyb3VuZCBzZXRFeHBv c2VkUmVjdCgpIGFuZCBleHBvc2VkUmVjdCgpCisgICAgICAgIGluIERyYXdpbmdBcmVhIGFuZCBX ZWJGcmFtZUxvYWRlckNsaWVudC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJGcmFtZUxv YWRlckNsaWVudDo6dHJhbnNpdGlvblRvQ29tbWl0dGVkRm9yTmV3UGFnZSk6CisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmg6CisKIDIwMTQtMDEtMDggIE1hcnRpbiBI b2NrICA8bWhvY2tAYXBwbGUuY29tPgogCiAgICAgICAgIFN0dWIgZm9yIFNlc3Npb24gQVBJCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkZy YW1lTG9hZGVyQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1 cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCmluZGV4IDNjYzE4M2FkOWIzMmExNGM5MTdl YzE3MDk5NjQ2MTNkZWFhOWY2ZGMuLjNjOGFlY2E2ZjFkOWZlYWJjZmFhYTJlMGEzOWMwMDg2YThl ZmI4YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwCkBAIC0xMjM4LDcgKzEy MzgsOSBAQCB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojp0cmFuc2l0aW9uVG9Db21taXR0ZWRG b3JOZXdQYWdlKCkKIAogICAgIG1fZnJhbWUtPmNvcmVGcmFtZSgpLT52aWV3KCktPnNldFByb2hp Yml0c1Njcm9sbGluZyhzaG91bGREaXNhYmxlU2Nyb2xsaW5nKTsKICAgICBtX2ZyYW1lLT5jb3Jl RnJhbWUoKS0+dmlldygpLT5zZXRWaXN1YWxVcGRhdGVzQWxsb3dlZEJ5Q2xpZW50KCF3ZWJQYWdl LT5zaG91bGRFeHRlbmRJbmNyZW1lbnRhbFJlbmRlcmluZ1N1cHByZXNzaW9uKCkpOworI2lmIFBM QVRGT1JNKE1BQykKICAgICBtX2ZyYW1lLT5jb3JlRnJhbWUoKS0+dmlldygpLT5zZXRFeHBvc2Vk UmVjdCh3ZWJQYWdlLT5kcmF3aW5nQXJlYSgpLT5leHBvc2VkUmVjdCgpKTsKKyNlbmRpZgogI2lm IFBMQVRGT1JNKElPUykKICAgICBtX2ZyYW1lLT5jb3JlRnJhbWUoKS0+dmlldygpLT5zZXREZWxl Z2F0ZXNTY3JvbGxpbmcodHJ1ZSk7CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy L1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYS5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJv Y2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVhLmgKaW5kZXggNjA4NTgzMjQzNmEwYjJjNjFhZTdiMDZi MjJhZWY4MTRjMmE0MTBlYi4uNmFkMWJiZDU4MGUwOTU2NWMwNzFjZTY0NGQ2MmFkZGI0ZGEwOTBl MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdB cmVhLmgKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0RyYXdpbmdBcmVh LmgKQEAgLTg2LDggKzg2LDEwIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlUHJl ZmVyZW5jZXMoY29uc3QgV2ViUHJlZmVyZW5jZXNTdG9yZSYpIHsgfQogICAgIHZpcnR1YWwgdm9p ZCBtYWluRnJhbWVDb250ZW50U2l6ZUNoYW5nZWQoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYpIHsg fQogCisjaWYgUExBVEZPUk0oTUFDKQogICAgIHZpcnR1YWwgdm9pZCBzZXRFeHBvc2VkUmVjdChj b25zdCBXZWJDb3JlOjpGbG9hdFJlY3QmKSA9IDA7CiAgICAgdmlydHVhbCBXZWJDb3JlOjpGbG9h dFJlY3QgZXhwb3NlZFJlY3QoKSBjb25zdCA9IDA7CisjZW5kaWYKICAgICB2aXJ0dWFsIHZvaWQg bWFpbkZyYW1lU2Nyb2xsYWJpbGl0eUNoYW5nZWQoYm9vbCkgeyB9CiAKICAgICB2aXJ0dWFsIGJv b2wgc3VwcG9ydHNBc3luY1Njcm9sbGluZygpIHsgcmV0dXJuIGZhbHNlOyB9Cg==