126639 2014-01-08 07:32:40 -0800 Switch uses of WTF::bind in MockMediaPlayerMediaSource to C++11 lambdas 2016-08-30 01:47:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 zan zan andersca commit-queue eric.carlson glenn jer.noble oldest_to_newest 965469 0 zan 2014-01-08 07:32:40 -0800 Switch uses of WTF::bind in MockMediaPlayerMediaSource to C++11 lambdas 965471 1 220630 zan 2014-01-08 07:34:17 -0800 Created attachment 220630 Patch 974285 2 220630 svillar 2014-01-31 07:10:52 -0800 Comment on attachment 220630 Patch lgtm 974298 3 220630 jer.noble 2014-01-31 08:22:52 -0800 Comment on attachment 220630 Patch r=me 974301 4 220630 jer.noble 2014-01-31 08:25:08 -0800 Comment on attachment 220630 Patch Actually, you should protect against this being freed before the lambda is called by passing in a RefPtr into the lambda. 974400 5 zan 2014-01-31 11:55:32 -0800 (In reply to comment #4) > (From update of attachment 220630 [details]) > Actually, you should protect against this being freed before the lambda is called by passing in a RefPtr into the lambda. MockMediaPlayerMediaSource is not ref-counted and is not derived from a ref-counted class (MediaPlayerPrivateInterface). It's obvious it probably should be. 974422 6 jer.noble 2014-01-31 12:39:45 -0800 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 220630 [details] [details]) > > Actually, you should protect against this being freed before the lambda is called by passing in a RefPtr into the lambda. > > MockMediaPlayerMediaSource is not ref-counted and is not derived from a ref-counted class (MediaPlayerPrivateInterface). > > It's obvious it probably should be. In this situation, you can use a WeakPtrFactory and WeakPtrs without making the class RefCounted. Though you're right this class should probably be RefCounted. 1224525 7 zan 2016-08-30 01:46:52 -0700 WTF::bind() uses have been removed, making the patch stale. 220630 2014-01-08 07:34:17 -0800 2016-08-30 01:47:03 -0700 Patch bug-126639-20140108163415.patch text/plain 2338 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDdhOTgzZDk4YjEzYTQw MzZjMTU3ZjJlNTY2MjQwYTI2Y2VkZWY3MS4uZjc4ZDExYWIyNzM0YzljYmFmNDIwMGY3YTVkYmE1 OWRjMDEyYjZhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTAxLTA4ICBaYW4g RG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBTd2l0Y2ggdXNlcyBv ZiBXVEY6OmJpbmQgaW4gTW9ja01lZGlhUGxheWVyTWVkaWFTb3VyY2UgdG8gQysrMTEgbGFtYmRh cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI2NjM5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9tb2NrL21lZGlhc291cmNlL01vY2tNZWRpYVBsYXllck1lZGlhU291cmNlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1vY2tNZWRpYVBsYXllck1lZGlhU291cmNlOjpwbGF5KTogQ2FwdHVy ZSB0aGUgdGhpcyBwb2ludGVyCisgICAgICAgIGZvciB0aGUgbGFtYmRhIGZ1bmN0aW9uIGFuZCBj YWxsIGFkdmFuY2VDdXJyZW50VGltZSgpIG9uIG1haW4gdGhyZWFkLgorICAgICAgICAoV2ViQ29y ZTo6TW9ja01lZGlhUGxheWVyTWVkaWFTb3VyY2U6OnNlZWtXaXRoVG9sZXJhbmNlKTogRGl0dG8u CisKKzIwMTQtMDEtMDggIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgorCiAg ICAgICAgIFtBdXRvbWFrZV0gU2NyaXB0cyBmb3IgZ2VuZXJhdGVkIGJ1aWxkIHRhcmdldHMgZG8g bm90IG5lY2Vzc2FyaWx5IHByb2R1Y2UgdGhlaXIgb3V0cHV0CiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjYzNzgKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbW9jay9tZWRpYXNvdXJjZS9Nb2NrTWVkaWFQbGF5ZXJNZWRpYVNv dXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL21lZGlhc291cmNlL01vY2tN ZWRpYVBsYXllck1lZGlhU291cmNlLmNwcAppbmRleCBlMGZjNTFjOWYwY2UzZjAyNTQ3MDg1MmI5 MGE0YTEyZTQxMGY1ODY1Li5iNzRhZDZhMmQ5MWY0YWFmYWUxODNhNTFmMDY1M2IyYTFmOGVlNDE3 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL21lZGlhc291cmNlL01v Y2tNZWRpYVBsYXllck1lZGlhU291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tb2NrL21lZGlhc291cmNlL01vY2tNZWRpYVBsYXllck1lZGlhU291cmNlLmNwcApAQCAtMzIs NyArMzIsNiBAQAogI2luY2x1ZGUgIkhUTUxNZWRpYVNvdXJjZS5oIgogI2luY2x1ZGUgIk1lZGlh UGxheWVyLmgiCiAjaW5jbHVkZSAiTW9ja01lZGlhU291cmNlUHJpdmF0ZS5oIgotI2luY2x1ZGUg PHd0Zi9GdW5jdGlvbmFsLmg+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KICNpbmNsdWRl IDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIApAQCAtMTE0LDcgKzExMyw5IEBAIHZvaWQgTW9ja01l ZGlhUGxheWVyTWVkaWFTb3VyY2U6OmNhbmNlbExvYWQoKQogdm9pZCBNb2NrTWVkaWFQbGF5ZXJN ZWRpYVNvdXJjZTo6cGxheSgpCiB7CiAgICAgbV9wbGF5aW5nID0gMTsKLSAgICBjYWxsT25NYWlu VGhyZWFkKGJpbmQoJk1vY2tNZWRpYVBsYXllck1lZGlhU291cmNlOjphZHZhbmNlQ3VycmVudFRp bWUsIHRoaXMpKTsKKyAgICBjYWxsT25NYWluVGhyZWFkKFt0aGlzXSB7CisgICAgICAgIGFkdmFu Y2VDdXJyZW50VGltZSgpOworICAgIH0pOwogfQogCiB2b2lkIE1vY2tNZWRpYVBsYXllck1lZGlh U291cmNlOjpwYXVzZSgpCkBAIC0yMDQsNyArMjA1LDkgQEAgdm9pZCBNb2NrTWVkaWFQbGF5ZXJN ZWRpYVNvdXJjZTo6c2Vla1dpdGhUb2xlcmFuY2UoZG91YmxlIHRpbWUsIGRvdWJsZSBuZWdhdGl2 ZVQKICAgICBtX3BsYXllci0+dGltZUNoYW5nZWQoKTsKIAogICAgIGlmIChtX3BsYXlpbmcpCi0g ICAgICAgIGNhbGxPbk1haW5UaHJlYWQoYmluZCgmTW9ja01lZGlhUGxheWVyTWVkaWFTb3VyY2U6 OmFkdmFuY2VDdXJyZW50VGltZSwgdGhpcykpOworICAgICAgICBjYWxsT25NYWluVGhyZWFkKFt0 aGlzXSB7CisgICAgICAgICAgICBhZHZhbmNlQ3VycmVudFRpbWUoKTsKKyAgICAgICAgfSk7CiB9 CiAKIHZvaWQgTW9ja01lZGlhUGxheWVyTWVkaWFTb3VyY2U6OmFkdmFuY2VDdXJyZW50VGltZSgp Cg==