126634 2014-01-08 02:31:03 -0800 Move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4 2015-05-11 03:13:17 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 jay.bhaskar webkit-unassigned cgarcia gustavo mrobinson ossy zan oldest_to_newest 965406 0 jay.bhaskar 2014-01-08 02:31:03 -0800 remove ENABLE_INSPECTOR_SERVER definition from config.h and placing it to SetupWebKitFeatures.m4 965768 1 220695 jay.bhaskar 2014-01-08 20:40:08 -0800 Created attachment 220695 Move ENABLE_INSPECTOR_SERVER 965826 2 220707 jay.bhaskar 2014-01-09 03:03:31 -0800 Created attachment 220707 Move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4 965861 3 mrobinson 2014-01-09 06:14:28 -0800 This seems like the opposite of what we want. Why is it useful to have it in SetupWebKitFeatures.m4 instead of config.h? Your patch also has the side-effect of disabling it on EFL. 220695 2014-01-08 20:40:08 -0800 2014-01-08 20:54:31 -0800 Move ENABLE_INSPECTOR_SERVER Patch text/plain 4661 jay.bhaskar SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTU0 NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAx LTA4ICBKYXkgQmhhc2thciAgPGpheS5iaGFza2FyQHNhbXN1bmcuY29tPgorCisgICAgICAgIE1v dmUgRU5BQkxFX0lOU1BFQ1RPUl9TRVJWRVIgZGVmaW5pdGlvbiB0byBTZXR1cFdlYktpdEZlYXR1 cmVzLm00CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjY2MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNvdXJjZS9hdXRvdG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNDoKKwogMjAxNC0wMS0wOCAg TWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g W0NNYWtlXSBTcGVjaWZ5IHRoZSBleGVjdXRhYmxlIGFuZCBsaWJyYXJ5IG91dHB1dCBsb2NhdGlv bnMgaW4gdGhlIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjE1NDQpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAx NC0wMS0wOCAgSmF5IEJoYXNrYXIgIDxqYXkuYmhhc2thckBzYW1zdW5nLmNvbT4KKworICAgICAg ICBNb3ZlIEVOQUJMRV9JTlNQRUNUT1JfU0VSVkVSIGRlZmluaXRpb24gdG8gU2V0dXBXZWJLaXRG ZWF0dXJlcy5tNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI2NjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBHTlVtYWtlZmlsZS5saXN0LmFtOgorICAgICAgICAqIGNvbmZpZy5oOgorCiAyMDE0LTAx LTA4ICBNYXJ0aW4gSG9jayAgPG1ob2NrQGFwcGxlLmNvbT4KIAogICAgICAgICBTdHViIGZvciBT ZXNzaW9uIEFQSQpJbmRleDogU291cmNlL1dlYktpdDIvR05VbWFrZWZpbGUubGlzdC5hbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5saXN0LmFtCShyZXZpc2lvbiAx NjE1NDMpCisrKyBTb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5saXN0LmFtCSh3b3JraW5nIGNv cHkpCkBAIC05ODIsMTcgKzk4Miw2IEBAIHdlYmtpdDJfc291cmNlcyArPSBcCiAJU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL1dlYlRleHRDaGVja2VyQ2xpZW50LmggXAogCVNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9XZWJVSUNsaWVudC5jcHAgXAogCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9X ZWJVSUNsaWVudC5oIFwKLQlTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVy L0hUVFBSZXF1ZXN0LmNwcCBcCi0JU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNl cnZlci9IVFRQUmVxdWVzdC5oIFwKLQlTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9y U2VydmVyL1dlYkluc3BlY3RvclNlcnZlci5jcHAgXAotCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9JbnNwZWN0b3JTZXJ2ZXIvV2ViSW5zcGVjdG9yU2VydmVyLmggXAotCVNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvV2ViU29ja2V0U2VydmVyLmNwcCBcCi0JU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9XZWJTb2NrZXRTZXJ2ZXIuaCBcCi0J U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9XZWJTb2NrZXRTZXJ2ZXJD bGllbnQuaCBcCi0JU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNlcnZlci9XZWJT b2NrZXRTZXJ2ZXJDb25uZWN0aW9uLmNwcCBcCi0JU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0lu c3BlY3RvclNlcnZlci9XZWJTb2NrZXRTZXJ2ZXJDb25uZWN0aW9uLmggXAotCVNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvZ3RrL1dlYkluc3BlY3RvclNlcnZlckd0ay5j cHAgXAotCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvc291cC9XZWJT b2NrZXRTZXJ2ZXJTb3VwLmNwcCBcCiAJU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlZpYnJh dGlvblByb3ZpZGVyLmNwcCBcCiAJU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlZpYnJhdGlv blByb3ZpZGVyLmggXAogCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJWaWJyYXRpb25Qcm94 eS5jcHAgXApAQCAtMTI3Miw2ICsxMjYxLDIxIEBAIHdlYmtpdDJfc291cmNlcyArPSBcCiAJU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcCBcCiAJU291cmNlL1dlYktpdDIv V2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmgKIAoraWYgRU5BQkxFX0lOU1BFQ1RPUl9TRVJWRVIKK3dl YmtpdDJfc291cmNlcyArPSBcCisJU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3BlY3RvclNl cnZlci9IVFRQUmVxdWVzdC5jcHAgXAorCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0 b3JTZXJ2ZXIvSFRUUFJlcXVlc3QuaCBcCisJU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0luc3Bl Y3RvclNlcnZlci9XZWJJbnNwZWN0b3JTZXJ2ZXIuY3BwIFwKKwlTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvSW5zcGVjdG9yU2VydmVyL1dlYkluc3BlY3RvclNlcnZlci5oIFwKKwlTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL1dlYlNvY2tldFNlcnZlci5jcHAgXAorCVNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvV2ViU29ja2V0U2VydmVyLmgg XAorCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIvV2ViU29ja2V0U2Vy dmVyQ2xpZW50LmggXAorCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9JbnNwZWN0b3JTZXJ2ZXIv V2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbi5jcHAgXAorCVNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9JbnNwZWN0b3JTZXJ2ZXIvV2ViU29ja2V0U2VydmVyQ29ubmVjdGlvbi5oIFwKKwlTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL2d0ay9XZWJJbnNwZWN0b3JTZXJ2ZXJH dGsuY3BwIFwKKwlTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvSW5zcGVjdG9yU2VydmVyL3NvdXAv V2ViU29ja2V0U2VydmVyU291cC5jcHAKK2VuZGlmICMgRU5EIEVOQUJMRV9JTlNQRUNUT1JfU0VS VkVSCisKIGlmIFRBUkdFVF9YMTEKIHdlYmtpdDJfc291cmNlcyArPSBcCiAJU291cmNlL1dlYktp dDIvU2hhcmVkL1BsdWdpbnMvTmV0c2NhcGUveDExL05ldHNjYXBlUGx1Z2luTW9kdWxlWDExLmNw cCBcCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9jb25maWcuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9jb25maWcuaAkocmV2aXNpb24gMTYxNTQzKQorKysgU291cmNlL1dlYktpdDIvY29u ZmlnLmgJKHdvcmtpbmcgY29weSkKQEAgLTY5LDEyICs2OSw2IEBACiAKICNkZWZpbmUgUExVR0lO X0FSQ0hJVEVDVFVSRShBUkNIKSAoZGVmaW5lZCBQTFVHSU5fQVJDSElURUNUVVJFXyMjQVJDSCAm JiBQTFVHSU5fQVJDSElURUNUVVJFXyMjQVJDSCkKIAotI2lmbmRlZiBFTkFCTEVfSU5TUEVDVE9S X1NFUlZFUgotI2lmIEVOQUJMRShJTlNQRUNUT1IpICYmIChQTEFURk9STShHVEspIHx8IFBMQVRG T1JNKEVGTCkpCi0jZGVmaW5lIEVOQUJMRV9JTlNQRUNUT1JfU0VSVkVSIDEKLSNlbmRpZgotI2Vu ZGlmCi0KICNpZm5kZWYgRU5BQkxFX1NFQ19JVEVNX1NISU0KICNpZiBQTEFURk9STShNQUMpICYm ICFQTEFURk9STShJT1MpCiAjZGVmaW5lIEVOQUJMRV9TRUNfSVRFTV9TSElNIDEKSW5kZXg6IFNv dXJjZS9hdXRvdG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvYXV0b3Rvb2xzL1NldHVwV2ViS2l0RmVhdHVyZXMubTQJKHJldmlzaW9uIDE2MTU0MykKKysr IFNvdXJjZS9hdXRvdG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNAkod29ya2luZyBjb3B5KQpA QCAtMTgzLDcgKzE4Myw4IEBAICRzcmNkaXIvVG9vbHMvZ3RrL2dlbmVyYXRlLWZlYXR1cmUtZGVm aW4KICAgICBFTkFCTEVfVklFV19NT0RFX0NTU19NRURJQT0xIFwKICAgICBFTkFCTEVfV0VCX1NP Q0tFVFM9MSBcCiAgICAgRU5BQkxFX1dFQl9USU1JTkc9MSBcCi0gICAgRU5BQkxFX1hIUl9USU1F T1VUPTEKKyAgICBFTkFCTEVfWEhSX1RJTUVPVVQ9MSBcCisgICAgRU5BQkxFX0lOU1BFQ1RPUl9T RVJWRVI9MQogCiBkbmwgQU1fV0VCS0lUX0ZFQVRVUkVfQ09ORElUSU9OQUwKIGRubCBDaGVja3Mg d2hldGhlciB0aGUgZ2l2ZW4gZmVhdHVyZSBpcyBlbmFibGVkIGluIHRoZQo= 220707 2014-01-09 03:03:31 -0800 2015-05-11 03:13:17 -0700 Move ENABLE_INSPECTOR_SERVER definition to SetupWebKitFeatures.m4 Patch text/plain 2266 jay.bhaskar SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE2MTU1 MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE0LTAx LTA5ICBKYXkgQmhhc2thciAgPGpheS5iaGFza2FyQHNhbXN1bmcuY29tPgorCisgICAgICAgIE1v dmUgRU5BQkxFX0lOU1BFQ1RPUl9TRVJWRVIgZGVmaW5pdGlvbiB0byBTZXR1cFdlYktpdEZlYXR1 cmVzLm00CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjY2MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNvdXJjZS9hdXRvdG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNDoKKwogMjAxNC0wMS0wOCAg TWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g W0NNYWtlXSBTcGVjaWZ5IHRoZSBleGVjdXRhYmxlIGFuZCBsaWJyYXJ5IG91dHB1dCBsb2NhdGlv bnMgaW4gdGhlIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNjE1NTIpCisrKyBTb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMiBAQAorMjAx NC0wMS0wOSAgSmF5IEJoYXNrYXIgIDxqYXkuYmhhc2thckBzYW1zdW5nLmNvbT4KKworICAgICAg ICBNb3ZlIEVOQUJMRV9JTlNQRUNUT1JfU0VSVkVSIGRlZmluaXRpb24gdG8gU2V0dXBXZWJLaXRG ZWF0dXJlcy5tNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTI2NjM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBjb25maWcuaDoKKwogMjAxNC0wMS0wOCAgSmlud29vIFNvbmcgIDxqaW53b283LnNvbmdA c2Ftc3VuZy5jb20+CiAKICAgICAgICAgV2ViS2l0MiBFRkwgYnVpbGQgZml4IGFmdGVyIHIxNjE1 MzAKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL2NvbmZpZy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL2NvbmZpZy5oCShyZXZpc2lvbiAxNjE1NTApCisrKyBTb3VyY2UvV2ViS2l0Mi9jb25m aWcuaAkod29ya2luZyBjb3B5KQpAQCAtNjksMTIgKzY5LDYgQEAKIAogI2RlZmluZSBQTFVHSU5f QVJDSElURUNUVVJFKEFSQ0gpIChkZWZpbmVkIFBMVUdJTl9BUkNISVRFQ1RVUkVfIyNBUkNIICYm IFBMVUdJTl9BUkNISVRFQ1RVUkVfIyNBUkNIKQogCi0jaWZuZGVmIEVOQUJMRV9JTlNQRUNUT1Jf U0VSVkVSCi0jaWYgRU5BQkxFKElOU1BFQ1RPUikgJiYgKFBMQVRGT1JNKEdUSykgfHwgUExBVEZP Uk0oRUZMKSkKLSNkZWZpbmUgRU5BQkxFX0lOU1BFQ1RPUl9TRVJWRVIgMQotI2VuZGlmCi0jZW5k aWYKLQogI2lmbmRlZiBFTkFCTEVfU0VDX0lURU1fU0hJTQogI2lmIFBMQVRGT1JNKE1BQykgJiYg IVBMQVRGT1JNKElPUykKICNkZWZpbmUgRU5BQkxFX1NFQ19JVEVNX1NISU0gMQpJbmRleDogU291 cmNlL2F1dG90b29scy9TZXR1cFdlYktpdEZlYXR1cmVzLm00Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9hdXRvdG9vbHMvU2V0dXBXZWJLaXRGZWF0dXJlcy5tNAkocmV2aXNpb24gMTYxNTUwKQorKysg U291cmNlL2F1dG90b29scy9TZXR1cFdlYktpdEZlYXR1cmVzLm00CSh3b3JraW5nIGNvcHkpCkBA IC0xODMsNyArMTgzLDggQEAgJHNyY2Rpci9Ub29scy9ndGsvZ2VuZXJhdGUtZmVhdHVyZS1kZWZp bgogICAgIEVOQUJMRV9WSUVXX01PREVfQ1NTX01FRElBPTEgXAogICAgIEVOQUJMRV9XRUJfU09D S0VUUz0xIFwKICAgICBFTkFCTEVfV0VCX1RJTUlORz0xIFwKLSAgICBFTkFCTEVfWEhSX1RJTUVP VVQ9MQorICAgIEVOQUJMRV9YSFJfVElNRU9VVD0xIFwKKyAgICBFTkFCTEVfSU5TUEVDVE9SX1NF UlZFUj0xCiAKIGRubCBBTV9XRUJLSVRfRkVBVFVSRV9DT05ESVRJT05BTAogZG5sIENoZWNrcyB3 aGV0aGVyIHRoZSBnaXZlbiBmZWF0dXJlIGlzIGVuYWJsZWQgaW4gdGhlCg==