126629 2014-01-08 01:43:14 -0800 invalid preprocessing directive in mathtags.in 2014-01-08 06:18:14 -0800 1 1 1 Unclassified WebKit MathML 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 100626 1 fred.wang fred.wang ap cfleizach commit-queue dbarton joepeck mrobinson oldest_to_newest 965385 0 fred.wang 2014-01-08 01:43:14 -0800 WebCore/Modules/mediacontrols/mediaControlsApple.js:825:34: warning: empty character constant [-Winvalid-pp-token] 1 warning generated. WebCore/mathml/mathtags.in:37:3: error: invalid preprocessing directive # These presentation MathML elements are not implemented. ^ 1 error generated. WebCore/mathml/mathtags.in:37:3: error: invalid preprocessing directive # These presentation MathML elements are not implemented. In mathtags.in, # should be replaced with // for comments. 965409 1 220618 fred.wang 2014-01-08 02:38:57 -0800 Created attachment 220618 Patch // does not seem to be accepted outside a # preprocessing instruction, so let's drop these comments. 965445 2 220618 commit-queue 2014-01-08 06:18:12 -0800 Comment on attachment 220618 Patch Clearing flags on attachment: 220618 Committed r161495: <http://trac.webkit.org/changeset/161495> 965446 3 commit-queue 2014-01-08 06:18:14 -0800 All reviewed patches have been landed. Closing bug. 220618 2014-01-08 02:38:57 -0800 2014-01-08 06:18:12 -0800 Patch patch.diff text/plain 1583 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwMGJlZmUxLi4yOWNkM2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTQtMDEtMDggIEZyw6lkw6lyaWMgV2FuZyAgPGZyZWQud2FuZ0BmcmVlLmZyPgorCisg ICAgICAgIFJlbW92ZSBpbnZhbGlkIGNvbW1lbnRzIGZyb20gbWF0aHRhZ3MuaW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY2MjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1hdGhtbC9tYXRodGFn cy5pbjoKKwogMjAxNC0wMS0wOCAgQW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAK ICAgICAgICAgY3JlYXRlTWF0aE1MT3BlcmF0b3IoKSBzaG91bGQgcmV0dXJuIFJlbmRlclB0ci4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL21hdGhtbC9tYXRodGFncy5pbiBiL1NvdXJjZS9X ZWJDb3JlL21hdGhtbC9tYXRodGFncy5pbgppbmRleCBkYWYzMzM0Li42MWE0OGM5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvbWF0aHRhZ3MuaW4KKysrIGIvU291cmNlL1dlYkNv cmUvbWF0aG1sL21hdGh0YWdzLmluCkBAIC0zNCwxNSArMzQsMTQgQEAgbXByZXNjcmlwdHMgaW50 ZXJmYWNlTmFtZT1NYXRoTUxJbmxpbmVDb250YWluZXJFbGVtZW50CiBub25lIGludGVyZmFjZU5h bWU9TWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVudAogc2VtYW50aWNzIGludGVyZmFjZU5hbWU9 TWF0aE1MU2VsZWN0RWxlbWVudAogCi0jIFRoZXNlIHByZXNlbnRhdGlvbiBNYXRoTUwgZWxlbWVu dHMgYXJlIG5vdCBpbXBsZW1lbnRlZC4KIG1hbGlnbmdyb3VwIGludGVyZmFjZU5hbWU9TWF0aE1M RWxlbWVudAogbWFsaWdubWFyayBpbnRlcmZhY2VOYW1lPU1hdGhNTEVsZW1lbnQKLW1lbmNsb3Nl IGludGVyZmFjZU5hbWU9TWF0aE1MRWxlbWVudCAjIGh0dHA6Ly93a2J1Zy84NTcyOQorbWVuY2xv c2UgaW50ZXJmYWNlTmFtZT1NYXRoTUxFbGVtZW50CiBtZ2x5cGggaW50ZXJmYWNlTmFtZT1NYXRo TUxFbGVtZW50Ci1tbGFiZWxlZHRyIGludGVyZmFjZU5hbWU9TWF0aE1MRWxlbWVudCAjIGh0dHA6 Ly93a2J1Zy84NTczMgorbWxhYmVsZWR0ciBpbnRlcmZhY2VOYW1lPU1hdGhNTEVsZW1lbnQKIG1s b25nZGl2IGludGVyZmFjZU5hbWU9TWF0aE1MRWxlbWVudAotbXBhZGRlZCBpbnRlcmZhY2VOYW1l PU1hdGhNTEVsZW1lbnQgIyBodHRwOi8vd2tidWcvODU3MzAKLW1zIGludGVyZmFjZU5hbWU9TWF0 aE1MRWxlbWVudCAjIGh0dHA6Ly93a2J1Zy8xMjU4NTkKK21wYWRkZWQgaW50ZXJmYWNlTmFtZT1N YXRoTUxFbGVtZW50CittcyBpbnRlcmZhY2VOYW1lPU1hdGhNTEVsZW1lbnQKIG1zY2FycmllcyBp bnRlcmZhY2VOYW1lPU1hdGhNTEVsZW1lbnQKIG1zY2FycnkgaW50ZXJmYWNlTmFtZT1NYXRoTUxF bGVtZW50CiBtc2dyb3VwIGludGVyZmFjZU5hbWU9TWF0aE1MRWxlbWVudAo=