126589 2014-01-07 12:20:45 -0800 r161364 caused JSC tests regression on non-DFG builds (e.g. C Loop and Windows) 2014-01-07 12:44:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 965111 0 mark.lam 2014-01-07 12:20:45 -0800 The removal of ENABLE(VALUE_PROFILER) in http://trac.webkit.org/changeset/161364 broke all non-DFG builds. That includes the C loop LLINT and Windows (only baseline JIT) builds. Per Filip, we'll resolve this by taking the small memory and perf hit on the non-DFG builds, and just do the value profiling work even though the profiling results won't be used by these non-DFG builds. Patch for the fix coming soon. ref: <rdar://problem/15758371> 965116 1 220540 mark.lam 2014-01-07 12:37:21 -0800 Created attachment 220540 the patch. 965117 2 220540 fpizlo 2014-01-07 12:42:14 -0800 Comment on attachment 220540 the patch. r=me 965118 3 mark.lam 2014-01-07 12:44:36 -0800 Thanks for the review. Landed in r161446: <http://trac.webkit.org/r161446>. 220540 2014-01-07 12:37:21 -0800 2014-01-07 12:42:14 -0800 the patch. bug-126589.patch text/plain 3926 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxNDQ1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAxLTA3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBy MTYxMzY0IGNhdXNlZCBKU0MgdGVzdHMgcmVncmVzc2lvbiBvbiBub24tREZHIGJ1aWxkcyAoZS5n LiBDIExvb3AgYW5kIFdpbmRvd3MpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI2NTg5LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFmdGVyIHRoZSByZW1vdmFsIG9mIEVOQUJMRShWQUxVRV9QUk9GSUxF UiksIHRoZSBMTElOVCBpcyBub3cgZXhwZWN0aW5nIHRoZQorICAgICAgICByZWxldmFudCBvcGNv ZGUgb3BlcmFuZHMgdG8gcG9pbnQgdG8gVmFsdWVQcm9maWxlciBkYXRhIHN0cnVjdHVyZXMgYW5k IHdpbGwKKyAgICAgICAgd3JpdGUgcHJvZmlsaW5nIGRhdGEgaW50byB0aGVtLiBIZW5jZSwgd2Ug bmVlZCB0byBhbGxvY2F0ZSB0aGVzZSBkYXRhCisgICAgICAgIHN0cnVjdHVyZXMgZXZlbiB0aG91 Z2ggdGhlIHByb2ZpbGluZyBkYXRhIHdvbid0IGJlIHVzZWQgaW4gbm9uLURGRyBidWlsZHMuCisK KyAgICAgICAgKiBieXRlY29kZS9Db2RlQmxvY2suY3BwOgorICAgICAgICAoSlNDOjpDb2RlQmxv Y2s6OkNvZGVCbG9jayk6CisKIDIwMTQtMDEtMDcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBBU1NFUlQgaW4gY29tcGlsZUFyaXRoTmVnYXRlIG9uIHBkZmpzCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcAkocmV2 aXNpb24gMTYxMzkwKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9j ay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE2NDQsMTQgKzE2NDQsMTIgQEAgQ29kZUJsb2NrOjpD b2RlQmxvY2soU2NyaXB0RXhlY3V0YWJsZSogbwogICAgIGlmIChzaXplX3Qgc2l6ZSA9IHVubGlu a2VkQ29kZUJsb2NrLT5udW1iZXJPZkxMaW50Q2FsbExpbmtJbmZvcygpKQogICAgICAgICBtX2xs aW50Q2FsbExpbmtJbmZvcy5yZXNpemVUb0ZpdChzaXplKTsKICNlbmRpZgotI2lmIEVOQUJMRShE RkdfSklUKQogICAgIGlmIChzaXplX3Qgc2l6ZSA9IHVubGlua2VkQ29kZUJsb2NrLT5udW1iZXJP ZkFycmF5UHJvZmlsZXMoKSkKICAgICAgICAgbV9hcnJheVByb2ZpbGVzLmdyb3coc2l6ZSk7CiAg ICAgaWYgKHNpemVfdCBzaXplID0gdW5saW5rZWRDb2RlQmxvY2stPm51bWJlck9mQXJyYXlBbGxv Y2F0aW9uUHJvZmlsZXMoKSkKICAgICAgICAgbV9hcnJheUFsbG9jYXRpb25Qcm9maWxlcy5yZXNp emVUb0ZpdChzaXplKTsKICAgICBpZiAoc2l6ZV90IHNpemUgPSB1bmxpbmtlZENvZGVCbG9jay0+ bnVtYmVyT2ZWYWx1ZVByb2ZpbGVzKCkpCiAgICAgICAgIG1fdmFsdWVQcm9maWxlcy5yZXNpemVU b0ZpdChzaXplKTsKLSNlbmRpZgogICAgIGlmIChzaXplX3Qgc2l6ZSA9IHVubGlua2VkQ29kZUJs b2NrLT5udW1iZXJPZk9iamVjdEFsbG9jYXRpb25Qcm9maWxlcygpKQogICAgICAgICBtX29iamVj dEFsbG9jYXRpb25Qcm9maWxlcy5yZXNpemVUb0ZpdChzaXplKTsKIApAQCAtMTY2OCw3ICsxNjY2 LDYgQEAgQ29kZUJsb2NrOjpDb2RlQmxvY2soU2NyaXB0RXhlY3V0YWJsZSogbwogICAgICAgICAg ICAgaW5zdHJ1Y3Rpb25zW2kgKyBqXS51Lm9wZXJhbmQgPSBwY1tpICsgal0udS5vcGVyYW5kOwog ICAgICAgICB9CiAgICAgICAgIHN3aXRjaCAocGNbaV0udS5vcGNvZGUpIHsKLSNpZiBFTkFCTEUo REZHX0pJVCkKICAgICAgICAgY2FzZSBvcF9nZXRfYnlfdmFsOgogICAgICAgICBjYXNlIG9wX2dl dF9hcmd1bWVudF9ieV92YWw6IHsKICAgICAgICAgICAgIGludCBhcnJheVByb2ZpbGVJbmRleCA9 IHBjW2kgKyBvcExlbmd0aCAtIDJdLnUub3BlcmFuZDsKQEAgLTE3MDUsNyArMTcwMiw2IEBAIENv ZGVCbG9jazo6Q29kZUJsb2NrKFNjcmlwdEV4ZWN1dGFibGUqIG8KICAgICAgICAgICAgIGluc3Ry dWN0aW9uc1tpICsgb3BMZW5ndGggLSAxXSA9ICZtX2FycmF5QWxsb2NhdGlvblByb2ZpbGVzW2Fy cmF5QWxsb2NhdGlvblByb2ZpbGVJbmRleF07CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAg fQotI2VuZGlmCiAgICAgICAgIGNhc2Ugb3BfbmV3X29iamVjdDogewogICAgICAgICAgICAgaW50 IG9iamVjdEFsbG9jYXRpb25Qcm9maWxlSW5kZXggPSBwY1tpICsgb3BMZW5ndGggLSAxXS51Lm9w ZXJhbmQ7CiAgICAgICAgICAgICBPYmplY3RBbGxvY2F0aW9uUHJvZmlsZSogb2JqZWN0QWxsb2Nh dGlvblByb2ZpbGUgPSAmbV9vYmplY3RBbGxvY2F0aW9uUHJvZmlsZXNbb2JqZWN0QWxsb2NhdGlv blByb2ZpbGVJbmRleF07CkBAIC0xNzE5LDcgKzE3MTUsNiBAQCBDb2RlQmxvY2s6OkNvZGVCbG9j ayhTY3JpcHRFeGVjdXRhYmxlKiBvCiAKICAgICAgICAgY2FzZSBvcF9jYWxsOgogICAgICAgICBj YXNlIG9wX2NhbGxfZXZhbDogewotI2lmIEVOQUJMRShERkdfSklUKQogICAgICAgICAgICAgVmFs dWVQcm9maWxlKiBwcm9maWxlID0gJm1fdmFsdWVQcm9maWxlc1twY1tpICsgb3BMZW5ndGggLSAx XS51Lm9wZXJhbmRdOwogICAgICAgICAgICAgQVNTRVJUKHByb2ZpbGUtPm1fYnl0ZWNvZGVPZmZz ZXQgPT0gLTEpOwogICAgICAgICAgICAgcHJvZmlsZS0+bV9ieXRlY29kZU9mZnNldCA9IGk7CkBA IC0xNzI3LDcgKzE3MjIsNiBAQCBDb2RlQmxvY2s6OkNvZGVCbG9jayhTY3JpcHRFeGVjdXRhYmxl KiBvCiAgICAgICAgICAgICBpbnQgYXJyYXlQcm9maWxlSW5kZXggPSBwY1tpICsgb3BMZW5ndGgg LSAyXS51Lm9wZXJhbmQ7CiAgICAgICAgICAgICBtX2FycmF5UHJvZmlsZXNbYXJyYXlQcm9maWxl SW5kZXhdID0gQXJyYXlQcm9maWxlKGkpOwogICAgICAgICAgICAgaW5zdHJ1Y3Rpb25zW2kgKyBv cExlbmd0aCAtIDJdID0gJm1fYXJyYXlQcm9maWxlc1thcnJheVByb2ZpbGVJbmRleF07Ci0jZW5k aWYKICNpZiBFTkFCTEUoTExJTlQpCiAgICAgICAgICAgICBpbnN0cnVjdGlvbnNbaSArIDVdID0g Jm1fbGxpbnRDYWxsTGlua0luZm9zW3BjW2kgKyA1XS51Lm9wZXJhbmRdOwogI2VuZGlmCkBAIC0x NzM3LDEyICsxNzMxLDEwIEBAIENvZGVCbG9jazo6Q29kZUJsb2NrKFNjcmlwdEV4ZWN1dGFibGUq IG8KICNpZiBFTkFCTEUoTExJTlQpCiAgICAgICAgICAgICBpbnN0cnVjdGlvbnNbaSArIDVdID0g Jm1fbGxpbnRDYWxsTGlua0luZm9zW3BjW2kgKyA1XS51Lm9wZXJhbmRdOwogI2VuZGlmCi0jaWYg RU5BQkxFKERGR19KSVQpCiAgICAgICAgICAgICBWYWx1ZVByb2ZpbGUqIHByb2ZpbGUgPSAmbV92 YWx1ZVByb2ZpbGVzW3BjW2kgKyBvcExlbmd0aCAtIDFdLnUub3BlcmFuZF07CiAgICAgICAgICAg ICBBU1NFUlQocHJvZmlsZS0+bV9ieXRlY29kZU9mZnNldCA9PSAtMSk7CiAgICAgICAgICAgICBw cm9maWxlLT5tX2J5dGVjb2RlT2Zmc2V0ID0gaTsKICAgICAgICAgICAgIGluc3RydWN0aW9uc1tp ICsgb3BMZW5ndGggLSAxXSA9IHByb2ZpbGU7Ci0jZW5kaWYKICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICB9CiAgICAgICAgIGNhc2Ugb3BfZ2V0X2J5X2lkX291dF9vZl9saW5lOgo=