126587 2014-01-07 12:08:27 -0800 FTL OSR entry should only check input variable types after it has set up OSR exit availability of those OSR entry values 2014-01-07 12:49:33 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 112840 1 fpizlo fpizlo barraclough ggaren mark.lam mhahnenberg msaboff oliver sam oldest_to_newest 965107 0 fpizlo 2014-01-07 12:08:27 -0800 There's nothing more hilarious than OSR exiting during OSR entry. Patch forthcoming. 965109 1 220538 fpizlo 2014-01-07 12:11:32 -0800 Created attachment 220538 the patch 965110 2 fpizlo 2014-01-07 12:13:04 -0800 Landed on branch in http://trac.webkit.org/changeset/161445 965119 3 220538 ggaren 2014-01-07 12:45:30 -0800 Comment on attachment 220538 the patch r=me 220538 2014-01-07 12:11:32 -0800 2014-01-07 12:45:30 -0800 the patch blah.patch text/plain 7668 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxNDQ0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBA CisyMDE0LTAxLTA3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RlRMIE9TUiBlbnRyeSBzaG91bGQgb25seSBjaGVjayBpbnB1dCB2YXJpYWJsZSB0eXBlcyBhZnRl ciBpdCBoYXMgc2V0IHVwIE9TUiBleGl0IGF2YWlsYWJpbGl0eSBvZiB0aG9zZSBPU1IgZW50cnkg dmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MjY1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisg ICAgICAgIEF0IHRoZSBwcm9sb2d1ZSBvZiBPU1IgZW50cnksIERGRyBJUiBrbm93cyB3aGVyZSB0 aGUgYXJndW1lbnRzIGFyZSBidXQgaGFzIG5vIGlkZWEKKyAgICAgICAgd2hlcmUgdGhlIGxvY2Fs cyBhcmUuIFNvLCBiZWZvcmUgT1NSIGVudHJ5IHN0YXJ0cyBkb2luZyBzcGVjdWxhdGlvbiBjaGVj a3MsIGl0CisgICAgICAgIHNob3VsZCBlc3RhYmxpc2ggKHZpYSBNb3ZIaW50cykgd2hlcmUgdGhl IGxvY2FscyBhcmUuIFRoZW4gaXQgY2FuIGRvIHRoZSBjaGVja3MKKyAgICAgICAgKG5hbWVseSwg dGhlIFNldEFyZ3VtZW50L1NldExvY2FsJ3MpLgorICAgICAgICAKKyAgICAgICAgQWxzbyBtYWtl IHRoaW5ncyBhIGJpdCBlYXNpZXIgdG8gZGVidWcgYnkgbWFraW5nIHZlcmJvc2VPU1IoKSBwcmlu dCBPU1IgZXhpdAorICAgICAgICBkaXNhc3NlbWJsaWVzLgorICAgICAgICAKKyAgICAgICAgKiBh c3NlbWJsZXIvTGlua0J1ZmZlci5jcHA6CisgICAgICAgIChKU0M6OkxpbmtCdWZmZXI6OmZpbmFs aXplQ29kZVdpdGhEaXNhc3NlbWJseSk6CisgICAgICAgICogZGZnL0RGR09TUkF2YWlsYWJpbGl0 eUFuYWx5c2lzUGhhc2UuY3BwOgorICAgICAgICAoSlNDOjpERkc6Ok9TUkF2YWlsYWJpbGl0eUFu YWx5c2lzUGhhc2U6OnJ1bik6CisgICAgICAgICogZGZnL0RGR09TUkVudHJ5cG9pbnRDcmVhdGlv blBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpPU1JFbnRyeXBvaW50Q3JlYXRpb25QaGFz ZTo6cnVuKToKKyAgICAgICAgKiBkZmcvREZHT1NSRXhpdENvbXBpbGVyLmNwcDoKKyAgICAgICAg KiBmdGwvRlRMT1NSRXhpdENvbXBpbGVyLmNwcDoKKyAgICAgICAgKEpTQzo6RlRMOjpjb21waWxl U3R1Yik6CisgICAgICAgICogcnVudGltZS9Db21tb25TbG93UGF0aHMuY3BwOgorICAgICAgICAo SlNDOjpTTE9XX1BBVEhfREVDTCk6CisKIDIwMTQtMDEtMDcgIE1pY2hhZWwgU2Fib2ZmICA8bXNh Ym9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQ1N0YWNrIEJyYW5jaDogQVJNNjQgQ3Jhc2ggcnVu bmluZyBlY21hL0Z1bmN0aW9uT2JqZWN0cy8xNS4zLjEuMS0zLmpzCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL0xpbmtCdWZmZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTGlua0J1ZmZlci5jcHAJKHJldmlzaW9uIDE2MTQw OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTGlua0J1ZmZlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQ2LDggKzQ2LDYgQEAgTGlua0J1ZmZlcjo6Q29kZVJlZiBMaW5rQnVm ZmVyOjpmaW5hbGl6ZQogCiBMaW5rQnVmZmVyOjpDb2RlUmVmIExpbmtCdWZmZXI6OmZpbmFsaXpl Q29kZVdpdGhEaXNhc3NlbWJseShjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikKIHsKLSAgICBBU1NF UlQoT3B0aW9uczo6c2hvd0Rpc2Fzc2VtYmx5KCkgfHwgT3B0aW9uczo6c2hvd0RGR0Rpc2Fzc2Vt Ymx5KCkpOwotICAgIAogICAgIENvZGVSZWYgcmVzdWx0ID0gZmluYWxpemVDb2RlV2l0aG91dERp c2Fzc2VtYmx5KCk7CiAKICNpZiBFTkFCTEUoRElTQVNTRU1CTEVSKQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JBdmFpbGFiaWxpdHlBbmFseXNpc1BoYXNlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkF2YWlsYWJpbGl0eUFu YWx5c2lzUGhhc2UuY3BwCShyZXZpc2lvbiAxNjE0MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR09TUkF2YWlsYWJpbGl0eUFuYWx5c2lzUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02MSwxNSArNjEsMTMgQEAgcHVibGljOgogICAgICAgICAgICAgICAgIEF2YWlsYWJpbGl0 eTo6dW5hdmFpbGFibGUoKS53aXRoRmx1c2goCiAgICAgICAgICAgICAgICAgICAgIEZsdXNoZWRB dChGbHVzaGVkSlNWYWx1ZSwgdmlydHVhbFJlZ2lzdGVyRm9yQXJndW1lbnQoYXJndW1lbnQpKSk7 CiAgICAgICAgIH0KLSAgICAgICAgZm9yICh1bnNpZ25lZCBsb2NhbCA9IHJvb3QtPnNzYS0+YXZh aWxhYmlsaXR5QXRIZWFkLm51bWJlck9mTG9jYWxzKCk7IGxvY2FsLS07KQotICAgICAgICAgICAg cm9vdC0+c3NhLT5hdmFpbGFiaWxpdHlBdEhlYWQubG9jYWwobG9jYWwpID0gQXZhaWxhYmlsaXR5 Ojp1bmF2YWlsYWJsZSgpOwotICAgICAgICAKKwogICAgICAgICBpZiAobV9ncmFwaC5tX3BsYW4u bW9kZSA9PSBGVExGb3JPU1JFbnRyeU1vZGUpIHsKLSAgICAgICAgICAgIGZvciAodW5zaWduZWQg bG9jYWwgPSBtX2dyYXBoLm1fcHJvZmlsZWRCbG9jay0+bV9udW1DYWxsZWVSZWdpc3RlcnM7IGxv Y2FsLS07KSB7Ci0gICAgICAgICAgICAgICAgcm9vdC0+c3NhLT5hdmFpbGFiaWxpdHlBdEhlYWQu bG9jYWwobG9jYWwpID0KLSAgICAgICAgICAgICAgICAgICAgQXZhaWxhYmlsaXR5Ojp1bmF2YWls YWJsZSgpLndpdGhGbHVzaCgKLSAgICAgICAgICAgICAgICAgICAgICAgIEZsdXNoZWRBdChGbHVz aGVkSlNWYWx1ZSwgdmlydHVhbFJlZ2lzdGVyRm9yTG9jYWwobG9jYWwpKSk7Ci0gICAgICAgICAg ICB9CisgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGxvY2FsID0gbV9ncmFwaC5tX3Byb2ZpbGVk QmxvY2stPm1fbnVtQ2FsbGVlUmVnaXN0ZXJzOyBsb2NhbC0tOykKKyAgICAgICAgICAgICAgICBy b290LT5zc2EtPmF2YWlsYWJpbGl0eUF0SGVhZC5sb2NhbChsb2NhbCkgPSBBdmFpbGFiaWxpdHk6 OnVuYXZhaWxhYmxlKCk7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBmb3IgKHVuc2ln bmVkIGxvY2FsID0gcm9vdC0+c3NhLT5hdmFpbGFiaWxpdHlBdEhlYWQubnVtYmVyT2ZMb2NhbHMo KTsgbG9jYWwtLTspCisgICAgICAgICAgICAgICAgcm9vdC0+c3NhLT5hdmFpbGFiaWxpdHlBdEhl YWQubG9jYWwobG9jYWwpID0gQXZhaWxhYmlsaXR5Ojp1bmF2YWlsYWJsZSgpOwogICAgICAgICB9 CiAgICAgICAgIAogICAgICAgICAvLyBUaGlzIGNvdWxkIGJlIG1hZGUgbW9yZSBlZmZpY2llbnQg YnkgcHJvY2Vzc2luZyBibG9ja3MgaW4gcmV2ZXJzZSBwb3N0b3JkZXIuCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkVudHJ5cG9pbnRDcmVhdGlvblBoYXNlLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkVudHJ5cG9pbnRDcmVh dGlvblBoYXNlLmNwcAkocmV2aXNpb24gMTYxNDA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdPU1JFbnRyeXBvaW50Q3JlYXRpb25QaGFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTgzLDE3ICs4Myw2IEBAIHB1YmxpYzoKICAgICAgICAgQmFzaWNCbG9jayogbmV3Um9vdCA9IGlu c2VydGlvblNldC5pbnNlcnQoMCk7CiAgICAgICAgIENvZGVPcmlnaW4gY29kZU9yaWdpbiA9IHRh cmdldC0+YXQoMCktPmNvZGVPcmlnaW47CiAgICAgICAgIAotICAgICAgICBmb3IgKGludCBhcmd1 bWVudCA9IDA7IGFyZ3VtZW50IDwgYmFzZWxpbmUtPm51bVBhcmFtZXRlcnMoKTsgKythcmd1bWVu dCkgewotICAgICAgICAgICAgTm9kZSogb2xkTm9kZSA9IHRhcmdldC0+dmFyaWFibGVzQXRIZWFk LmFyZ3VtZW50KGFyZ3VtZW50KTsKLSAgICAgICAgICAgIGlmICghb2xkTm9kZSkgewotICAgICAg ICAgICAgICAgIC8vIEp1c3QgZm9yIHNhbml0eSwgYWx3YXlzIGhhdmUgYSBTZXRBcmd1bWVudCBl dmVuIGlmIGl0J3Mgbm90IG5lZWRlZC4KLSAgICAgICAgICAgICAgICBvbGROb2RlID0gbV9ncmFw aC5tX2FyZ3VtZW50c1thcmd1bWVudF07Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBOb2Rl KiBub2RlID0gbmV3Um9vdC0+YXBwZW5kTm9kZSgKLSAgICAgICAgICAgICAgICBtX2dyYXBoLCBT cGVjTm9uZSwgU2V0QXJndW1lbnQsIGNvZGVPcmlnaW4sCi0gICAgICAgICAgICAgICAgT3BJbmZv KG9sZE5vZGUtPnZhcmlhYmxlQWNjZXNzRGF0YSgpKSk7Ci0gICAgICAgICAgICBtX2dyYXBoLm1f YXJndW1lbnRzW2FyZ3VtZW50XSA9IG5vZGU7Ci0gICAgICAgIH0KICAgICAgICAgVmVjdG9yPE5v ZGUqPiBsb2NhbHMoYmFzZWxpbmUtPm1fbnVtQ2FsbGVlUmVnaXN0ZXJzKTsKICAgICAgICAgZm9y IChpbnQgbG9jYWwgPSAwOyBsb2NhbCA8IGJhc2VsaW5lLT5tX251bUNhbGxlZVJlZ2lzdGVyczsg Kytsb2NhbCkgewogICAgICAgICAgICAgTm9kZSogcHJldmlvdXNIZWFkID0gdGFyZ2V0LT52YXJp YWJsZXNBdEhlYWQubG9jYWwobG9jYWwpOwpAQCAtMTA4LDYgKzk3LDE5IEBAIHB1YmxpYzoKICAg ICAgICAgICAgICAgICBtX2dyYXBoLCBTcGVjTm9uZSwgTW92SGludCwgY29kZU9yaWdpbiwgT3BJ bmZvKHZhcmlhYmxlLT5sb2NhbCgpLm9mZnNldCgpKSwKICAgICAgICAgICAgICAgICBFZGdlKGxv Y2Fsc1tsb2NhbF0pKTsKICAgICAgICAgfQorCisgICAgICAgIGZvciAoaW50IGFyZ3VtZW50ID0g MDsgYXJndW1lbnQgPCBiYXNlbGluZS0+bnVtUGFyYW1ldGVycygpOyArK2FyZ3VtZW50KSB7Cisg ICAgICAgICAgICBOb2RlKiBvbGROb2RlID0gdGFyZ2V0LT52YXJpYWJsZXNBdEhlYWQuYXJndW1l bnQoYXJndW1lbnQpOworICAgICAgICAgICAgaWYgKCFvbGROb2RlKSB7CisgICAgICAgICAgICAg ICAgLy8gSnVzdCBmb3Igc2FuaXR5LCBhbHdheXMgaGF2ZSBhIFNldEFyZ3VtZW50IGV2ZW4gaWYg aXQncyBub3QgbmVlZGVkLgorICAgICAgICAgICAgICAgIG9sZE5vZGUgPSBtX2dyYXBoLm1fYXJn dW1lbnRzW2FyZ3VtZW50XTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIE5vZGUqIG5vZGUg PSBuZXdSb290LT5hcHBlbmROb2RlKAorICAgICAgICAgICAgICAgIG1fZ3JhcGgsIFNwZWNOb25l LCBTZXRBcmd1bWVudCwgY29kZU9yaWdpbiwKKyAgICAgICAgICAgICAgICBPcEluZm8ob2xkTm9k ZS0+dmFyaWFibGVBY2Nlc3NEYXRhKCkpKTsKKyAgICAgICAgICAgIG1fZ3JhcGgubV9hcmd1bWVu dHNbYXJndW1lbnRdID0gbm9kZTsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgZm9yIChp bnQgbG9jYWwgPSAwOyBsb2NhbCA8IGJhc2VsaW5lLT5tX251bUNhbGxlZVJlZ2lzdGVyczsgKyts b2NhbCkgewogICAgICAgICAgICAgTm9kZSogcHJldmlvdXNIZWFkID0gdGFyZ2V0LT52YXJpYWJs ZXNBdEhlYWQubG9jYWwobG9jYWwpOwogICAgICAgICAgICAgaWYgKCFwcmV2aW91c0hlYWQpCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09TUkV4aXRDb21waWxlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdPU1JFeGl0Q29tcGlsZXIu Y3BwCShyZXZpc2lvbiAxNjE0MDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR09T UkV4aXRDb21waWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTk2LDcgKzk2LDcgQEAgdm9pZCBj b21waWxlT1NSRXhpdChFeGVjU3RhdGUqIGV4ZWMpCiAgICAgICAgIAogICAgICAgICBMaW5rQnVm ZmVyIHBhdGNoQnVmZmVyKCp2bSwgJmppdCwgY29kZUJsb2NrKTsKICAgICAgICAgZXhpdC5tX2Nv ZGUgPSBGSU5BTElaRV9DT0RFX0lGKAotICAgICAgICAgICAgc2hvdWxkU2hvd0Rpc2Fzc2VtYmx5 KCksCisgICAgICAgICAgICBzaG91bGRTaG93RGlzYXNzZW1ibHkoKSB8fCBPcHRpb25zOjp2ZXJi b3NlT1NSKCksCiAgICAgICAgICAgICBwYXRjaEJ1ZmZlciwKICAgICAgICAgICAgICgiREZHIE9T UiBleGl0ICMldSAoJXMsICVzKSBmcm9tICVzLCB3aXRoIG9wZXJhbmRzID0gJXMiLAogICAgICAg ICAgICAgICAgIGV4aXRJbmRleCwgdG9DU3RyaW5nKGV4aXQubV9jb2RlT3JpZ2luKS5kYXRhKCks CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTE9TUkV4aXRDb21waWxlci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExPU1JFeGl0Q29tcGls ZXIuY3BwCShyZXZpc2lvbiAxNjE0MDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZU TE9TUkV4aXRDb21waWxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5MSw3ICsyOTEsNyBAQCBz dGF0aWMgdm9pZCBjb21waWxlU3R1YigKICAgICAKICAgICBMaW5rQnVmZmVyIHBhdGNoQnVmZmVy KCp2bSwgJmppdCwgY29kZUJsb2NrKTsKICAgICBleGl0Lm1fY29kZSA9IEZJTkFMSVpFX0NPREVf SUYoCi0gICAgICAgIHNob3VsZFNob3dEaXNhc3NlbWJseSgpLAorICAgICAgICBzaG91bGRTaG93 RGlzYXNzZW1ibHkoKSB8fCBPcHRpb25zOjp2ZXJib3NlT1NSKCksCiAgICAgICAgIHBhdGNoQnVm ZmVyLAogICAgICAgICAoIkZUTCBPU1IgZXhpdCAjJXUgKCVzLCAlcykgZnJvbSAlcywgd2l0aCBv cGVyYW5kcyA9ICVzLCBhbmQgcmVjb3JkID0gJXMiLAogICAgICAgICAgICAgZXhpdElELCB0b0NT dHJpbmcoZXhpdC5tX2NvZGVPcmlnaW4pLmRhdGEoKSwKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0NvbW1vblNsb3dQYXRocy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcAkocmV2aXNpb24gMTYxNDA5 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29tbW9uU2xvd1BhdGhzLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzYwLDYgKzM2MCw3IEBAIFNMT1dfUEFUSF9ERUNMKHNsb3dfcGF0 aF9uZWdhdGUpCiBTTE9XX1BBVEhfREVDTChzbG93X3BhdGhfYWRkKQogewogICAgIEJFR0lOKCk7 CisgICAgCiAgICAgSlNWYWx1ZSB2MSA9IE9QX0MoMikuanNWYWx1ZSgpOwogICAgIEpTVmFsdWUg djIgPSBPUF9DKDMpLmpzVmFsdWUoKTsKICAgICAK