126582 2014-01-07 07:27:27 -0800 [GTK][CMake] Links system library to gtkdoc-scan instead of the built one 2014-01-09 06:07:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 gustavo gustavo mrobinson oldest_to_newest 965007 0 gustavo 2014-01-07 07:27:27 -0800 [GTK][CMake] Links system library to gtkdoc-scan instead of the built one 965008 1 220524 gustavo 2014-01-07 07:28:54 -0800 Created attachment 220524 Patch 965022 2 220524 mrobinson 2014-01-07 08:25:12 -0800 Comment on attachment 220524 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220524&action=review > Tools/gtk/common.py:48 > + library_build_dir = build_path(*args) What's going on here that it needs the root of the build directory instead of the directory with the libraries? 965432 3 gustavo 2014-01-08 04:14:54 -0800 (In reply to comment #2) > > Tools/gtk/common.py:48 > > + library_build_dir = build_path(*args) > > What's going on here that it needs the root of the build directory instead of the directory with the libraries? Exactly! We could land your patch to put the binaries in bin/ and libs in lib/ instead if you prefer, I don't know why they started going to the root, so it may be better to be explicit about it, r=me on it. 965697 4 mrobinson 2014-01-08 17:16:12 -0800 Thanks. Landed this in: http://trac.webkit.org/changeset/161528. 965860 5 220524 gustavo 2014-01-09 06:07:21 -0800 Comment on attachment 220524 Patch Thanks! 220524 2014-01-07 07:28:54 -0800 2014-01-09 06:07:20 -0800 Patch bug-126582-20140107132852.patch text/plain 1182 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxNDI2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWEzZjdiZDZiMjBkYzMwODRkMDlkMjA1N2JlYTE3ZmE0 OTUwN2FmZC4uOWViMmI3NmU4MzI0MDg0MTllMGU3NjY1ZTk1Y2E4YjJiMWNmNDVmMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTAxLTA3ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxnbnNAZ25vbWUub3JnPgor CisgICAgICAgIFtHVEtdW0NNYWtlXSBMaW5rcyBzeXN0ZW0gbGlicmFyeSB0byBndGtkb2Mtc2Nh biBpbnN0ZWFkIG9mIHRoZSBidWlsdCBvbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEyNjU4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZ3RrL2NvbW1vbi5weToKKyAgICAgICAgKGxpYnJhcnlfYnVp bGRfcGF0aCk6CisKIDIwMTQtMDEtMDcgIEJyaWFuIEhvbHQgIDxicmlhbi5ob2x0QHNhbXN1bmcu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEFkZCBteXNlbGYgYXMgYSBjb21taXR0ZXIuCmRp ZmYgLS1naXQgYS9Ub29scy9ndGsvY29tbW9uLnB5IGIvVG9vbHMvZ3RrL2NvbW1vbi5weQppbmRl eCAwMmRiOTMyN2ViMWU5NjhlNDgwOGI2ZDZiOTc0MTA5NzZiOWIzMzBiLi4yODEwZjVmMWQ5OWUz NDVhYTM1YWYyYTNjMzdmZWU1ZWYyNjYzZmYxIDEwMDY0NAotLS0gYS9Ub29scy9ndGsvY29tbW9u LnB5CisrKyBiL1Rvb2xzL2d0ay9jb21tb24ucHkKQEAgLTQ1LDcgKzQ1LDcgQEAgZGVmIGxpYnJh cnlfYnVpbGRfcGF0aCgqYXJncyk6CiAgICAgZ2xvYmFsIGxpYnJhcnlfYnVpbGRfZGlyCiAgICAg aWYgbm90IGxpYnJhcnlfYnVpbGRfZGlyOgogICAgICAgICBpZiBpc19jbWFrZV9idWlsZCgpOgot ICAgICAgICAgICAgbGlicmFyeV9idWlsZF9kaXIgPSBidWlsZF9wYXRoKCdsaWInLCAqYXJncykK KyAgICAgICAgICAgIGxpYnJhcnlfYnVpbGRfZGlyID0gYnVpbGRfcGF0aCgqYXJncykKICAgICAg ICAgZWxzZToKICAgICAgICAgICAgIGxpYnJhcnlfYnVpbGRfZGlyID0gYnVpbGRfcGF0aCgnLmxp YnMnLCAqYXJncykKICAgICByZXR1cm4gbGlicmFyeV9idWlsZF9kaXIK