126579 2014-01-07 06:37:29 -0800 AX: Make roleValue() return DescriptionListRole for <dl> elements 2014-01-08 02:54:51 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mario webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 964988 0 mario 2014-01-07 06:37:29 -0800 At the moment, roleValue() returns ListRole for every list element, even <dl> ones and so we need to check the result of isDescriptionList() in places where we want to know if it's a normal list or a description list (e.g. the ATK wrapper). This bug is about fixing that small issue, according to the comments on bug 125857. 964989 1 webkit-bug-importer 2014-01-07 06:38:17 -0800 <rdar://problem/15762003> 965002 2 220523 mario 2014-01-07 07:15:46 -0800 Created attachment 220523 Patch proposal Attaching patch proposal. In the end, I think no change is needed in the Mac since the code to map DescriptionListRole into NSAccessibilityListRole in role(), and the code to return NSAccessibilityDescriptionListSubrole/NSAccessibilityDefinitionListSubrole is already there and should keep working fine. 965417 3 mario 2014-01-08 02:54:51 -0800 Committed r161492: <http://trac.webkit.org/changeset/161492> 220523 2014-01-07 07:15:46 -0800 2014-01-07 09:15:55 -0800 Patch proposal 0001-2014-01-07-Mario-Sanchez-Prada-mario.prada-samsung.c.patch text/plain 4399 mario RnJvbSAzNmJmYzY4ODA5MjQyNzUxNTQ4ODBlMWVjMjEzNDNkNWRiNTkwYWM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpby5wcmFkYUBzYW1z dW5nLmNvbT4KRGF0ZTogVHVlLCA3IEphbiAyMDE0IDE1OjEyOjQ2ICswMDAwClN1YmplY3Q6IFtQ QVRDSF0gMjAxNC0wMS0wNyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1hcmlvLnByYWRhQHNhbXN1 bmcuY29tPgoKICAgICAgICBBWDogTWFrZSByb2xlVmFsdWUoKSByZXR1cm4gRGVzY3JpcHRpb25M aXN0Um9sZSBmb3IgPGRsPiBlbGVtZW50cwogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMjY1NzkKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCgogICAgICAgIEltcGxlbWVudCBBY2Nlc3NpYmlsaXR5TGlzdDo6cm9sZVZhbHVlKCkgc28g aXQgd2lsbCByZXR1cm4KICAgICAgICBMaXN0Um9sZSBvciBEZXNjcmlwdGlvbkxpc3RSb2xlIGRl cGVuZGluZyBvbiB0aGUgdHlwZSBvZiBsaXN0LgoKICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVk LCBhcyBubyBuZXcgZnVuY3Rpb25hbGl0eSB3YXMgYWRkZWQgYW5kIHBvcnRzCiAgICAgICAgc2hv dWxkIHN0aWxsIGJlIGV4cG9zaW5nIHRoZSByaWdodCByb2xlIGZvciA8ZGw+IGVsZW1lbnRzCgog ICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5jcHA6CiAgICAgICAgKFdl YkNvcmU6OkFjY2Vzc2liaWxpdHlMaXN0Ojpyb2xlVmFsdWUpOiBJbXBsZW1lbnRlZC4KICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3QuaDoKCiAgICAgICAgKiBhY2Nlc3Np YmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6CiAgICAgICAgKGF0a1Jv bGUpOiBSZW1vdmVkIGV4dHJhIGNoZWNrcyBmb3Igb2JqZWN0cyB3aXRoIExpc3RSb2xlIHJvbGUu Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDIwICsrKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlMaXN0LmNwcCB8ICAgIDcgKysrKysrKwogU291cmNlL1dlYkNvcmUvYWNj ZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5oICAgfCAgICAyICstCiAuLi4vYXRrL1dlYktp dEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcCAgICAgICAgICAgICB8ICAgIDQgLS0tLQogNCBmaWxl cyBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBlMzI1MzA0Li43YTQ4MTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTQtMDEt MDcgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpby5wcmFkYUBzYW1zdW5nLmNvbT4KKworICAg ICAgICBBWDogTWFrZSByb2xlVmFsdWUoKSByZXR1cm4gRGVzY3JpcHRpb25MaXN0Um9sZSBmb3Ig PGRsPiBlbGVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTI2NTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW1wbGVtZW50IEFjY2Vzc2liaWxpdHlMaXN0Ojpyb2xlVmFsdWUoKSBzbyBpdCB3aWxs IHJldHVybgorICAgICAgICBMaXN0Um9sZSBvciBEZXNjcmlwdGlvbkxpc3RSb2xlIGRlcGVuZGlu ZyBvbiB0aGUgdHlwZSBvZiBsaXN0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQsIGFz IG5vIG5ldyBmdW5jdGlvbmFsaXR5IHdhcyBhZGRlZCBhbmQgcG9ydHMKKyAgICAgICAgc2hvdWxk IHN0aWxsIGJlIGV4cG9zaW5nIHRoZSByaWdodCByb2xlIGZvciA8ZGw+IGVsZW1lbnRzCisKKyAg ICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkFjY2Vzc2liaWxpdHlMaXN0Ojpyb2xlVmFsdWUpOiBJbXBsZW1lbnRlZC4KKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlMaXN0Lmg6CisKKyAgICAgICAgKiBhY2Nl c3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHA6CisgICAgICAgIChh dGtSb2xlKTogUmVtb3ZlZCBleHRyYSBjaGVja3MgZm9yIG9iamVjdHMgd2l0aCBMaXN0Um9sZSBy b2xlLgorCiAyMDE0LTAxLTA2ICBHdXJwcmVldCBLYXVyICA8ay5ndXJwcmVldEBzYW1zdW5nLmNv bT4KIAogICAgICAgICA8aHI+IGFwcGVhcnMgZ3JheSBpbnN0ZWFkIG9mIGdyZWVuIGJlY2F1c2Ug b2YgY29sb3IgYXR0cmlidXRlIGlzIGRlZmluZWQgZm9sbG93ZWQgYnkgbm9zaGFkZSBhdHRyaWJ1 dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eUxpc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlz dC5jcHAKaW5kZXggYTI0MDZiYS4uNjlhYTcxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TGlzdC5jcHAKQEAgLTkzLDYgKzkzLDEzIEBAIGJv b2wgQWNjZXNzaWJpbGl0eUxpc3Q6OmlzRGVzY3JpcHRpb25MaXN0KCkgY29uc3QKICAgICBOb2Rl KiBub2RlID0gbV9yZW5kZXJlci0+bm9kZSgpOwogICAgIHJldHVybiBub2RlICYmIG5vZGUtPmhh c1RhZ05hbWUoZGxUYWcpOyAgICAKIH0KKworQWNjZXNzaWJpbGl0eVJvbGUgQWNjZXNzaWJpbGl0 eUxpc3Q6OnJvbGVWYWx1ZSgpIGNvbnN0Cit7CisgICAgaWYgKGlzRGVzY3JpcHRpb25MaXN0KCkp CisgICAgICAgIHJldHVybiBEZXNjcmlwdGlvbkxpc3RSb2xlOwogICAgIAorICAgIHJldHVybiBM aXN0Um9sZTsKK30KICAgICAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3QuaCBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eUxpc3QuaAppbmRleCBiZDhhYmM1Li4z MWU5YjFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlMaXN0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5TGlzdC5oCkBAIC00Niw3ICs0Niw3IEBAIHB1YmxpYzoKICAgICBib29sIGlzT3JkZXJlZExp c3QoKSBjb25zdDsKICAgICBib29sIGlzRGVzY3JpcHRpb25MaXN0KCkgY29uc3Q7CiAKLSAgICB2 aXJ0dWFsIEFjY2Vzc2liaWxpdHlSb2xlIHJvbGVWYWx1ZSgpIGNvbnN0IE9WRVJSSURFIHsgcmV0 dXJuIExpc3RSb2xlOyB9CisgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5Um9sZSByb2xlVmFsdWUo KSBjb25zdCBPVkVSUklERSBGSU5BTDsKIHByaXZhdGU6CiAgICAgdmlydHVhbCBib29sIGNvbXB1 dGVBY2Nlc3NpYmlsaXR5SXNJZ25vcmVkKCkgY29uc3QgT1ZFUlJJREU7CiB9OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBw ZXJBdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNz aWJsZVdyYXBwZXJBdGsuY3BwCmluZGV4IDdlODg4ODUuLmJmZTcwNTUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRr LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3Np YmxlV3JhcHBlckF0ay5jcHAKQEAgLTYzNCwxMCArNjM0LDYgQEAgc3RhdGljIEF0a1JvbGUgYXRr Um9sZShBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0KQogICAgIGNhc2UgQ29sb3JXZWxs Um9sZToKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX0NPTE9SX0NIT09TRVI7CiAgICAgY2FzZSBM aXN0Um9sZToKLSNpZiBBVEtfQ0hFQ0tfVkVSU0lPTigyLCAxMSwgNCkKLSAgICAgICAgaWYgKGNv cmVPYmplY3QtPmlzTGlzdCgpICYmIHRvQWNjZXNzaWJpbGl0eUxpc3QoY29yZU9iamVjdCktPmlz RGVzY3JpcHRpb25MaXN0KCkpCi0gICAgICAgICAgICByZXR1cm4gQVRLX1JPTEVfREVTQ1JJUFRJ T05fTElTVDsKLSNlbmRpZgogICAgICAgICByZXR1cm4gQVRLX1JPTEVfTElTVDsKICAgICBjYXNl IFNjcm9sbEJhclJvbGU6CiAgICAgICAgIHJldHVybiBBVEtfUk9MRV9TQ1JPTExfQkFSOwotLSAK MS43LjEwLjQKCg==