<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126578</bug_id>
          
          <creation_ts>2014-01-07 06:22:12 -0800</creation_ts>
          <short_desc>Fix compilation issue with GLES2 after http://webkit.org/b/126548</short_desc>
          <delta_ts>2014-01-13 05:42:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Platform</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Pascal Jacquemart">p.jacquemart</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bfulgham</cc>
    
    <cc>boxerlee</cc>
    
    <cc>bw80.lee</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jonlee</cc>
    
    <cc>laszlo.gombos</cc>
    
    <cc>mbaker</cc>
    
    <cc>ossy</cc>
    
    <cc>peavo</cc>
    
    <cc>roger_fong</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>964979</commentid>
    <comment_count>0</comment_count>
    <who name="Pascal Jacquemart">p.jacquemart</who>
    <bug_when>2014-01-07 06:22:12 -0800</bug_when>
    <thetext>Missing include ;-{</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>964981</commentid>
    <comment_count>1</comment_count>
      <attachid>220520</attachid>
    <who name="Pascal Jacquemart">p.jacquemart</who>
    <bug_when>2014-01-07 06:27:02 -0800</bug_when>
    <thetext>Created attachment 220520
Adding GLES include

Simply adding GLES2/gl2.h include 
Beware such include is not present in OpenGLESShims.h</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>965011</commentid>
    <comment_count>2</comment_count>
      <attachid>220520</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-01-07 07:44:49 -0800</bug_when>
    <thetext>Comment on attachment 220520
Adding GLES include

Sorry!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>965012</commentid>
    <comment_count>3</comment_count>
      <attachid>220520</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-07 07:46:01 -0800</bug_when>
    <thetext>Comment on attachment 220520
Adding GLES include

Rejecting attachment 220520 from commit-queue.

Failed to run &quot;[&apos;/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=webkit-queues.appspot.com&apos;, &apos;--bot-id=webkit-cq-01&apos;, &apos;validate-changelog&apos;, &apos;--check-oops&apos;, &apos;--non-interactive&apos;, 220520, &apos;--port=mac&apos;]&quot; exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6347019723472896</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>965021</commentid>
    <comment_count>4</comment_count>
      <attachid>220530</attachid>
    <who name="Pascal Jacquemart">p.jacquemart</who>
    <bug_when>2014-01-07 08:23:44 -0800</bug_when>
    <thetext>Created attachment 220530
Adding GLES include 2

Updated bug number</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>965030</commentid>
    <comment_count>5</comment_count>
      <attachid>220530</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-01-07 08:58:38 -0800</bug_when>
    <thetext>Comment on attachment 220530
Adding GLES include 2

r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>965042</commentid>
    <comment_count>6</comment_count>
      <attachid>220530</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2014-01-07 09:31:04 -0800</bug_when>
    <thetext>Comment on attachment 220530
Adding GLES include 2

Clearing flags on attachment: 220530

Committed r161428: &lt;http://trac.webkit.org/changeset/161428&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>965049</commentid>
    <comment_count>7</comment_count>
    <who name="">peavo</who>
    <bug_when>2014-01-07 09:45:38 -0800</bug_when>
    <thetext>*** Bug 126581 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220520</attachid>
            <date>2014-01-07 06:27:02 -0800</date>
            <delta_ts>2014-01-07 07:46:01 -0800</delta_ts>
            <desc>Adding GLES include</desc>
            <filename>fix-opengles2-compilation.diff</filename>
            <type>text/plain</type>
            <size>1108</size>
            <attacher name="Pascal Jacquemart">p.jacquemart</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA3ZTA1M2JiLi40NDJhNGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTQtMDEtMDcgIFBhc2NhbCBKYWNxdWVtYXJ0ICA8cC5qYWNxdWVtYXJ0QHNhbXN1bmcu
Y29tPgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBpc3N1ZSB3aXRoIEdMRVMyIGFmdGVyIGh0
dHA6Ly93ZWJraXQub3JnL2IvMTI2NTQ4CisgICAgICAgIE5lZWQgdGhlIGJ1ZyBVUkwgKE9PUFMh
KS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBs
YXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZW1wb3JhcnlPcGVuR0xTZXR0aW5nLmNwcDogYWRkZWQg
R0xFUzIvZ2wyLmggaW5jbHVkZQorCiAyMDE0LTAxLTA3ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBs
ZS5jb20+CiAKICAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjU2Mj4gRE9NUHJvZ3Jl
c3NFdmVudCBoYXMgdW5zcGVjaWZpZWQgYXZhaWxhYmlsaXR5CmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGVtcG9yYXJ5T3BlbkdMU2V0dGluZy5j
cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGVtcG9yYXJ5T3Bl
bkdMU2V0dGluZy5jcHAKaW5kZXggOGNjOGVhYS4uZmM4NzQyYSAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL1RlbXBvcmFyeU9wZW5HTFNldHRpbmcu
Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZW1wb3Jh
cnlPcGVuR0xTZXR0aW5nLmNwcApAQCAtMzAsNiArMzAsNyBAQAogI2luY2x1ZGUgIlRlbXBvcmFy
eU9wZW5HTFNldHRpbmcuaCIKIAogI2lmIFVTRShPUEVOR0xfRVNfMikKKyNpbmNsdWRlIDxHTEVT
Mi9nbDIuaD4KICNpbmNsdWRlICJPcGVuR0xFU1NoaW1zLmgiCiAjZWxpZiBQTEFURk9STShNQUMp
CiAjaW5jbHVkZSA8T3BlbkdML2dsLmg+Cg==
</data>
<flag name="review"
          id="244252"
          type_id="1"
          status="+"
          setter="bfulgham"
    />
    <flag name="commit-queue"
          id="244253"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>220530</attachid>
            <date>2014-01-07 08:23:44 -0800</date>
            <delta_ts>2014-01-07 09:31:04 -0800</delta_ts>
            <desc>Adding GLES include 2</desc>
            <filename>fix-opengles2-compilation-2.diff</filename>
            <type>text/plain</type>
            <size>1128</size>
            <attacher name="Pascal Jacquemart">p.jacquemart</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCA3ZTA1M2JiLi40NDJhNGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y
ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg
QEAKKzIwMTQtMDEtMDcgIFBhc2NhbCBKYWNxdWVtYXJ0ICA8cC5qYWNxdWVtYXJ0QHNhbXN1bmcu
Y29tPgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiBpc3N1ZSB3aXRoIEdMRVMyIGFmdGVyIGh0
dHA6Ly93ZWJraXQub3JnL2IvMTI2NTQ4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn
L3Nob3dfYnVnLmNnaT9pZD0xMjY1NzgKKworICAgICAgICBSZXZpZXdlZCBieSAgQnJlbnQgRnVs
Z2hhbQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbmdsL1RlbXBvcmFyeU9wZW5H
TFNldHRpbmcuY3BwOiBhZGRlZCBHTEVTMi9nbDIuaCBpbmNsdWRlCisKIDIwMTQtMDEtMDcgIE1h
cmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3Jn
L2IvMTI2NTYyPiBET01Qcm9ncmVzc0V2ZW50IGhhcyB1bnNwZWNpZmllZCBhdmFpbGFiaWxpdHkK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW5nbC9UZW1w
b3JhcnlPcGVuR0xTZXR0aW5nLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz
L29wZW5nbC9UZW1wb3JhcnlPcGVuR0xTZXR0aW5nLmNwcAppbmRleCA4Y2M4ZWFhLi5mYzg3NDJh
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9vcGVuZ2wvVGVt
cG9yYXJ5T3BlbkdMU2V0dGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh
cGhpY3Mvb3BlbmdsL1RlbXBvcmFyeU9wZW5HTFNldHRpbmcuY3BwCkBAIC0zMCw2ICszMCw3IEBA
CiAjaW5jbHVkZSAiVGVtcG9yYXJ5T3BlbkdMU2V0dGluZy5oIgogCiAjaWYgVVNFKE9QRU5HTF9F
U18yKQorI2luY2x1ZGUgPEdMRVMyL2dsMi5oPgogI2luY2x1ZGUgIk9wZW5HTEVTU2hpbXMuaCIK
ICNlbGlmIFBMQVRGT1JNKE1BQykKICNpbmNsdWRlIDxPcGVuR0wvZ2wuaD4K
</data>

          </attachment>
      

    </bug>

</bugzilla>