126560 2014-01-06 19:09:09 -0800 [Mac] Fix incorrectness in use of some AppKit enums 2014-01-06 19:56:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrowe mrowe commit-queue oldest_to_newest 964844 0 mrowe 2014-01-06 19:09:09 -0800 There are places in DumpRenderTree and WebKitTestRunner where we work with AppKit enums incorrectly. We do a switch over NSScrollerPart but only handle one case, and we pass an integer to a function that expects NSBackingStoreType without a cast. 964846 1 220482 mrowe 2014-01-06 19:13:36 -0800 Created attachment 220482 Patch 964853 2 220482 commit-queue 2014-01-06 19:56:37 -0800 Comment on attachment 220482 Patch Clearing flags on attachment: 220482 Committed r161396: <http://trac.webkit.org/changeset/161396> 964854 3 commit-queue 2014-01-06 19:56:38 -0800 All reviewed patches have been landed. Closing bug. 220482 2014-01-06 19:13:36 -0800 2014-01-06 19:56:37 -0800 Patch bug-126560-20140106191340.patch text/plain 4264 mrowe U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMzgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGI4ZGRmOTcwMmFmZTZmMmQxNTAxYTJjMTAyNDM0ODgw NzMzZDMyNC4uNjU1ZjEzZWExOGY3ODU5OWMwNWYwNWJjMDZhM2Y0MmM4NjczNzgzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE0LTAxLTA2ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CisKKyAgICAgICAg PGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjU2MD4gRml4IGluY29ycmVjdG5lc3MgaW4gdXNlIG9m IHNvbWUgQXBwS2l0IGVudW1zCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAg ICAgICgtW0RSVE1vY2tTY3JvbGxlciByZWN0Rm9yUGFydDpdKTogTW92ZSB0byB1c2luZyBhbiBp ZiB3aXRoIGVhcmx5IHJldHVybiBpbnN0ZWFkIG9mIGEgc3dpdGNoCisgICAgICAgIHdpdGggYSBz aW5nbGUgY2FzZS4gVGhpcyBhdm9pZHMgdGhlIHBvdGVudGlhbCBmb3Igd2FybmluZ3MgYWJvdXQg dW5oYW5kbGVkIGNhc2VzLgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3Jt V2ViVmlld01hYy5tbToKKyAgICAgICAgKFdUUjo6UGxhdGZvcm1XZWJWaWV3OjpQbGF0Zm9ybVdl YlZpZXcpOiBDYXN0IHRoZSBhcmd1bWVudCB0byBOU0JhY2tpbmdTdG9yZVR5cGUuCisKIDIwMTQt MDEtMDQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHVEtdIE1vdmUgYWxsIEdUSy9HT2JqZWN0IHVuaXQgdGVzdHMgdG8gVG9vbHMvVGVzdFdl YktpdEFQSQpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJU cmVlLm1tIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5kZXJUcmVlLm1tCmluZGV4 IGVhOTQ0MTc3MWRiNTIwYWVmODY4YjYyNWIyMjFlODBkN2QyOTY1ODguLjkwNmQzOTg2NjY3Mzg0 YzE1ZGM2NzVkNTc1NjE0YWQwZWU2MDQ1MmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9EdW1wUmVuZGVyVHJlZS5tbQorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9tYWMv RHVtcFJlbmRlclRyZWUubW0KQEAgLTQ3OSwyNCArNDc5LDIxIEBAIHN0YXRpYyB2b2lkIGFkanVz dEZvbnRzKCkKIAogLSAoTlNSZWN0KXJlY3RGb3JQYXJ0OihOU1Njcm9sbGVyUGFydClwYXJ0Q29k ZQogewotICAgIHN3aXRjaCAocGFydENvZGUpIHsKLSAgICBjYXNlIE5TU2Nyb2xsZXJLbm9iOiB7 Ci0gICAgICAgIE5TUmVjdCBmcmFtZVJlY3QgPSBbc2VsZiBmcmFtZV07Ci0gICAgICAgIE5TUmVj dCBib3VuZHMgPSBbc2VsZiBib3VuZHNdOwotICAgICAgICBCT09MIGlzSG9yaXpvbnRhbCA9IGZy YW1lUmVjdC5zaXplLndpZHRoID4gZnJhbWVSZWN0LnNpemUuaGVpZ2h0OwotICAgICAgICBDR0Zs b2F0IHRyYWNrTGVuZ3RoID0gaXNIb3Jpem9udGFsID8gYm91bmRzLnNpemUud2lkdGggOiBib3Vu ZHMuc2l6ZS5oZWlnaHQ7Ci0gICAgICAgIENHRmxvYXQgbWluS25vYlNpemUgPSBpc0hvcml6b250 YWwgPyBib3VuZHMuc2l6ZS5oZWlnaHQgOiBib3VuZHMuc2l6ZS53aWR0aDsKLSAgICAgICAgQ0dG bG9hdCBrbm9iTGVuZ3RoID0gbWF4KG1pbktub2JTaXplLCBzdGF0aWNfY2FzdDxDR0Zsb2F0Pihy b3VuZCh0cmFja0xlbmd0aCAqIFtzZWxmIGtub2JQcm9wb3J0aW9uXSkpKTsKLSAgICAgICAgQ0dG bG9hdCBrbm9iUG9zaXRpb24gPSBzdGF0aWNfY2FzdDxDR0Zsb2F0Pigocm91bmQoW3NlbGYgZG91 YmxlVmFsdWVdICogKHRyYWNrTGVuZ3RoIC0ga25vYkxlbmd0aCkpKSk7Ci0gICAgICAgIAotICAg ICAgICBpZiAoaXNIb3Jpem9udGFsKQotICAgICAgICAgICAgcmV0dXJuIE5TTWFrZVJlY3QoYm91 bmRzLm9yaWdpbi54ICsga25vYlBvc2l0aW9uLCBib3VuZHMub3JpZ2luLnksIGtub2JMZW5ndGgs IGJvdW5kcy5zaXplLmhlaWdodCk7CisgICAgaWYgKHBhcnRDb2RlICE9IE5TU2Nyb2xsZXJLbm9i KQorICAgICAgICByZXR1cm4gW3N1cGVyIHJlY3RGb3JQYXJ0OnBhcnRDb2RlXTsKIAotICAgICAg ICByZXR1cm4gTlNNYWtlUmVjdChib3VuZHMub3JpZ2luLngsIGJvdW5kcy5vcmlnaW4ueSArICAr IGtub2JQb3NpdGlvbiwgYm91bmRzLnNpemUud2lkdGgsIGtub2JMZW5ndGgpOwotICAgIH0KLSAg ICB9CisgICAgTlNSZWN0IGZyYW1lUmVjdCA9IFtzZWxmIGZyYW1lXTsKKyAgICBOU1JlY3QgYm91 bmRzID0gW3NlbGYgYm91bmRzXTsKKyAgICBCT09MIGlzSG9yaXpvbnRhbCA9IGZyYW1lUmVjdC5z aXplLndpZHRoID4gZnJhbWVSZWN0LnNpemUuaGVpZ2h0OworICAgIENHRmxvYXQgdHJhY2tMZW5n dGggPSBpc0hvcml6b250YWwgPyBib3VuZHMuc2l6ZS53aWR0aCA6IGJvdW5kcy5zaXplLmhlaWdo dDsKKyAgICBDR0Zsb2F0IG1pbktub2JTaXplID0gaXNIb3Jpem9udGFsID8gYm91bmRzLnNpemUu aGVpZ2h0IDogYm91bmRzLnNpemUud2lkdGg7CisgICAgQ0dGbG9hdCBrbm9iTGVuZ3RoID0gbWF4 KG1pbktub2JTaXplLCBzdGF0aWNfY2FzdDxDR0Zsb2F0Pihyb3VuZCh0cmFja0xlbmd0aCAqIFtz ZWxmIGtub2JQcm9wb3J0aW9uXSkpKTsKKyAgICBDR0Zsb2F0IGtub2JQb3NpdGlvbiA9IHN0YXRp Y19jYXN0PENHRmxvYXQ+KChyb3VuZChbc2VsZiBkb3VibGVWYWx1ZV0gKiAodHJhY2tMZW5ndGgg LSBrbm9iTGVuZ3RoKSkpKTsKICAgICAKLSAgICByZXR1cm4gW3N1cGVyIHJlY3RGb3JQYXJ0OnBh cnRDb2RlXTsKKyAgICBpZiAoaXNIb3Jpem9udGFsKQorICAgICAgICByZXR1cm4gTlNNYWtlUmVj dChib3VuZHMub3JpZ2luLnggKyBrbm9iUG9zaXRpb24sIGJvdW5kcy5vcmlnaW4ueSwga25vYkxl bmd0aCwgYm91bmRzLnNpemUuaGVpZ2h0KTsKKworICAgIHJldHVybiBOU01ha2VSZWN0KGJvdW5k cy5vcmlnaW4ueCwgYm91bmRzLm9yaWdpbi55ICsgICsga25vYlBvc2l0aW9uLCBib3VuZHMuc2l6 ZS53aWR0aCwga25vYkxlbmd0aCk7CiB9CiAKIC0gKHZvaWQpZHJhd0tub2IKZGlmZiAtLWdpdCBh L1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbSBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvbWFjL1BsYXRmb3JtV2ViVmlld01hYy5tbQppbmRleCBkNDRlOGE2 ZjUzOTU0MGYxMjQ2YTY5MDgyYTYzOWY1YmRmY2M0ZDI4Li5iNmM1M2EyZTE4ZDk2MjU2Nzg5OWFj NjNjNDlmYTFmYTE1MzdiODA2IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL21h Yy9QbGF0Zm9ybVdlYlZpZXdNYWMubW0KKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9tYWMv UGxhdGZvcm1XZWJWaWV3TWFjLm1tCkBAIC0xMzcsNyArMTM3LDcgQEAgUGxhdGZvcm1XZWJWaWV3 OjpQbGF0Zm9ybVdlYlZpZXcoV0tDb250ZXh0UmVmIGNvbnRleHRSZWYsIFdLUGFnZUdyb3VwUmVm IHBhZ2VHcm8KICAgICBbbV92aWV3IHNldFdpbmRvd09jY2x1c2lvbkRldGVjdGlvbkVuYWJsZWQ6 Tk9dOwogCiAgICAgTlNSZWN0IHdpbmRvd1JlY3QgPSBOU09mZnNldFJlY3QocmVjdCwgLTEwMDAw LCBbKE5TU2NyZWVuICopW1tOU1NjcmVlbiBzY3JlZW5zXSBvYmplY3RBdEluZGV4OjBdIGZyYW1l XS5zaXplLmhlaWdodCAtIHJlY3Quc2l6ZS5oZWlnaHQgKyAxMDAwMCk7Ci0gICAgbV93aW5kb3cg PSBbW1dlYktpdFRlc3RSdW5uZXJXaW5kb3cgYWxsb2NdIGluaXRXaXRoQ29udGVudFJlY3Q6d2lu ZG93UmVjdCBzdHlsZU1hc2s6TlNCb3JkZXJsZXNzV2luZG93TWFzayBiYWNraW5nOl9OU0JhY2tp bmdTdG9yZVVuYnVmZmVyZWQgZGVmZXI6WUVTXTsKKyAgICBtX3dpbmRvdyA9IFtbV2ViS2l0VGVz dFJ1bm5lcldpbmRvdyBhbGxvY10gaW5pdFdpdGhDb250ZW50UmVjdDp3aW5kb3dSZWN0IHN0eWxl TWFzazpOU0JvcmRlcmxlc3NXaW5kb3dNYXNrIGJhY2tpbmc6KE5TQmFja2luZ1N0b3JlVHlwZSlf TlNCYWNraW5nU3RvcmVVbmJ1ZmZlcmVkIGRlZmVyOllFU107CiAgICAgbV93aW5kb3cucGxhdGZv cm1XZWJWaWV3ID0gdGhpczsKICAgICBbbV93aW5kb3cgc2V0Q29sb3JTcGFjZTpbW05TU2NyZWVu IG1haW5TY3JlZW5dIGNvbG9yU3BhY2VdXTsKICAgICBbbV93aW5kb3cgc2V0Q29sbGVjdGlvbkJl aGF2aW9yOk5TV2luZG93Q29sbGVjdGlvbkJlaGF2aW9yU3RhdGlvbmFyeV07Cg==