<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>126554</bug_id>
          
          <creation_ts>2014-01-06 17:08:19 -0800</creation_ts>
          <short_desc>style-bot confused about leading spaces</short_desc>
          <delta_ts>2014-03-03 05:27:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>127076</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Brent Fulgham">bfulgham</reporter>
          <assigned_to name="Gergő Balogh">gbalogh.u-szeged</assigned_to>
          <cc>ap</cc>
    
    <cc>gbalogh.u-szeged</cc>
    
    <cc>ossy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>964821</commentid>
    <comment_count>0</comment_count>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2014-01-06 17:08:19 -0800</bug_when>
    <thetext>Style bot seems to believe that code like the following is incorrectly indented:

 56: TemporaryOpenGLSetting::~TemporaryOpenGLSetting()
 57: {
 58:     if (m_originalState == m_scopedState)
 59:         return;
 60: 
 61:     if (GL_TRUE == m_originalState)
 62:         ::glEnable(m_capability);
 63:     else
 64:         ::glDisable(m_capability);
 65: }

ERROR: Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp:56:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/TemporaryOpenGLSetting.cpp:56:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]

Other code in the same patch is reprimanded with demands that we use two different levels of indentation:

297        ::glStencilMaskSeparate(GL_FRONT, 0xffffffff);
298        clearMask |= GL_STENCIL_BUFFER_BIT;
299    }
300
301    TemporaryOpenGLSetting scopedScissor(GL_SCISSOR_TEST, GL_FALSE);
302    TemporaryOpenGLSetting scopedDither(GL_SCISSOR_TEST, GL_FALSE);
303
304    ::glClear(clearMask);

ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:301:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:302:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:301:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:302:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>986321</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2014-03-03 05:27:46 -0800</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 127076 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>