126551 2014-01-06 17:01:11 -0800 CStack Branch: Fix nativeForGenerator() for non-X86 platforms 2014-01-06 22:04:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 964816 0 msaboff 2014-01-06 17:01:11 -0800 The modification to ThunkGenerators.cpp::nativeForGenerator() done for X86 need to be made for all platforms. 964825 1 220475 msaboff 2014-01-06 17:21:21 -0800 Created attachment 220475 Patch 964877 2 220475 ggaren 2014-01-06 21:29:04 -0800 Comment on attachment 220475 Patch r=me 964882 3 msaboff 2014-01-06 22:04:15 -0800 Committed r161405: <http://trac.webkit.org/changeset/161405> 220475 2014-01-06 17:21:21 -0800 2014-01-06 21:29:04 -0800 Patch 126551.patch text/plain 5176 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMzg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE0LTAxLTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IEZpeCBuYXRpdmVGb3JHZW5lcmF0b3IoKSBmb3Igbm9uLVg4NiBw bGF0Zm9ybXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEyNjU1MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZWQgdGhlIGV4cGxpY2l0IHNhdmluZyBhbmQgcmVzdG9yaW5nIG9mIHRoZSByZXR1cm4g YWRkcmVzcyBhbmQgY2FsbCBmcmFtZSByZWdpc3RlcgorICAgICAgICBmcm9tIHRoZSBub24tWDg2 IHBhdGhzIG9mIG5hdGl2ZUZvckdlbmVyYXRvcigpIGFzIHRoZXNlIGFyZSBubyBsb25nZXIgbmVl ZGVkLgorICAgICAgICBUaGUgZnVuY3Rpb24gcHJvbG9ndWUgYW5kIGVwaWxvZ3VlIG5vdyBwZXJm b3JtIGNhbGxpbmcgY29udmVudGlvbiBjb25zaXN0ZW50IHNhdmluZworICAgICAgICBhbmQgcmVz dG9yaW5nIG9mIHRoZXNlIHZhbHVlcy4KKworICAgICAgICAqIGppdC9UaHVua0dlbmVyYXRvcnMu Y3BwOgorICAgICAgICAoSlNDOjpuYXRpdmVGb3JHZW5lcmF0b3IpOgorCiAyMDE0LTAxLTA2ICBN YXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBDU3RhY2s6IEpTTG9jayBk cm9wIGFuZCBncmFiIGxvY2sgQVBJcyBzaG91bGQgYmUgcHJpdmF0ZS4KSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaml0L1RodW5rR2VuZXJhdG9ycy5jcHAJKHJldmlzaW9uIDE2MTM4 NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvVGh1bmtHZW5lcmF0b3JzLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjgyLDcgKzI4Miw2IEBAIHN0YXRpYyBNYWNyb0Fzc2VtYmxlckNvZGVS ZWYgbmF0aXZlRm9yR2UKICAgICAvLyBjYWxsIHRoZSBmdW5jdGlvbgogICAgIGppdC5lbWl0R2V0 RnJvbUNhbGxGcmFtZUhlYWRlclB0cihKU1N0YWNrOjpDYWxsZWUsIEpTSW50ZXJmYWNlSklUOjpy ZWdUMSk7CiAgICAgaml0LmxvYWRQdHIoSlNJbnRlcmZhY2VKSVQ6OkFkZHJlc3MoSlNJbnRlcmZh Y2VKSVQ6OnJlZ1QxLCBKU0Z1bmN0aW9uOjpvZmZzZXRPZkV4ZWN1dGFibGUoKSksIEpTSW50ZXJm YWNlSklUOjpyZWdUMSk7Ci0gICAgaml0Lm1vdmUoSlNJbnRlcmZhY2VKSVQ6OnJlZ1QwLCBKU0lu dGVyZmFjZUpJVDo6Y2FsbEZyYW1lUmVnaXN0ZXIpOyAvLyBFYWdlcmx5IHJlc3RvcmUgY2FsbGVy IGZyYW1lIHJlZ2lzdGVyIHRvIGF2b2lkIGxvYWRpbmcgZnJvbSBzdGFjay4KICAgICBqaXQuY2Fs bChKU0ludGVyZmFjZUpJVDo6QWRkcmVzcyhKU0ludGVyZmFjZUpJVDo6cmVnVDEsIGV4ZWN1dGFi bGVPZmZzZXRUb0Z1bmN0aW9uKSk7CiAKICAgICBqaXQuYWRkUHRyKEpTSW50ZXJmYWNlSklUOjpU cnVzdGVkSW1tMzIoMTYgLSBzaXplb2Yodm9pZCopKSwgSlNJbnRlcmZhY2VKSVQ6OnN0YWNrUG9p bnRlclJlZ2lzdGVyKTsKQEAgLTMxMiw3ICszMTEsNiBAQCBzdGF0aWMgTWFjcm9Bc3NlbWJsZXJD b2RlUmVmIG5hdGl2ZUZvckdlCiAKICAgICBqaXQuZW1pdEdldEZyb21DYWxsRnJhbWVIZWFkZXJQ dHIoSlNTdGFjazo6Q2FsbGVlLCBYODZSZWdpc3RlcnM6OmVkeCk7CiAgICAgaml0LmxvYWRQdHIo SlNJbnRlcmZhY2VKSVQ6OkFkZHJlc3MoWDg2UmVnaXN0ZXJzOjplZHgsIEpTRnVuY3Rpb246Om9m ZnNldE9mRXhlY3V0YWJsZSgpKSwgWDg2UmVnaXN0ZXJzOjpyOSk7Ci0gICAgaml0Lm1vdmUoSlNJ bnRlcmZhY2VKSVQ6OnJlZ1QwLCBKU0ludGVyZmFjZUpJVDo6Y2FsbEZyYW1lUmVnaXN0ZXIpOyAv LyBFYWdlcmx5IHJlc3RvcmUgY2FsbGVyIGZyYW1lIHJlZ2lzdGVyIHRvIGF2b2lkIGxvYWRpbmcg ZnJvbSBzdGFjay4KICAgICBqaXQuY2FsbChKU0ludGVyZmFjZUpJVDo6QWRkcmVzcyhYODZSZWdp c3RlcnM6OnI5LCBleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvbikpOwogCiAgICAgaml0LmFkZFB0 cihKU0ludGVyZmFjZUpJVDo6VHJ1c3RlZEltbTMyKDQgKiBzaXplb2YoaW50NjRfdCkgKyAxNiAt IHNpemVvZihpbnQ2NF90KSksIEpTSW50ZXJmYWNlSklUOjpzdGFja1BvaW50ZXJSZWdpc3Rlcik7 CkBAIC0zMzEsMjggKzMyOSwxOCBAQCBzdGF0aWMgTWFjcm9Bc3NlbWJsZXJDb2RlUmVmIG5hdGl2 ZUZvckdlCiAgICAgaml0LmVtaXRHZXRGcm9tQ2FsbEZyYW1lSGVhZGVyUHRyKEpTU3RhY2s6OlNj b3BlQ2hhaW4sIEpTSW50ZXJmYWNlSklUOjpyZWdUMSwgQVJNNjRSZWdpc3RlcnM6OngzKTsKICAg ICBqaXQuZW1pdFB1dENlbGxUb0NhbGxGcmFtZUhlYWRlcihKU0ludGVyZmFjZUpJVDo6cmVnVDEs IEpTU3RhY2s6OlNjb3BlQ2hhaW4pOwogCi0gICAgaml0LnByZXNlcnZlUmV0dXJuQWRkcmVzc0Fm dGVyQ2FsbChKU0ludGVyZmFjZUpJVDo6cmVnVDMpOyAvLyBDYWxsZWUgcHJlc2VydmVkCi0gICAg aml0LmVtaXRQdXRSZXR1cm5QQ1RvQ2FsbEZyYW1lSGVhZGVyKEFSTTY0UmVnaXN0ZXJzOjpscik7 Ci0KICAgICAvLyBIb3N0IGZ1bmN0aW9uIHNpZ25hdHVyZTogZihFeGVjU3RhdGUqKTsKICAgICBq aXQubW92ZShKU0ludGVyZmFjZUpJVDo6Y2FsbEZyYW1lUmVnaXN0ZXIsIEFSTTY0UmVnaXN0ZXJz Ojp4MCk7CiAKICAgICBqaXQuZW1pdEdldEZyb21DYWxsRnJhbWVIZWFkZXJQdHIoSlNTdGFjazo6 Q2FsbGVlLCBBUk02NFJlZ2lzdGVyczo6eDEpOwogICAgIGppdC5sb2FkUHRyKEpTSW50ZXJmYWNl SklUOjpBZGRyZXNzKEFSTTY0UmVnaXN0ZXJzOjp4MSwgSlNGdW5jdGlvbjo6b2Zmc2V0T2ZFeGVj dXRhYmxlKCkpLCBBUk02NFJlZ2lzdGVyczo6eDIpOwotICAgIGppdC5tb3ZlKEFSTTY0UmVnaXN0 ZXJzOjp4MywgSlNJbnRlcmZhY2VKSVQ6OmNhbGxGcmFtZVJlZ2lzdGVyKTsgLy8gRWFnZXJseSBy ZXN0b3JlIGNhbGxlciBmcmFtZSByZWdpc3RlciB0byBhdm9pZCBsb2FkaW5nIGZyb20gc3RhY2su CiAgICAgaml0LmNhbGwoSlNJbnRlcmZhY2VKSVQ6OkFkZHJlc3MoQVJNNjRSZWdpc3RlcnM6Ongy LCBleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvbikpOwotCi0gICAgaml0LnJlc3RvcmVSZXR1cm5B ZGRyZXNzQmVmb3JlUmV0dXJuKEpTSW50ZXJmYWNlSklUOjpyZWdUMyk7Ci0KICNlbGlmIENQVShB Uk0pIHx8IENQVShTSDQpIHx8IENQVShNSVBTKQogICAgIC8vIExvYWQgY2FsbGVyIGZyYW1lJ3Mg c2NvcGUgY2hhaW4gaW50byB0aGlzIGNhbGxmcmFtZSBzbyB0aGF0IHdoYXRldmVyIHdlIGNhbGwg Y2FuIGdldCB0byBpdHMgZ2xvYmFsIGRhdGEuCiAgICAgaml0LmVtaXRHZXRDYWxsZXJGcmFtZUZy b21DYWxsRnJhbWVIZWFkZXJQdHIoSlNJbnRlcmZhY2VKSVQ6OnJlZ1QyKTsKICAgICBqaXQuZW1p dEdldEZyb21DYWxsRnJhbWVIZWFkZXJQdHIoSlNTdGFjazo6U2NvcGVDaGFpbiwgSlNJbnRlcmZh Y2VKSVQ6OnJlZ1QxLCBKU0ludGVyZmFjZUpJVDo6cmVnVDIpOwogICAgIGppdC5lbWl0UHV0Q2Vs bFRvQ2FsbEZyYW1lSGVhZGVyKEpTSW50ZXJmYWNlSklUOjpyZWdUMSwgSlNTdGFjazo6U2NvcGVD aGFpbik7CiAKLSAgICBqaXQucHJlc2VydmVSZXR1cm5BZGRyZXNzQWZ0ZXJDYWxsKEpTSW50ZXJm YWNlSklUOjpyZWdUMyk7IC8vIENhbGxlZSBwcmVzZXJ2ZWQKLSAgICBqaXQuZW1pdFB1dFJldHVy blBDVG9DYWxsRnJhbWVIZWFkZXIoSlNJbnRlcmZhY2VKSVQ6OnJlZ1QzKTsKLQogI2lmIENQVShN SVBTKQogICAgIC8vIEFsbG9jYXRlIHN0YWNrIHNwYWNlIGZvciAodW51c2VkKSAxNiBieXRlcyAo OC1ieXRlIGFsaWduZWQpIGZvciA0IGFyZ3VtZW50cy4KICAgICBqaXQuc3ViUHRyKEpTSW50ZXJm YWNlSklUOjpUcnVzdGVkSW1tMzIoMTYpLCBKU0ludGVyZmFjZUpJVDo6c3RhY2tQb2ludGVyUmVn aXN0ZXIpOwpAQCAtMzYzLDcgKzM1MSw2IEBAIHN0YXRpYyBNYWNyb0Fzc2VtYmxlckNvZGVSZWYg bmF0aXZlRm9yR2UKICAgICBqaXQubW92ZShKU0ludGVyZmFjZUpJVDo6Y2FsbEZyYW1lUmVnaXN0 ZXIsIEpTSW50ZXJmYWNlSklUOjphcmd1bWVudEdQUjApOwogCiAgICAgaml0LmVtaXRHZXRGcm9t Q2FsbEZyYW1lSGVhZGVyUHRyKEpTU3RhY2s6OkNhbGxlZSwgSlNJbnRlcmZhY2VKSVQ6OmFyZ3Vt ZW50R1BSMSk7Ci0gICAgaml0Lm1vdmUoSlNJbnRlcmZhY2VKSVQ6OnJlZ1QyLCBKU0ludGVyZmFj ZUpJVDo6Y2FsbEZyYW1lUmVnaXN0ZXIpOyAvLyBFYWdlcmx5IHJlc3RvcmUgY2FsbGVyIGZyYW1l IHJlZ2lzdGVyIHRvIGF2b2lkIGxvYWRpbmcgZnJvbSBzdGFjay4KICAgICBqaXQubG9hZFB0cihK U0ludGVyZmFjZUpJVDo6QWRkcmVzcyhKU0ludGVyZmFjZUpJVDo6YXJndW1lbnRHUFIxLCBKU0Z1 bmN0aW9uOjpvZmZzZXRPZkV4ZWN1dGFibGUoKSksIEpTSW50ZXJmYWNlSklUOjpyZWdUMik7CiAg ICAgaml0LmNhbGwoSlNJbnRlcmZhY2VKSVQ6OkFkZHJlc3MoSlNJbnRlcmZhY2VKSVQ6OnJlZ1Qy LCBleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvbikpOwogCkBAIC0zNzEsOCArMzU4LDYgQEAgc3Rh dGljIE1hY3JvQXNzZW1ibGVyQ29kZVJlZiBuYXRpdmVGb3JHZQogICAgIC8vIFJlc3RvcmUgc3Rh Y2sgc3BhY2UKICAgICBqaXQuYWRkUHRyKEpTSW50ZXJmYWNlSklUOjpUcnVzdGVkSW1tMzIoMTYp LCBKU0ludGVyZmFjZUpJVDo6c3RhY2tQb2ludGVyUmVnaXN0ZXIpOwogI2VuZGlmCi0KLSAgICBq aXQucmVzdG9yZVJldHVybkFkZHJlc3NCZWZvcmVSZXR1cm4oSlNJbnRlcmZhY2VKSVQ6OnJlZ1Qz KTsKICNlbHNlCiAjZXJyb3IgIkpJVCBub3Qgc3VwcG9ydGVkIG9uIHRoaXMgcGxhdGZvcm0uIgog ICAgIFVOVVNFRF9QQVJBTShleGVjdXRhYmxlT2Zmc2V0VG9GdW5jdGlvbik7Cg==