126550 2014-01-06 17:01:08 -0800 CStack Branch: Disable JIT stack alignment check for ARM64 2014-01-06 17:53:41 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 964815 0 msaboff 2014-01-06 17:01:08 -0800 Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment() is not needed. Also, the implementation of checkStackPointerAlignment() would need to be reworked given the limits on the operations that can be done with the stack pointer register in ARM64. Therefore checkStackPointerAlignment() should be conditionally disabled for ARM64. 964824 1 220474 msaboff 2014-01-06 17:20:57 -0800 Created attachment 220474 Patch 964828 2 220474 mark.lam 2014-01-06 17:39:06 -0800 Comment on attachment 220474 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220474&action=review r=me with comment fix. > Source/JavaScriptCore/ChangeLog:8 > + Disabled the compilation of the body of checkStackPointerAlignment for ARM64. Can you put your bug comment here instead? The bug comment said, "Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment() is not needed. Also, the implementation of checkStackPointerAlignment() would need to be reworked given the limits on the operations that can be done with the stack pointer register in ARM64. Therefore checkStackPointerAlignment() should be conditionally disabled for ARM64." I think your bug comment does a good job of explaining why we needed this change. 964833 3 msaboff 2014-01-06 17:53:41 -0800 Committed r161390: <http://trac.webkit.org/changeset/161390> 220474 2014-01-06 17:20:57 -0800 2014-01-06 17:39:06 -0800 Patch 126550.patch text/plain 1281 msaboff SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMzg3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTAxLTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAg ICAgIENTdGFjayBCcmFuY2g6IERpc2FibGUgSklUIHN0YWNrIGFsaWdubWVudCBjaGVjayBmb3Ig QVJNNjQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEy NjU1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERp c2FibGVkIHRoZSBjb21waWxhdGlvbiBvZiB0aGUgYm9keSBvZiBjaGVja1N0YWNrUG9pbnRlckFs aWdubWVudCBmb3IgQVJNNjQuCisKKyAgICAgICAgKiBqaXQvQXNzZW1ibHlIZWxwZXJzLmg6Cisg ICAgICAgIChKU0M6OkFzc2VtYmx5SGVscGVyczo6Y2hlY2tTdGFja1BvaW50ZXJBbGlnbm1lbnQp OgorCiAyMDE0LTAxLTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBDU3RhY2s6IEpTTG9jayBkcm9wIGFuZCBncmFiIGxvY2sgQVBJcyBzaG91bGQgYmUgcHJpdmF0 ZS4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvQXNzZW1ibHlIZWxwZXJzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhlbHBlcnMuaAko cmV2aXNpb24gMTYxMzg3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2ppdC9Bc3NlbWJseUhl bHBlcnMuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNyArNjEsNyBAQCBwdWJsaWM6CiAKICAgICB2 b2lkIGNoZWNrU3RhY2tQb2ludGVyQWxpZ25tZW50KCkKICAgICB7Ci0jaWZuZGVmIE5ERUJVRwor I2lmICFkZWZpbmVkKE5ERUJVRykgJiYgIUNQVShBUk02NCkKICAgICAgICAgSnVtcCBzdGFja1Bv aW50ZXJBbGlnbmVkID0gYnJhbmNoVGVzdFB0cihaZXJvLCBzdGFja1BvaW50ZXJSZWdpc3Rlciwg VHJ1c3RlZEltbTMyKDB4ZikpOwogICAgICAgICBicmVha3BvaW50KCk7CiAgICAgICAgIHN0YWNr UG9pbnRlckFsaWduZWQubGluayh0aGlzKTsK