126539 2014-01-06 14:08:31 -0800 CStack: JSLock drop and grab lock APIs should be private. 2014-01-06 14:15:06 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mhahnenberg msaboff oliver oldest_to_newest 964750 0 mark.lam 2014-01-06 14:08:31 -0800 We want the dropping and re-acquisition of the VM API lock to be via the DropAllLocks raii object. Hence, we should not publicly publishing the APIs for dropping and re-acquiring the locks. 964754 1 220456 mark.lam 2014-01-06 14:12:01 -0800 Created attachment 220456 the patch. 964756 2 220456 mhahnenberg 2014-01-06 14:12:28 -0800 Comment on attachment 220456 the patch. r=me 964757 3 mark.lam 2014-01-06 14:15:06 -0800 Thanks for the review. Landed in r161372 on the jsCStack branch: <http://trac.webkit.org/r161372>. 220456 2014-01-06 14:12:01 -0800 2014-01-06 14:12:27 -0800 the patch. bug-126539.patch text/plain 1704 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTYxMzcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE0LTAxLTA2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD U3RhY2s6IEpTTG9jayBkcm9wIGFuZCBncmFiIGxvY2sgQVBJcyBzaG91bGQgYmUgcHJpdmF0ZS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyNjUzOS4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSB3YW50 IHRoZSBkcm9wcGluZyBhbmQgcmUtYWNxdWlzaXRpb24gb2YgdGhlIFZNIEFQSSBsb2NrIHRvIGJl IHZpYSB0aGUKKyAgICAgICAgRHJvcEFsbExvY2tzIHJhaWkgb2JqZWN0LiBIZW5jZSwgd2Ugc2hv dWxkIG5vdCBwdWJsaWNseSBwdWJsaXNoaW5nIHRoZQorICAgICAgICBBUElzIGZvciBkcm9wcGlu ZyBhbmQgcmUtYWNxdWlyaW5nIHRoZSBsb2Nrcy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNMb2Nr Lmg6CisKIDIwMTQtMDEtMDYgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAg ICAgIEZvbGxvdyB1cCBwYXRjaCB0byByZW1vdmUgdGhlIG5lZWQgZm9yIFZNRW50cnlTY29wZTo6 bV9wcmV2Rmlyc3RFbnRyeVNjb3BlLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNMb2NrLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNMb2NrLmgJKHJldmlzaW9uIDE2MTM3MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTTG9jay5oCSh3b3JraW5nIGNvcHkpCkBAIC05NSwxMCArOTUsNiBAQCBuYW1lc3BhY2Ug SlNDIHsKIAogICAgICAgICBKU19FWFBPUlRfUFJJVkFURSBib29sIGN1cnJlbnRUaHJlYWRJc0hv bGRpbmdMb2NrKCk7CiAKLSAgICAgICAgdW5zaWduZWQgZHJvcEFsbExvY2tzKFNwaW5Mb2NrJik7 Ci0gICAgICAgIHVuc2lnbmVkIGRyb3BBbGxMb2Nrc1VuY29uZGl0aW9uYWxseShTcGluTG9jayYp OwotICAgICAgICB2b2lkIGdyYWJBbGxMb2Nrcyh1bnNpZ25lZCBsb2NrQ291bnQsIFNwaW5Mb2Nr Jik7Ci0KICAgICAgICAgdm9pZCB3aWxsRGVzdHJveVZNKFZNKik7CiAKICAgICAgICAgY2xhc3Mg RHJvcEFsbExvY2tzIHsKQEAgLTExNyw2ICsxMTMsMTAgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAg ICAgIH07CiAKICAgICBwcml2YXRlOgorICAgICAgICB1bnNpZ25lZCBkcm9wQWxsTG9ja3MoU3Bp bkxvY2smKTsKKyAgICAgICAgdW5zaWduZWQgZHJvcEFsbExvY2tzVW5jb25kaXRpb25hbGx5KFNw aW5Mb2NrJik7CisgICAgICAgIHZvaWQgZ3JhYkFsbExvY2tzKHVuc2lnbmVkIGxvY2tDb3VudCwg U3BpbkxvY2smKTsKKwogICAgICAgICBTcGluTG9jayBtX3NwaW5Mb2NrOwogICAgICAgICBNdXRl eCBtX2xvY2s7CiAgICAgICAgIFRocmVhZElkZW50aWZpZXIgbV9vd25lclRocmVhZDsK