126514 2014-01-06 01:15:31 -0800 RenderInline::clone() should return RenderPtr. 2014-01-08 09:29:45 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue darin esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 964576 0 kling 2014-01-06 01:15:31 -0800 RenderInline::clone() should return RenderPtr. 964577 1 220419 kling 2014-01-06 01:20:31 -0800 Created attachment 220419 Patch 964582 2 kling 2014-01-06 01:43:16 -0800 Committed r161335: <http://trac.webkit.org/changeset/161335> 965507 3 darin 2014-01-08 09:08:25 -0800 For some reason the commit log entry for this patch gives credit to Gurpreet Kaur. Seems like that’s probably a bug in webkit-patch! 965517 4 kling 2014-01-08 09:29:45 -0800 (In reply to comment #3) > For some reason the commit log entry for this patch gives credit to Gurpreet Kaur. Seems like that’s probably a bug in webkit-patch! Nah, I botched it when landing with "patch --fuzz 3" :( 220419 2014-01-06 01:20:31 -0800 2014-01-06 01:21:19 -0800 Patch bug-126514.diff text/plain 4586 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkNmYyZDMzLi45ZGY2ZWVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjMg QEAKIDIwMTQtMDEtMDYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgogCisgICAg ICAgIFJlbmRlcklubGluZTo6Y2xvbmUoKSBzaG91bGQgcmV0dXJuIFJlbmRlclB0ci4KKyAgICAg ICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjUxND4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJJbmxpbmUuaDoKKyAg ICAgICAgKiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlcklubGluZTo6Y2xvbmUpOgorCisgICAgICAgICAgICBUd2Vha2VkIHRvIHJldHVybiBSZW5k ZXJQdHI8UmVuZGVySW5saW5lPi4KKworICAgICAgICAoV2ViQ29yZTo6UmVuZGVySW5saW5lOjpz cGxpdElubGluZXMpOgorCisgICAgICAgICAgICBTdG9yZSBjbG9uZWQgUmVuZGVySW5saW5lcyBp biBSZW5kZXJQdHJzLiBVc2UgbGVha1B0cigpIHRvIHNpbmsKKyAgICAgICAgICAgIHRoZW0gaW50 byBvd25lcnNoaXAtdGFraW5nIEFQSXMgdGhhdCBzdGlsbCB1c2UgcmF3IHBvaW50ZXJzLgorCisy MDE0LTAxLTA2ICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KKwogICAgICAgICBS ZW5kZXJCbG9jazo6Y2xvbmUoKSBzaG91bGQgcmV0dXJuIFJlbmRlclB0ci4KICAgICAgICAgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzEyNjUxMz4KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlcklubGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVySW5saW5lLmNwcAppbmRleCA2ODAwY2E1Li5kYjRiYTZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcApAQCAtMzMwLDkgKzMzMCw5IEBAIHZvaWQgUmVuZGVy SW5saW5lOjphZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKFJlbmRlck9iamVjdCogbmV3Q2hp bGQsIFJlbmRlck9iCiAgICAgbmV3Q2hpbGQtPnNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1Jl Y2FsYygpOwogfQogCi1SZW5kZXJJbmxpbmUqIFJlbmRlcklubGluZTo6Y2xvbmUoKSBjb25zdAor UmVuZGVyUHRyPFJlbmRlcklubGluZT4gUmVuZGVySW5saW5lOjpjbG9uZSgpIGNvbnN0CiB7Ci0g ICAgUmVuZGVySW5saW5lKiBjbG9uZUlubGluZSA9IG5ldyBSZW5kZXJJbmxpbmUoKmVsZW1lbnQo KSwgc3R5bGUoKSk7CisgICAgUmVuZGVyUHRyPFJlbmRlcklubGluZT4gY2xvbmVJbmxpbmUgPSBj cmVhdGVSZW5kZXJlcjxSZW5kZXJJbmxpbmU+KCplbGVtZW50KCksIHN0eWxlKCkpOwogICAgIGNs b25lSW5saW5lLT5pbml0aWFsaXplU3R5bGUoKTsKICAgICBjbG9uZUlubGluZS0+c2V0Rmxvd1Ro cmVhZFN0YXRlKGZsb3dUaHJlYWRTdGF0ZSgpKTsKICAgICByZXR1cm4gY2xvbmVJbmxpbmU7CkBA IC0zNDMsNyArMzQzLDcgQEAgdm9pZCBSZW5kZXJJbmxpbmU6OnNwbGl0SW5saW5lcyhSZW5kZXJC bG9jayogZnJvbUJsb2NrLCBSZW5kZXJCbG9jayogdG9CbG9jaywKICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGlsZCwgUmVuZGVyQm94TW9kZWxP YmplY3QqIG9sZENvbnQpCiB7CiAgICAgLy8gQ3JlYXRlIGEgY2xvbmUgb2YgdGhpcyBpbmxpbmUu Ci0gICAgUmVuZGVySW5saW5lKiBjbG9uZUlubGluZSA9IGNsb25lKCk7CisgICAgUmVuZGVyUHRy PFJlbmRlcklubGluZT4gY2xvbmVJbmxpbmUgPSBjbG9uZSgpOwogICAgIGNsb25lSW5saW5lLT5z ZXRDb250aW51YXRpb24ob2xkQ29udCk7CiAKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCkBA IC0zNjksNyArMzY5LDcgQEAgdm9pZCBSZW5kZXJJbmxpbmU6OnNwbGl0SW5saW5lcyhSZW5kZXJC bG9jayogZnJvbUJsb2NrLCBSZW5kZXJCbG9jayogdG9CbG9jaywKICAgICB9CiAKICAgICAvLyBI b29rIHxjbG9uZXwgdXAgYXMgdGhlIGNvbnRpbnVhdGlvbiBvZiB0aGUgbWlkZGxlIGJsb2NrLgot ICAgIG1pZGRsZUJsb2NrLT5zZXRDb250aW51YXRpb24oY2xvbmVJbmxpbmUpOworICAgIG1pZGRs ZUJsb2NrLT5zZXRDb250aW51YXRpb24oY2xvbmVJbmxpbmUuZ2V0KCkpOwogCiAgICAgLy8gV2Ug aGF2ZSBiZWVuIHJlcGFyZW50ZWQgYW5kIGFyZSBub3cgdW5kZXIgdGhlIGZyb21CbG9jay4gIFdl IG5lZWQKICAgICAvLyB0byB3YWxrIHVwIG91ciBpbmxpbmUgcGFyZW50IGNoYWluIHVudGlsIHdl IGhpdCB0aGUgY29udGFpbmluZyBibG9jay4KQEAgLTM4NywxNiArMzg3LDE2IEBAIHZvaWQgUmVu ZGVySW5saW5lOjpzcGxpdElubGluZXMoUmVuZGVyQmxvY2sqIGZyb21CbG9jaywgUmVuZGVyQmxv Y2sqIHRvQmxvY2ssCiAgICAgICAgIEFTU0VSVChjdXJyLT5pc1JlbmRlcklubGluZSgpKTsKICAg ICAgICAgaWYgKHNwbGl0RGVwdGggPCBjTWF4U3BsaXREZXB0aCkgewogICAgICAgICAgICAgLy8g Q3JlYXRlIGEgbmV3IGNsb25lLgotICAgICAgICAgICAgUmVuZGVySW5saW5lKiBjbG9uZUNoaWxk ID0gY2xvbmVJbmxpbmU7CisgICAgICAgICAgICBSZW5kZXJQdHI8UmVuZGVySW5saW5lPiBjbG9u ZUNoaWxkID0gc3RkOjptb3ZlKGNsb25lSW5saW5lKTsKICAgICAgICAgICAgIGNsb25lSW5saW5l ID0gdG9SZW5kZXJJbmxpbmUoY3VyciktPmNsb25lKCk7CiAKICAgICAgICAgICAgIC8vIEluc2Vy dCBvdXIgY2hpbGQgY2xvbmUgYXMgdGhlIGZpcnN0IGNoaWxkLgotICAgICAgICAgICAgY2xvbmVJ bmxpbmUtPmFkZENoaWxkSWdub3JpbmdDb250aW51YXRpb24oY2xvbmVDaGlsZCwgMCk7CisgICAg ICAgICAgICBjbG9uZUlubGluZS0+YWRkQ2hpbGRJZ25vcmluZ0NvbnRpbnVhdGlvbihjbG9uZUNo aWxkLmxlYWtQdHIoKSwgMCk7CiAKICAgICAgICAgICAgIC8vIEhvb2sgdGhlIGNsb25lIHVwIGFz IGEgY29udGludWF0aW9uIG9mIHxjdXJyfC4KICAgICAgICAgICAgIFJlbmRlcklubGluZSogaW5s aW5lQ3VyciA9IHRvUmVuZGVySW5saW5lKGN1cnIpOwogICAgICAgICAgICAgb2xkQ29udCA9IGlu bGluZUN1cnItPmNvbnRpbnVhdGlvbigpOwotICAgICAgICAgICAgaW5saW5lQ3Vyci0+c2V0Q29u dGludWF0aW9uKGNsb25lSW5saW5lKTsKKyAgICAgICAgICAgIGlubGluZUN1cnItPnNldENvbnRp bnVhdGlvbihjbG9uZUlubGluZS5nZXQoKSk7CiAgICAgICAgICAgICBjbG9uZUlubGluZS0+c2V0 Q29udGludWF0aW9uKG9sZENvbnQpOwogCiAgICAgICAgICAgICAvLyBOb3cgd2UgbmVlZCB0byB0 YWtlIGFsbCBvZiB0aGUgY2hpbGRyZW4gc3RhcnRpbmcgZnJvbSB0aGUgZmlyc3QgY2hpbGQKQEAg LTQxOCw3ICs0MTgsNyBAQCB2b2lkIFJlbmRlcklubGluZTo6c3BsaXRJbmxpbmVzKFJlbmRlckJs b2NrKiBmcm9tQmxvY2ssIFJlbmRlckJsb2NrKiB0b0Jsb2NrLAogICAgIH0KIAogICAgIC8vIE5v dyB3ZSBhcmUgYXQgdGhlIGJsb2NrIGxldmVsLiBXZSBuZWVkIHRvIHB1dCB0aGUgY2xvbmUgaW50 byB0aGUgdG9CbG9jay4KLSAgICB0b0Jsb2NrLT5pbnNlcnRDaGlsZEludGVybmFsKGNsb25lSW5s aW5lLCBudWxscHRyLCBOb3RpZnlDaGlsZHJlbik7CisgICAgdG9CbG9jay0+aW5zZXJ0Q2hpbGRJ bnRlcm5hbChjbG9uZUlubGluZS5sZWFrUHRyKCksIG51bGxwdHIsIE5vdGlmeUNoaWxkcmVuKTsK IAogICAgIC8vIE5vdyB0YWtlIGFsbCB0aGUgY2hpbGRyZW4gYWZ0ZXIgY3VyckNoaWxkIGFuZCBy ZW1vdmUgdGhlbSBmcm9tIHRoZSBmcm9tQmxvY2sKICAgICAvLyBhbmQgcHV0IHRoZW0gaW4gdGhl IHRvQmxvY2suCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5s aW5lLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmgKaW5kZXggNjNk MWNlZC4uMjZmYmRiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl cklubGluZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbmxpbmUuaApA QCAtMTY5LDcgKzE2OSw3IEBAIHByaXZhdGU6CiAgICAgCiAgICAgdmlydHVhbCB2b2lkIHVwZGF0 ZUZyb21TdHlsZSgpIE9WRVJSSURFIEZJTkFMOwogICAgIAotICAgIFJlbmRlcklubGluZSogY2xv bmUoKSBjb25zdDsKKyAgICBSZW5kZXJQdHI8UmVuZGVySW5saW5lPiBjbG9uZSgpIGNvbnN0Owog CiAgICAgdm9pZCBwYWludE91dGxpbmVGb3JMaW5lKEdyYXBoaWNzQ29udGV4dCosIGNvbnN0IExh eW91dFBvaW50JiwgY29uc3QgTGF5b3V0UmVjdCYgcHJldkxpbmUsIGNvbnN0IExheW91dFJlY3Qm IHRoaXNMaW5lLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBMYXlvdXRSZWN0 JiBuZXh0TGluZSwgY29uc3QgQ29sb3IpOwo=