126513 2014-01-06 00:36:12 -0800 RenderBlock::clone() should return RenderPtr. 2014-01-06 02:35:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 964567 0 kling 2014-01-06 00:36:12 -0800 RenderBlock::clone() should return RenderPtr. 964568 1 220417 kling 2014-01-06 00:40:31 -0800 Created attachment 220417 Patch 964575 2 220417 koivisto 2014-01-06 01:13:33 -0800 Comment on attachment 220417 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=220417&action=review > Source/WebCore/rendering/RenderBlock.cpp:515 > + RenderPtr<RenderElement> cloneRenderer = element()->createElementRenderer(style()); > + cloneBlock = RenderPtr<RenderBlock>(toRenderBlock(cloneRenderer.leakPtr())); :( 964588 3 kling 2014-01-06 02:35:57 -0800 Committed r161337: <http://trac.webkit.org/changeset/161337> 220417 2014-01-06 00:40:31 -0800 2014-01-06 01:13:33 -0800 Patch bug-126513.diff text/plain 6052 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0N2MyOTJlLi5kNmYyZDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTQtMDEtMDYgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIFJlbmRlckJsb2NrOjpjbG9uZSgpIHNob3VsZCByZXR1cm4gUmVuZGVyUHRyLgorICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTI2NTEzPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmg6CisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJsb2NrOjpjbG9uZSk6CisKKyAgICAgICAgICAgIEhhY2tlZCB0byByZXR1cm4gUmVuZGVyUHRy PFJlbmRlckJsb2NrPi4gVGhpcyBlbmRlZCB1cCBsb29raW5nCisgICAgICAgICAgICBhIGJpdCBu YXN0eSBiZWNhdXNlIG9mIHJlbmRlcmVyIGZhY3RvcnkgZnVuY3Rpb25zIHRoYXQgcmV0dXJuCisg ICAgICAgICAgICByYXcgcG9pbnRlcnMuIEl0IHdpbGwgZ2V0IHRpZGllZCB1cCBldmVudHVhbGx5 LgorCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6c3BsaXRCbG9ja3MpOgorCisgICAg ICAgICAgICBTdG9yZSBjbG9uZWQgUmVuZGVyQmxvY2tzIGluIFJlbmRlclB0cnMuIFVzZSBsZWFr UHRyKCkgdG8gc2luaworICAgICAgICAgICAgdGhlbSBpbnRvIG93bmVyc2hpcC10YWtpbmcgQVBJ cyB0aGF0IHN0aWxsIHVzZSByYXcgcG9pbnRlcnMuCisKIDIwMTQtMDEtMDUgIEFuZHJlYXMgS2xp bmcgIDxha2xpbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBsaW5lYWdlT2ZUeXBlIHRvIHNp bXBsaWZ5IHR3byByZW5kZXJpbmcgaGVscGVycy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQmxvY2suY3BwCmluZGV4IGQ0ZTM2ZTUuLmFlZTA4N2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtNTA0LDE1ICs1MDQsMTUgQEAgUmVuZGVyQmxvY2sq IFJlbmRlckJsb2NrOjpjb250YWluaW5nQ29sdW1uc0Jsb2NrKGJvb2wgYWxsb3dBbm9ueW1vdXND b2x1bW5CbG9jaykKICAgICByZXR1cm4gMDsKIH0KIAotUmVuZGVyQmxvY2sqIFJlbmRlckJsb2Nr OjpjbG9uZSgpIGNvbnN0CitSZW5kZXJQdHI8UmVuZGVyQmxvY2s+IFJlbmRlckJsb2NrOjpjbG9u ZSgpIGNvbnN0CiB7Ci0gICAgUmVuZGVyQmxvY2sqIGNsb25lQmxvY2s7CisgICAgUmVuZGVyUHRy PFJlbmRlckJsb2NrPiBjbG9uZUJsb2NrOwogICAgIGlmIChpc0Fub255bW91c0Jsb2NrKCkpIHsK LSAgICAgICAgY2xvbmVCbG9jayA9IGNyZWF0ZUFub255bW91c0Jsb2NrKCk7CisgICAgICAgIGNs b25lQmxvY2sgPSBSZW5kZXJQdHI8UmVuZGVyQmxvY2s+KGNyZWF0ZUFub255bW91c0Jsb2NrKCkp OwogICAgICAgICBjbG9uZUJsb2NrLT5zZXRDaGlsZHJlbklubGluZShjaGlsZHJlbklubGluZSgp KTsKICAgICB9IGVsc2UgewotICAgICAgICBhdXRvIGNsb25lUmVuZGVyZXIgPSBlbGVtZW50KCkt PmNyZWF0ZUVsZW1lbnRSZW5kZXJlcihzdHlsZSgpKTsKLSAgICAgICAgY2xvbmVCbG9jayA9IHRv UmVuZGVyQmxvY2soY2xvbmVSZW5kZXJlci5sZWFrUHRyKCkpOworICAgICAgICBSZW5kZXJQdHI8 UmVuZGVyRWxlbWVudD4gY2xvbmVSZW5kZXJlciA9IGVsZW1lbnQoKS0+Y3JlYXRlRWxlbWVudFJl bmRlcmVyKHN0eWxlKCkpOworICAgICAgICBjbG9uZUJsb2NrID0gUmVuZGVyUHRyPFJlbmRlckJs b2NrPih0b1JlbmRlckJsb2NrKGNsb25lUmVuZGVyZXIubGVha1B0cigpKSk7CiAgICAgICAgIGNs b25lQmxvY2stPmluaXRpYWxpemVTdHlsZSgpOwogCiAgICAgICAgIC8vIFRoaXMgdGFrZXMgY2Fy ZSBvZiBzZXR0aW5nIHRoZSByaWdodCB2YWx1ZSBvZiBjaGlsZHJlbklubGluZSBpbiBjYXNlCkBA IC01MjksNyArNTI5LDcgQEAgdm9pZCBSZW5kZXJCbG9jazo6c3BsaXRCbG9ja3MoUmVuZGVyQmxv Y2sqIGZyb21CbG9jaywgUmVuZGVyQmxvY2sqIHRvQmxvY2ssCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBSZW5kZXJPYmplY3QqIGJlZm9yZUNoaWxkLCBSZW5kZXJCb3hNb2RlbE9iamVj dCogb2xkQ29udCkKIHsKICAgICAvLyBDcmVhdGUgYSBjbG9uZSBvZiB0aGlzIGlubGluZS4KLSAg ICBSZW5kZXJCbG9jayogY2xvbmVCbG9jayA9IGNsb25lKCk7CisgICAgUmVuZGVyUHRyPFJlbmRl ckJsb2NrPiBjbG9uZUJsb2NrID0gY2xvbmUoKTsKICAgICBpZiAoIWlzQW5vbnltb3VzQmxvY2so KSkKICAgICAgICAgY2xvbmVCbG9jay0+c2V0Q29udGludWF0aW9uKG9sZENvbnQpOwogCkBAIC01 NDMsMTEgKzU0MywxMSBAQCB2b2lkIFJlbmRlckJsb2NrOjpzcGxpdEJsb2NrcyhSZW5kZXJCbG9j ayogZnJvbUJsb2NrLCBSZW5kZXJCbG9jayogdG9CbG9jaywKIAogICAgIC8vIE5vdyB0YWtlIGFs bCBvZiB0aGUgY2hpbGRyZW4gZnJvbSBiZWZvcmVDaGlsZCB0byB0aGUgZW5kIGFuZCByZW1vdmUK ICAgICAvLyB0aGVtIGZyb20gfHRoaXN8IGFuZCBwbGFjZSB0aGVtIGluIHRoZSBjbG9uZS4KLSAg ICBtb3ZlQ2hpbGRyZW5UbyhjbG9uZUJsb2NrLCBiZWZvcmVDaGlsZCwgMCwgdHJ1ZSk7CisgICAg bW92ZUNoaWxkcmVuVG8oY2xvbmVCbG9jay5nZXQoKSwgYmVmb3JlQ2hpbGQsIDAsIHRydWUpOwog ICAgIAogICAgIC8vIEhvb2sgfGNsb25lfCB1cCBhcyB0aGUgY29udGludWF0aW9uIG9mIHRoZSBt aWRkbGUgYmxvY2suCiAgICAgaWYgKCFjbG9uZUJsb2NrLT5pc0Fub255bW91c0Jsb2NrKCkpCi0g ICAgICAgIG1pZGRsZUJsb2NrLT5zZXRDb250aW51YXRpb24oY2xvbmVCbG9jayk7CisgICAgICAg IG1pZGRsZUJsb2NrLT5zZXRDb250aW51YXRpb24oY2xvbmVCbG9jay5nZXQoKSk7CiAKICAgICAv LyBXZSBoYXZlIGJlZW4gcmVwYXJlbnRlZCBhbmQgYXJlIG5vdyB1bmRlciB0aGUgZnJvbUJsb2Nr LiAgV2UgbmVlZAogICAgIC8vIHRvIHdhbGsgdXAgb3VyIGJsb2NrIHBhcmVudCBjaGFpbiB1bnRp bCB3ZSBoaXQgdGhlIGNvbnRhaW5pbmcgYW5vbnltb3VzIGNvbHVtbnMgYmxvY2suCkBAIC01NjIs MTEgKzU2MiwxMSBAQCB2b2lkIFJlbmRlckJsb2NrOjpzcGxpdEJsb2NrcyhSZW5kZXJCbG9jayog ZnJvbUJsb2NrLCBSZW5kZXJCbG9jayogdG9CbG9jaywKICAgICAgICAgUmVuZGVyQmxvY2sqIGJs b2NrQ3VyciA9IHRvUmVuZGVyQmxvY2soY3Vycik7CiAgICAgICAgIAogICAgICAgICAvLyBDcmVh dGUgYSBuZXcgY2xvbmUuCi0gICAgICAgIFJlbmRlckJsb2NrKiBjbG9uZUNoaWxkID0gY2xvbmVC bG9jazsKKyAgICAgICAgUmVuZGVyUHRyPFJlbmRlckJsb2NrPiBjbG9uZUNoaWxkID0gc3RkOjpt b3ZlKGNsb25lQmxvY2spOwogICAgICAgICBjbG9uZUJsb2NrID0gYmxvY2tDdXJyLT5jbG9uZSgp OwogCiAgICAgICAgIC8vIEluc2VydCBvdXIgY2hpbGQgY2xvbmUgYXMgdGhlIGZpcnN0IGNoaWxk LgotICAgICAgICBjbG9uZUJsb2NrLT5hZGRDaGlsZElnbm9yaW5nQ29udGludWF0aW9uKGNsb25l Q2hpbGQsIDApOworICAgICAgICBjbG9uZUJsb2NrLT5hZGRDaGlsZElnbm9yaW5nQ29udGludWF0 aW9uKGNsb25lQ2hpbGQubGVha1B0cigpLCAwKTsKIAogICAgICAgICAvLyBIb29rIHRoZSBjbG9u ZSB1cCBhcyBhIGNvbnRpbnVhdGlvbiBvZiB8Y3VycnwuICBOb3RlIHdlIGRvIGVuY291bnRlcgog ICAgICAgICAvLyBhbm9ueW1vdXMgYmxvY2tzIHBvc3NpYmx5IGFzIHdlIHdhbGsgdXAgdGhlIGJs b2NrIGNoYWluLiAgV2hlbiB3ZSBzcGxpdCBhbgpAQCAtNTc0LDEzICs1NzQsMTMgQEAgdm9pZCBS ZW5kZXJCbG9jazo6c3BsaXRCbG9ja3MoUmVuZGVyQmxvY2sqIGZyb21CbG9jaywgUmVuZGVyQmxv Y2sqIHRvQmxvY2ssCiAgICAgICAgIC8vIGFjdHVhbGx5IHNwbGl0IGEgcmVhbCBlbGVtZW50Lgog ICAgICAgICBpZiAoIWJsb2NrQ3Vyci0+aXNBbm9ueW1vdXNCbG9jaygpKSB7CiAgICAgICAgICAg ICBvbGRDb250ID0gYmxvY2tDdXJyLT5jb250aW51YXRpb24oKTsKLSAgICAgICAgICAgIGJsb2Nr Q3Vyci0+c2V0Q29udGludWF0aW9uKGNsb25lQmxvY2spOworICAgICAgICAgICAgYmxvY2tDdXJy LT5zZXRDb250aW51YXRpb24oY2xvbmVCbG9jay5nZXQoKSk7CiAgICAgICAgICAgICBjbG9uZUJs b2NrLT5zZXRDb250aW51YXRpb24ob2xkQ29udCk7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBO b3cgd2UgbmVlZCB0byB0YWtlIGFsbCBvZiB0aGUgY2hpbGRyZW4gc3RhcnRpbmcgZnJvbSB0aGUg Zmlyc3QgY2hpbGQKICAgICAgICAgLy8gKmFmdGVyKiBjdXJyQ2hpbGQgYW5kIGFwcGVuZCB0aGVt IGFsbCB0byB0aGUgY2xvbmUuCi0gICAgICAgIGJsb2NrQ3Vyci0+bW92ZUNoaWxkcmVuVG8oY2xv bmVCbG9jaywgY3VyckNoaWxkTmV4dFNpYmxpbmcsIDAsIHRydWUpOworICAgICAgICBibG9ja0N1 cnItPm1vdmVDaGlsZHJlblRvKGNsb25lQmxvY2suZ2V0KCksIGN1cnJDaGlsZE5leHRTaWJsaW5n LCAwLCB0cnVlKTsKIAogICAgICAgICAvLyBLZWVwIHdhbGtpbmcgdXAgdGhlIGNoYWluLgogICAg ICAgICBjdXJyQ2hpbGQgPSBjdXJyOwpAQCAtNTg5LDcgKzU4OSw3IEBAIHZvaWQgUmVuZGVyQmxv Y2s6OnNwbGl0QmxvY2tzKFJlbmRlckJsb2NrKiBmcm9tQmxvY2ssIFJlbmRlckJsb2NrKiB0b0Js b2NrLAogICAgIH0KIAogICAgIC8vIE5vdyB3ZSBhcmUgYXQgdGhlIGNvbHVtbnMgYmxvY2sgbGV2 ZWwuIFdlIG5lZWQgdG8gcHV0IHRoZSBjbG9uZSBpbnRvIHRoZSB0b0Jsb2NrLgotICAgIHRvQmxv Y2stPmluc2VydENoaWxkSW50ZXJuYWwoY2xvbmVCbG9jaywgbnVsbHB0ciwgTm90aWZ5Q2hpbGRy ZW4pOworICAgIHRvQmxvY2stPmluc2VydENoaWxkSW50ZXJuYWwoY2xvbmVCbG9jay5sZWFrUHRy KCksIG51bGxwdHIsIE5vdGlmeUNoaWxkcmVuKTsKIAogICAgIC8vIE5vdyB0YWtlIGFsbCB0aGUg Y2hpbGRyZW4gYWZ0ZXIgY3VyckNoaWxkIGFuZCByZW1vdmUgdGhlbSBmcm9tIHRoZSBmcm9tQmxv Y2sKICAgICAvLyBhbmQgcHV0IHRoZW0gaW4gdGhlIHRvQmxvY2suCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9jay5oCmluZGV4IDczZjlmYzIuLmQwMjdlNmUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCkBAIC01ODMsNyArNTgzLDcgQEAgcHJpdmF0ZToKICAg ICAgICAgICAgICAgICAgICAgIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQsIFJlbmRlckJveE1v ZGVsT2JqZWN0KiBvbGRDb250KTsKICAgICB2b2lkIHNwbGl0RmxvdyhSZW5kZXJPYmplY3QqIGJl Zm9yZUNoaWxkLCBSZW5kZXJCbG9jayogbmV3QmxvY2tCb3gsCiAgICAgICAgICAgICAgICAgICAg UmVuZGVyT2JqZWN0KiBuZXdDaGlsZCwgUmVuZGVyQm94TW9kZWxPYmplY3QqIG9sZENvbnQpOwot ICAgIFJlbmRlckJsb2NrKiBjbG9uZSgpIGNvbnN0OworICAgIFJlbmRlclB0cjxSZW5kZXJCbG9j az4gY2xvbmUoKSBjb25zdDsKICAgICBSZW5kZXJCbG9jayogY29udGludWF0aW9uQmVmb3JlKFJl bmRlck9iamVjdCogYmVmb3JlQ2hpbGQpOwogICAgIFJlbmRlckJsb2NrKiBjb250YWluaW5nQ29s dW1uc0Jsb2NrKGJvb2wgYWxsb3dBbm9ueW1vdXNDb2x1bW5CbG9jayA9IHRydWUpOwogICAgIFJl bmRlckJsb2NrKiBjb2x1bW5zQmxvY2tGb3JTcGFubmluZ0VsZW1lbnQoUmVuZGVyT2JqZWN0KiBu ZXdDaGlsZCk7Cg==