126511 2014-01-05 23:33:00 -0800 build.webkit.org/dashboard should still function if localStorage is disabled 2014-01-06 12:47:30 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thorton thorton ap timothy oldest_to_newest 964559 0 thorton 2014-01-05 23:33:00 -0800 Right now, the dashboard completely fails to load if localStorage is run-time disabled or not built into the browser. 964560 1 220416 thorton 2014-01-05 23:43:13 -0800 Created attachment 220416 patch 964632 2 220416 ap 2014-01-06 08:43:59 -0800 Comment on attachment 220416 patch View in context: https://bugs.webkit.org/attachment.cgi?id=220416&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:44 > + console.log("Couldn't use localStorage, settings won't work: " + e); Can we hide the gear icon if it's not going to work anyway? Or is this warning incorrect, and it will work, just not persistently? 964676 3 220441 thorton 2014-01-06 11:07:04 -0800 Created attachment 220441 patch that hides the gear 964700 4 220441 ap 2014-01-06 11:59:55 -0800 Comment on attachment 220441 patch that hides the gear View in context: https://bugs.webkit.org/attachment.cgi?id=220441&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:45 > + try { > + localStorage.setItem(key, JSON.stringify(value)); > + } catch(e) { > + console.log("Couldn't use localStorage, settings won't work: " + e); > + } Do we need this try/catch now? Seems helpful to have breakage clearly visible. 964723 5 thorton 2014-01-06 12:47:30 -0800 http://trac.webkit.org/changeset/161360 220416 2014-01-05 23:43:13 -0800 2014-01-06 11:07:04 -0800 patch ls.diff text/plain 1881 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1NldHRpbmdzLmpzIGIvVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKaW5kZXggYWJlNDljYS4uYWUxN2Y4MSAxMDA2NDQKLS0t IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGlj X2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Nj cmlwdHMvU2V0dGluZ3MuanMKQEAgLTM4LDEyICszOCwyMCBAQCBTZXR0aW5ncy5wcm90b3R5cGUg PSB7CiAKICAgICBzZXRPYmplY3Q6IGZ1bmN0aW9uKGtleSwgdmFsdWUpCiAgICAgewotICAgICAg ICBsb2NhbFN0b3JhZ2Uuc2V0SXRlbShrZXksIEpTT04uc3RyaW5naWZ5KHZhbHVlKSk7CisgICAg ICAgIHRyeSB7CisgICAgICAgICAgICBsb2NhbFN0b3JhZ2Uuc2V0SXRlbShrZXksIEpTT04uc3Ry aW5naWZ5KHZhbHVlKSk7CisgICAgICAgIH0gY2F0Y2goZSkgeworICAgICAgICAgICAgY29uc29s ZS5sb2coIkNvdWxkbid0IHVzZSBsb2NhbFN0b3JhZ2UsIHNldHRpbmdzIHdvbid0IHdvcms6ICIg KyBlKTsKKyAgICAgICAgfQogICAgIH0sCiAKICAgICBnZXRPYmplY3Q6IGZ1bmN0aW9uKGtleSkK ICAgICB7Ci0gICAgICAgIHJldHVybiBKU09OLnBhcnNlKGxvY2FsU3RvcmFnZS5nZXRJdGVtKGtl eSkpOworICAgICAgICB0cnkgeworICAgICAgICAgICAgcmV0dXJuIEpTT04ucGFyc2UobG9jYWxT dG9yYWdlLmdldEl0ZW0oa2V5KSk7CisgICAgICAgIH0gY2F0Y2goZSkgeworICAgICAgICAgICAg Y29uc29sZS5sb2coIkNvdWxkbid0IHVzZSBsb2NhbFN0b3JhZ2UsIHNldHRpbmdzIHdvbid0IHdv cms6ICIgKyBlKTsKKyAgICAgICAgfQogICAgIH0sCiAKICAgICBhZGRTZXR0aW5nTGlzdGVuZXI6 IGZ1bmN0aW9uKGtleSwgY2FsbGJhY2spCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9U b29scy9DaGFuZ2VMb2cKaW5kZXggMTM4YTVjZC4uM2RlNmZmZCAxMDA2NDQKLS0tIGEvVG9vbHMv Q2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTAx LTA1ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIGJ1 aWxkLndlYmtpdC5vcmcvZGFzaGJvYXJkIHNob3VsZCBzdGlsbCBmdW5jdGlvbiBpZiBsb2NhbFN0 b3JhZ2UgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNjUxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIElmIGxvY2FsU3RvcmFnZSBpcyBkaXNhYmxlZCwgd2Ugc2hvdWxkIGNhcnJ5IG9u IHdpdGggYSB3YXJuaW5nLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanM6 CisgICAgICAgIChTZXR0aW5ncy5wcm90b3R5cGUuc2V0T2JqZWN0KToKKyAgICAgICAgKFNldHRp bmdzLnByb3RvdHlwZS5nZXRPYmplY3QpOgorCiAyMDE0LTAxLTA1ICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtDTWFrZV0gQWRkIHN1cHBv cnQgZm9yIGJ1aWxkaW5nIHRoZSBHVEsrIHBvcnQgd2l0aCBjbWFrZSB0byBidWlsZC13ZWJraXQK 220441 2014-01-06 11:07:04 -0800 2014-01-06 11:59:55 -0800 patch that hides the gear ls.diff text/plain 3623 thorton ZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL01haW4uanMgYi9Ub29scy9CdWlsZFNs YXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQv U2NyaXB0cy9NYWluLmpzCmluZGV4IGYxZWMzYjguLjY0Y2Y0ZDYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rh c2hib2FyZC9TY3JpcHRzL01haW4uanMKKysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvTWFpbi5q cwpAQCAtMjE2LDEwICsyMTYsMTIgQEAgZnVuY3Rpb24gZG9jdW1lbnRSZWFkeSgpCiAKICAgICBk b2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHRhYmxlKTsKIAotICAgIHZhciBzZXR0aW5nc0J1dHRv biA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwotICAgIHNldHRpbmdzQnV0dG9uLmFk ZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgZnVuY3Rpb24gKCkgeyBzZXR0aW5ncy50b2dnbGVTZXR0 aW5nc0Rpc3BsYXkoKTsgfSk7Ci0gICAgc2V0dGluZ3NCdXR0b24uY2xhc3NMaXN0LmFkZCgic2V0 dGluZ3MiKTsKLSAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKHNldHRpbmdzQnV0dG9uKTsK KyAgICBpZiAoc2V0dGluZ3MuYXZhaWxhYmxlKCkpIHsKKyAgICAgICAgdmFyIHNldHRpbmdzQnV0 dG9uID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CisgICAgICAgIHNldHRpbmdzQnV0 dG9uLmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgZnVuY3Rpb24gKCkgeyBzZXR0aW5ncy50b2dn bGVTZXR0aW5nc0Rpc3BsYXkoKTsgfSk7CisgICAgICAgIHNldHRpbmdzQnV0dG9uLmNsYXNzTGlz dC5hZGQoInNldHRpbmdzIik7CisgICAgICAgIGRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoc2V0 dGluZ3NCdXR0b24pOworICAgIH0KIAogICAgIHVwZGF0ZUhpZGRlblBsYXRmb3JtcygpOwogICAg IHNldHRpbmdzLmFkZFNldHRpbmdMaXN0ZW5lcigiaGlkZGVuUGxhdGZvcm1zIiwgdXBkYXRlSGlk ZGVuUGxhdGZvcm1zKTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL1NldHRpbmdz LmpzIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKaW5kZXggYWJlNDljYS4uOTRk YmNmYyAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKKysrIGIv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanMKQEAgLTM4LDEyICszOCwzNSBAQCBTZXR0 aW5ncy5wcm90b3R5cGUgPSB7CiAKICAgICBzZXRPYmplY3Q6IGZ1bmN0aW9uKGtleSwgdmFsdWUp CiAgICAgewotICAgICAgICBsb2NhbFN0b3JhZ2Uuc2V0SXRlbShrZXksIEpTT04uc3RyaW5naWZ5 KHZhbHVlKSk7CisgICAgICAgIHRyeSB7CisgICAgICAgICAgICBsb2NhbFN0b3JhZ2Uuc2V0SXRl bShrZXksIEpTT04uc3RyaW5naWZ5KHZhbHVlKSk7CisgICAgICAgIH0gY2F0Y2goZSkgeworICAg ICAgICAgICAgY29uc29sZS5sb2coIkNvdWxkbid0IHVzZSBsb2NhbFN0b3JhZ2UsIHNldHRpbmdz IHdvbid0IHdvcms6ICIgKyBlKTsKKyAgICAgICAgfQogICAgIH0sCiAKICAgICBnZXRPYmplY3Q6 IGZ1bmN0aW9uKGtleSkKICAgICB7Ci0gICAgICAgIHJldHVybiBKU09OLnBhcnNlKGxvY2FsU3Rv cmFnZS5nZXRJdGVtKGtleSkpOworICAgICAgICB0cnkgeworICAgICAgICAgICAgcmV0dXJuIEpT T04ucGFyc2UobG9jYWxTdG9yYWdlLmdldEl0ZW0oa2V5KSk7CisgICAgICAgIH0gY2F0Y2goZSkg eworICAgICAgICAgICAgY29uc29sZS5sb2coIkNvdWxkbid0IHVzZSBsb2NhbFN0b3JhZ2UsIHNl dHRpbmdzIHdvbid0IHdvcms6ICIgKyBlKTsKKyAgICAgICAgfQorICAgIH0sCisKKyAgICBhdmFp bGFibGU6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHRyeSB7CisgICAgICAgICAgICBsb2Nh bFN0b3JhZ2Uuc2V0SXRlbSgidGVzdExvY2FsU3RvcmFnZSIsICJ0ZXN0Iik7CisgICAgICAgICAg ICBpZiAobG9jYWxTdG9yYWdlLmdldEl0ZW0oInRlc3RMb2NhbFN0b3JhZ2UiKSAhPSAidGVzdCIp CisgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICAgICAgbG9jYWxTdG9yYWdl LnJlbW92ZUl0ZW0oInRlc3RMb2NhbFN0b3JhZ2UiKTsKKyAgICAgICAgfSBjYXRjaChlKSB7Cisg ICAgICAgICAgICBjb25zb2xlLmxvZygiQ291bGRuJ3QgdXNlIGxvY2FsU3RvcmFnZSwgc2V0dGlu Z3Mgd29uJ3Qgd29yazogIiArIGUpOworICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAg ICB9CisKKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfSwKIAogICAgIGFkZFNldHRpbmdMaXN0 ZW5lcjogZnVuY3Rpb24oa2V5LCBjYWxsYmFjaykKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhYWY2MjhlLi43ZGY5MjIwIDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIw MTQtMDEtMDYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAg ICAgYnVpbGQud2Via2l0Lm9yZy9kYXNoYm9hcmQgc2hvdWxkIHN0aWxsIGZ1bmN0aW9uIGlmIGxv Y2FsU3RvcmFnZSBpcyBkaXNhYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTI2NTExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgSWYgbG9jYWxTdG9yYWdlIGlzIGRpc2FibGVkLCB3ZSBzaG91bGQgY2Fy cnkgb24gd2l0aCBhIHdhcm5pbmcuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9NYWluLmpz OgorICAgICAgICBEb24ndCBzaG93IHRoZSBnZWFyIGlmIGxvY2FsU3RvcmFnZSBpc24ndCB3b3Jr aW5nLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvU2V0dGluZ3MuanM6CisgICAgICAgIChT ZXR0aW5ncy5wcm90b3R5cGUuc2V0T2JqZWN0KToKKyAgICAgICAgKFNldHRpbmdzLnByb3RvdHlw ZS5nZXRPYmplY3QpOgorICAgICAgICAoU2V0dGluZ3MucHJvdG90eXBlLmF2YWlsYWJsZSk6CisK IDIwMTQtMDEtMDYgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CiAKICAgICAg ICAgQWRkaW5nIG15c2VsZiBhcyBhIHJldmlld2VyLgo=