126502 2014-01-05 11:40:48 -0800 [GTK] v2.3.3 fails to build in Debian / FreeBSD 2014-02-11 06:20:31 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 128598 1 berto webkit-unassigned benjamin cmarcelo commit-queue mark.lam zan oldest_to_newest 964511 0 berto 2014-01-05 11:40:48 -0800 Here's the error: ../Source/JavaScriptCore/interpreter/Interpreter.cpp: In member function 'JSC::JSValue JSC::Interpreter::executeCall(JSC::CallFrame*, JSC::JSObject*, JSC::CallType, const JSC::CallData&, JSC::JSValue, const JSC::ArgList&)': ../Source/JavaScriptCore/interpreter/Interpreter.cpp:973:168: error: 'callToNativeFunction' was not declared in this scope result = JSValue::decode(callToNativeFunction(reinterpret_cast<void*>(callData.native.function), &vm.topCallFrame, &protoCallFrame, m_stack.getTopOfStack())); ^ ../Source/JavaScriptCore/interpreter/Interpreter.cpp: In member function 'JSC::JSObject* JSC::Interpreter::executeConstruct(JSC::CallFrame*, JSC::JSObject*, JSC::ConstructType, const JSC::ConstructData&, const JSC::ArgList&)': ../Source/JavaScriptCore/interpreter/Interpreter.cpp:1041:173: error: 'callToNativeFunction' was not declared in this scope result = JSValue::decode(callToNativeFunction(reinterpret_cast<void*>(constructData.native.function), &vm.topCallFrame, &protoCallFrame, m_stack.getTopOfStack())); Complete build output here: https://buildd.debian.org/status/fetch.php?pkg=webkitgtk&arch=kfreebsd-amd64&ver=2.3.3-1&stamp=1388886358 964585 1 zan 2014-01-06 01:52:45 -0800 ENABLE_LLINT is not being enabled on FreeBSD. http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Platform.h#L726 968258 2 berto 2014-01-15 03:24:51 -0800 (In reply to comment #1) > ENABLE_LLINT is not being enabled on FreeBSD. > http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Platform.h#L726 Yeah, but JSC should anyway build without it, shouldn't it? We can also enable LLINT in FreeBSD, is there any reason why it wouldn't work? It seems to built fine at least... 968262 3 berto 2014-01-15 03:34:02 -0800 And it looks like this broke after r160186, adding Mark Lam to Cc. 968307 4 mark.lam 2014-01-15 07:01:04 -0800 (In reply to comment #2) > (In reply to comment #1) > > ENABLE_LLINT is not being enabled on FreeBSD. > > http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Platform.h#L726 > > Yeah, but JSC should anyway build without it, shouldn't it? > > We can also enable LLINT in FreeBSD, is there any reason why it > wouldn't work? It seems to built fine at least... Sorry about the breakage, but going forward, the LLINT will be an essential part of the JSC build. This (breakage) wasn’t by design, but it came out of a natural progression in the development of the JSC JIT. If you build with the JIT, the LLINT is needed to provide glue trampoline (e.g. callToJavaScript and callToNativeFunction). If you build without the JIT, the LLINT is needed to provide the C loop interpreter. Either way, you will need the LLINT. The only alternative to this is to build with JIT only and provide your own glue trampoline. For example, see jit/JITStubsX86.h and jit/JITStubsMSVC64.asm. This is no recommended because the LLINT assembly will be undergoing continual development over time, and these one off bits of ASM code can easily bit rot. I recommend you add LLINT support to the FreeBSD port. Thanks. 968352 5 berto 2014-01-15 09:20:26 -0800 (In reply to comment #4) > I recommend you add LLINT support to the FreeBSD port. Thanks. Thanks for the answer. I wonder, instead of adding FREEBSD to the list, can I just replace (OS(DARWIN) || OS(LINUX)) with OS(UNIX) or is there any reason why it wouldn't work in some Unix system? 968355 6 mark.lam 2014-01-15 09:23:22 -0800 (In reply to comment #5) > (In reply to comment #4) > > I recommend you add LLINT support to the FreeBSD port. Thanks. > > Thanks for the answer. > > I wonder, instead of adding FREEBSD to the list, can I just replace > (OS(DARWIN) || OS(LINUX)) with OS(UNIX) or is there any reason why it > wouldn't work in some Unix system? The LLINT requires an extra build phase to generate LLIntAssembly.h. It is not guaranteed that all platforms support this build phase. 968358 7 221276 berto 2014-01-15 09:30:17 -0800 Created attachment 221276 Patch (In reply to comment #6) > The LLINT requires an extra build phase to generate LLIntAssembly.h. > It is not guaranteed that all platforms support this build phase. I see. Here's the patch with FreeBSD only then. Thanks again! 968361 8 221276 mark.lam 2014-01-15 09:32:41 -0800 Comment on attachment 221276 Patch r=me assuming you’ve tested it and confirmed that it resolves the issue. 968367 9 berto 2014-01-15 09:39:40 -0800 (In reply to comment #8) > (From update of attachment 221276 [details]) > r=me assuming you’ve tested it and confirmed that it resolves the issue. Yeah, I'll anyway do a full rebuild again later to double check before committing the change. 968449 10 berto 2014-01-15 13:17:12 -0800 Committed r162086: <http://trac.webkit.org/changeset/162086> 221276 2014-01-15 09:30:17 -0800 2014-01-15 09:32:40 -0800 Patch 126502.diff text/plain 1060 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggM2I5MzA5ZS4uZmIwNTYyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0wMS0xNSAg QWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIHYyLjMu MyBmYWlscyB0byBidWlsZCBpbiBEZWJpYW4gLyBGcmVlQlNECisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMjY1MDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOiBBZGQgTExJTlQg c3VwcG9ydCB0byBGcmVlQlNELgorCiAyMDE0LTAxLTE0ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRl cnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQW5kIHlldCBhbm90aGVyIGJ1aWxkIGZpeC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oCmluZGV4IDZjYzExNWUuLjQ2YTA2ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtNzE0LDcgKzcx NCw3IEBACiAgICBsb3ctbGV2ZWwgaW50ZXJwcmV0ZXIuICovCiAjaWYgIWRlZmluZWQoRU5BQkxF X0xMSU5UKSBcCiAgICAgJiYgRU5BQkxFKEpJVCkgXAotICAgICYmIChPUyhEQVJXSU4pIHx8IE9T KExJTlVYKSkgXAorICAgICYmIChPUyhEQVJXSU4pIHx8IE9TKExJTlVYKSB8fCBPUyhGUkVFQlNE KSkgXAogICAgICYmIChQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKElPUykgfHwgUExBVEZPUk0o R1RLKSkgXAogICAgICYmIChDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KSB8fCBDUFUoQVJNX1RIVU1C MikgfHwgQ1BVKEFSTV9UUkFESVRJT05BTCkgfHwgQ1BVKEFSTTY0KSB8fCBDUFUoTUlQUykgfHwg Q1BVKFNINCkpCiAjZGVmaW5lIEVOQUJMRV9MTElOVCAxCg==