126490 2014-01-04 08:33:16 -0800 JSPromiseReaction.cpp should use Compiler macros instead of raw "final" and "override" 2014-01-04 18:11:37 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki webkit-unassigned commit-queue fpizlo sam oldest_to_newest 964401 0 ysuzuki 2014-01-04 08:33:16 -0800 Since JSPromiseReaction.cpp use raw "final" and "override" macros, JSC cannot be built on Ubuntu 12.04's default compiler (g++ (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3) 964402 1 ysuzuki 2014-01-04 08:33:31 -0800 I'll submit a patch soon. 964403 2 220375 ysuzuki 2014-01-04 08:41:47 -0800 Created attachment 220375 Patch 964417 3 ysuzuki 2014-01-04 10:45:34 -0800 Thank you for your quick review, Sam! Could you set cq+? 964437 4 sam 2014-01-04 17:43:57 -0800 (In reply to comment #3) > Thank you for your quick review, Sam! Could you set cq+? Done. 964439 5 220375 commit-queue 2014-01-04 18:11:34 -0800 Comment on attachment 220375 Patch Clearing flags on attachment: 220375 Committed r161317: <http://trac.webkit.org/changeset/161317> 964440 6 commit-queue 2014-01-04 18:11:37 -0800 All reviewed patches have been landed. Closing bug. 220375 2014-01-04 08:41:47 -0800 2014-01-04 18:11:34 -0800 Patch bug-126490-20140105014324.patch text/plain 1563 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTYxMzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MzcwODM4ZDc4YjM0ZWM4ZWQ4MWQxMmZhODQ5YjViZWQ0OTNjYmQ5Li45MmIxNDdiZWFmMmMyYzM5 OTU2NWUxMDQ1M2JiZDNkNzBiZjUyODQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxNC0wMS0wNCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBVc2UgQ29tcGlsZXIgbWFjcm9zIGluc3RlYWQgb2YgcmF3ICJmaW5h bCIgYW5kICJvdmVycmlkZSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEyNjQ5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcnVudGltZS9KU1Byb21pc2VSZWFjdGlvbi5jcHA6CisKIDIwMTQtMDEtMDMg IERhdmlkIEZhcmxlciAgPGRmYXJsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtzdXBlciBkZWFs bG9jXSBtaXNzaW5nIGluIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5t bSwgZmFpbHMgdG8gYnVpbGQgd2l0aCAtV2Vycm9yLC1Xb2JqYy1taXNzaW5nLXN1cGVyLWNhbGxz CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb21pc2VSZWFj dGlvbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb21pc2VSZWFjdGlv bi5jcHAKaW5kZXggNDY2ODU2YTk5OGZlYmNiMjA1MTA1MzQzNmY3Y2FiMzgyNzE0M2Y2Ni4uODlj YWZmNTBmZjE0YzM0OTU4MjM3Y2Y2YmNhODY3OTIzODM3ZWVhYiAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNQcm9taXNlUmVhY3Rpb24uY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTUHJvbWlzZVJlYWN0aW9uLmNwcApAQCAtMzcsNyAr MzcsNyBAQAogCiBuYW1lc3BhY2UgSlNDIHsKIAotY2xhc3MgRXhlY3V0ZVByb21pc2VSZWFjdGlv bk1pY3JvdGFzayBmaW5hbCA6IHB1YmxpYyBNaWNyb3Rhc2sgeworY2xhc3MgRXhlY3V0ZVByb21p c2VSZWFjdGlvbk1pY3JvdGFzayBGSU5BTCA6IHB1YmxpYyBNaWNyb3Rhc2sgewogcHVibGljOgog ICAgIEV4ZWN1dGVQcm9taXNlUmVhY3Rpb25NaWNyb3Rhc2soVk0mIHZtLCBKU1Byb21pc2VSZWFj dGlvbiogcmVhY3Rpb24sIEpTVmFsdWUgYXJndW1lbnQpCiAgICAgewpAQCAtNTAsNyArNTAsNyBA QCBwdWJsaWM6CiAgICAgfQogCiBwcml2YXRlOgotICAgIHZpcnR1YWwgdm9pZCBydW4oRXhlY1N0 YXRlKikgb3ZlcnJpZGU7CisgICAgdmlydHVhbCB2b2lkIHJ1bihFeGVjU3RhdGUqKSBPVkVSUklE RTsKIAogICAgIFN0cm9uZzxKU1Byb21pc2VSZWFjdGlvbj4gbV9yZWFjdGlvbjsKICAgICBTdHJv bmc8VW5rbm93bj4gbV9hcmd1bWVudDsK